From efabe359428d2b69979deff9002f13ed1bcfc6a4 Mon Sep 17 00:00:00 2001 From: Vladimir Krivosheev Date: Wed, 30 Nov 2016 11:43:54 +0100 Subject: [PATCH] save one map lookup --- .../com/intellij/openapi/module/impl/ModuleManagerImpl.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/platform/projectModel-impl/src/com/intellij/openapi/module/impl/ModuleManagerImpl.java b/platform/projectModel-impl/src/com/intellij/openapi/module/impl/ModuleManagerImpl.java index 6dd38e390aab..8bfd08f450f1 100644 --- a/platform/projectModel-impl/src/com/intellij/openapi/module/impl/ModuleManagerImpl.java +++ b/platform/projectModel-impl/src/com/intellij/openapi/module/impl/ModuleManagerImpl.java @@ -154,9 +154,7 @@ public abstract class ModuleManagerImpl extends ModuleManager implements Project } final ModifiableModuleModel model = getModifiableModel(); - Module[] existingModules = model.getModules(); - ModuleGroupInterner groupInterner = new ModuleGroupInterner(); Map modulePathMap = new THashMap<>(myModulePaths.size()); @@ -165,13 +163,12 @@ public abstract class ModuleManagerImpl extends ModuleManager implements Project } for (Module existingModule : existingModules) { - ModulePath correspondingPath = modulePathMap.get(existingModule.getModuleFilePath()); + ModulePath correspondingPath = modulePathMap.remove(existingModule.getModuleFilePath()); if (correspondingPath == null) { model.disposeModule(existingModule); } else { myModulePaths.remove(correspondingPath); - modulePathMap.remove(correspondingPath.getPath()); String groupStr = correspondingPath.getModuleGroup(); String[] group = groupStr == null ? null : groupStr.split(MODULE_GROUP_SEPARATOR);