From ed930bae59dd0316c396edcacd737d56aa08485e Mon Sep 17 00:00:00 2001 From: Julia Beliaeva Date: Fri, 30 Jun 2017 20:15:33 +0300 Subject: [PATCH] [file-history] inline myRevisionsInOrderComparator --- .../vcs/history/FileHistoryPanelImpl.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/platform/vcs-impl/src/com/intellij/openapi/vcs/history/FileHistoryPanelImpl.java b/platform/vcs-impl/src/com/intellij/openapi/vcs/history/FileHistoryPanelImpl.java index f7c6bee418d2..0e6ce4a99cb6 100644 --- a/platform/vcs-impl/src/com/intellij/openapi/vcs/history/FileHistoryPanelImpl.java +++ b/platform/vcs-impl/src/com/intellij/openapi/vcs/history/FileHistoryPanelImpl.java @@ -42,8 +42,8 @@ import com.intellij.openapi.vcs.changes.CurrentContentRevision; import com.intellij.openapi.vcs.changes.issueLinks.IssueLinkRenderer; import com.intellij.openapi.vcs.changes.issueLinks.TableLinkMouseListener; import com.intellij.openapi.vcs.history.actions.AnnotateRevisionAction; -import com.intellij.openapi.vcs.history.actions.CreatePatchAction; import com.intellij.openapi.vcs.history.actions.CompareRevisionsAction; +import com.intellij.openapi.vcs.history.actions.CreatePatchAction; import com.intellij.openapi.vcs.history.actions.GetVersionAction; import com.intellij.openapi.vcs.vfs.VcsFileSystem; import com.intellij.openapi.vcs.vfs.VcsVirtualFile; @@ -81,6 +81,9 @@ import java.io.IOException; import java.util.*; import java.util.List; +import static java.util.Comparator.comparing; +import static java.util.Comparator.reverseOrder; + /** * author: lesya */ @@ -98,10 +101,6 @@ public class FileHistoryPanelImpl extends PanelWithActionsAndCloseButton impleme @NotNull private final AsynchConsumer myHistoryPanelRefresh; @NotNull private final Map myRevisionsOrder = ContainerUtil.newHashMap(); @NotNull private final Map myRevisionToVirtualFile = ContainerUtil.newHashMap(); - @NotNull private final Comparator myRevisionsInOrderComparator = (o1, o2) -> { - // descending - return Comparing.compare(myRevisionsOrder.get(o2.getRevisionNumber()), myRevisionsOrder.get(o1.getRevisionNumber())); - }; @NotNull private final DetailsPanel myDetails; @NotNull private final DualView myDualView; @Nullable private final JComponent myAdditionalDetails; @@ -280,7 +279,8 @@ public class FileHistoryPanelImpl extends PanelWithActionsAndCloseButton impleme @NotNull VcsHistoryProvider provider, @Nullable ColumnInfo[] additionalColumns) { ArrayList columns = new ArrayList<>(); - columns.add(new TreeNodeColumnInfoWrapper<>(new RevisionColumnInfo(myRevisionsInOrderComparator))); + columns.add(new TreeNodeColumnInfoWrapper<>( + new RevisionColumnInfo(comparing(revision -> myRevisionsOrder.get(revision.getRevisionNumber()), reverseOrder())))); if (!provider.isDateOmittable()) columns.add(new TreeNodeColumnInfoWrapper<>(new DateColumnInfo())); columns.add(new TreeNodeColumnInfoWrapper<>(new AuthorColumnInfo())); if (additionalColumns != null) { @@ -538,7 +538,7 @@ public class FileHistoryPanelImpl extends PanelWithActionsAndCloseButton impleme final VcsFileRevision[] revisions = getSelectedRevisions(); if (revisions.length > 0) { - Arrays.sort(revisions, Comparator.comparing(VcsRevisionDescription::getRevisionNumber)); + Arrays.sort(revisions, comparing(VcsRevisionDescription::getRevisionNumber)); for (VcsFileRevision revision : revisions) { if (!myHistorySession.isContentAvailable(revision)) { @@ -739,7 +739,7 @@ public class FileHistoryPanelImpl extends PanelWithActionsAndCloseButton impleme @Nullable @Override public Comparator getComparator() { - return Comparator.comparing(revision -> valueOf(revision)); + return comparing(revision -> valueOf(revision)); } @Nullable