From 29e92773846b286f8a47664a6581e048416a90fb Mon Sep 17 00:00:00 2001 From: Vladimir Krivosheev Date: Sat, 17 Jan 2015 18:16:48 +0100 Subject: [PATCH 01/24] =?UTF-8?q?reduce=20usage=20of=20JSDebuggerSupportUt?= =?UTF-8?q?ils=20=E2=80=94=20move=20getContextElement=20to=20new=20Debugge?= =?UTF-8?q?rSupportUtils=20util=20class=20(available=20in=20community)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../jetbrains/debugger/DebuggerSupportUtils.java | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 platform/script-debugger/debugger-ui/src/org/jetbrains/debugger/DebuggerSupportUtils.java diff --git a/platform/script-debugger/debugger-ui/src/org/jetbrains/debugger/DebuggerSupportUtils.java b/platform/script-debugger/debugger-ui/src/org/jetbrains/debugger/DebuggerSupportUtils.java new file mode 100644 index 000000000000..f5bb519c0e71 --- /dev/null +++ b/platform/script-debugger/debugger-ui/src/org/jetbrains/debugger/DebuggerSupportUtils.java @@ -0,0 +1,15 @@ +package org.jetbrains.debugger; + +import com.intellij.openapi.project.Project; +import com.intellij.openapi.vfs.VirtualFile; +import com.intellij.psi.PsiElement; +import com.intellij.xdebugger.XDebuggerUtil; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +public final class DebuggerSupportUtils { + @Nullable + public static PsiElement getContextElement(@NotNull VirtualFile virtualFile, int offset, @NotNull Project project) { + return XDebuggerUtil.getInstance().findContextElement(virtualFile, offset, project, true); + } +} From f84ec8d9f634f9ae91bab050613e73fa525141ba Mon Sep 17 00:00:00 2001 From: Vladimir Krivosheev Date: Sat, 17 Jan 2015 18:25:25 +0100 Subject: [PATCH 02/24] reduce usage of JSDebuggerSupportUtils --- .../jetbrains/debugger/DebuggerSupportUtils.java | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/platform/script-debugger/debugger-ui/src/org/jetbrains/debugger/DebuggerSupportUtils.java b/platform/script-debugger/debugger-ui/src/org/jetbrains/debugger/DebuggerSupportUtils.java index f5bb519c0e71..3f25196b5b18 100644 --- a/platform/script-debugger/debugger-ui/src/org/jetbrains/debugger/DebuggerSupportUtils.java +++ b/platform/script-debugger/debugger-ui/src/org/jetbrains/debugger/DebuggerSupportUtils.java @@ -1,15 +1,21 @@ package org.jetbrains.debugger; -import com.intellij.openapi.project.Project; import com.intellij.openapi.vfs.VirtualFile; import com.intellij.psi.PsiElement; import com.intellij.xdebugger.XDebuggerUtil; -import org.jetbrains.annotations.NotNull; +import com.intellij.xdebugger.XSourcePosition; import org.jetbrains.annotations.Nullable; public final class DebuggerSupportUtils { @Nullable - public static PsiElement getContextElement(@NotNull VirtualFile virtualFile, int offset, @NotNull Project project) { - return XDebuggerUtil.getInstance().findContextElement(virtualFile, offset, project, true); + public static XSourcePosition calcSourcePosition(@Nullable PsiElement element) { + if (element != null) { + PsiElement navigationElement = element.getNavigationElement(); + VirtualFile file = navigationElement.getContainingFile().getVirtualFile(); + if (file != null) { + return XDebuggerUtil.getInstance().createPositionByOffset(file, navigationElement.getTextOffset()); + } + } + return null; } } From cf6bfd7ef2cd4c276b40661235397a579529f43a Mon Sep 17 00:00:00 2001 From: Dennis Ushakov Date: Mon, 19 Jan 2015 12:44:24 +0300 Subject: [PATCH 03/24] #WEB-14743 fixed --- .../jetbrains/python/module/PyProjectStructureDetector.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/python/pluginSrc/com/jetbrains/python/module/PyProjectStructureDetector.java b/python/pluginSrc/com/jetbrains/python/module/PyProjectStructureDetector.java index 585ce5c16680..4e805355e83a 100644 --- a/python/pluginSrc/com/jetbrains/python/module/PyProjectStructureDetector.java +++ b/python/pluginSrc/com/jetbrains/python/module/PyProjectStructureDetector.java @@ -49,11 +49,15 @@ public class PyProjectStructureDetector extends ProjectStructureDetector { @NotNull List result) { LOG.info("Detecting roots under " + dir); for (File child : children) { - if (FileUtilRt.extensionEquals(child.getName(), "py")) { + final String name = child.getName(); + if (FileUtilRt.extensionEquals(name, "py")) { LOG.info("Found Python file " + child.getPath()); result.add(new DetectedContentRoot(dir, "Python", PythonModuleTypeBase.getInstance(), WebModuleType.getInstance())); return DirectoryProcessingResult.SKIP_CHILDREN; } + if ("node_modules".equals(name)) { + return DirectoryProcessingResult.SKIP_CHILDREN; + } } return DirectoryProcessingResult.PROCESS_CHILDREN; } From d60840ee4ffcbe3720ef90952b1cbec5e6204761 Mon Sep 17 00:00:00 2001 From: Anna Kozlova Date: Mon, 19 Jan 2015 12:06:50 +0100 Subject: [PATCH 04/24] cleanup 'public' modifier from the interface on "pull default method" (IDEA-135292) --- .../src/com/intellij/refactoring/util/RefactoringUtil.java | 1 + java/java-tests/testData/refactoring/pullUp/AsDefault.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/java/java-impl/src/com/intellij/refactoring/util/RefactoringUtil.java b/java/java-impl/src/com/intellij/refactoring/util/RefactoringUtil.java index ed51aa5120b4..43758f620342 100644 --- a/java/java-impl/src/com/intellij/refactoring/util/RefactoringUtil.java +++ b/java/java-impl/src/com/intellij/refactoring/util/RefactoringUtil.java @@ -718,6 +718,7 @@ public class RefactoringUtil { PsiUtil.setModifierProperty(method, PsiModifier.FINAL, false); PsiUtil.setModifierProperty(method, PsiModifier.SYNCHRONIZED, false); PsiUtil.setModifierProperty(method, PsiModifier.NATIVE, false); + PsiUtil.setModifierProperty(method, PsiModifier.PUBLIC, false); removeFinalParameters(method); } diff --git a/java/java-tests/testData/refactoring/pullUp/AsDefault.java b/java/java-tests/testData/refactoring/pullUp/AsDefault.java index 3379c19a779e..05cf9b018841 100644 --- a/java/java-tests/testData/refactoring/pullUp/AsDefault.java +++ b/java/java-tests/testData/refactoring/pullUp/AsDefault.java @@ -3,5 +3,5 @@ interface Bar { } interface Base { } class Foo implements Base { - void get(Bar bar) { } + public void get(Bar bar) { } } \ No newline at end of file From 48c46f3fb5cbedf4c38e49a3bf394dc13dfbdc7c Mon Sep 17 00:00:00 2001 From: Anna Kozlova Date: Mon, 19 Jan 2015 12:34:15 +0100 Subject: [PATCH 05/24] typo (IDEA-135291) --- .../src/messages/InspectionsBundle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/platform-resources-en/src/messages/InspectionsBundle.properties b/platform/platform-resources-en/src/messages/InspectionsBundle.properties index ba051086dd92..01b8c5e80e0d 100644 --- a/platform/platform-resources-en/src/messages/InspectionsBundle.properties +++ b/platform/platform-resources-en/src/messages/InspectionsBundle.properties @@ -100,7 +100,7 @@ inspection.empty.method.delete.quickfix=Delete unnecessary method(s) inspection.empty.method.problem.descriptor=Method only calls its super inspection.empty.method.problem.descriptor1=Empty method overrides empty method inspection.empty.method.problem.descriptor2=The method is empty -inspection.empty.method.problem.descriptor3=The method and all it's derivables are empty +inspection.empty.method.problem.descriptor3=The method and all its derivables are empty inspection.empty.method.problem.descriptor4=All implementations of this method are empty #redundant cast From 7463327b77fb49c97896005022bd88c595f79626 Mon Sep 17 00:00:00 2001 From: Anna Kozlova Date: Mon, 19 Jan 2015 12:38:41 +0100 Subject: [PATCH 06/24] register action shortcut in plugin.xml so minor IDEs won't get it in their keymaps --- platform/platform-resources/src/idea/Keymap_Default.xml | 3 --- resources/src/idea/JavaActions.xml | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/platform/platform-resources/src/idea/Keymap_Default.xml b/platform/platform-resources/src/idea/Keymap_Default.xml index baf7d20c0c52..8cd7594ebaaa 100644 --- a/platform/platform-resources/src/idea/Keymap_Default.xml +++ b/platform/platform-resources/src/idea/Keymap_Default.xml @@ -716,9 +716,6 @@ - - - diff --git a/resources/src/idea/JavaActions.xml b/resources/src/idea/JavaActions.xml index 7836da0b2add..4d4329d87e6d 100644 --- a/resources/src/idea/JavaActions.xml +++ b/resources/src/idea/JavaActions.xml @@ -70,6 +70,7 @@ + From c5c7eeae5dc8317975a2ac366f1cbbb818d6b9da Mon Sep 17 00:00:00 2001 From: Anna Kozlova Date: Mon, 19 Jan 2015 13:02:24 +0100 Subject: [PATCH 07/24] add "implement methods" fix for unrelated default methods error (IDEA-135295) --- .../daemon/impl/analysis/GenericsHighlightUtil.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/GenericsHighlightUtil.java b/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/GenericsHighlightUtil.java index e1fdc3840f2a..6832f9d226db 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/GenericsHighlightUtil.java +++ b/java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/GenericsHighlightUtil.java @@ -455,9 +455,11 @@ public class GenericsHighlightUtil { HighlightUtil.formatClass(superContainingClass), JavaHighlightUtil.formatMethod(superMethod), HighlightUtil.formatClass(superContainingClass, false)); - return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR) + final HighlightInfo info = HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR) .range(classIdentifier).descriptionAndTooltip(message) .create(); + QuickFixAction.registerQuickFixAction(info, QUICK_FIX_FACTORY.createImplementMethodsFix(aClass)); + return info; } if (isDefault || !isAbstract && superMethod.hasModifierProperty(PsiModifier.ABSTRACT)) { @@ -471,9 +473,11 @@ public class GenericsHighlightUtil { HighlightUtil.formatClass(containingClass) + " and " + HighlightUtil.formatClass(superContainingClass); - return HighlightInfo + final HighlightInfo info = HighlightInfo .newHighlightInfo(HighlightInfoType.ERROR).range(classIdentifier).descriptionAndTooltip(inheritUnrelatedDefaultsMessage) .create(); + QuickFixAction.registerQuickFixAction(info, QUICK_FIX_FACTORY.createImplementMethodsFix(aClass)); + return info; } } } From b507f4bdd9dac935b75e6301f35ee7e063e946f3 Mon Sep 17 00:00:00 2001 From: "Egor.Ushakov" Date: Mon, 19 Jan 2015 15:23:23 +0300 Subject: [PATCH 08/24] icons integrated - DSGN-1688 Icons for Console and idea.log are identical --- platform/icons/src/debugger/console_log.png | Bin 208 -> 210 bytes platform/icons/src/debugger/console_log@2x.png | Bin 270 -> 282 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/platform/icons/src/debugger/console_log.png b/platform/icons/src/debugger/console_log.png index 3e9ae80c01d41a98fd19e8a78bcc2ac7fb960569..9b18e1e769a8cdbeae9920f5f90d1781b6b084c1 100644 GIT binary patch delta 90 zcmV-g0Hy!X0n!1GBmtR`C0|a)Y5-Iq2Z})k_@H6@E`V{cVW6!!Fq_FTfK(SSAYrmx wfMEc|E0Kx1G0Jmpz;kHQofB*mh07*qoM6N<$f=Tis@c;k- delta 88 zcmV-e0H^=b0nh=EBmtL^C0|S?+5j}{gN&gDZ u2B0axP)v*g*l-Rt4Zt3V_%NCmFfah=z;s14fMK8j0000Q0-6GlBmv=(C5>pI69Q043kOEd+>iz<`Iqr~?Mv0eI9ArJouONF+B44|)d>i$@(mozCe%I{*M) W2^P*Ik=Wz_0000Fs5TJJmxZuN32PC3lkQmiMAQ4?Zv6yNhKywF-h5#8M zz<>kOEd)j#FvJ~z#{i-XriKGZ!HJ^|pn5?>cLz{{aU{Z_;Q#>p#~2vI9z&l10000< KMNUMnLSTXhRwgF^ From 7eec28c4c154e4bf88e2497f534884cfc0c51459 Mon Sep 17 00:00:00 2001 From: Konstantin Bulenkov Date: Mon, 19 Jan 2015 14:03:00 +0100 Subject: [PATCH 09/24] duplicate symbols in Search Everywhere --- .../src/com/intellij/ide/actions/SearchEverywhereAction.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/lang-impl/src/com/intellij/ide/actions/SearchEverywhereAction.java b/platform/lang-impl/src/com/intellij/ide/actions/SearchEverywhereAction.java index 4bcc12c7164f..9924625c86f5 100644 --- a/platform/lang-impl/src/com/intellij/ide/actions/SearchEverywhereAction.java +++ b/platform/lang-impl/src/com/intellij/ide/actions/SearchEverywhereAction.java @@ -1685,7 +1685,7 @@ public class SearchEverywhereAction extends AnAction implements CustomComponentA if (o instanceof PsiElement && !(((PsiElement)o).getParent() instanceof PsiFile)) { final PsiElement element = (PsiElement)o; final PsiFile file = element.getContainingFile(); - if (!myListModel.contains(o) && + if (!myListModel.contains(o) && !symbols.contains(o) && //some elements are non-physical like DB columns (file == null || (file.getVirtualFile() != null && (includeLibs || scope.accept(file.getVirtualFile()))))) { symbols.add(o); From a5a75b212024ca035d021871a5c1937fa1db86cd Mon Sep 17 00:00:00 2001 From: Dmitry Batrak Date: Mon, 19 Jan 2015 16:09:46 +0300 Subject: [PATCH 10/24] IDEA-69974 Fold regions are not properly created if 'Collapse All' is invoked right after opening editor --- .../folding/impl/FoldingUpdate.java | 7 +++++++ .../impl/UpdateFoldRegionsOperation.java | 19 +++++++++++-------- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/codeInsight/folding/impl/FoldingUpdate.java b/platform/lang-impl/src/com/intellij/codeInsight/folding/impl/FoldingUpdate.java index 07bd92cb687a..333725920ac6 100644 --- a/platform/lang-impl/src/com/intellij/codeInsight/folding/impl/FoldingUpdate.java +++ b/platform/lang-impl/src/com/intellij/codeInsight/folding/impl/FoldingUpdate.java @@ -281,6 +281,13 @@ public class FoldingUpdate { } public static class FoldingMap extends MultiMap{ + public FoldingMap() { + } + + public FoldingMap(FoldingMap map) { + super(map); + } + @NotNull @Override protected Map> createMap() { diff --git a/platform/lang-impl/src/com/intellij/codeInsight/folding/impl/UpdateFoldRegionsOperation.java b/platform/lang-impl/src/com/intellij/codeInsight/folding/impl/UpdateFoldRegionsOperation.java index ad0992d6128f..3e0d504fddd2 100644 --- a/platform/lang-impl/src/com/intellij/codeInsight/folding/impl/UpdateFoldRegionsOperation.java +++ b/platform/lang-impl/src/com/intellij/codeInsight/folding/impl/UpdateFoldRegionsOperation.java @@ -76,11 +76,14 @@ class UpdateFoldRegionsOperation implements Runnable { FoldingModelEx foldingModel = (FoldingModelEx)myEditor.getFoldingModel(); Map rangeToExpandStatusMap = newTroveMap(); - removeInvalidRegions(info, foldingModel, rangeToExpandStatusMap); + // FoldingUpdate caches instances of our object, so they must be immutable. + FoldingUpdate.FoldingMap elementsToFold = new FoldingUpdate.FoldingMap(myElementsToFoldMap); + + removeInvalidRegions(info, foldingModel, elementsToFold, rangeToExpandStatusMap); Map shouldExpand = newTroveMap(); Map groupExpand = newTroveMap(); - List newRegions = addNewRegions(info, foldingModel, rangeToExpandStatusMap, shouldExpand, groupExpand); + List newRegions = addNewRegions(info, foldingModel, elementsToFold, rangeToExpandStatusMap, shouldExpand, groupExpand); applyExpandStatus(newRegions, shouldExpand, groupExpand); } @@ -100,14 +103,14 @@ class UpdateFoldRegionsOperation implements Runnable { private List addNewRegions(@NotNull EditorFoldingInfo info, @NotNull FoldingModelEx foldingModel, - @NotNull Map rangeToExpandStatusMap, + FoldingUpdate.FoldingMap elementsToFold, @NotNull Map rangeToExpandStatusMap, @NotNull Map shouldExpand, @NotNull Map groupExpand) { List newRegions = newArrayList(); SmartPointerManager smartPointerManager = SmartPointerManager.getInstance(myProject); - for (PsiElement element : myElementsToFoldMap.keySet()) { + for (PsiElement element : elementsToFold.keySet()) { ProgressManager.checkCanceled(); - final Collection descriptors = myElementsToFoldMap.get(element); + final Collection descriptors = elementsToFold.get(element); for (FoldingDescriptor descriptor : descriptors) { FoldingGroup group = descriptor.getGroup(); TextRange range = descriptor.getRange(); @@ -165,7 +168,7 @@ class UpdateFoldRegionsOperation implements Runnable { private void removeInvalidRegions(@NotNull EditorFoldingInfo info, @NotNull FoldingModelEx foldingModel, - @NotNull Map rangeToExpandStatusMap) { + FoldingUpdate.FoldingMap elementsToFold, @NotNull Map rangeToExpandStatusMap) { List toRemove = newArrayList(); InjectedLanguageManager injectedManager = InjectedLanguageManager.getInstance(myProject); for (FoldRegion region : foldingModel.getAllFoldRegions()) { @@ -176,7 +179,7 @@ class UpdateFoldRegionsOperation implements Runnable { if (isInjected != myForInjected) continue; } final Collection descriptors; - if (element != null && !(descriptors = myElementsToFoldMap.get(element)).isEmpty()) { + if (element != null && !(descriptors = elementsToFold.get(element)).isEmpty()) { boolean matchingDescriptorFound = false; FoldingDescriptor[] array = descriptors.toArray(new FoldingDescriptor[descriptors.size()]); for (FoldingDescriptor descriptor : array) { @@ -194,7 +197,7 @@ class UpdateFoldRegionsOperation implements Runnable { break; } else { - myElementsToFoldMap.remove(element, descriptor); + elementsToFold.remove(element, descriptor); } } } From 74dfa8b378b4ee1ed022312163ee11336ac62b9d Mon Sep 17 00:00:00 2001 From: Denis Fokin Date: Mon, 19 Jan 2015 16:23:35 +0300 Subject: [PATCH 11/24] IDEA-135271 Delete file dialog does not position mouse cursor on default button --- .../src/com/intellij/ui/messages/SheetMessage.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/platform/platform-impl/src/com/intellij/ui/messages/SheetMessage.java b/platform/platform-impl/src/com/intellij/ui/messages/SheetMessage.java index 7837b48ab3fa..e9627386eb88 100755 --- a/platform/platform-impl/src/com/intellij/ui/messages/SheetMessage.java +++ b/platform/platform-impl/src/com/intellij/ui/messages/SheetMessage.java @@ -25,6 +25,7 @@ import com.intellij.openapi.wm.ex.WindowManagerEx; import com.intellij.ui.Gray; import com.intellij.ui.JBColor; import com.intellij.ui.mac.MacMainFrameDecorator; +import com.intellij.util.IJSwingUtilities; import com.intellij.util.ui.Animator; import org.jetbrains.annotations.NotNull; @@ -221,6 +222,7 @@ public class SheetMessage { staticImage = null; myWindow.setContentPane(myController.getPanel(myWindow)); + IJSwingUtilities.moveMousePointerOn(myWindow.getRootPane().getDefaultButton()); myController.requestFocus(); } else { if (restoreFullScreenButton) { From 66eba8e34d22b4b396f614dac87eeeab7f81b468 Mon Sep 17 00:00:00 2001 From: Konstantin Bulenkov Date: Mon, 19 Jan 2015 14:24:48 +0100 Subject: [PATCH 12/24] can't find Kotlin top-level function in SE --- .../intellij/ide/actions/SearchEverywhereAction.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/platform/lang-impl/src/com/intellij/ide/actions/SearchEverywhereAction.java b/platform/lang-impl/src/com/intellij/ide/actions/SearchEverywhereAction.java index 9924625c86f5..6ce52a5ab56e 100644 --- a/platform/lang-impl/src/com/intellij/ide/actions/SearchEverywhereAction.java +++ b/platform/lang-impl/src/com/intellij/ide/actions/SearchEverywhereAction.java @@ -1682,7 +1682,7 @@ public class SearchEverywhereAction extends AnAction implements CustomComponentA myProgressIndicator, new Processor() { @Override public boolean process(Object o) { - if (o instanceof PsiElement && !(((PsiElement)o).getParent() instanceof PsiFile)) { + if (isSymbol(o)) { final PsiElement element = (PsiElement)o; final PsiFile file = element.getContainingFile(); if (!myListModel.contains(o) && !symbols.contains(o) && @@ -1698,6 +1698,16 @@ public class SearchEverywhereAction extends AnAction implements CustomComponentA return symbols; } + protected boolean isSymbol(Object o) { + if (o instanceof PsiElement) { + final PsiElement e = (PsiElement)o; + //todo[kb] need a better way to avoid mixing java classes with symbols. Same to other languages where + //todo[kb] symbol provider returns classes. We need kind of suppressor API & EP here. + return !e.getLanguage().is(Language.findLanguageByID("JAVA")) || !(e.getParent() instanceof PsiFile); + } + return false; + } + private SearchResult getClasses(String pattern, boolean includeLibs, final int max, ChooseByNamePopup chooseByNamePopup) { final SearchResult classes = new SearchResult(); if (chooseByNamePopup == null) { From 4a7928f3763a205d7dc51a05e8ed16a49e17ad2f Mon Sep 17 00:00:00 2001 From: Dmitry Batrak Date: Mon, 19 Jan 2015 16:45:13 +0300 Subject: [PATCH 13/24] IDEA-69974 Fold regions are not properly created if 'Collapse All' is invoked right after opening editor test case added --- ...gProcessingOnDocumentModificationTest.java | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/java/java-tests/testSrc/com/intellij/openapi/editor/impl/FoldingProcessingOnDocumentModificationTest.java b/java/java-tests/testSrc/com/intellij/openapi/editor/impl/FoldingProcessingOnDocumentModificationTest.java index 6da536d86d2c..ad12ef131055 100644 --- a/java/java-tests/testSrc/com/intellij/openapi/editor/impl/FoldingProcessingOnDocumentModificationTest.java +++ b/java/java-tests/testSrc/com/intellij/openapi/editor/impl/FoldingProcessingOnDocumentModificationTest.java @@ -16,6 +16,7 @@ package com.intellij.openapi.editor.impl; import com.intellij.codeInsight.folding.CodeFoldingManager; +import com.intellij.openapi.actionSystem.IdeActions; import com.intellij.openapi.editor.CaretModel; import com.intellij.openapi.editor.FoldRegion; import com.intellij.testFramework.TestFileType; @@ -55,7 +56,31 @@ public class FoldingProcessingOnDocumentModificationTest extends AbstractEditorT assertFalse(foldRegion.isExpanded()); } + public void testCollapseAllHappensBeforeFirstCodeFoldingPass() throws Exception { + init("class Foo {\n" + + " void m() {\n" + + " System.out.println();\n" + + " System.out.println();\n" + + " }\n" + + "}", TestFileType.JAVA); + + buildInitialFoldRegions(); + executeAction(IdeActions.ACTION_COLLAPSE_ALL_REGIONS); + runFoldingPass(true); + assertEquals(1, myEditor.getFoldingModel().getAllFoldRegions().length); + } + + private static void buildInitialFoldRegions() { + CodeFoldingManager.getInstance(getProject()).buildInitialFoldings(myEditor); + } + private static void updateFoldRegions() { CodeFoldingManager.getInstance(getProject()).updateFoldRegions(myEditor); } + + private static void runFoldingPass(boolean firstTime) { + Runnable runnable = CodeFoldingManager.getInstance(getProject()).updateFoldRegionsAsync(myEditor, firstTime); + assertNotNull(runnable); + runnable.run(); + } } From ab14fd7d1248de979b2a69b59aaadc645a05acca Mon Sep 17 00:00:00 2001 From: "Egor.Ushakov" Date: Mon, 19 Jan 2015 16:28:07 +0300 Subject: [PATCH 14/24] decompiler: fixed NPE with disabled line mapping --- .../org/jetbrains/java/decompiler/IdeaDecompiler.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/plugins/java-decompiler/plugin/src/org/jetbrains/java/decompiler/IdeaDecompiler.java b/plugins/java-decompiler/plugin/src/org/jetbrains/java/decompiler/IdeaDecompiler.java index 93650c2da4af..72e0f4f06512 100644 --- a/plugins/java-decompiler/plugin/src/org/jetbrains/java/decompiler/IdeaDecompiler.java +++ b/plugins/java-decompiler/plugin/src/org/jetbrains/java/decompiler/IdeaDecompiler.java @@ -1,5 +1,5 @@ /* - * Copyright 2000-2014 JetBrains s.r.o. + * Copyright 2000-2015 JetBrains s.r.o. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -183,8 +183,9 @@ public class IdeaDecompiler extends ClassFileDecompilers.Light { } decompiler.decompileContext(); - file.putUserData(LineNumbersMapping.LINE_NUMBERS_MAPPING_KEY, - new ExactMatchLineNumbersMapping(saver.myMapping)); + if (saver.myMapping != null) { + file.putUserData(LineNumbersMapping.LINE_NUMBERS_MAPPING_KEY, new ExactMatchLineNumbersMapping(saver.myMapping)); + } return saver.myResult; } @@ -344,7 +345,7 @@ public class IdeaDecompiler extends ClassFileDecompilers.Light { private static class ExactMatchLineNumbersMapping implements LineNumbersMapping { private int[] myMapping; - private ExactMatchLineNumbersMapping(int[] mapping) { + private ExactMatchLineNumbersMapping(@NotNull int[] mapping) { myMapping = mapping; } From 4fb1124d2dd6ead2c24ec00417438051cb3a40fe Mon Sep 17 00:00:00 2001 From: Roman Shevchenko Date: Mon, 19 Jan 2015 14:58:18 +0100 Subject: [PATCH 15/24] IDEA-133004 (no comment injections for binary files) --- .../plugins/intelliLang/inject/InjectorUtils.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/plugins/IntelliLang/src/org/intellij/plugins/intelliLang/inject/InjectorUtils.java b/plugins/IntelliLang/src/org/intellij/plugins/intelliLang/inject/InjectorUtils.java index 1b4e43ec4df1..035507d22122 100644 --- a/plugins/IntelliLang/src/org/intellij/plugins/intelliLang/inject/InjectorUtils.java +++ b/plugins/IntelliLang/src/org/intellij/plugins/intelliLang/inject/InjectorUtils.java @@ -1,5 +1,5 @@ /* - * Copyright 2000-2014 JetBrains s.r.o. + * Copyright 2000-2015 JetBrains s.r.o. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -229,15 +229,17 @@ public class InjectorUtils { public static BaseInjection findCommentInjection(@NotNull PsiElement context, @NotNull String supportId, @Nullable Ref causeRef) { PsiElement target = CompletionUtil.getOriginalOrSelf(context); PsiFile file = target.getContainingFile(); + if (file == null || file.getFileType().isBinary()) return null; TreeMap map = getInjectionMap(file); - Map.Entry entry = map == null ? null : map.lowerEntry(target.getTextRange()); + if (map == null) return null; + Map.Entry entry = map.lowerEntry(target.getTextRange()); if (entry == null) return null; PsiComment psiComment = PsiTreeUtil.findElementOfClassAtOffset(file, entry.getKey().getStartOffset(), PsiComment.class, false); if (psiComment == null) return null; TextRange r0 = psiComment.getTextRange(); - // calulate topmost siblings & heights + // calculate topmost siblings & heights PsiElement commonParent = PsiTreeUtil.findCommonParent(psiComment, target); int h1 = 0, h2 = 0; PsiElement e1 = psiComment, e2 = target; @@ -269,8 +271,7 @@ public class InjectorUtils { } @Nullable - private static TreeMap getInjectionMap(@Nullable final PsiFile file) { - if (file == null) return null; // e.g. null for synthetic groovy variables + private static TreeMap getInjectionMap(@NotNull final PsiFile file) { return CachedValuesManager.getCachedValue(file, new CachedValueProvider>() { @Nullable @Override From 4ff4a347ac342a72e3b9254821095e875dfc7f9f Mon Sep 17 00:00:00 2001 From: "Vladimir.Orlov" Date: Mon, 19 Jan 2015 17:12:35 +0300 Subject: [PATCH 16/24] IDEA-133615 Automatic update breaks --- platform/util/src/com/intellij/util/Restarter.java | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/util/src/com/intellij/util/Restarter.java b/platform/util/src/com/intellij/util/Restarter.java index 8ee6f46b1093..fdcc4f876b3f 100644 --- a/platform/util/src/com/intellij/util/Restarter.java +++ b/platform/util/src/com/intellij/util/Restarter.java @@ -156,6 +156,7 @@ public class Restarter { public static File createTempExecutable(File executable) throws IOException { File executableDir = new File(System.getProperty("user.home") + "/." + System.getProperty("idea.paths.selector") + "/restart"); File copy = new File(executableDir.getPath() + "/" + executable.getName()); + if (!FileUtilRt.createDirectory(executableDir)) throw new IOException("Cannot create dir: " + executableDir); if (!FileUtilRt.ensureCanCreateFile(copy) || (copy.exists() && !copy.delete())) { String ext = FileUtilRt.getExtension(executable.getName()); copy = FileUtilRt.createTempFile(executableDir, FileUtilRt.getNameWithoutExtension(copy.getName()), From 9cf3ef745393cdf5c72da0ddc17c65abbaf9919b Mon Sep 17 00:00:00 2001 From: Daniil Ovchinnikov Date: Mon, 19 Jan 2015 17:12:52 +0300 Subject: [PATCH 17/24] IDEA-135033 Storage for activation status fixed & .gdsl files within library sources ignored --- .../groovy/dsl/DslActivationStatus.java | 20 +++++++++++++------ .../groovy/dsl/GroovyDslFileIndex.java | 7 +++++-- 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/dsl/DslActivationStatus.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/dsl/DslActivationStatus.java index de1d162148bb..267707e08207 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/dsl/DslActivationStatus.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/dsl/DslActivationStatus.java @@ -1,5 +1,5 @@ /* - * Copyright 2000-2014 JetBrains s.r.o. + * Copyright 2000-2015 JetBrains s.r.o. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,6 +16,7 @@ package org.jetbrains.plugins.groovy.dsl; import com.intellij.openapi.components.*; +import com.intellij.openapi.util.text.StringUtil; import com.intellij.openapi.vfs.VirtualFile; import com.intellij.openapi.vfs.VirtualFileManager; import gnu.trove.THashMap; @@ -49,11 +50,16 @@ public class DslActivationStatus implements PersistentStateComponent { @Nullable public synchronized String getInactivityReason(VirtualFile file) { String status = myStatus.get(file); - return status == null || status == ENABLED ? null : status; + return ENABLED.equals(status) ? null : status; } public synchronized boolean isActivated(VirtualFile file) { - return myStatus.get(file) == ENABLED; + final String status = myStatus.get(file); + if (status == null) { + myStatus.put(file, ENABLED); + return true; + } + return ENABLED.equals(status); } @Nullable @@ -66,7 +72,9 @@ public class DslActivationStatus implements PersistentStateComponent { Element element = new Element("file"); root.addContent(element); element.setAttribute("url", file.getUrl()); - element.setAttribute("status", (status == ENABLED ? "" : status)); + if (!ENABLED.equals(status)) { + element.setAttribute("status", status); + } } return root; } @@ -76,10 +84,10 @@ public class DslActivationStatus implements PersistentStateComponent { List children = state.getChildren("file"); for (Element element : children) { String url = element.getAttributeValue("url", ""); - String status = element.getAttributeValue("status", ENABLED); + String status = element.getAttributeValue("status"); VirtualFile file = VirtualFileManager.getInstance().findFileByUrl(url); if (file != null) { - myStatus.put(file, status); + myStatus.put(file, StringUtil.isNotEmpty(status) ? status : ENABLED); } } } diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/dsl/GroovyDslFileIndex.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/dsl/GroovyDslFileIndex.java index e9692292588f..692aab0efc4c 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/dsl/GroovyDslFileIndex.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/dsl/GroovyDslFileIndex.java @@ -74,7 +74,7 @@ import java.util.regex.Pattern; */ public class GroovyDslFileIndex extends ScalarIndexExtension { private static final Key> CACHED_EXECUTOR = Key.create("CachedGdslExecutor"); - private static final Logger LOG = Logger.getInstance("#org.jetbrains.plugins.groovy.dsl.GroovyDslFileIndex"); + private static final Logger LOG = Logger.getInstance(GroovyDslFileIndex.class); @NonNls public static final ID NAME = ID.create("GroovyDslFileIndex"); @NonNls private static final String OUR_KEY = "ourKey"; @@ -412,7 +412,10 @@ public class GroovyDslFileIndex extends ScalarIndexExtension { if (!vfile.isValid()) { continue; } - if (!fileIndex.isInLibraryClasses(vfile) && !fileIndex.isInLibrarySource(vfile)) { + if (fileIndex.isInLibrarySource(vfile)) { + continue; + } + if (!fileIndex.isInLibraryClasses(vfile)) { if (!fileIndex.isInSourceContent(vfile) || !isActivated(vfile)) { continue; } From d261422680c7868d5d556c7eee653fcd5f4fdcc2 Mon Sep 17 00:00:00 2001 From: Eugene Zhuravlev Date: Mon, 19 Jan 2015 15:02:19 +0100 Subject: [PATCH 18/24] deleting classpath index files for changed output roots --- .../jps/incremental/IncProjectBuilder.java | 27 ++++++++++++++----- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/jps/jps-builders/src/org/jetbrains/jps/incremental/IncProjectBuilder.java b/jps/jps-builders/src/org/jetbrains/jps/incremental/IncProjectBuilder.java index 2f82e8df8b21..f8f576dec0fa 100644 --- a/jps/jps-builders/src/org/jetbrains/jps/incremental/IncProjectBuilder.java +++ b/jps/jps-builders/src/org/jetbrains/jps/incremental/IncProjectBuilder.java @@ -16,10 +16,7 @@ package org.jetbrains.jps.incremental; import com.intellij.openapi.diagnostic.Logger; -import com.intellij.openapi.util.LowMemoryWatcher; -import com.intellij.openapi.util.SystemInfo; -import com.intellij.openapi.util.UserDataHolder; -import com.intellij.openapi.util.UserDataHolderBase; +import com.intellij.openapi.util.*; import com.intellij.openapi.util.io.FileUtil; import com.intellij.openapi.util.text.StringUtil; import com.intellij.util.SmartList; @@ -84,7 +81,7 @@ import java.util.concurrent.atomic.AtomicReference; public class IncProjectBuilder { private static final Logger LOG = Logger.getInstance("#org.jetbrains.jps.incremental.IncProjectBuilder"); - private static final String CLASSPATH_INDEX_FINE_NAME = "classpath.index"; + private static final String CLASSPATH_INDEX_FILE_NAME = "classpath.index"; private static final boolean GENERATE_CLASSPATH_INDEX = Boolean.parseBoolean(System.getProperty(GlobalOptions.GENERATE_CLASSPATH_INDEX_OPTION, "false")); private static final boolean SYNC_DELETE = Boolean.parseBoolean(System.getProperty("jps.sync.delete", SystemInfo.isWindows ? "true" : "false")); private static final GlobalContextKey>> TARGET_WITH_CLEARED_OUTPUT = GlobalContextKey.create("_targets_with_cleared_output_"); @@ -334,7 +331,25 @@ public class IncProjectBuilder { BuildRunner.PARALLEL_BUILD_ENABLED); context.addBuildListener(new ChainedTargetsBuildListener(context)); + + //Deletes class loader classpath index files for changed output roots + context.addBuildListener(new BuildListener() { + @Override + public void filesGenerated(Collection> paths) { + final Set outputs = new THashSet(FileUtil.FILE_HASHING_STRATEGY); + for (Pair pair : paths) { + outputs.add(new File(pair.getFirst())); + } + for (File root : outputs) { + //noinspection ResultOfMethodCallIgnored + new File(root, CLASSPATH_INDEX_FILE_NAME).delete(); + } + } + @Override + public void filesDeleted(Collection paths) { + } + }); for (TargetBuilder builder : myBuilderRegistry.getTargetBuilders()) { builder.buildStarted(context); } @@ -965,7 +980,7 @@ public class IncProjectBuilder { File outputDir = ((ModuleBuildTarget)target).getOutputDir(); if (outputDir != null && outputDirs.add(outputDir)) { try { - BufferedWriter writer = new BufferedWriter(new FileWriter(new File(outputDir, CLASSPATH_INDEX_FINE_NAME))); + BufferedWriter writer = new BufferedWriter(new FileWriter(new File(outputDir, CLASSPATH_INDEX_FILE_NAME))); try { writeIndex(writer, outputDir, ""); } From 439d072906234171ff988c6bfb5393be551479cd Mon Sep 17 00:00:00 2001 From: Anna Kozlova Date: Mon, 19 Jan 2015 15:02:11 +0100 Subject: [PATCH 19/24] scopes: include/exclude disable status (IDEA-135311) --- .../util/scopeChooser/ScopeEditorPanel.java | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/ide/util/scopeChooser/ScopeEditorPanel.java b/platform/lang-impl/src/com/intellij/ide/util/scopeChooser/ScopeEditorPanel.java index f36f1e8f9bc7..d4802b60188c 100644 --- a/platform/lang-impl/src/com/intellij/ide/util/scopeChooser/ScopeEditorPanel.java +++ b/platform/lang-impl/src/com/intellij/ide/util/scopeChooser/ScopeEditorPanel.java @@ -38,6 +38,7 @@ import com.intellij.ui.*; import com.intellij.ui.components.panels.VerticalLayout; import com.intellij.ui.treeStructure.Tree; import com.intellij.util.Alarm; +import com.intellij.util.ArrayUtil; import com.intellij.util.Consumer; import com.intellij.util.ui.ColorIcon; import com.intellij.util.ui.UIUtil; @@ -237,11 +238,11 @@ public class ScopeEditorPanel { myPackageTree.getSelectionModel().addTreeSelectionListener(new TreeSelectionListener() { @Override public void valueChanged(TreeSelectionEvent e) { - final boolean recursiveEnabled = isButtonEnabled(true, e.getPaths(), e); + final boolean recursiveEnabled = isButtonEnabled(true); includeRec.setEnabled(recursiveEnabled); excludeRec.setEnabled(recursiveEnabled); - final boolean nonRecursiveEnabled = isButtonEnabled(false, e.getPaths(), e); + final boolean nonRecursiveEnabled = isButtonEnabled(false); include.setEnabled(nonRecursiveEnabled); exclude.setEnabled(nonRecursiveEnabled); } @@ -281,19 +282,6 @@ public class ScopeEditorPanel { return buttonsPanel; } - static boolean isButtonEnabled(boolean rec, TreePath[] paths, TreeSelectionEvent e) { - if (paths != null) { - for (TreePath path : paths) { - if (!e.isAddedPath(path)) continue; - final PackageDependenciesNode node = (PackageDependenciesNode)path.getLastPathComponent(); - if (PatternDialectProvider.getInstance(DependencyUISettings.getInstance().SCOPE_TYPE).createPackageSet(node, rec) != null) { - return true; - } - } - } - return false; - } - boolean isButtonEnabled(boolean rec) { final TreePath[] paths = myPackageTree.getSelectionPaths(); if (paths != null) { From 296d5e3182d130a4f10b8b56ab0143d50ca6ae7c Mon Sep 17 00:00:00 2001 From: Anna Kozlova Date: Mon, 19 Jan 2015 15:15:10 +0100 Subject: [PATCH 20/24] NPE (IDEA-135369) --- .../src/org/jetbrains/java/generate/psi/PsiAdapter.java | 8 ++++++-- .../openapi/projectRoots/JavaVersionServiceImpl.java | 2 ++ .../intellij/openapi/projectRoots/JavaVersionService.java | 2 ++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/java/java-analysis-impl/src/org/jetbrains/java/generate/psi/PsiAdapter.java b/java/java-analysis-impl/src/org/jetbrains/java/generate/psi/PsiAdapter.java index 75d620e1f3be..e19f7f578bf9 100644 --- a/java/java-analysis-impl/src/org/jetbrains/java/generate/psi/PsiAdapter.java +++ b/java/java-analysis-impl/src/org/jetbrains/java/generate/psi/PsiAdapter.java @@ -18,8 +18,8 @@ package org.jetbrains.java.generate.psi; import com.intellij.openapi.project.Project; import com.intellij.openapi.projectRoots.JavaSdkVersion; import com.intellij.openapi.projectRoots.JavaVersionService; +import com.intellij.openapi.projectRoots.JdkVersionUtil; import com.intellij.openapi.util.text.StringUtil; -import com.intellij.pom.java.LanguageLevel; import com.intellij.psi.*; import com.intellij.psi.codeStyle.CodeStyleManager; import com.intellij.psi.codeStyle.JavaCodeStyleManager; @@ -670,7 +670,11 @@ public class PsiAdapter { } public static int getJavaVersion(PsiElement element) { - final JavaSdkVersion sdkVersion = JavaVersionService.getInstance().getJavaSdkVersion(element); + JavaSdkVersion sdkVersion = JavaVersionService.getInstance().getJavaSdkVersion(element); + if (sdkVersion == null) { + sdkVersion = JavaSdkVersion.fromLanguageLevel(PsiUtil.getLanguageLevel(element)); + } + int version = 0; switch (sdkVersion) { case JDK_1_0: diff --git a/java/java-impl/src/com/intellij/openapi/projectRoots/JavaVersionServiceImpl.java b/java/java-impl/src/com/intellij/openapi/projectRoots/JavaVersionServiceImpl.java index 1a3ce4e0cea2..e473f5c67281 100644 --- a/java/java-impl/src/com/intellij/openapi/projectRoots/JavaVersionServiceImpl.java +++ b/java/java-impl/src/com/intellij/openapi/projectRoots/JavaVersionServiceImpl.java @@ -17,6 +17,7 @@ package com.intellij.openapi.projectRoots; import com.intellij.psi.PsiElement; import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; /** * @author anna @@ -28,6 +29,7 @@ public class JavaVersionServiceImpl extends JavaVersionService { return JavaSdkVersionUtil.isAtLeast(element, version); } + @Nullable @Override public JavaSdkVersion getJavaSdkVersion(@NotNull PsiElement element) { return JavaSdkVersionUtil.getJavaSdkVersion(element); diff --git a/java/java-psi-api/src/com/intellij/openapi/projectRoots/JavaVersionService.java b/java/java-psi-api/src/com/intellij/openapi/projectRoots/JavaVersionService.java index 5108c592c6ac..fe1873fdfd8d 100644 --- a/java/java-psi-api/src/com/intellij/openapi/projectRoots/JavaVersionService.java +++ b/java/java-psi-api/src/com/intellij/openapi/projectRoots/JavaVersionService.java @@ -23,6 +23,7 @@ import com.intellij.openapi.components.ServiceManager; import com.intellij.psi.PsiElement; import com.intellij.psi.util.PsiUtil; import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; public class JavaVersionService { public static JavaVersionService getInstance() { @@ -33,6 +34,7 @@ public class JavaVersionService { return PsiUtil.getLanguageLevel(element).isAtLeast(version.getMaxLanguageLevel()); } + @Nullable public JavaSdkVersion getJavaSdkVersion(@NotNull PsiElement element) { return JavaSdkVersion.fromLanguageLevel(PsiUtil.getLanguageLevel(element)); } From 4d2a8450dacb8cecf0cc45fe1ee5581938b1dedf Mon Sep 17 00:00:00 2001 From: nik Date: Mon, 19 Jan 2015 17:23:03 +0300 Subject: [PATCH 21/24] nio2 implementation of 'clonePermissions' corrected --- .../src/com/intellij/openapi/util/io/FileSystemUtil.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/platform/util/src/com/intellij/openapi/util/io/FileSystemUtil.java b/platform/util/src/com/intellij/openapi/util/io/FileSystemUtil.java index d734d4b4faa7..cbcf77d90fe6 100644 --- a/platform/util/src/com/intellij/openapi/util/io/FileSystemUtil.java +++ b/platform/util/src/com/intellij/openapi/util/io/FileSystemUtil.java @@ -305,12 +305,13 @@ public class FileSystemUtil { @Override protected boolean clonePermissions(@NotNull String source, @NotNull String target) throws Exception { if (SystemInfo.isUnix) { - Object pathObj = myGetPath.invoke(myDefaultFileSystem, source, ArrayUtil.EMPTY_STRING_ARRAY); - Map attributes = (Map)myReadAttributes.invoke(null, pathObj, "posix:permissions", myLinkOptions); + Object sourcePath = myGetPath.invoke(myDefaultFileSystem, source, ArrayUtil.EMPTY_STRING_ARRAY); + Object targetPath = myGetPath.invoke(myDefaultFileSystem, target, ArrayUtil.EMPTY_STRING_ARRAY); + Map attributes = (Map)myReadAttributes.invoke(null, sourcePath, "posix:permissions", myLinkOptions); if (attributes != null) { Object permissions = attributes.get("permissions"); if (permissions instanceof Collection) { - mySetAttribute.invoke(null, pathObj, "posix:permissions", permissions, myLinkOptions); + mySetAttribute.invoke(null, targetPath, "posix:permissions", permissions, myLinkOptions); return true; } } From 90a236e3f367d98032823e41b0a7dd6bd2b42480 Mon Sep 17 00:00:00 2001 From: nik Date: Mon, 19 Jan 2015 18:03:59 +0300 Subject: [PATCH 22/24] clone only 'executable' permissions during copying to avoid read-only files in the output (IDEA-133984) --- .../openapi/util/io/FileSystemUtil.java | 97 ++++++++++++++----- .../intellij/openapi/util/io/FileUtil.java | 2 +- 2 files changed, 76 insertions(+), 23 deletions(-) diff --git a/platform/util/src/com/intellij/openapi/util/io/FileSystemUtil.java b/platform/util/src/com/intellij/openapi/util/io/FileSystemUtil.java index cbcf77d90fe6..20e41ed39aad 100644 --- a/platform/util/src/com/intellij/openapi/util/io/FileSystemUtil.java +++ b/platform/util/src/com/intellij/openapi/util/io/FileSystemUtil.java @@ -56,7 +56,7 @@ public class FileSystemUtil { @Nullable protected abstract String resolveSymLink(@NotNull String path) throws Exception; - protected boolean clonePermissions(@NotNull String source, @NotNull String target) throws Exception { return false; } + protected boolean clonePermissions(@NotNull String source, @NotNull String target, boolean onlyPermissionsToExecute) throws Exception { return false; } @NotNull private String getName() { return getClass().getSimpleName().replace("MediatorImpl", ""); } @@ -196,7 +196,21 @@ public class FileSystemUtil { */ public static boolean clonePermissions(@NotNull String source, @NotNull String target) { try { - return ourMediator.clonePermissions(source, target); + return ourMediator.clonePermissions(source, target, false); + } + catch (Exception e) { + LOG.warn(e); + return false; + } + } + + /** + * Gives the second file permissions to execute of the first one if possible; returns true if succeed. + * Will do nothing on Windows. + */ + public static boolean clonePermissionsToExecute(@NotNull String source, @NotNull String target) { + try { + return ourMediator.clonePermissions(source, target, true); } catch (Exception e) { LOG.warn(e); @@ -303,22 +317,44 @@ public class FileSystemUtil { } @Override - protected boolean clonePermissions(@NotNull String source, @NotNull String target) throws Exception { + protected boolean clonePermissions(@NotNull String source, @NotNull String target, boolean onlyPermissionsToExecute) throws Exception { if (SystemInfo.isUnix) { Object sourcePath = myGetPath.invoke(myDefaultFileSystem, source, ArrayUtil.EMPTY_STRING_ARRAY); Object targetPath = myGetPath.invoke(myDefaultFileSystem, target, ArrayUtil.EMPTY_STRING_ARRAY); - Map attributes = (Map)myReadAttributes.invoke(null, sourcePath, "posix:permissions", myLinkOptions); - if (attributes != null) { - Object permissions = attributes.get("permissions"); - if (permissions instanceof Collection) { - mySetAttribute.invoke(null, targetPath, "posix:permissions", permissions, myLinkOptions); - return true; + Collection sourcePermissions = getPermissions(sourcePath); + if (sourcePermissions != null) { + Collection permissionsToSet; + if (onlyPermissionsToExecute) { + Collection targetPermissions = getPermissions(targetPath); + permissionsToSet = new HashSet(); + for (Object permission : targetPermissions) { + if (!permission.toString().endsWith("_EXECUTE")) { + permissionsToSet.add(permission); + } + } + for (Object permission : sourcePermissions) { + if (permission.toString().endsWith("_EXECUTE")) { + permissionsToSet.add(permission); + } + } } + else { + permissionsToSet = sourcePermissions; + } + mySetAttribute.invoke(null, targetPath, "posix:permissions", permissionsToSet, myLinkOptions); + return true; } } return false; } + + private Collection getPermissions(Object sourcePath) throws IllegalAccessException, InvocationTargetException { + Map attributes = (Map)myReadAttributes.invoke(null, sourcePath, "posix:permissions", myLinkOptions); + if (attributes == null) return null; + Object permissions = attributes.get("permissions"); + return permissions instanceof Collection ? (Collection)permissions : null; + } } @@ -347,6 +383,7 @@ public class FileSystemUtil { int S_IFREG = 0100000; // regular file int S_IFDIR = 0040000; // directory int PERM_MASK = 0777; + int EXECUTE_MASK = 0111; int WRITE_MASK = 0222; int W_OK = 2; // write permission flag for access(2) @@ -397,14 +434,13 @@ public class FileSystemUtil { int res = SystemInfo.isLinux ? myLibC.__lxstat64(0, path, buffer) : myLibC.lstat(path, buffer); if (res != 0) return null; - int mode = (SystemInfo.isLinux ? buffer.getInt(myOffsets[OFF_MODE]) : buffer.getShort(myOffsets[OFF_MODE])) & LibC.S_MASK; + int mode = getModeFlags(buffer) & LibC.S_MASK; boolean isSymlink = (mode & LibC.S_IFLNK) == LibC.S_IFLNK; if (isSymlink) { - res = SystemInfo.isLinux ? myLibC.__xstat64(0, path, buffer) : myLibC.stat(path, buffer); - if (res != 0) { + if (!loadFileStatus(path, buffer)) { return FileAttributes.BROKEN_SYMLINK; } - mode = (SystemInfo.isLinux ? buffer.getInt(myOffsets[OFF_MODE]) : buffer.getShort(myOffsets[OFF_MODE])) & LibC.S_MASK; + mode = getModeFlags(buffer) & LibC.S_MASK; } boolean isDirectory = (mode & LibC.S_IFDIR) == LibC.S_IFDIR; @@ -419,6 +455,10 @@ public class FileSystemUtil { return new FileAttributes(isDirectory, isSpecial, isSymlink, false, size, mTime, writable); } + private boolean loadFileStatus(@NotNull String path, Memory buffer) { + return (SystemInfo.isLinux ? myLibC.__xstat64(0, path, buffer) : myLibC.stat(path, buffer)) == 0; + } + @Override protected String resolveSymLink(@NotNull final String path) throws Exception { try { @@ -435,15 +475,25 @@ public class FileSystemUtil { } @Override - protected boolean clonePermissions(@NotNull String source, @NotNull String target) throws Exception { + protected boolean clonePermissions(@NotNull String source, @NotNull String target, boolean onlyPermissionsToExecute) throws Exception { Memory buffer = new Memory(256); - int res = SystemInfo.isLinux ? myLibC.__xstat64(0, source, buffer) : myLibC.stat(source, buffer); - if (res == 0) { - int permissions = (SystemInfo.isLinux ? buffer.getInt(myOffsets[OFF_MODE]) : buffer.getShort(myOffsets[OFF_MODE])) & LibC.PERM_MASK; - return myLibC.chmod(target, permissions) == 0; - } + if (!loadFileStatus(source, buffer)) return false; - return false; + int permissions; + int sourcePermissions = getModeFlags(buffer) & LibC.PERM_MASK; + if (onlyPermissionsToExecute) { + if (!loadFileStatus(target, buffer)) return false; + int targetPermissions = getModeFlags(buffer) & LibC.PERM_MASK; + permissions = targetPermissions & ~LibC.EXECUTE_MASK | sourcePermissions & LibC.EXECUTE_MASK; + } + else { + permissions = sourcePermissions; + } + return myLibC.chmod(target, permissions) == 0; + } + + private int getModeFlags(Memory buffer) { + return SystemInfo.isLinux ? buffer.getInt(myOffsets[OFF_MODE]) : buffer.getShort(myOffsets[OFF_MODE]); } private boolean ownFile(Memory buffer) { @@ -510,11 +560,14 @@ public class FileSystemUtil { } @Override - protected boolean clonePermissions(@NotNull String source, @NotNull String target) throws Exception { + protected boolean clonePermissions(@NotNull String source, @NotNull String target, boolean onlyPermissionsToExecute) throws Exception { if (SystemInfo.isUnix) { File srcFile = new File(source); File dstFile = new File(target); - return dstFile.setWritable(srcFile.canWrite(), true) && dstFile.setExecutable(srcFile.canExecute(), true); + if (!onlyPermissionsToExecute) { + if (!dstFile.setWritable(srcFile.canWrite(), true)) return false; + } + return dstFile.setExecutable(srcFile.canExecute(), true); } return false; diff --git a/platform/util/src/com/intellij/openapi/util/io/FileUtil.java b/platform/util/src/com/intellij/openapi/util/io/FileUtil.java index a747727cfbc3..419c1bbfe14c 100644 --- a/platform/util/src/com/intellij/openapi/util/io/FileUtil.java +++ b/platform/util/src/com/intellij/openapi/util/io/FileUtil.java @@ -497,7 +497,7 @@ public class FileUtil extends FileUtilRt { } if (SystemInfo.isUnix && fromFile.canExecute()) { - FileSystemUtil.clonePermissions(fromFile.getPath(), toFile.getPath()); + FileSystemUtil.clonePermissionsToExecute(fromFile.getPath(), toFile.getPath()); } } From 58dca1b0ae782163cf8a087e2a8c3df10ef8fcf8 Mon Sep 17 00:00:00 2001 From: "Egor.Ushakov" Date: Mon, 19 Jan 2015 18:07:55 +0300 Subject: [PATCH 23/24] IDEA-133347 Can't set breakpoint and debug in decompiled code --- .../ui/breakpoints/JavaLineBreakpointTypeBase.java | 6 +----- .../src/com/intellij/xdebugger/impl/XDebuggerUtilImpl.java | 7 ++++++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaLineBreakpointTypeBase.java b/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaLineBreakpointTypeBase.java index ebaee1e6d5ee..1be1fb56557d 100644 --- a/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaLineBreakpointTypeBase.java +++ b/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaLineBreakpointTypeBase.java @@ -1,5 +1,5 @@ /* - * Copyright 2000-2014 JetBrains s.r.o. + * Copyright 2000-2015 JetBrains s.r.o. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,7 +16,6 @@ package com.intellij.debugger.ui.breakpoints; import com.intellij.debugger.engine.DebuggerUtils; -import com.intellij.execution.filters.LineNumbersMapping; import com.intellij.openapi.editor.Document; import com.intellij.openapi.fileEditor.FileDocumentManager; import com.intellij.openapi.fileTypes.StdFileTypes; @@ -129,9 +128,6 @@ public abstract class JavaLineBreakpointTypeBase

Date: Mon, 19 Jan 2015 19:07:24 +0300 Subject: [PATCH 24/24] IDEA-126120 Proper handling for intersection types --- .../statements/expressions/TypesUtil.java | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/lang/psi/impl/statements/expressions/TypesUtil.java b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/lang/psi/impl/statements/expressions/TypesUtil.java index eaebe9c3be64..675b413ea83f 100644 --- a/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/lang/psi/impl/statements/expressions/TypesUtil.java +++ b/plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/lang/psi/impl/statements/expressions/TypesUtil.java @@ -221,20 +221,31 @@ public class TypesUtil { @NotNull PsiElement context, @NotNull ApplicableTo position) { if (actualType instanceof PsiIntersectionType) { + ConversionResult min = ConversionResult.ERROR; for (PsiType child : ((PsiIntersectionType)actualType).getConjuncts()) { - if (canAssign(targetType, child, context, position) == ConversionResult.OK) { + final ConversionResult result = canAssign(targetType, child, context, position); + if (result.ordinal() < min.ordinal()) { + min = result; + } + if (min == ConversionResult.OK) { return ConversionResult.OK; } } - return ConversionResult.ERROR; + return min; } + if (targetType instanceof PsiIntersectionType) { + ConversionResult max = ConversionResult.OK; for (PsiType child : ((PsiIntersectionType)targetType).getConjuncts()) { - if (canAssign(child, actualType, context, position) != ConversionResult.OK) { + final ConversionResult result = canAssign(child, actualType, context, position); + if (result.ordinal() > max.ordinal()) { + max = result; + } + if (max == ConversionResult.ERROR) { return ConversionResult.ERROR; } } - return ConversionResult.OK; + return max; } final ConversionResult result = areTypesConvertible(targetType, actualType, context, position);