From ec190d6006f2d0af23b0c6ded16fcc08aabf1684 Mon Sep 17 00:00:00 2001 From: Alexander Koshevoy Date: Mon, 31 Oct 2016 17:37:28 +0300 Subject: [PATCH] PY-21273 Lack of synchronization for myDebuggerReader fixed according to the review remark --- .../pydev/transport/ClientModeDebuggerTransport.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/python/pydevSrc/com/jetbrains/python/debugger/pydev/transport/ClientModeDebuggerTransport.java b/python/pydevSrc/com/jetbrains/python/debugger/pydev/transport/ClientModeDebuggerTransport.java index 4deb6b3e6a06..9bd13a4bdc91 100644 --- a/python/pydevSrc/com/jetbrains/python/debugger/pydev/transport/ClientModeDebuggerTransport.java +++ b/python/pydevSrc/com/jetbrains/python/debugger/pydev/transport/ClientModeDebuggerTransport.java @@ -72,7 +72,7 @@ public class ClientModeDebuggerTransport extends BaseDebuggerTransport { @NotNull private volatile State myState = State.INIT; @Nullable private Socket mySocket; - @Nullable private DebuggerReader myDebuggerReader; + @Nullable private volatile DebuggerReader myDebuggerReader; public ClientModeDebuggerTransport(@NotNull IPyDebugProcess debugProcess, @NotNull RemoteDebugger debugger, @@ -198,8 +198,9 @@ public class ClientModeDebuggerTransport extends BaseDebuggerTransport { @Override public void close() { try { - if (myDebuggerReader != null) { - myDebuggerReader.stop(); + DebuggerReader debuggerReader = myDebuggerReader; + if (debuggerReader != null) { + debuggerReader.stop(); } } finally {