diff --git a/java/java-analysis-impl/src/META-INF/JavaAnalysisPlugin.xml b/java/java-analysis-impl/src/META-INF/JavaAnalysisPlugin.xml
index ed069fa8c587..93ff32ca0703 100644
--- a/java/java-analysis-impl/src/META-INF/JavaAnalysisPlugin.xml
+++ b/java/java-analysis-impl/src/META-INF/JavaAnalysisPlugin.xml
@@ -98,6 +98,7 @@
diff --git a/java/java-impl/src/com/intellij/codeInspection/AnonymousCanBeMethodReferenceInspection.java b/java/java-impl/src/com/intellij/codeInspection/AnonymousCanBeMethodReferenceInspection.java
index 8c8ab485435b..706d68fa6dcd 100644
--- a/java/java-impl/src/com/intellij/codeInspection/AnonymousCanBeMethodReferenceInspection.java
+++ b/java/java-impl/src/com/intellij/codeInspection/AnonymousCanBeMethodReferenceInspection.java
@@ -1,4 +1,4 @@
-// Copyright 2000-2017 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
+// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.codeInspection;
import com.intellij.codeInspection.LambdaCanBeMethodReferenceInspection.MethodReferenceCandidate;
@@ -81,7 +81,7 @@ public class AnonymousCanBeMethodReferenceInspection extends AbstractBaseJavaLoc
final TextRange rangeInElement = new TextRange(0, aClass.getStartOffsetInParent() + lBrace.getStartOffsetInParent());
ProblemHighlightType type;
if (methodReferenceCandidate.mySafeQualifier && methodReferenceCandidate.myConformsCodeStyle) {
- type = ProblemHighlightType.LIKE_UNUSED_SYMBOL;
+ type = ProblemHighlightType.GENERIC_ERROR_OR_WARNING;
}
else {
if (!isOnTheFly) return;
diff --git a/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedDeclarationInspection.java b/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedDeclarationInspection.java
index 13de5cd40b6b..ad02a4e0b057 100644
--- a/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedDeclarationInspection.java
+++ b/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedDeclarationInspection.java
@@ -338,7 +338,7 @@ public final class UnusedDeclarationInspection extends UnusedDeclarationInspecti
PsiElement toHighlight = ObjectUtils.notNull(psiVariable.getNameIdentifier(), psiVariable);
return myInspectionManager.createProblemDescriptor(
toHighlight, JavaBundle.message("inspection.unused.assignment.problem.descriptor1"), (LocalQuickFix)null,
- ProblemHighlightType.LIKE_UNUSED_SYMBOL, false);
+ ProblemHighlightType.GENERIC_ERROR_OR_WARNING, false);
}
}
}
diff --git a/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedParametersInspection.java b/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedParametersInspection.java
index e53eca02f81e..0fdf97e1dbe5 100644
--- a/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedParametersInspection.java
+++ b/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedParametersInspection.java
@@ -64,7 +64,7 @@ class UnusedParametersInspection extends GlobalJavaBatchInspectionTool {
? "inspection.unused.parameter.composer"
: "inspection.unused.parameter.composer1"),
new AcceptSuggested(globalContext.getRefManager(), processor, refParameter.getName()),
- ProblemHighlightType.LIKE_UNUSED_SYMBOL, false));
+ ProblemHighlightType.GENERIC_ERROR_OR_WARNING, false));
}
}
return result.toArray(CommonProblemDescriptor.EMPTY_ARRAY);
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterCallInExpression.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterCallInExpression.java
index 0cd57f4074f3..652017771b6e 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterCallInExpression.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterCallInExpression.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
String foo(int n) {
return switch (n) {
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterCallInStatement.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterCallInStatement.java
index c527f8fb89b8..e8b05c8793df 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterCallInStatement.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterCallInStatement.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
void foo(int n) {
String s;
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterConstInExpression.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterConstInExpression.java
index 3fa486fe32f3..c2b29fd40c89 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterConstInExpression.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterConstInExpression.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
String foo(int n) {
return switch (n) {
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterSwitchExpressionInExpression.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterSwitchExpressionInExpression.java
index 7033e8b1ae63..f7f443416846 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterSwitchExpressionInExpression.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterSwitchExpressionInExpression.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
int foo(final int x, int n) {
return switch (x) {
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterThrowInExpression.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterThrowInExpression.java
index 72b890cb7d20..9960f9b01c40 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterThrowInExpression.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterThrowInExpression.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
String foo(int n) {
return switch (n) {
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterThrowInStatement.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterThrowInStatement.java
index d453062d5e13..58eb644c0247 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterThrowInStatement.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/afterThrowInStatement.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
String foo(int n) {
switch (n) {
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeCallInExpression.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeCallInExpression.java
index 4010a8644b41..cfddf3a9f810 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeCallInExpression.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeCallInExpression.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
String foo(int n) {
return switch (n) {
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeCallInStatement.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeCallInStatement.java
index 2df03f479191..e9596a547e0f 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeCallInStatement.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeCallInStatement.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
void foo(int n) {
String s;
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeConstInExpression.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeConstInExpression.java
index 428259580d9a..25403abc30ea 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeConstInExpression.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeConstInExpression.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
String foo(int n) {
return switch (n) {
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeSwitchExpressionInExpression.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeSwitchExpressionInExpression.java
index 716e9d40b9c3..da18dd457f55 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeSwitchExpressionInExpression.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeSwitchExpressionInExpression.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
int foo(final int x, int n) {
return switch (x) {
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeThrowInExpression.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeThrowInExpression.java
index 3f40027d1ecd..1f52cf3bb637 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeThrowInExpression.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeThrowInExpression.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
String foo(int n) {
return switch (n) {
diff --git a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeThrowInStatement.java b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeThrowInStatement.java
index cc1a2c6cc60c..89e1f6abf00b 100644
--- a/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeThrowInStatement.java
+++ b/java/java-tests/testData/inspection/redundantLabeledSwitchRuleCodeBlockFix/beforeThrowInStatement.java
@@ -1,4 +1,4 @@
-// "Unwrap code block of labeled rule" "LIKE_UNUSED_SYMBOL"
+// "Unwrap code block of labeled rule" "GENERIC_ERROR_OR_WARNING"
class C {
String foo(int n) {
switch (n) {
diff --git a/java/java-tests/testSrc/com/intellij/codeInspection/ex/InspectionProfileTest.java b/java/java-tests/testSrc/com/intellij/codeInspection/ex/InspectionProfileTest.java
index 549d6acebf0d..620ba23aed63 100644
--- a/java/java-tests/testSrc/com/intellij/codeInspection/ex/InspectionProfileTest.java
+++ b/java/java-tests/testSrc/com/intellij/codeInspection/ex/InspectionProfileTest.java
@@ -201,9 +201,7 @@ public class InspectionProfileTest extends LightIdeaTestCase {
public void testCustomTextAttributes() throws IOException, JDOMException {
@Language("XML") String content = "\n" +
" \n" +
- " \n" +
- " \n" +
+ " \n" +
"";
InspectionProfileImpl profile = createProfile();
readFromXml(profile, content);
@@ -727,7 +725,7 @@ public class InspectionProfileTest extends LightIdeaTestCase {
});
String mergedText = "\n" +
" \n" +
- " \n" +
+ " \n" +
" \n" +
" \n" +
" \n" +
diff --git a/java/java-tests/testSrc/com/intellij/codeInspection/ex/ProjectInspectionManagerTest.kt b/java/java-tests/testSrc/com/intellij/codeInspection/ex/ProjectInspectionManagerTest.kt
index cf16b2c595e0..87caf2a196cb 100644
--- a/java/java-tests/testSrc/com/intellij/codeInspection/ex/ProjectInspectionManagerTest.kt
+++ b/java/java-tests/testSrc/com/intellij/codeInspection/ex/ProjectInspectionManagerTest.kt
@@ -1,4 +1,4 @@
-// Copyright 2000-2020 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
+// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.codeInspection.ex
import com.intellij.codeHighlighting.HighlightDisplayLevel
@@ -136,7 +136,7 @@ class ProjectInspectionManagerTest {
-
+
""".trimIndent())
@@ -251,7 +251,7 @@ class ProjectInspectionManagerTest {
-
+
diff --git a/platform/analysis-api/src/com/intellij/codeInspection/InspectionEP.java b/platform/analysis-api/src/com/intellij/codeInspection/InspectionEP.java
index 8971f4ca0619..c7e5b7831c47 100644
--- a/platform/analysis-api/src/com/intellij/codeInspection/InspectionEP.java
+++ b/platform/analysis-api/src/com/intellij/codeInspection/InspectionEP.java
@@ -237,6 +237,12 @@ public class InspectionEP extends LanguageExtensionPoint
@Attribute("isInternal")
public boolean isInternal;
+ /**
+ * TextAttributesKey's external name
+ */
+ @Attribute("editorAttributes")
+ public String editorAttributes;
+
@Override
public String toString() {
return "InspectionEP{" +
diff --git a/platform/analysis-api/src/com/intellij/codeInspection/InspectionProfileEntry.java b/platform/analysis-api/src/com/intellij/codeInspection/InspectionProfileEntry.java
index 741556608724..39afc8dc2927 100644
--- a/platform/analysis-api/src/com/intellij/codeInspection/InspectionProfileEntry.java
+++ b/platform/analysis-api/src/com/intellij/codeInspection/InspectionProfileEntry.java
@@ -1,4 +1,4 @@
-// Copyright 2000-2020 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
+// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.codeInspection;
import com.intellij.codeHighlighting.HighlightDisplayLevel;
@@ -27,7 +27,10 @@ import com.intellij.util.containers.HashingStrategy;
import com.intellij.util.xmlb.SerializationFilter;
import com.intellij.util.xmlb.annotations.Property;
import org.jdom.Element;
-import org.jetbrains.annotations.*;
+import org.jetbrains.annotations.Nls;
+import org.jetbrains.annotations.NonNls;
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
import javax.swing.*;
import java.io.BufferedReader;
@@ -482,6 +485,17 @@ public abstract class InspectionProfileEntry implements BatchSuppressableTool {
return null;
}
+ /**
+ * Do not override the method, register attributes in plugin.xml
+ *
+ * @return attributesKey's external name if editor presentation should be different from severity presentation
+ * {@code null} if attributes should correspond to chosen severity
+ */
+ public String getEditorAttributesKey() {
+ return null;
+ }
+
+
public static @Nls String getGeneralGroupName() {
return InspectionsBundle.message("inspection.general.tools.group.name");
}
diff --git a/platform/analysis-api/src/com/intellij/codeInspection/LocalInspectionEP.java b/platform/analysis-api/src/com/intellij/codeInspection/LocalInspectionEP.java
index 0abf316062aa..6f74453a96aa 100644
--- a/platform/analysis-api/src/com/intellij/codeInspection/LocalInspectionEP.java
+++ b/platform/analysis-api/src/com/intellij/codeInspection/LocalInspectionEP.java
@@ -37,12 +37,6 @@ public class LocalInspectionEP extends InspectionEP implements LocalInspectionTo
@Attribute("dynamicGroup")
public boolean dynamicGroup;
- /**
- * TextAttributesKey's external name
- */
- @Attribute("editorAttributes")
- public String editorAttributes;
-
@Override
public String getDefaultID() {
return id;
diff --git a/platform/analysis-api/src/com/intellij/codeInspection/LocalInspectionTool.java b/platform/analysis-api/src/com/intellij/codeInspection/LocalInspectionTool.java
index a998aae07442..77c3769df533 100644
--- a/platform/analysis-api/src/com/intellij/codeInspection/LocalInspectionTool.java
+++ b/platform/analysis-api/src/com/intellij/codeInspection/LocalInspectionTool.java
@@ -66,16 +66,6 @@ public abstract class LocalInspectionTool extends InspectionProfileEntry {
return getID();
}
- /**
- * Do not override the method, register attributes in plugin.xml
- *
- * @return attributesKey's external name if editor presentation should be different from severity presentation
- * {@code null} if attributes should correspond to chosen severity
- */
- public String getEditorAttributesKey() {
- return null;
- }
-
@Override
@NonNls
@Nullable
diff --git a/platform/analysis-api/src/com/intellij/codeInspection/ex/InspectionToolWrapper.java b/platform/analysis-api/src/com/intellij/codeInspection/ex/InspectionToolWrapper.java
index eb1b4314fb8e..0d3583e5952e 100644
--- a/platform/analysis-api/src/com/intellij/codeInspection/ex/InspectionToolWrapper.java
+++ b/platform/analysis-api/src/com/intellij/codeInspection/ex/InspectionToolWrapper.java
@@ -142,7 +142,12 @@ public abstract class InspectionToolWrapper toolWrapper = state.getTool();
if (toolWrapper.isInitialized()) {
@@ -148,7 +147,7 @@ public final class ToolsImpl implements Tools {
inspectionElement.setAttribute(ENABLED_BY_DEFAULT_ATTRIBUTE, Boolean.toString(myDefaultState.isEnabled()));
@Nullable String attributesKey = myDefaultState.getTextAttributesKeyExternalName();
if (attributesKey != null) {
- JDOMExternalizerUtil.writeField(inspectionElement, "myExternalName", attributesKey);
+ inspectionElement.setAttribute("editorAttributes", attributesKey);
}
InspectionToolWrapper,?> toolWrapper = myDefaultState.getTool();
if (toolWrapper.isInitialized()) {
@@ -167,9 +166,9 @@ public final class ToolsImpl implements Tools {
}
myDefaultState.setLevel(level);
InspectionToolWrapper,?> toolWrapper = myDefaultState.getTool();
- String attr = JDOMExternalizerUtil.readField(toolElement, "myExternalName");
- if (attr != null) {
- myDefaultState.setTextAttributesKey(attr);
+ String editorAttributes = toolElement.getAttributeValue("editorAttributes");
+ if (editorAttributes != null) {
+ myDefaultState.setTextAttributesKey(editorAttributes);
}
String enabled = toolElement.getAttributeValue(ENABLED_ATTRIBUTE);
boolean isEnabled = Boolean.parseBoolean(enabled);
@@ -210,9 +209,9 @@ public final class ToolsImpl implements Tools {
state = addTool(scopeName, copyToolWrapper, Boolean.parseBoolean(enabledInScope), scopeLevel);
}
- attr = JDOMExternalizerUtil.readField(scopeElement, "myExternalName");
- if (attr != null) {
- state.setTextAttributesKey(attr);
+ editorAttributes = scopeElement.getAttributeValue("editorAttributes");
+ if (editorAttributes != null) {
+ state.setTextAttributesKey(editorAttributes);
}
scopeNames.add(scopeName);
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/FinalMethodInFinalClassInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/FinalMethodInFinalClassInspection.java
index b3b96d01f550..6d99dd54683f 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/FinalMethodInFinalClassInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/FinalMethodInFinalClassInspection.java
@@ -16,7 +16,6 @@
package com.siyeh.ig.classlayout;
import com.intellij.codeInsight.AnnotationUtil;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.psi.*;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
@@ -67,7 +66,7 @@ public class FinalMethodInFinalClassInspection extends BaseInspection {
for (final PsiElement child : children) {
final String text = child.getText();
if (PsiModifier.FINAL.equals(text)) {
- registerError(child, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(child);
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/FinalPrivateMethodInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/FinalPrivateMethodInspection.java
index a25fc6e9d751..9b7b04c2fb87 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/FinalPrivateMethodInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/classlayout/FinalPrivateMethodInspection.java
@@ -66,7 +66,7 @@ public class FinalPrivateMethodInspection extends BaseInspection {
if (!HighlightUtil.isLegalModifierCombination(method.getModifierList())) {
return;
}
- registerModifierError(PsiModifier.FINAL, method, ProblemHighlightType.LIKE_UNUSED_SYMBOL, PsiModifier.FINAL);
+ registerModifierError(PsiModifier.FINAL, method, ProblemHighlightType.GENERIC_ERROR_OR_WARNING, PsiModifier.FINAL);
}
}
}
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/ConfusingElseInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/ConfusingElseInspection.java
index 407fdb6808d9..c649971bc412 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/ConfusingElseInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/ConfusingElseInspection.java
@@ -16,7 +16,6 @@
package com.siyeh.ig.controlflow;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
@@ -140,7 +139,7 @@ public class ConfusingElseInspection extends BaseInspection {
if (parentCompletesNormally(statement)) {
return;
}
- registerError(elseToken, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(elseToken);
}
private boolean parentCompletesNormally(PsiElement element) {
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryBreakInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryBreakInspection.java
index 58d6e376401f..2b309aa5e990 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryBreakInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryBreakInspection.java
@@ -1,7 +1,6 @@
// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.siyeh.ig.controlflow;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.psi.*;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
@@ -54,11 +53,11 @@ public class UnnecessaryBreakInspection extends BaseInspection {
final PsiBlockStatement blockStatement = (PsiBlockStatement)exitedStatement;
final PsiCodeBlock block = blockStatement.getCodeBlock();
if (ControlFlowUtils.blockCompletesWithStatement(block, statement)) {
- registerError(statement.getFirstChild(), ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(statement.getFirstChild());
}
}
else if (ControlFlowUtils.statementCompletesWithStatement(exitedStatement, statement)) {
- registerError(statement.getFirstChild(), ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(statement.getFirstChild());
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryContinueInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryContinueInspection.java
index afacbb13dbc2..79adfbf6502c 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryContinueInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryContinueInspection.java
@@ -15,7 +15,6 @@
*/
package com.siyeh.ig.controlflow;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.psi.*;
import com.intellij.psi.util.FileTypeUtils;
@@ -85,11 +84,11 @@ public class UnnecessaryContinueInspection extends BaseInspection {
final PsiBlockStatement blockStatement = (PsiBlockStatement)body;
final PsiCodeBlock block = blockStatement.getCodeBlock();
if (ControlFlowUtils.blockCompletesWithStatement(block, statement)) {
- registerError(statement.getFirstChild(), ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(statement.getFirstChild());
}
}
else if (ControlFlowUtils.statementCompletesWithStatement(body, statement)) {
- registerError(statement.getFirstChild(), ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(statement.getFirstChild());
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryDefaultInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryDefaultInspection.java
index 5207cd8e6201..d785a4b24895 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryDefaultInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryDefaultInspection.java
@@ -42,7 +42,8 @@ import java.util.Collection;
import java.util.Set;
import static com.intellij.codeInsight.daemon.impl.analysis.SwitchBlockHighlightingModel.PatternsInSwitchBlockHighlightingModel.CompletenessResult.COMPLETE_WITHOUT_TOTAL;
-import static com.intellij.codeInspection.ProblemHighlightType.*;
+import static com.intellij.codeInspection.ProblemHighlightType.GENERIC_ERROR_OR_WARNING;
+import static com.intellij.codeInspection.ProblemHighlightType.INFORMATION;
public class UnnecessaryDefaultInspection extends BaseInspection {
@@ -167,7 +168,7 @@ public class UnnecessaryDefaultInspection extends BaseInspection {
highlightType = INFORMATION;
}
else {
- highlightType = LIKE_UNUSED_SYMBOL;
+ highlightType = GENERIC_ERROR_OR_WARNING;
}
registerError(defaultStatement.getFirstChild(), highlightType);
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryLabelOnBreakStatementInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryLabelOnBreakStatementInspection.java
index 99630705cd05..66bcaeabd14f 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryLabelOnBreakStatementInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryLabelOnBreakStatementInspection.java
@@ -16,7 +16,6 @@
package com.siyeh.ig.controlflow;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
@@ -103,7 +102,7 @@ public class UnnecessaryLabelOnBreakStatementInspection
return;
}
if (exitedStatement.equals(labelEnabledParent)) {
- registerError(labelIdentifier, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(labelIdentifier);
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryLabelOnContinueStatementInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryLabelOnContinueStatementInspection.java
index b413c35fda41..2d0393448803 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryLabelOnContinueStatementInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryLabelOnContinueStatementInspection.java
@@ -16,7 +16,6 @@
package com.siyeh.ig.controlflow;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
@@ -84,7 +83,7 @@ public class UnnecessaryLabelOnContinueStatementInspection
final PsiStatement labelEnabledParent = PsiTreeUtil.getParentOfType(statement, PsiLoopStatement.class);
if (labelEnabledParent == null) return;
if (!exitedStatement.equals(labelEnabledParent)) return;
- registerError(labelIdentifier, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(labelIdentifier);
}
}
}
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryReturnInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryReturnInspection.java
index 3dbccafc2f8d..ee7bce2456fe 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryReturnInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/UnnecessaryReturnInspection.java
@@ -15,7 +15,6 @@
*/
package com.siyeh.ig.controlflow;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.openapi.util.Ref;
import com.intellij.psi.*;
@@ -84,7 +83,7 @@ public class UnnecessaryReturnInspection extends BaseInspection {
super.visitReturnStatement(statement);
final Ref constructorRef = Ref.create();
if (isReturnRedundant(statement, ignoreInThenBranch, true, constructorRef)) {
- registerError(statement.getFirstChild(), ProblemHighlightType.LIKE_UNUSED_SYMBOL, constructorRef.get());
+ registerError(statement.getFirstChild(), constructorRef.get());
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/errorhandling/EmptyFinallyBlockInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/errorhandling/EmptyFinallyBlockInspection.java
index 8f65f93a479c..8f56f0404a07 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/errorhandling/EmptyFinallyBlockInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/errorhandling/EmptyFinallyBlockInspection.java
@@ -17,7 +17,6 @@ package com.siyeh.ig.errorhandling;
import com.intellij.codeInsight.BlockUtils;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.tree.IElementType;
@@ -153,7 +152,7 @@ public class EmptyFinallyBlockInspection extends BaseInspection {
final String childText = child.getText();
if (PsiKeyword.FINALLY.equals(childText)) {
final boolean canDeleteTry = statement.getCatchBlocks().length == 0 && statement.getResourceList() == null;
- registerError(child, ProblemHighlightType.LIKE_UNUSED_SYMBOL, Boolean.valueOf(canDeleteTry));
+ registerError(child, Boolean.valueOf(canDeleteTry));
return;
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/imports/JavaLangImportInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/imports/JavaLangImportInspection.java
index c2153ffc2271..c43ffe3e3675 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/imports/JavaLangImportInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/imports/JavaLangImportInspection.java
@@ -16,7 +16,6 @@
package com.siyeh.ig.imports;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.psi.PsiFile;
import com.intellij.psi.PsiImportStatement;
import com.intellij.psi.PsiJavaCodeReferenceElement;
@@ -69,7 +68,7 @@ public class JavaLangImportInspection extends BaseInspection implements CleanupL
}
if (statement.isOnDemand()) {
if (HardcodedMethodConstants.JAVA_LANG.equals(text)) {
- registerError(statement, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(statement);
}
}
else {
@@ -84,7 +83,7 @@ public class JavaLangImportInspection extends BaseInspection implements CleanupL
if (ImportUtils.hasOnDemandImportConflict(text, statement)) {
return;
}
- registerError(statement, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(statement);
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/imports/SamePackageImportInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/imports/SamePackageImportInspection.java
index 933a6fc9f1b6..600a87829e12 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/imports/SamePackageImportInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/imports/SamePackageImportInspection.java
@@ -16,7 +16,6 @@
package com.siyeh.ig.imports;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.psi.*;
import com.intellij.psi.util.FileTypeUtils;
import com.siyeh.InspectionGadgetsBundle;
@@ -72,7 +71,7 @@ public class SamePackageImportInspection extends BaseInspection implements Clean
final String text = importStatement.getQualifiedName();
if (importStatement.isOnDemand()) {
if (packageName.equals(text)) {
- registerError(importStatement, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(importStatement);
}
}
else {
@@ -88,7 +87,7 @@ public class SamePackageImportInspection extends BaseInspection implements Clean
parentName = text.substring(0, classNameIndex);
}
if (packageName.equals(parentName)) {
- registerError(importStatement, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(importStatement);
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnaryPlusInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnaryPlusInspection.java
index 21b66ac41ba0..87258ee06646 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnaryPlusInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnaryPlusInspection.java
@@ -131,7 +131,7 @@ public final class UnaryPlusInspection extends BaseInspection {
// unary plus might have been used as cast to int
return;
}
- registerError(prefixExpression.getOperationSign(), ProblemHighlightType.LIKE_UNUSED_SYMBOL, isOnTheFly(), prefixExpression);
+ registerError(prefixExpression.getOperationSign(), ProblemHighlightType.GENERIC_ERROR_OR_WARNING, isOnTheFly(), prefixExpression);
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnnecessaryExplicitNumericCastInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnnecessaryExplicitNumericCastInspection.java
index 949eef8a0027..a0f6a572b800 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnnecessaryExplicitNumericCastInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnnecessaryExplicitNumericCastInspection.java
@@ -2,7 +2,6 @@
package com.siyeh.ig.numeric;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.lang.java.parser.ExpressionParser;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
@@ -100,7 +99,7 @@ public final class UnnecessaryExplicitNumericCastInspection extends BaseInspecti
}
final PsiTypeElement typeElement = expression.getCastType();
if (typeElement != null) {
- registerError(typeElement, ProblemHighlightType.LIKE_UNUSED_SYMBOL, expression.getOperand());
+ registerError(typeElement, expression.getOperand());
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnnecessaryUnaryMinusInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnnecessaryUnaryMinusInspection.java
index da140d64cd88..e1acb56c93ea 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnnecessaryUnaryMinusInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/numeric/UnnecessaryUnaryMinusInspection.java
@@ -1,7 +1,7 @@
-// Copyright 2000-2021 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
+// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.siyeh.ig.numeric;
-import com.intellij.codeInspection.*;
+import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.tree.IElementType;
@@ -172,7 +172,7 @@ public final class UnnecessaryUnaryMinusInspection extends BaseInspection {
ContainerUtil.addIfNotNull(fixes, createRemoveDoubleUnaryMinusFix(prefixExpr));
}
if (!fixes.isEmpty()) {
- registerError(prefixExpr.getOperationSign(), ProblemHighlightType.LIKE_UNUSED_SYMBOL,
+ registerError(prefixExpr.getOperationSign(),
(Object)fixes.toArray(InspectionGadgetsFix.EMPTY_ARRAY));
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/redundancy/UnusedLabelInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/redundancy/UnusedLabelInspection.java
index 54e86b2f30f1..fa2c6ed7579a 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/redundancy/UnusedLabelInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/redundancy/UnusedLabelInspection.java
@@ -16,7 +16,6 @@
package com.siyeh.ig.redundancy;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.siyeh.InspectionGadgetsBundle;
@@ -86,7 +85,7 @@ public class UnusedLabelInspection extends BaseInspection {
return;
}
final PsiIdentifier labelIdentifier = statement.getLabelIdentifier();
- registerError(labelIdentifier, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(labelIdentifier);
}
private static boolean containsBreakOrContinueForLabel(PsiLabeledStatement statement) {
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/serialization/TransientFieldInNonSerializableClassInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/serialization/TransientFieldInNonSerializableClassInspection.java
index ce2b6720e7e8..cc9d5165ce33 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/serialization/TransientFieldInNonSerializableClassInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/serialization/TransientFieldInNonSerializableClassInspection.java
@@ -15,7 +15,6 @@
*/
package com.siyeh.ig.serialization;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.psi.PsiClass;
import com.intellij.psi.PsiField;
import com.intellij.psi.PsiModifier;
@@ -59,7 +58,7 @@ public class TransientFieldInNonSerializableClassInspection extends BaseInspecti
if (SerializationUtils.isSerializable(aClass)) {
return;
}
- registerModifierError(PsiModifier.TRANSIENT, field, ProblemHighlightType.LIKE_UNUSED_SYMBOL, field);
+ registerModifierError(PsiModifier.TRANSIENT, field, field);
}
}
}
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/RedundantFieldInitializationInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/RedundantFieldInitializationInspection.java
index 39d69e126676..afeae9686447 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/RedundantFieldInitializationInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/RedundantFieldInitializationInspection.java
@@ -17,7 +17,6 @@ package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.java.analysis.JavaAnalysisBundle;
import com.intellij.openapi.project.Project;
@@ -109,7 +108,7 @@ public class RedundantFieldInitializationInspection extends BaseInspection imple
if (isAssignmentInInitializerOverwritten(field)) {
return;
}
- registerError(initializer, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(initializer);
}
private boolean isAssignmentInInitializerOverwritten(@NotNull PsiField field) {
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/RedundantImplementsInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/RedundantImplementsInspection.java
index 8a1972023d3d..439913f2c4d8 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/RedundantImplementsInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/RedundantImplementsInspection.java
@@ -17,7 +17,6 @@ package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.MultipleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
@@ -168,7 +167,7 @@ public class RedundantImplementsInspection extends BaseInspection implements Cle
}
final PsiClass extendedClass = (PsiClass)extendsReferent;
if (extendedClass.isInheritor(implementedClass, true)) {
- register(implementsElement);
+ registerError(implementsElement);
return;
}
}
@@ -184,16 +183,12 @@ public class RedundantImplementsInspection extends BaseInspection implements Cle
final PsiClass testImplementedClass =
(PsiClass)implementsReferent;
if (testImplementedClass.isInheritor(implementedClass, true)) {
- register(implementsElement);
+ registerError(implementsElement);
return;
}
}
}
- private void register(PsiJavaCodeReferenceElement implementsElement) {
- registerError(implementsElement, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
- }
-
private void checkExtendedInterface(PsiJavaCodeReferenceElement extendsElement, PsiJavaCodeReferenceElement[] extendsElements) {
final PsiElement target = extendsElement.resolve();
if (!(target instanceof PsiClass)) {
@@ -215,7 +210,7 @@ public class RedundantImplementsInspection extends BaseInspection implements Cle
final PsiClass testExtendedInterface =
(PsiClass)implementsReferent;
if (testExtendedInterface.isInheritor(extendedInterface, true)) {
- register(extendsElement);
+ registerError(extendsElement);
return;
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/SimplifiableAnnotationInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/SimplifiableAnnotationInspection.java
index 78857b3c284e..eddb344e0fe2 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/SimplifiableAnnotationInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/SimplifiableAnnotationInspection.java
@@ -17,7 +17,6 @@ package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
@@ -151,7 +150,7 @@ public class SimplifiableAnnotationInspection extends BaseInspection implements
}
if (attributes.length == 0) {
if (parameterList.getChildren().length > 0 && !containsError(annotation)) {
- registerError(parameterList, ProblemHighlightType.LIKE_UNUSED_SYMBOL, Boolean.FALSE);
+ registerError(parameterList, Boolean.FALSE);
}
}
else if (attributes.length == 1) {
@@ -161,7 +160,7 @@ public class SimplifiableAnnotationInspection extends BaseInspection implements
if (identifier != null && attributeValue != null) {
@NonNls final String name = attribute.getName();
if (PsiAnnotation.DEFAULT_REFERENCED_METHOD_NAME.equals(name) && !containsError(annotation)) {
- registerErrorAtOffset(attribute, 0, attributeValue.getStartOffsetInParent(), ProblemHighlightType.LIKE_UNUSED_SYMBOL,
+ registerErrorAtOffset(attribute, 0, attributeValue.getStartOffsetInParent(),
Boolean.FALSE);
}
}
@@ -174,8 +173,8 @@ public class SimplifiableAnnotationInspection extends BaseInspection implements
return;
}
if (!containsError(annotation)) {
- registerError(arrayValue.getFirstChild(), ProblemHighlightType.LIKE_UNUSED_SYMBOL, Boolean.FALSE);
- registerError(arrayValue.getLastChild(), ProblemHighlightType.LIKE_UNUSED_SYMBOL, Boolean.FALSE);
+ registerError(arrayValue.getFirstChild(), Boolean.FALSE);
+ registerError(arrayValue.getLastChild(), Boolean.FALSE);
}
}
else {
@@ -190,8 +189,8 @@ public class SimplifiableAnnotationInspection extends BaseInspection implements
continue;
}
if (!containsError(annotation)) {
- registerError(arrayValue.getFirstChild(), ProblemHighlightType.LIKE_UNUSED_SYMBOL, Boolean.FALSE);
- registerError(arrayValue.getLastChild(), ProblemHighlightType.LIKE_UNUSED_SYMBOL, Boolean.FALSE);
+ registerError(arrayValue.getFirstChild(), Boolean.FALSE);
+ registerError(arrayValue.getLastChild(), Boolean.FALSE);
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedInnerClassAccessInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedInnerClassAccessInspection.java
index 2d16490772bf..1e8f8f6cf274 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedInnerClassAccessInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedInnerClassAccessInspection.java
@@ -1,4 +1,4 @@
-// Copyright 2000-2020 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
+// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
@@ -125,7 +125,7 @@ public class UnnecessarilyQualifiedInnerClassAccessInspection extends BaseInspec
if (referenceClass == null) {
return;
}
- ProblemHighlightType highlightType = ProblemHighlightType.LIKE_UNUSED_SYMBOL;
+ ProblemHighlightType highlightType = ProblemHighlightType.GENERIC_ERROR_OR_WARNING;
if (!referenceClass.equals(qualifierTarget) || !ClassUtils.isInsideClassBody(reference, referenceClass)) {
if (ignoreReferencesNeedingImport &&
(PsiTreeUtil.isAncestor(referenceClass, qualifierTarget, true) ||
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedStaticUsageInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedStaticUsageInspection.java
index c5ce45638869..662e3f68d5f0 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedStaticUsageInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedStaticUsageInspection.java
@@ -17,7 +17,6 @@ package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.MultipleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.TextRange;
@@ -111,7 +110,7 @@ public class UnnecessarilyQualifiedStaticUsageInspection extends BaseInspection
if (!isUnnecessarilyQualifiedAccess(reference, m_ignoreStaticAccessFromStaticContext, m_ignoreStaticFieldAccesses, m_ignoreStaticMethodCalls)) {
return;
}
- registerError(qualifier, ProblemHighlightType.LIKE_UNUSED_SYMBOL, reference);
+ registerError(qualifier, reference);
}
@Override
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedStaticallyImportedElementInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedStaticallyImportedElementInspection.java
index 3864b4f8faf5..4c9aa4e27185 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedStaticallyImportedElementInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarilyQualifiedStaticallyImportedElementInspection.java
@@ -17,7 +17,6 @@ package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.siyeh.InspectionGadgetsBundle;
@@ -78,7 +77,7 @@ public class UnnecessarilyQualifiedStaticallyImportedElementInspection extends B
return;
}
if (ImportUtils.isAlreadyStaticallyImported(reference)) {
- registerError(Objects.requireNonNull(reference.getQualifier()), ProblemHighlightType.LIKE_UNUSED_SYMBOL, reference.resolve());
+ registerError(Objects.requireNonNull(reference.getQualifier()), reference.resolve());
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryCallToStringValueOfInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryCallToStringValueOfInspection.java
index 1197a70f8d37..e944744821d0 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryCallToStringValueOfInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryCallToStringValueOfInspection.java
@@ -19,7 +19,6 @@ import com.intellij.codeInsight.Nullability;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.CommonQuickFixBundle;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.dataFlow.NullabilityUtil;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
@@ -140,7 +139,7 @@ public class UnnecessaryCallToStringValueOfInspection extends BaseInspection imp
public void visitMethodCallExpression(PsiMethodCallExpression call) {
final PsiExpression argument = tryUnwrapRedundantConversion(call);
if (argument == null) return;
- registerErrorAtOffset(call, 0, call.getArgumentList().getStartOffsetInParent(), ProblemHighlightType.LIKE_UNUSED_SYMBOL,
+ registerErrorAtOffset(call, 0, call.getArgumentList().getStartOffsetInParent(),
calculateReplacementText(call, argument));
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryConstantArrayCreationExpressionInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryConstantArrayCreationExpressionInspection.java
index 3d0ef01a9afe..28d42ef92f37 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryConstantArrayCreationExpressionInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryConstantArrayCreationExpressionInspection.java
@@ -1,10 +1,9 @@
-// Copyright 2000-2021 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
+// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.CommonQuickFixBundle;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiUtil;
@@ -101,7 +100,7 @@ public class UnnecessaryConstantArrayCreationExpressionInspection extends BaseIn
if (hasGenericTypeParameters(variable)) {
return;
}
- registerErrorAtOffset(parent, 0, expression.getStartOffsetInParent(), ProblemHighlightType.LIKE_UNUSED_SYMBOL,
+ registerErrorAtOffset(parent, 0, expression.getStartOffsetInParent(),
expressionType.getPresentableText());
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryConstructorInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryConstructorInspection.java
index bc4213a26914..3fe097760979 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryConstructorInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryConstructorInspection.java
@@ -16,7 +16,6 @@
package com.siyeh.ig.style;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
@@ -121,7 +120,7 @@ public class UnnecessaryConstructorInspection extends BaseInspection {
final PsiCodeBlock body = constructor.getBody();
if (ControlFlowUtils.isEmptyCodeBlock(body) ||
isSuperConstructorInvocationWithoutArguments(ControlFlowUtils.getOnlyStatementInBlock(body))) {
- registerError(identifier, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(identifier);
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryFinalOnLocalVariableOrParameterInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryFinalOnLocalVariableOrParameterInspection.java
index 44890d65927c..d7ca7c2400dd 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryFinalOnLocalVariableOrParameterInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryFinalOnLocalVariableOrParameterInspection.java
@@ -16,7 +16,6 @@
package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.MultipleCheckboxOptionsPanel;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
@@ -115,7 +114,7 @@ public class UnnecessaryFinalOnLocalVariableOrParameterInspection extends BaseIn
}
}
final PsiLocalVariable variable = (PsiLocalVariable)firstElement;
- registerModifierError(PsiModifier.FINAL, variable, ProblemHighlightType.LIKE_UNUSED_SYMBOL, variable);
+ registerModifierError(PsiModifier.FINAL, variable, variable);
}
@Override
@@ -136,7 +135,7 @@ public class UnnecessaryFinalOnLocalVariableOrParameterInspection extends BaseIn
return;
}
if (method.hasModifierProperty(PsiModifier.ABSTRACT)) {
- registerModifierError(PsiModifier.FINAL, parameter, ProblemHighlightType.LIKE_UNUSED_SYMBOL, parameter);
+ registerModifierError(PsiModifier.FINAL, parameter, parameter);
}
else if (!onlyWarnOnAbstractMethods) {
check(parameter);
@@ -152,7 +151,7 @@ public class UnnecessaryFinalOnLocalVariableOrParameterInspection extends BaseIn
if (element instanceof PsiResourceVariable) {
final PsiResourceVariable variable = (PsiResourceVariable)element;
if (variable.hasModifierProperty(PsiModifier.FINAL)) {
- registerModifierError(PsiModifier.FINAL, variable, ProblemHighlightType.LIKE_UNUSED_SYMBOL, variable);
+ registerModifierError(PsiModifier.FINAL, variable, variable);
}
}
}
@@ -171,7 +170,7 @@ public class UnnecessaryFinalOnLocalVariableOrParameterInspection extends BaseIn
continue;
}
if (parameter.getType() instanceof PsiDisjunctionType || !isNecessaryFinal(parameter, parameter.getDeclarationScope())) {
- registerModifierError(PsiModifier.FINAL, parameter, ProblemHighlightType.LIKE_UNUSED_SYMBOL, parameter);
+ registerModifierError(PsiModifier.FINAL, parameter, parameter);
}
}
}
@@ -196,7 +195,7 @@ public class UnnecessaryFinalOnLocalVariableOrParameterInspection extends BaseIn
private void check(PsiParameter parameter) {
if (!isNecessaryFinal(parameter, parameter.getDeclarationScope())) {
- registerModifierError(PsiModifier.FINAL, parameter, ProblemHighlightType.LIKE_UNUSED_SYMBOL, parameter);
+ registerModifierError(PsiModifier.FINAL, parameter, parameter);
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryModifierInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryModifierInspection.java
index f89966cd2fd7..eb30fc94c29e 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryModifierInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryModifierInspection.java
@@ -2,7 +2,6 @@
package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.psi.*;
import com.intellij.psi.tree.IElementType;
import com.intellij.psi.util.PsiTreeUtil;
@@ -176,7 +175,7 @@ public class UnnecessaryModifierInspection extends BaseInspection implements Cle
private void registerError(@NotNull PsiKeyword modifier,
@NotNull @PropertyKey(resourceBundle = InspectionGadgetsBundle.BUNDLE) String key) {
- registerError(modifier, ProblemHighlightType.LIKE_UNUSED_SYMBOL, InspectionGadgetsBundle.message(key), modifier.getText());
+ registerError(modifier, InspectionGadgetsBundle.message(key), modifier.getText());
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryQualifierForThisInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryQualifierForThisInspection.java
index 706e23606789..41eb8e96ae0b 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryQualifierForThisInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryQualifierForThisInspection.java
@@ -17,7 +17,6 @@ package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.siyeh.InspectionGadgetsBundle;
@@ -89,7 +88,7 @@ public class UnnecessaryQualifierForThisInspection extends BaseInspection implem
if (containingClass == null || !containingClass.equals(referent)) {
return;
}
- registerError(qualifier, ProblemHighlightType.LIKE_UNUSED_SYMBOL, thisExpression);
+ registerError(qualifier, thisExpression);
}
@Override
@@ -119,7 +118,7 @@ public class UnnecessaryQualifierForThisInspection extends BaseInspection implem
assert copyQualifierExpression != null;
PsiReplacementUtil.replaceExpression(copyQualifierExpression, PsiKeyword.SUPER);
if (copy.resolve() == ((PsiReferenceExpression)parent).resolve()) {
- registerError(qualifier, ProblemHighlightType.LIKE_UNUSED_SYMBOL, expression);
+ registerError(qualifier, expression);
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySemicolonInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySemicolonInspection.java
index 27864754ea68..6e011c2c86e0 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySemicolonInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySemicolonInspection.java
@@ -17,7 +17,6 @@ package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.lang.LanguageUtil;
import com.intellij.openapi.project.Project;
@@ -121,7 +120,7 @@ public class UnnecessarySemicolonInspection extends BaseInspection implements Cl
for (PsiElement sibling = element.getFirstChild(); sibling != null; sibling = PsiTreeUtil.skipWhitespacesAndCommentsForward(sibling)) {
if (sibling instanceof PsiErrorElement) return;
if (PsiUtil.isJavaToken(sibling, JavaTokenType.SEMICOLON)) {
- registerError(sibling, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(sibling);
}
}
}
@@ -138,12 +137,12 @@ public class UnnecessarySemicolonInspection extends BaseInspection implements Cl
if (sibling instanceof PsiErrorElement) return;
if (PsiUtil.isJavaToken(sibling, JavaTokenType.SEMICOLON)) {
if (semicolonSeen) {
- registerError(sibling, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(sibling);
}
else if (!ignoreAfterEnumConstants) {
final PsiElement element = PsiTreeUtil.skipWhitespacesAndCommentsForward(sibling);
if (PsiUtil.isJavaToken(element, JavaTokenType.RBRACE)) {
- registerError(sibling, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(sibling);
}
}
semicolonSeen = true;
@@ -161,7 +160,7 @@ public class UnnecessarySemicolonInspection extends BaseInspection implements Cl
if (semicolon == null) {
return;
}
- registerError(semicolon, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(semicolon);
}
}
@@ -172,7 +171,7 @@ public class UnnecessarySemicolonInspection extends BaseInspection implements Cl
if (PsiUtil.isJavaToken(last, JavaTokenType.RPARENTH)) {
final PsiElement prev = PsiTreeUtil.skipWhitespacesAndCommentsBackward(last);
if (PsiUtil.isJavaToken(prev, JavaTokenType.SEMICOLON)) {
- registerError(prev, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(prev);
}
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySuperConstructorInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySuperConstructorInspection.java
index 8d870db2c5d7..2836857f983d 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySuperConstructorInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySuperConstructorInspection.java
@@ -17,9 +17,11 @@ package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.openapi.project.Project;
-import com.intellij.psi.*;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiKeyword;
+import com.intellij.psi.PsiMethodCallExpression;
+import com.intellij.psi.PsiReferenceExpression;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
@@ -79,7 +81,7 @@ public class UnnecessarySuperConstructorInspection extends BaseInspection implem
if (!call.getArgumentList().isEmpty()) {
return;
}
- registerError(call, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(call);
}
}
}
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySuperQualifierInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySuperQualifierInspection.java
index 6247ea6607b4..91932f839d14 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySuperQualifierInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessarySuperQualifierInspection.java
@@ -17,7 +17,6 @@ package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.java.analysis.JavaAnalysisBundle;
import com.intellij.openapi.project.Project;
@@ -138,7 +137,7 @@ public class UnnecessarySuperQualifierInspection extends BaseInspection implemen
}
}
}
- registerError(expression, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(expression);
}
private static boolean hasUnnecessarySuperQualifier(PsiReferenceExpression referenceExpression) {
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryThisInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryThisInspection.java
index 87f2d07d1cb4..0f500ff5888d 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryThisInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryThisInspection.java
@@ -18,7 +18,6 @@ package com.siyeh.ig.style;
import com.intellij.codeInsight.daemon.impl.analysis.HighlightUtil;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
@@ -99,7 +98,7 @@ public class UnnecessaryThisInspection extends BaseInspection implements Cleanup
if (parenthesizedThis.getParent() instanceof PsiNewExpression) {
final PsiReference qualifier = expression.getQualifier();
if (qualifier == null || qualifier.resolve() == PsiTreeUtil.getParentOfType(expression, PsiClass.class)) {
- registerError(expression, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(expression);
}
}
}
@@ -135,7 +134,7 @@ public class UnnecessaryThisInspection extends BaseInspection implements Cleanup
}
if (parent instanceof PsiCallExpression) {
// method calls are always in error
- registerError(qualifierExpression, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(qualifierExpression);
return;
}
final PsiElement target = expression.resolve();
@@ -149,7 +148,7 @@ public class UnnecessaryThisInspection extends BaseInspection implements Cleanup
if (variable instanceof PsiField && HighlightUtil.isIllegalForwardReferenceToField(expression, (PsiField)variable, true) != null) {
return;
}
- registerError(thisExpression, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(thisExpression);
}
else {
final String qualifierName = qualifier.getReferenceName();
@@ -169,7 +168,7 @@ public class UnnecessaryThisInspection extends BaseInspection implements Cleanup
final PsiResolveHelper resolveHelper = psiFacade.getResolveHelper();
while (parentClass != null) {
if (qualifierName.equals(parentClass.getName())) {
- registerError(thisExpression, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(thisExpression);
}
final PsiMethod[] methods = parentClass.findMethodsByName(methodName, true);
for (PsiMethod method : methods) {
@@ -196,7 +195,7 @@ public class UnnecessaryThisInspection extends BaseInspection implements Cleanup
PsiClass parentClass = ClassUtils.getContainingClass(expression);
while (parentClass != null) {
if (qualifierName.equals(parentClass.getName())) {
- registerError(thisExpression, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(thisExpression);
}
final PsiField field = parentClass.findFieldByName(referenceName, true);
if (field != null) {
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryToStringCallInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryToStringCallInspection.java
index ff9af89c6d2e..1b51c2193e67 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryToStringCallInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/UnnecessaryToStringCallInspection.java
@@ -19,7 +19,6 @@ import com.intellij.codeInsight.Nullability;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.CommonQuickFixBundle;
import com.intellij.codeInspection.ProblemDescriptor;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.dataFlow.NullabilityUtil;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.java.analysis.JavaAnalysisBundle;
@@ -121,7 +120,7 @@ public class UnnecessaryToStringCallInspection extends BaseInspection implements
NullabilityUtil.getExpressionNullability(qualifier, true) != Nullability.NOT_NULL) {
return;
}
- registerError(referenceNameElement, ProblemHighlightType.LIKE_UNUSED_SYMBOL, qualifier.isPhysical() ? null : qualifier.getText());
+ registerError(referenceNameElement, qualifier.isPhysical() ? null : qualifier.getText());
}
}
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/threading/EmptySynchronizedStatementInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/threading/EmptySynchronizedStatementInspection.java
index 90981b39cce0..fbc3fefef55f 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/threading/EmptySynchronizedStatementInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/threading/EmptySynchronizedStatementInspection.java
@@ -15,7 +15,6 @@
*/
package com.siyeh.ig.threading;
-import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.psi.PsiCodeBlock;
import com.intellij.psi.PsiFile;
import com.intellij.psi.PsiKeyword;
@@ -63,7 +62,7 @@ public class EmptySynchronizedStatementInspection extends BaseInspection {
if (!ControlFlowUtils.isEmptyCodeBlock(body)) {
return;
}
- registerError(statement.getFirstChild(), ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ registerError(statement.getFirstChild());
}
}
}
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/src/META-INF/InspectionGadgets.xml b/plugins/InspectionGadgets/src/META-INF/InspectionGadgets.xml
index c6baec326b66..25979d7c3c3f 100644
--- a/plugins/InspectionGadgets/src/META-INF/InspectionGadgets.xml
+++ b/plugins/InspectionGadgets/src/META-INF/InspectionGadgets.xml
@@ -430,13 +430,15 @@
level="WARNING" implementationClass="com.siyeh.ig.classlayout.FinalClassInspection"/>
@@ -2229,7 +2239,7 @@
implementationClass="com.siyeh.ig.serialization.SerializableRecordContainsIgnoredMembersInspection"/>
@@ -2513,7 +2525,7 @@
level="WARNING" implementationClass="com.siyeh.ig.threading.DoubleCheckedLockingInspection"/>
-
-
@@ -2767,7 +2785,7 @@
level="WARNING" implementationClass="com.siyeh.ig.visibility.LambdaParameterHidingMemberVariableInspection"/>
+ enabledByDefault="true" level="WARNING" groupKey="group.name.javafx" key="inspection.java.fx.unused.imports.display.name" editorAttributes="NOT_USED_ELEMENT_ATTRIBUTES"/>
diff --git a/plugins/javaFX/src/org/jetbrains/plugins/javaFX/fxml/codeInsight/inspections/JavaFxUnusedImportsInspection.java b/plugins/javaFX/src/org/jetbrains/plugins/javaFX/fxml/codeInsight/inspections/JavaFxUnusedImportsInspection.java
index 04b3c67f418c..2f04d1cdf43f 100644
--- a/plugins/javaFX/src/org/jetbrains/plugins/javaFX/fxml/codeInsight/inspections/JavaFxUnusedImportsInspection.java
+++ b/plugins/javaFX/src/org/jetbrains/plugins/javaFX/fxml/codeInsight/inspections/JavaFxUnusedImportsInspection.java
@@ -1,18 +1,4 @@
-/*
- * Copyright 2000-2013 JetBrains s.r.o.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
+// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package org.jetbrains.plugins.javaFX.fxml.codeInsight.inspections;
import com.intellij.codeInsight.daemon.QuickFixBundle;
@@ -74,12 +60,12 @@ public class JavaFxUnusedImportsInspection extends XmlSuppressableInspectionTool
if (target.endsWith(".*")) {
if (!usedNames.contains(StringUtil.trimEnd(target, ".*"))) {
problems.add(inspectionManager
- .createProblemDescriptor(instruction, JavaFXBundle.message("inspection.javafx.unused.imports.problem"), new JavaFxOptimizeImportsFix(), ProblemHighlightType.LIKE_UNUSED_SYMBOL, isOnTheFly));
+ .createProblemDescriptor(instruction, JavaFXBundle.message("inspection.javafx.unused.imports.problem"), new JavaFxOptimizeImportsFix(), ProblemHighlightType.GENERIC_ERROR_OR_WARNING, isOnTheFly));
}
}
else if (!usedNames.contains(target) || targetProcessingInstructions.containsKey(StringUtil.getPackageName(target) + ".*")) {
problems.add(inspectionManager
- .createProblemDescriptor(instruction, JavaFXBundle.message("inspection.javafx.unused.imports.problem"), new JavaFxOptimizeImportsFix(), ProblemHighlightType.LIKE_UNUSED_SYMBOL, isOnTheFly));
+ .createProblemDescriptor(instruction, JavaFXBundle.message("inspection.javafx.unused.imports.problem"), new JavaFxOptimizeImportsFix(), ProblemHighlightType.GENERIC_ERROR_OR_WARNING, isOnTheFly));
}
}
return problems.isEmpty() ? null : problems.toArray(ProblemDescriptor.EMPTY_ARRAY);