From e8bab554e145ce9e9850ff5997c3edb4464136bc Mon Sep 17 00:00:00 2001 From: Vladimir Kharitonov Date: Mon, 4 Mar 2024 15:32:50 +0100 Subject: [PATCH] dispose JSQuery in JCefImageViewer properly GitOrigin-RevId: a0974489809d90c3f64b87844b13ec7f1489d123 --- .../src/org/intellij/images/editor/impl/jcef/JCefImageViewer.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/images/src/org/intellij/images/editor/impl/jcef/JCefImageViewer.kt b/images/src/org/intellij/images/editor/impl/jcef/JCefImageViewer.kt index 03bd71c8b28b..9b280ffd5ba4 100644 --- a/images/src/org/intellij/images/editor/impl/jcef/JCefImageViewer.kt +++ b/images/src/org/intellij/images/editor/impl/jcef/JCefImageViewer.kt @@ -132,7 +132,6 @@ class JCefImageViewer(private val myFile: VirtualFile, override fun dispose() { ourCefClient.removeRequestHandler(myRequestHandler, myBrowser.cefBrowser) ourCefClient.removeLoadHandler(myLoadHandler, myBrowser.cefBrowser) - myViewerStateJSQuery.clearHandlers() myDocument.removeDocumentListener(this) } @@ -237,6 +236,7 @@ class JCefImageViewer(private val myFile: VirtualFile, Disposer.register(this, myBrowser) myViewerStateJSQuery = JBCefJSQuery.create(myBrowser as JBCefBrowserBase) + Disposer.register(this, myViewerStateJSQuery) myViewerStateJSQuery.addHandler { s: String -> val oldState = myState try {