From e8005e8796fcec2b2b8bfcae9320f3d6b715bab9 Mon Sep 17 00:00:00 2001
From: Bas Leijdekkers <basleijdekkers@gmail.com>
Date: Thu, 3 Dec 2015 11:20:13 +0100
Subject: [PATCH] IG: handle try-with-resources like javac does it in "Field
 may be 'final'" inspection

---
 .../ig/psiutils/DefiniteAssignmentUtil.java   | 18 ++++++-
 .../style/field_final/FieldMayBeFinal.java    | 47 ++++++++++++++-----
 2 files changed, 53 insertions(+), 12 deletions(-)

diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/psiutils/DefiniteAssignmentUtil.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/psiutils/DefiniteAssignmentUtil.java
index 765df624c522..c9dcbbe031be 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/psiutils/DefiniteAssignmentUtil.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/psiutils/DefiniteAssignmentUtil.java
@@ -441,8 +441,24 @@ public final class DefiniteAssignmentUtil {
   }
 
   private static void checkTryStatement(PsiTryStatement tryStatement, DefiniteAssignment definiteAssignment) {
-    // try with resources not specified
+    // try with resources not specified in JLS Java SE 8 Edition chapter 16
     final boolean da = definiteAssignment.isDefinitelyAssigned();
+    final PsiResourceList resourceList = tryStatement.getResourceList();
+    if (resourceList != null) {
+      for (PsiResourceListElement element : resourceList) {
+        if (element instanceof PsiResourceExpression) {
+          final PsiResourceExpression resourceExpression = (PsiResourceExpression)element;
+          checkExpression(resourceExpression.getExpression(), definiteAssignment, BooleanExpressionValue.UNDEFINED);
+        }
+        else if (element instanceof PsiResourceVariable) {
+          final PsiResourceVariable resourceVariable = (PsiResourceVariable)element;
+          checkExpression(resourceVariable.getInitializer(), definiteAssignment, BooleanExpressionValue.UNDEFINED);
+        }
+        else {
+          throw new AssertionError();
+        }
+      }
+    }
     checkCodeBlock(tryStatement.getTryBlock(), definiteAssignment);
     final boolean du = definiteAssignment.isDefinitelyUnassigned();
     boolean resultDa = definiteAssignment.isDefinitelyAssigned();
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/style/field_final/FieldMayBeFinal.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/style/field_final/FieldMayBeFinal.java
index 299549b239ed..37176beb5548 100644
--- a/plugins/InspectionGadgets/test/com/siyeh/igtest/style/field_final/FieldMayBeFinal.java
+++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/style/field_final/FieldMayBeFinal.java
@@ -1,5 +1,9 @@
 package com.siyeh.igtest.style.field_final;
-import java.awt.*; import java.io.File;import java.io.IOException; import java.util.*;
+
+import java.awt.*;
+import java.io.*;
+import java.util.*;
+
 public class FieldMayBeFinal {
 
     private static String string;
@@ -576,15 +580,6 @@ class T21 {
     final Object[] objects = new Object[]{1, 2, i=3};
   }
 }
-class T22 {
-  private final int i; // may not be final, but green when it is
-  {
-    new Object() {{
-      System.out.println(i);
-    }};
-    i = 1;
-  }
-}
 class T23 {
   private int <warning descr="Field 'i' may be 'final'">i</warning>; // may be final
   {
@@ -776,7 +771,7 @@ class T44 {
   }
 }
 class T45 {
-  private int i; // should be allowed final, but does not compile in javac
+  private int i; // should be allowed final and green when it is, but does not compile in javac
   {
     for (; true; i = 1) {
       i = 2;
@@ -898,6 +893,36 @@ class T60 {
     if (false) i = 2;
   }
 }
+class T61 {
+  private String <warning descr="Field 's' may be 'final'">s</warning>; // may be final
+  T61() throws IOException {
+    try (final InputStream is = new FileInputStream(s="ab")) {
+    }
+  }
+}
+class T62 {
+  private String s; // may not be final
+  T62() throws IOException {
+    try (final InputStream is = new FileInputStream(s="ab")) {
+    }
+    s = "ba";
+  }
+}
+class T63 {
+  private String s; // may not be final
+  T63() throws IOException {
+    try (final InputStream is = new FileInputStream(s=s="ab")) {
+    }
+  }
+}
+class T64 {
+  private String s; // may not be final, but green when it is.
+  T64() throws IOException {
+    try (final InputStream is = new FileInputStream("ab") {{System.out.println(s);}}) {
+    }
+    s="";
+  }
+}
 class Foo {
 
   public interface Accessor<T> {