From e7f0c335b09721333913edb1fac6892aa75b28a3 Mon Sep 17 00:00:00 2001 From: Ekaterina Tuzova Date: Thu, 8 May 2014 14:11:37 +0400 Subject: [PATCH] add both add field and remove param QuickFixes for the param in __init__ method --- .../inspections/PyUnusedLocalInspectionVisitor.java | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/python/src/com/jetbrains/python/inspections/PyUnusedLocalInspectionVisitor.java b/python/src/com/jetbrains/python/inspections/PyUnusedLocalInspectionVisitor.java index fab75bed993c..4c8d23b422e7 100644 --- a/python/src/com/jetbrains/python/inspections/PyUnusedLocalInspectionVisitor.java +++ b/python/src/com/jetbrains/python/inspections/PyUnusedLocalInspectionVisitor.java @@ -300,17 +300,14 @@ public class PyUnusedLocalInspectionVisitor extends PyInspectionVisitor { boolean canRemove = !(PsiTreeUtil.getPrevSiblingOfType(element, PyParameter.class) instanceof PySingleStarParameter) || PsiTreeUtil.getNextSiblingOfType(element, PyParameter.class) != null; - final LocalQuickFix[] fixes; + final List fixes = new ArrayList(); if (mayBeField) { - fixes = new LocalQuickFix[]{new AddFieldQuickFix(name, name, containingClass.getName())}; + fixes.add(new AddFieldQuickFix(name, name, containingClass.getName())); } - else if (canRemove) { - fixes = new LocalQuickFix[]{new PyRemoveParameterQuickFix()}; + if (canRemove) { + fixes.add(new PyRemoveParameterQuickFix()); } - else { - fixes = LocalQuickFix.EMPTY_ARRAY; - } - registerWarning(element, PyBundle.message("INSP.unused.locals.parameter.isnot.used", name), fixes); + registerWarning(element, PyBundle.message("INSP.unused.locals.parameter.isnot.used", name), fixes.toArray(new LocalQuickFix[fixes.size()])); } else { if (myIgnoreTupleUnpacking && isTupleUnpacking(element)) {