From e757903e8c91e85cd6d132d89deb8ac4c1f37dc5 Mon Sep 17 00:00:00 2001 From: Anna Kozlova Date: Tue, 22 Oct 2024 11:10:39 +0200 Subject: [PATCH] [kotlin] test navigation: `isPotentialTestClass` should return true under test root only ^KTIJ-31722 fixed GitOrigin-RevId: 5fd47d86c90f3dc6acec03ac30338f93bb36b182 --- .../codeInsight/lineMarker/runMarkers/jUnit5TestFile.kt | 4 ++++ .../org/jetbrains/kotlin/idea/junit/KotlinJUnit5Framework.kt | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/kotlin/idea/tests/testData/codeInsight/lineMarker/runMarkers/jUnit5TestFile.kt b/plugins/kotlin/idea/tests/testData/codeInsight/lineMarker/runMarkers/jUnit5TestFile.kt index def463e1e851..e18685e74a1f 100644 --- a/plugins/kotlin/idea/tests/testData/codeInsight/lineMarker/runMarkers/jUnit5TestFile.kt +++ b/plugins/kotlin/idea/tests/testData/codeInsight/lineMarker/runMarkers/jUnit5TestFile.kt @@ -54,4 +54,8 @@ class Go { private class Simple { @Test fun foo() {} +} + +class NoTestInside { + fun foo() {} } \ No newline at end of file diff --git a/plugins/kotlin/run-configurations/junit/src/org/jetbrains/kotlin/idea/junit/KotlinJUnit5Framework.kt b/plugins/kotlin/run-configurations/junit/src/org/jetbrains/kotlin/idea/junit/KotlinJUnit5Framework.kt index 3bd1fe31452e..d3044e64c2ff 100644 --- a/plugins/kotlin/run-configurations/junit/src/org/jetbrains/kotlin/idea/junit/KotlinJUnit5Framework.kt +++ b/plugins/kotlin/run-configurations/junit/src/org/jetbrains/kotlin/idea/junit/KotlinJUnit5Framework.kt @@ -77,8 +77,8 @@ class KotlinJUnit5Framework: JUnit5Framework(), KotlinPsiBasedTestFramework { } private fun checkIsJUnit5LikeTestClass(declaration: KtClassOrObject, isPotential: Boolean): ThreeState = - if (isPotential && isUnderTestSources(declaration)) { - UNSURE + if (isPotential) { + if (isUnderTestSources(declaration)) UNSURE else NO } else if (!isFrameworkAvailable(declaration)) { NO } else if (declaration is KtClass && declaration.isInner()) {