From e668634844d930395d8bf05237504cd2c3e17e6b Mon Sep 17 00:00:00 2001 From: Vladimir Krivosheev Date: Fri, 29 Nov 2013 14:31:26 +0100 Subject: [PATCH] fix Url equality (scheme) --- .../src/com/intellij/util/UrlImpl.java | 21 +++---------------- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/platform/platform-impl/src/com/intellij/util/UrlImpl.java b/platform/platform-impl/src/com/intellij/util/UrlImpl.java index 04af1fada4e9..f5afeb6c8fcd 100644 --- a/platform/platform-impl/src/com/intellij/util/UrlImpl.java +++ b/platform/platform-impl/src/com/intellij/util/UrlImpl.java @@ -147,26 +147,11 @@ public final class UrlImpl implements Url { return true; } if (!(o instanceof UrlImpl)) { - if (o instanceof Url && isInLocalFileSystem()) { - Url url = (Url)o; - if (url.isInLocalFileSystem()) { - return url.getPath().equals(path); - } - } return false; } UrlImpl url = (UrlImpl)o; - if (scheme == null ? url.scheme == null : !scheme.equals(url.scheme)) { - return false; - } - if (authority == null ? url.authority != null : !authority.equals(url.authority)) { - return false; - } - if (!getPath().equals(url.getPath())) { - return false; - } - return parameters == null ? url.parameters == null : parameters.equals(url.parameters); + return StringUtil.equals(scheme, url.scheme) && StringUtil.equals(authority, url.authority) && getPath().equals(url.getPath()) && StringUtil.equals(parameters, url.parameters); } @Override @@ -177,10 +162,10 @@ public final class UrlImpl implements Url { @Override public int hashCode() { int result = scheme == null ? 0 : scheme.hashCode(); - result = 31 * result + (authority != null ? authority.hashCode() : 0); + result = 31 * result + (authority == null ? 0 : authority.hashCode()); String decodedPath = getPath(); result = 31 * result + decodedPath.hashCode(); - result = 31 * result + (parameters != null ? parameters.hashCode() : 0); + result = 31 * result + (parameters == null ? 0 : parameters.hashCode()); return result; } } \ No newline at end of file