diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/controlflow/pointless_null_check/PointlessNullCheck.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/controlflow/pointless_null_check/PointlessNullCheck.java
index aa4aac99855b..41251edb3493 100644
--- a/plugins/InspectionGadgets/test/com/siyeh/igtest/controlflow/pointless_null_check/PointlessNullCheck.java
+++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/controlflow/pointless_null_check/PointlessNullCheck.java
@@ -3,34 +3,34 @@ package com.siyeh.igtest.controlflow.pointless_null_check;
public class PointlessNullCheck {
public void testViolations(Object arg) {
- if (arg != null && arg instanceof String) {
+ if (arg != null && arg instanceof String) {
System.out.println("this should trigger a warning");
}
- if (null != arg && arg instanceof String) {
+ if (null != arg && arg instanceof String) {
System.out.println("this should trigger a warning");
}
- if (arg instanceof String && null != arg) {
+ if (arg instanceof String && null != arg) {
System.out.println("this should trigger a warning");
}
- if (arg instanceof String && arg != null) {
+ if (arg instanceof String && arg != null) {
System.out.println("this should trigger a warning");
}
- if ((arg instanceof String) && (arg != null)) {
+ if ((arg instanceof String) && (arg != null)) {
System.out.println("this should trigger a warning");
}
- if (arg == null || !(arg instanceof String)) {
+ if (arg == null || !(arg instanceof String)) {
System.out.println("this should trigger a warning");
}
- if (((arg) != (null)) && ((arg) instanceof String)) {
+ if (((arg) != (null)) && ((arg) instanceof String)) {
System.out.println("this should trigger a warning");
}
- if (arg != null && (arg instanceof String || arg instanceof Integer)) {
+ if (arg != null && (arg instanceof String || arg instanceof Integer)) {
System.out.println("this should trigger a warning");
}
}
@@ -50,7 +50,7 @@ public class PointlessNullCheck {
System.out.println("this should not trigger a warning");
}
- if (arg.charAt(5) instanceof String && arg.charAt(5) != null) {
+ if (arg1.substring(5) instanceof String && arg1.substring(5) != null) {
System.out.println("this should not trigger a warning");
}
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/controlflow/pointless_null_check/expected.xml b/plugins/InspectionGadgets/test/com/siyeh/igtest/controlflow/pointless_null_check/expected.xml
deleted file mode 100644
index de2c46db9665..000000000000
--- a/plugins/InspectionGadgets/test/com/siyeh/igtest/controlflow/pointless_null_check/expected.xml
+++ /dev/null
@@ -1,51 +0,0 @@
-
-
-
- PointlessNullCheck.java
- 6
- Pointless null check
- Unnecessary 'null' check
-
-
- PointlessNullCheck.java
- 10
- Pointless null check
- Unnecessary 'null' check
-
-
- PointlessNullCheck.java
- 14
- Pointless null check
- Unnecessary 'null' check
-
-
- PointlessNullCheck.java
- 18
- Pointless null check
- Unnecessary 'null' check
-
-
- PointlessNullCheck.java
- 22
- Pointless null check
- Unnecessary 'null' check
-
-
- PointlessNullCheck.java
- 26
- Pointless null check
- Unnecessary 'null' check
-
-
- PointlessNullCheck.java
- 30
- Pointless null check
- Unnecessary 'null' check
-
-
- PointlessNullCheck.java
- 33
- Pointless 'null' check
- Unnecessary 'null' check
-
-
diff --git a/plugins/InspectionGadgets/testsrc/com/siyeh/ig/controlflow/PointlessNullCheckInspectionTest.java b/plugins/InspectionGadgets/testsrc/com/siyeh/ig/controlflow/PointlessNullCheckInspectionTest.java
index f202527e2c6b..c687af5ab798 100644
--- a/plugins/InspectionGadgets/testsrc/com/siyeh/ig/controlflow/PointlessNullCheckInspectionTest.java
+++ b/plugins/InspectionGadgets/testsrc/com/siyeh/ig/controlflow/PointlessNullCheckInspectionTest.java
@@ -1,6 +1,8 @@
package com.siyeh.ig.controlflow;
-import com.siyeh.ig.IGInspectionTestCase;
+import com.intellij.codeInspection.InspectionProfileEntry;
+import com.siyeh.ig.LightInspectionTestCase;
+import org.jetbrains.annotations.Nullable;
/**
* Unit test for PointlessNullCheckInspection.
@@ -9,10 +11,15 @@ import com.siyeh.ig.IGInspectionTestCase;
* @author Etienne Studer
* @author Hamlet D'Arcy
*/
+public class PointlessNullCheckInspectionTest extends LightInspectionTestCase {
-public class PointlessNullCheckInspectionTest extends IGInspectionTestCase {
+ public void testPointlessNullCheck() {
+ doTest();
+ }
- public void test() throws Exception {
- doTest("com/siyeh/igtest/controlflow/pointless_null_check", new PointlessNullCheckInspection());
+ @Nullable
+ @Override
+ protected InspectionProfileEntry getInspection() {
+ return new PointlessNullCheckInspection();
}
}