From e499be144370a63e45388d2fb59d64ba8fdbbd17 Mon Sep 17 00:00:00 2001 From: Georgii Ustinov Date: Thu, 11 Sep 2025 11:39:59 +0300 Subject: [PATCH] [Java. Code completion] IDEA-379113 refactoring: make all test files start with the lower letter GitOrigin-RevId: 7863d60c6181ee90fd8c5819e3e907890581fddf --- ...toCompletionAfterErrorElementWithDot.java} | 0 ...oAutoCompletionAfterMethodInvocation.java} | 0 .../completion/LoggerCompletionTest.kt | 20 +++++++++++++------ 3 files changed, 14 insertions(+), 6 deletions(-) rename java/java-tests/testData/codeInsight/completion/logger/{NoAutoCompletionAfterErrorElementWithDot.java => noAutoCompletionAfterErrorElementWithDot.java} (100%) rename java/java-tests/testData/codeInsight/completion/logger/{NoAutoCompletionAfterMethodInvocation.java => noAutoCompletionAfterMethodInvocation.java} (100%) diff --git a/java/java-tests/testData/codeInsight/completion/logger/NoAutoCompletionAfterErrorElementWithDot.java b/java/java-tests/testData/codeInsight/completion/logger/noAutoCompletionAfterErrorElementWithDot.java similarity index 100% rename from java/java-tests/testData/codeInsight/completion/logger/NoAutoCompletionAfterErrorElementWithDot.java rename to java/java-tests/testData/codeInsight/completion/logger/noAutoCompletionAfterErrorElementWithDot.java diff --git a/java/java-tests/testData/codeInsight/completion/logger/NoAutoCompletionAfterMethodInvocation.java b/java/java-tests/testData/codeInsight/completion/logger/noAutoCompletionAfterMethodInvocation.java similarity index 100% rename from java/java-tests/testData/codeInsight/completion/logger/NoAutoCompletionAfterMethodInvocation.java rename to java/java-tests/testData/codeInsight/completion/logger/noAutoCompletionAfterMethodInvocation.java diff --git a/java/java-tests/testSrc/com/intellij/java/codeInsight/completion/LoggerCompletionTest.kt b/java/java-tests/testSrc/com/intellij/java/codeInsight/completion/LoggerCompletionTest.kt index b67ddfcaaaf5..92dc151a6bf9 100644 --- a/java/java-tests/testSrc/com/intellij/java/codeInsight/completion/LoggerCompletionTest.kt +++ b/java/java-tests/testSrc/com/intellij/java/codeInsight/completion/LoggerCompletionTest.kt @@ -10,7 +10,6 @@ import com.intellij.openapi.components.service import com.intellij.testFramework.LightProjectDescriptor import com.intellij.testFramework.NeedsIndex import com.intellij.ui.logging.JvmLoggingSettingsStorage -import junit.framework.TestCase private const val SMART_MODE_REASON_MESSAGE = "Logger completion is not supported in the dumb mode" @@ -230,15 +229,24 @@ class LoggerCompletionTest : LightFixtureCompletionTestCase() { override fun getBasePath() = JavaTestUtil.getRelativeJavaTestDataPath() + "/codeInsight/completion/logger" + override fun doAntiTest() { + doAntiTest(*emptyArray()) + } + private fun doAntiTest(vararg names: String) { val name = getTestName(true) configureByFile("$name.java") assertStringItems(*names) - TestCase.assertFalse( - lookup.items.any { - it is JvmLoggerLookupElement - } - ) + if (names.isEmpty()) { + assertNull(lookup) + } + else { + assertFalse( + lookup.items.any { + it is JvmLoggerLookupElement + } + ) + } } private fun doTest(position: Int, vararg names: String) {