diff --git a/plugins/junit/src/com/intellij/execution/junit/JUnitConfiguration.java b/plugins/junit/src/com/intellij/execution/junit/JUnitConfiguration.java index 0b7ab14a151d..d1edefd03f21 100644 --- a/plugins/junit/src/com/intellij/execution/junit/JUnitConfiguration.java +++ b/plugins/junit/src/com/intellij/execution/junit/JUnitConfiguration.java @@ -310,7 +310,7 @@ public class JUnitConfiguration extends ModuleBasedConfiguration tests = new LinkedHashSet(); + final LinkedHashSet tests = new LinkedHashSet(); for (Object o : patternsElement.getChildren(PATTERN_EL_NAME)) { Element patternElement = (Element)o; tests.add(patternElement.getAttributeValue(TEST_CLASS_ATT_NAME)); @@ -403,7 +403,7 @@ public class JUnitConfiguration extends ModuleBasedConfiguration classes, PsiMethod method) { myData.TEST_OBJECT = TEST_PATTERN; - final Set patterns = new HashSet(); + final LinkedHashSet patterns = new LinkedHashSet(); final String methodSufiix; if (method != null) { myData.METHOD_NAME = method.getName(); @@ -437,7 +437,7 @@ public class JUnitConfiguration extends ModuleBasedConfiguration myPattern = new LinkedHashSet(); + private LinkedHashSet myPattern = new LinkedHashSet(); //iws/ipr compatibility public String ENV_VARIABLES; private Map myEnvs = new LinkedHashMap(); @@ -581,7 +581,7 @@ public class JUnitConfiguration extends ModuleBasedConfiguration pattern) { + public void setPatterns(LinkedHashSet pattern) { myPattern = pattern; } diff --git a/plugins/junit/src/com/intellij/execution/junit/TestObject.java b/plugins/junit/src/com/intellij/execution/junit/TestObject.java index e1b74d5452ef..eb9de875c346 100644 --- a/plugins/junit/src/com/intellij/execution/junit/TestObject.java +++ b/plugins/junit/src/com/intellij/execution/junit/TestObject.java @@ -509,18 +509,18 @@ public abstract class TestObject implements JavaCommandLine { testNames.add(name); } } + final JUnitConfiguration.Data data = myConfiguration.getPersistentData(); if (perModule != null) { for (List perModuleClasses : perModule.values()) { Collections.sort(perModuleClasses); testNames.addAll(perModuleClasses); } } - else { + else if (JUnitConfiguration.TEST_PACKAGE.equals(data.TEST_OBJECT)) { Collections.sort(testNames); //sort tests in FQN order } - final JUnitConfiguration.Data data = myConfiguration.getPersistentData(); - final String category = data.TEST_OBJECT == JUnitConfiguration.TEST_CATEGORY ? data.getCategory() : ""; + final String category = JUnitConfiguration.TEST_CATEGORY.equals(data.TEST_OBJECT) ? data.getCategory() : ""; JUnitStarter.printClassesList(testNames, packageName, category, myTempFile); if (perModule != null && perModule.size() > 1) { diff --git a/plugins/testng/src/com/theoryinpractice/testng/configuration/SearchingForTestsTask.java b/plugins/testng/src/com/theoryinpractice/testng/configuration/SearchingForTestsTask.java index 8358fcd253dd..ccc820a83817 100644 --- a/plugins/testng/src/com/theoryinpractice/testng/configuration/SearchingForTestsTask.java +++ b/plugins/testng/src/com/theoryinpractice/testng/configuration/SearchingForTestsTask.java @@ -83,7 +83,7 @@ public class SearchingForTestsTask extends Task.Backgroundable { myServerSocket = serverSocket; myConfig = config; myTempFile = tempFile; - myClasses = new HashMap>(); + myClasses = new LinkedHashMap>(); } public void run(@NotNull ProgressIndicator indicator) { @@ -190,13 +190,13 @@ public class SearchingForTestsTask extends Task.Backgroundable { } private void composeTestSuiteFromClasses() { - Map> map = new HashMap>(); + Map> map = new LinkedHashMap>(); final boolean findTestMethodsForClass = shouldSearchForTestMethods(); for (final Map.Entry> entry : myClasses.entrySet()) { final Collection depMethods = entry.getValue(); - Collection methods = new HashSet(depMethods.size()); + Collection methods = new LinkedHashSet(depMethods.size()); for (PsiMethod method : depMethods) { methods.add(method.getName()); } @@ -523,7 +523,7 @@ public class SearchingForTestsTask extends Task.Backgroundable { final Set alreadyMarkedToBeChecked, @Nullable final PsiClass... classes) { if (classes != null && classes.length > 0) { - final Set groupDependencies = new HashSet(); + final Set groupDependencies = new LinkedHashSet(); TestNGUtil.collectAnnotationValues(groupDependencies, "dependsOnGroups", methods, classes); final Set membersToCheckNow = new LinkedHashSet(); if (!groupDependencies.isEmpty()) { @@ -574,7 +574,7 @@ public class SearchingForTestsTask extends Task.Backgroundable { final PsiClass... classes) { final PsiClass[] psiClasses; if (methods != null && methods.length > 0) { - final Set containingClasses = new HashSet(); + final Set containingClasses = new LinkedHashSet(); for (PsiMethod method : methods) { containingClasses.add(method.getContainingClass()); } @@ -583,7 +583,7 @@ public class SearchingForTestsTask extends Task.Backgroundable { psiClasses = classes; } for (final PsiClass containingClass : psiClasses) { - final Set testMethodDependencies = new HashSet(); + final Set testMethodDependencies = new LinkedHashSet(); TestNGUtil.collectAnnotationValues(testMethodDependencies, "dependsOnMethods", methods, containingClass); if (!testMethodDependencies.isEmpty()) { ApplicationManager.getApplication().runReadAction(new Runnable() { diff --git a/plugins/testng/src/com/theoryinpractice/testng/configuration/TestNGConfiguration.java b/plugins/testng/src/com/theoryinpractice/testng/configuration/TestNGConfiguration.java index cc87a11d2e3c..70b5693be574 100644 --- a/plugins/testng/src/com/theoryinpractice/testng/configuration/TestNGConfiguration.java +++ b/plugins/testng/src/com/theoryinpractice/testng/configuration/TestNGConfiguration.java @@ -269,7 +269,7 @@ public class TestNGConfiguration extends ModuleBasedConfiguration patterns = new LinkedHashSet(); + LinkedHashSet patterns = new LinkedHashSet(); for (PsiClass pattern : classes) { patterns.add(JavaExecutionUtil.getRuntimeQualifiedName(pattern) + suffix); } @@ -373,7 +373,7 @@ public class TestNGConfiguration extends ModuleBasedConfiguration tests = new LinkedHashSet(); + final LinkedHashSet tests = new LinkedHashSet(); for (Object o : patternsElement.getChildren(PATTERN_EL_NAME)) { Element patternElement = (Element)o; tests.add(patternElement.getAttributeValue(TEST_CLASS_ATT_NAME)); diff --git a/plugins/testng/src/com/theoryinpractice/testng/model/TestData.java b/plugins/testng/src/com/theoryinpractice/testng/model/TestData.java index b40ab4c3ef03..2a75977483bb 100644 --- a/plugins/testng/src/com/theoryinpractice/testng/model/TestData.java +++ b/plugins/testng/src/com/theoryinpractice/testng/model/TestData.java @@ -57,7 +57,7 @@ public class TestData implements Cloneable public List TEST_LISTENERS = new ArrayList(); public boolean USE_DEFAULT_REPORTERS = false; public String PROPERTIES_FILE; - private Set myPatterns = new LinkedHashSet(); + private LinkedHashSet myPatterns = new LinkedHashSet(); public TestData() { TEST_OBJECT = TestType.CLASS.getType(); @@ -168,7 +168,7 @@ public class TestData implements Cloneable data.USE_DEFAULT_REPORTERS = USE_DEFAULT_REPORTERS; data.ENVS = new LinkedHashMap(ENVS); - data.myPatterns = new HashSet(); + data.myPatterns = new LinkedHashSet(); data.myPatterns.addAll(myPatterns); data.setScope(getScope()); return data; @@ -251,7 +251,7 @@ public class TestData implements Cloneable return myPatterns; } - public void setPatterns(Set set) { + public void setPatterns(LinkedHashSet set) { myPatterns = set; } }