From e3094c56ce406a4cd073062575a3d1ef7874ba53 Mon Sep 17 00:00:00 2001
From: Bas Leijdekkers <basleijdekkers@gmail.com>
Date: Wed, 2 Nov 2016 10:42:05 +0100
Subject: [PATCH] IG: better name for inspection: "Synthetic accessor call"

---
 .../src/META-INF/InspectionGadgets.xml                    | 2 +-
 .../src/com/siyeh/InspectionGadgetsBundle.properties      | 4 ++--
 ...teMemberAccessBetweenOuterAndInnerClassInspection.java | 2 +-
 .../PrivateMemberAccessBetweenOuterAndInnerClass.java     | 8 ++++----
 .../Simple.java                                           | 6 +++---
 5 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/META-INF/InspectionGadgets.xml b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/META-INF/InspectionGadgets.xml
index a854f4bc39d4..5b0f3324d668 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/META-INF/InspectionGadgets.xml
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/META-INF/InspectionGadgets.xml
@@ -1213,7 +1213,7 @@
                      key="large.initializer.primitive.type.array.display.name" groupBundle="messages.InspectionsBundle"
                      groupKey="group.names.j2me.issues" enabledByDefault="false" level="WARNING"
                      implementationClass="com.siyeh.ig.j2me.OverlyLargePrimitiveArrayInitializerInspection"/>
-    <localInspection groupPath="Java" language="JAVA" suppressId="SyntheticMethodCall" alternativeId="PrivateMemberAccessBetweenOuterAndInnerClass"
+    <localInspection groupPath="Java" language="JAVA" suppressId="SyntheticAccessorCall" alternativeId="PrivateMemberAccessBetweenOuterAndInnerClass"
                      shortName="PrivateMemberAccessBetweenOuterAndInnerClass" bundle="com.siyeh.InspectionGadgetsBundle"
                      key="private.member.access.between.outer.and.inner.classes.display.name" groupBundle="messages.InspectionsBundle"
                      groupKey="group.names.j2me.issues" enabledByDefault="false" level="WARNING"
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/InspectionGadgetsBundle.properties b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/InspectionGadgetsBundle.properties
index fe5d941648dc..c2617be9b93d 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/InspectionGadgetsBundle.properties
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/InspectionGadgetsBundle.properties
@@ -439,8 +439,8 @@ method.call.in.loop.condition.problem.descriptor=Call to method <code>#ref()</co
 large.initializer.primitive.type.array.display.name=Overly large initializer for array of primitive type
 large.initializer.primitive.type.array.problem.descriptor=Primitive array initializer with too many elements ({0}) #loc
 large.initializer.primitive.type.array.maximum.number.of.elements.option=Maximum number of elements:
-private.member.access.between.outer.and.inner.classes.display.name=Synthetic method call
-private.member.access.between.outer.and.inner.classes.problem.descriptor=Access to 'private' member of class ''{0}'' requires synthetic method call #loc
+private.member.access.between.outer.and.inner.classes.display.name=Synthetic accessor call
+private.member.access.between.outer.and.inner.classes.problem.descriptor=Access to 'private' member of class ''{0}'' requires synthetic accessor call #loc
 private.member.access.between.outer.and.inner.classes.make.local.quickfix=Make ''{0}'' package-private
 private.member.access.between.outer.and.inner.classes.make.constructor.package.local.quickfix=Make ''{0}'' constructor package-private
 recordstore.opened.not.safely.closed.display.name=RecordStore opened but not safely closed
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/j2me/PrivateMemberAccessBetweenOuterAndInnerClassInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/j2me/PrivateMemberAccessBetweenOuterAndInnerClassInspection.java
index f62a4da82e95..287e8d28a253 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/j2me/PrivateMemberAccessBetweenOuterAndInnerClassInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/j2me/PrivateMemberAccessBetweenOuterAndInnerClassInspection.java
@@ -35,7 +35,7 @@ public class PrivateMemberAccessBetweenOuterAndInnerClassInspection extends Base
   @NotNull
   @Override
   public String getID() {
-    return "SyntheticMethodCall";
+    return "SyntheticAccessorCall";
   }
 
   @Nullable
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/j2me/private_member_access_between_outer_and_inner_class/PrivateMemberAccessBetweenOuterAndInnerClass.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/j2me/private_member_access_between_outer_and_inner_class/PrivateMemberAccessBetweenOuterAndInnerClass.java
index c5ebc18b6e00..c9191ac4ba06 100644
--- a/plugins/InspectionGadgets/test/com/siyeh/igtest/j2me/private_member_access_between_outer_and_inner_class/PrivateMemberAccessBetweenOuterAndInnerClass.java
+++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/j2me/private_member_access_between_outer_and_inner_class/PrivateMemberAccessBetweenOuterAndInnerClass.java
@@ -9,7 +9,7 @@ public class PrivateMemberAccessBetweenOuterAndInnerClass {
         System.out.println(caption);
         Object btn = new Object() {
             public void foo() {
-                System.out.println(<warning descr="Access to private member of class 'PrivateMemberAccessBetweenOuterAndInnerClass' requires synthetic method call">caption</warning>);
+                System.out.println(<warning descr="Access to private member of class 'PrivateMemberAccessBetweenOuterAndInnerClass' requires synthetic accessor call">caption</warning>);
                 System.out.println(N);
             }
         };
@@ -20,7 +20,7 @@ public class PrivateMemberAccessBetweenOuterAndInnerClass {
 class X {
     void test() {
         Private ref = new Private("access");
-        System.out.println(ref.<warning descr="Access to private member of class 'Private' requires synthetic method call">field</warning>);
+        System.out.println(ref.<warning descr="Access to private member of class 'Private' requires synthetic accessor call">field</warning>);
         PrivateAccessor.printPrivate(ref);
         new PrivateAccessor().print(ref);
     }
@@ -37,10 +37,10 @@ class X {
             // prevent synthetic constructor
         }
         void print(Private ref) {
-            System.out.println(ref.<warning descr="Access to private member of class 'Private' requires synthetic method call">field</warning>);
+            System.out.println(ref.<warning descr="Access to private member of class 'Private' requires synthetic accessor call">field</warning>);
         }
         static void printPrivate(Private ref) {
-            System.out.println(ref.<warning descr="Access to private member of class 'Private' requires synthetic method call">field</warning>);
+            System.out.println(ref.<warning descr="Access to private member of class 'Private' requires synthetic accessor call">field</warning>);
         }
     }
 }
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/j2me/private_member_access_between_outer_and_inner_class/Simple.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/j2me/private_member_access_between_outer_and_inner_class/Simple.java
index 428dcb93c3b2..f3c662d4b213 100644
--- a/plugins/InspectionGadgets/test/com/siyeh/igtest/j2me/private_member_access_between_outer_and_inner_class/Simple.java
+++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/j2me/private_member_access_between_outer_and_inner_class/Simple.java
@@ -9,9 +9,9 @@ public class Simple {
     private void foo() {}
     
     class Inner {{
-        new <warning descr="Access to private member of class 'Simple' requires synthetic method call">Simple</warning>();
-        System.out.println(<warning descr="Access to private member of class 'Simple' requires synthetic method call">i</warning>);
-        <warning descr="Access to private member of class 'Simple' requires synthetic method call">foo</warning>();
+        new <warning descr="Access to private member of class 'Simple' requires synthetic accessor call">Simple</warning>();
+        System.out.println(<warning descr="Access to private member of class 'Simple' requires synthetic accessor call">i</warning>);
+        <warning descr="Access to private member of class 'Simple' requires synthetic accessor call">foo</warning>();
     }}
 }
 class Other {