From 60a78cb6cc172b4156f31ebe8153bdc3695b0c29 Mon Sep 17 00:00:00 2001
From: Dmitry Trofimov <dmitry.trofimov@jetbrains.com>
Date: Fri, 30 Jul 2010 22:06:36 +0400
Subject: [PATCH 01/42] inspection fixes

---
 .idea/misc.xml             |  1 +
 .idea/projectCodeStyle.xml | 20 ++++++++++----------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/.idea/misc.xml b/.idea/misc.xml
index a79bafffabe3..3fe0c7739f67 100644
--- a/.idea/misc.xml
+++ b/.idea/misc.xml
@@ -4,6 +4,7 @@
     <scope name="IDEA Test Sources" pattern="test:*..*" />
     <option name="SKIP_IMPORT_STATEMENTS" value="false" />
   </component>
+  <component name="IdProvider" IDEtalkID="88DB5D232B345F18EEFB2825E88EC093" />
   <component name="JavadocGenerationManager">
     <option name="OUTPUT_DIRECTORY" />
     <option name="OPTION_SCOPE" value="protected" />
diff --git a/.idea/projectCodeStyle.xml b/.idea/projectCodeStyle.xml
index f71917e9772d..12908df60236 100644
--- a/.idea/projectCodeStyle.xml
+++ b/.idea/projectCodeStyle.xml
@@ -127,6 +127,16 @@
           <option name="LABEL_INDENT_ABSOLUTE" value="false" />
           <option name="USE_RELATIVE_INDENTS" value="false" />
         </ADDITIONAL_INDENT_OPTIONS>
+        <ADDITIONAL_INDENT_OPTIONS fileType="html">
+          <option name="INDENT_SIZE" value="2" />
+          <option name="CONTINUATION_INDENT_SIZE" value="4" />
+          <option name="TAB_SIZE" value="8" />
+          <option name="USE_TAB_CHARACTER" value="false" />
+          <option name="SMART_TABS" value="false" />
+          <option name="LABEL_INDENT_SIZE" value="0" />
+          <option name="LABEL_INDENT_ABSOLUTE" value="false" />
+          <option name="USE_RELATIVE_INDENTS" value="false" />
+        </ADDITIONAL_INDENT_OPTIONS>
         <ADDITIONAL_INDENT_OPTIONS fileType="java">
           <option name="INDENT_SIZE" value="2" />
           <option name="CONTINUATION_INDENT_SIZE" value="2" />
@@ -147,16 +157,6 @@
           <option name="LABEL_INDENT_ABSOLUTE" value="false" />
           <option name="USE_RELATIVE_INDENTS" value="false" />
         </ADDITIONAL_INDENT_OPTIONS>
-        <ADDITIONAL_INDENT_OPTIONS fileType="jsp">
-          <option name="INDENT_SIZE" value="2" />
-          <option name="CONTINUATION_INDENT_SIZE" value="4" />
-          <option name="TAB_SIZE" value="8" />
-          <option name="USE_TAB_CHARACTER" value="false" />
-          <option name="SMART_TABS" value="false" />
-          <option name="LABEL_INDENT_SIZE" value="0" />
-          <option name="LABEL_INDENT_ABSOLUTE" value="false" />
-          <option name="USE_RELATIVE_INDENTS" value="false" />
-        </ADDITIONAL_INDENT_OPTIONS>
         <ADDITIONAL_INDENT_OPTIONS fileType="rb">
           <option name="INDENT_SIZE" value="2" />
           <option name="CONTINUATION_INDENT_SIZE" value="8" />

From a89603e5c0d19b098f705191b952e12702dcdbc7 Mon Sep 17 00:00:00 2001
From: Alexey Pegov <alexey.pegov@jetbrains.com>
Date: Mon, 2 Aug 2010 13:51:22 +0400
Subject: [PATCH 02/42] fix git branches status bar widget: there is no
 InsertOverwrite widget on Macs :)

---
 .../src/git4idea/checkout/branches/GitBranchesWidget.java      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
index ca47ea25fc41..94657453bc93 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
@@ -29,6 +29,7 @@ import com.intellij.openapi.ui.popup.ListPopup;
 import com.intellij.openapi.util.Disposer;
 import com.intellij.openapi.util.IconLoader;
 import com.intellij.openapi.util.Ref;
+import com.intellij.openapi.util.SystemInfo;
 import com.intellij.openapi.vcs.VcsException;
 import com.intellij.openapi.vcs.changes.ui.ChangesViewContentManager;
 import com.intellij.openapi.vfs.VirtualFile;
@@ -148,7 +149,7 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
         StatusBar statusBar = WindowManager.getInstance().getStatusBar(project);
         if (statusBar != null) {
           final GitBranchesWidget w = new GitBranchesWidget(project, configurations);
-          statusBar.addWidget(w, "after InsertOverwrite", project);
+          statusBar.addWidget(w, "after " + (SystemInfo.isMac ? "Encoding" : "InsertOverwrite"), project);
           widget.set(w);
         }
       }

From 0340b76b8183c07bc35b2f269a9bfe2ada132749 Mon Sep 17 00:00:00 2001
From: Dmitry Avdeev <Dmitry.Avdeev@jetbrains.com>
Date: Wed, 28 Jul 2010 17:12:51 +0400
Subject: [PATCH 03/42] Create JavaEE Web Page action

---
 .../actions/CreateFileFromTemplateAction.java | 74 +++++++++++++++++++
 .../ide/actions/CreateFromTemplateAction.java | 51 ++++---------
 .../ide/actions/TemplateKindProvider.java     | 56 ++++++++++++++
 .../ide/actions/CreateHtmlFileAction.java     | 33 ++++-----
 4 files changed, 157 insertions(+), 57 deletions(-)
 create mode 100644 platform/lang-impl/src/com/intellij/ide/actions/CreateFileFromTemplateAction.java
 create mode 100644 platform/lang-impl/src/com/intellij/ide/actions/TemplateKindProvider.java

diff --git a/platform/lang-impl/src/com/intellij/ide/actions/CreateFileFromTemplateAction.java b/platform/lang-impl/src/com/intellij/ide/actions/CreateFileFromTemplateAction.java
new file mode 100644
index 000000000000..7f161b853d26
--- /dev/null
+++ b/platform/lang-impl/src/com/intellij/ide/actions/CreateFileFromTemplateAction.java
@@ -0,0 +1,74 @@
+/*
+ * Copyright 2000-2010 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.ide.actions;
+
+import com.intellij.ide.fileTemplates.FileTemplate;
+import com.intellij.ide.fileTemplates.FileTemplateManager;
+import com.intellij.ide.fileTemplates.FileTemplateUtil;
+import com.intellij.ide.util.PropertiesComponent;
+import com.intellij.openapi.fileEditor.FileEditorManager;
+import com.intellij.openapi.vfs.VirtualFile;
+import com.intellij.psi.PsiDirectory;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiFile;
+import com.intellij.util.IncorrectOperationException;
+
+import javax.swing.*;
+
+/**
+ * @author Dmitry Avdeev
+ */
+public abstract class CreateFileFromTemplateAction extends CreateFromTemplateAction<PsiFile> {
+
+  public CreateFileFromTemplateAction(String text, String description, Icon icon) {
+    super(text, description, icon);
+  }
+
+  protected PsiFile createFileFromTemplate(String name, FileTemplate template, PsiDirectory dir) {
+
+    PsiElement element;
+    try {
+      element = FileTemplateUtil
+        .createFromTemplate(template, name, FileTemplateManager.getInstance().getDefaultProperties(), dir);
+      final PsiFile psiFile = element.getContainingFile();
+
+      final VirtualFile virtualFile = psiFile.getVirtualFile();
+      if (virtualFile != null) {
+        FileEditorManager.getInstance(dir.getProject()).openFile(virtualFile, true);
+        String property = getDefaultTemplateProperty();
+        if (property != null) {
+          PropertiesComponent.getInstance(dir.getProject()).setValue(property, template.getName());
+        }
+        return psiFile;
+      }
+    }
+    catch (IncorrectOperationException e) {
+      throw e;
+    }
+    catch (Exception e) {
+      LOG.error(e);
+    }
+
+    return null;
+  }
+
+
+  @Override
+  protected PsiFile createFile(String name, String templateName, PsiDirectory dir) {
+    final FileTemplate template = FileTemplateManager.getInstance().getInternalTemplate(templateName);
+    return createFileFromTemplate(name, template, dir);
+  }
+}
diff --git a/platform/lang-impl/src/com/intellij/ide/actions/CreateFromTemplateAction.java b/platform/lang-impl/src/com/intellij/ide/actions/CreateFromTemplateAction.java
index edca8c915d14..34928e5d968b 100644
--- a/platform/lang-impl/src/com/intellij/ide/actions/CreateFromTemplateAction.java
+++ b/platform/lang-impl/src/com/intellij/ide/actions/CreateFromTemplateAction.java
@@ -17,19 +17,13 @@ package com.intellij.ide.actions;
 
 import com.intellij.CommonBundle;
 import com.intellij.ide.IdeView;
-import com.intellij.ide.fileTemplates.FileTemplate;
-import com.intellij.ide.fileTemplates.FileTemplateManager;
-import com.intellij.ide.fileTemplates.FileTemplateUtil;
+import com.intellij.ide.util.PropertiesComponent;
 import com.intellij.openapi.actionSystem.*;
 import com.intellij.openapi.diagnostic.Logger;
-import com.intellij.openapi.fileEditor.FileEditorManager;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.Ref;
-import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.psi.PsiDirectory;
 import com.intellij.psi.PsiElement;
-import com.intellij.psi.PsiFile;
-import com.intellij.util.IncorrectOperationException;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
@@ -39,37 +33,12 @@ import javax.swing.*;
  * @author Eugene.Kudelevsky
  */
 public abstract class CreateFromTemplateAction<T extends PsiElement> extends AnAction {
-  private static final Logger LOG = Logger.getInstance("#com.intellij.ide.actions.CreateFromTemplateAction");
+  protected static final Logger LOG = Logger.getInstance("#com.intellij.ide.actions.CreateFromTemplateAction");
 
   public CreateFromTemplateAction(String text, String description, Icon icon) {
     super(text, description, icon);
   }
-
-  protected static PsiFile createFileFromTemplate(String name, String templateName, PsiDirectory dir) {
-    final FileTemplate template = FileTemplateManager.getInstance().getInternalTemplate(templateName);
-
-    PsiElement element;
-    try {
-      element = FileTemplateUtil
-        .createFromTemplate(template, name, FileTemplateManager.getInstance().getDefaultProperties(), dir);
-      final PsiFile psiFile = element.getContainingFile();
-
-      final VirtualFile virtualFile = psiFile.getVirtualFile();
-      if (virtualFile != null) {
-        FileEditorManager.getInstance(dir.getProject()).openFile(virtualFile, true);
-        return psiFile;
-      }
-    }
-    catch (IncorrectOperationException e) {
-      throw e;
-    }
-    catch (Exception e) {
-      LOG.error(e);
-    }
-
-    return null;
-  }
-
+  
   public final void actionPerformed(final AnActionEvent e) {
     final DataContext dataContext = e.getDataContext();
 
@@ -105,22 +74,30 @@ public abstract class CreateFromTemplateAction<T extends PsiElement> extends AnA
       });
     if (createdElement != null) {
       view.selectElement(createdElement);
-      postProcesss(createdElement, selectedTemplateName.get());
+      postProcess(createdElement, selectedTemplateName.get());
     }
   }
 
-  protected void postProcesss(T createdElement, String templateName) {
+  protected void postProcess(T createdElement, String templateName) {
   }
 
   @Nullable
   protected abstract T createFile(String name, String templateName, PsiDirectory dir);
 
-  protected abstract void checkBeforeCreate(String name, String templateName, PsiDirectory dir);
+  protected void checkBeforeCreate(String name, String templateName, PsiDirectory dir) {
+    dir.checkCreateFile(name);
+  }
 
   protected abstract void buildDialog(Project project, PsiDirectory directory, CreateFileFromTemplateDialog.Builder builder);
 
   @Nullable
   protected String getDefaultTemplateName(@NotNull PsiDirectory dir) {
+    String property = getDefaultTemplateProperty();
+    return property == null ? null : PropertiesComponent.getInstance(dir.getProject()).getValue(property);
+  }
+
+  @Nullable
+  protected String getDefaultTemplateProperty() {
     return null;
   }
 
diff --git a/platform/lang-impl/src/com/intellij/ide/actions/TemplateKindProvider.java b/platform/lang-impl/src/com/intellij/ide/actions/TemplateKindProvider.java
new file mode 100644
index 000000000000..5353aa6286db
--- /dev/null
+++ b/platform/lang-impl/src/com/intellij/ide/actions/TemplateKindProvider.java
@@ -0,0 +1,56 @@
+/*
+ * Copyright 2000-2010 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.ide.actions;
+
+import com.intellij.openapi.actionSystem.ActionManager;
+import com.intellij.openapi.actionSystem.AnAction;
+import com.intellij.openapi.extensions.ExtensionPointName;
+import com.intellij.openapi.extensions.Extensions;
+import com.intellij.psi.PsiDirectory;
+
+import javax.swing.*;
+
+/**
+ * @author Dmitry Avdeev
+ */
+public abstract class TemplateKindProvider {
+
+  private final static ExtensionPointName<TemplateKindProvider> EP_NAME =
+    ExtensionPointName.create("com.intellij.javaee.templateKindProvider");
+
+  public static void addAdditionalKinds(AnAction action, PsiDirectory dir, CreateFileFromTemplateDialog.Builder builder) {
+    String id = ActionManager.getInstance().getId(action);
+    for (TemplateKindProvider provider : Extensions.getExtensions(EP_NAME)) {
+      for (Kind kind : provider.getAdditionalKinds(dir)) {
+        builder.addKind(kind.name, kind.icon, kind.templateName);
+      }
+    }
+  }
+  public abstract boolean isAvailable(Class<? extends AnAction> actionClass);
+  public abstract Kind[] getAdditionalKinds(PsiDirectory dir);
+
+  public static class Kind {
+    public final String name;
+    public final String templateName;
+    public final Icon icon;
+
+    public Kind(String name, String templateName, Icon icon) {
+      this.name = name;
+      this.templateName = templateName;
+      this.icon = icon;
+    }
+  }
+}
diff --git a/xml/impl/src/com/intellij/ide/actions/CreateHtmlFileAction.java b/xml/impl/src/com/intellij/ide/actions/CreateHtmlFileAction.java
index 9727f397e814..cd1d5d130e0f 100644
--- a/xml/impl/src/com/intellij/ide/actions/CreateHtmlFileAction.java
+++ b/xml/impl/src/com/intellij/ide/actions/CreateHtmlFileAction.java
@@ -16,21 +16,16 @@
 package com.intellij.ide.actions;
 
 import com.intellij.ide.fileTemplates.FileTemplateManager;
-import com.intellij.ide.util.PropertiesComponent;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.fileTypes.StdFileTypes;
 import com.intellij.openapi.project.Project;
 import com.intellij.psi.PsiDirectory;
-import com.intellij.psi.PsiFile;
 import com.intellij.xml.XmlBundle;
 import org.jetbrains.annotations.NonNls;
-import org.jetbrains.annotations.NotNull;
 
 /**
  * @author Eugene.Kudelevsky
  */
-public class CreateHtmlFileAction extends CreateFromTemplateAction<PsiFile> {
-  private static final Logger LOG = Logger.getInstance("#com.intellij.ide.actions.CreateHtmlFileAction");
+public class CreateHtmlFileAction extends CreateFileFromTemplateAction {
 
   @NonNls private static final String DEFAULT_HTML_TEMPLATE_PROPERTY = "DefaultHtmlFileTemplate";
 
@@ -39,15 +34,8 @@ public class CreateHtmlFileAction extends CreateFromTemplateAction<PsiFile> {
   }
 
   @Override
-  protected PsiFile createFile(String name, String templateName, PsiDirectory dir) {
-    PropertiesComponent.getInstance(dir.getProject()).setValue(DEFAULT_HTML_TEMPLATE_PROPERTY, templateName);
-
-    return createFileFromTemplate(name, templateName, dir);
-  }
-
-  @Override
-  protected void checkBeforeCreate(String name, String templateName, PsiDirectory dir) {
-    dir.checkCreateFile(name);
+  protected String getDefaultTemplateProperty() {
+    return DEFAULT_HTML_TEMPLATE_PROPERTY;
   }
 
   @Override
@@ -59,13 +47,18 @@ public class CreateHtmlFileAction extends CreateFromTemplateAction<PsiFile> {
       .addKind("XHTML file", StdFileTypes.XHTML.getIcon(), FileTemplateManager.INTERNAL_XHTML_TEMPLATE_NAME);
   }
 
-  @Override
-  protected String getDefaultTemplateName(@NotNull PsiDirectory dir) {
-    return PropertiesComponent.getInstance(dir.getProject()).getValue(DEFAULT_HTML_TEMPLATE_PROPERTY);
-  }
-
   @Override
   protected String getActionName(PsiDirectory directory, String newName, String templateName) {
     return XmlBundle.message("new.html.file.action");
   }
+
+  @Override
+  public int hashCode() {
+    return 0;
+  }
+
+  @Override
+  public boolean equals(Object obj) {
+    return obj instanceof CreateHtmlFileAction;
+  }
 }

From 93eb8cf2b7aa205927ca47f200f562513097575b Mon Sep 17 00:00:00 2001
From: Dmitry Avdeev <Dmitry.Avdeev@jetbrains.com>
Date: Thu, 29 Jul 2010 18:59:25 +0400
Subject: [PATCH 04/42] el variables from including files: JspFileIndex
 refactored to use BaseJspFile

---
 .../source/tree/java/PsiLocalVariableImpl.java  |  7 ++++---
 .../psi/impl/source/jsp/JspContextManager.java  | 17 ++++++++++-------
 .../src/com/intellij/psi/jsp/JspSpiUtil.java    |  4 ++--
 3 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/java/java-impl/src/com/intellij/psi/impl/source/tree/java/PsiLocalVariableImpl.java b/java/java-impl/src/com/intellij/psi/impl/source/tree/java/PsiLocalVariableImpl.java
index 6c9680020c0a..178e328233b8 100644
--- a/java/java-impl/src/com/intellij/psi/impl/source/tree/java/PsiLocalVariableImpl.java
+++ b/java/java-impl/src/com/intellij/psi/impl/source/tree/java/PsiLocalVariableImpl.java
@@ -27,6 +27,7 @@ import com.intellij.psi.impl.source.codeStyle.CodeEditUtil;
 import com.intellij.psi.impl.source.jsp.JspContextManager;
 import com.intellij.psi.impl.source.jsp.jspJava.JspCodeBlock;
 import com.intellij.psi.impl.source.tree.*;
+import com.intellij.psi.jsp.BaseJspFile;
 import com.intellij.psi.jsp.JspElementType;
 import com.intellij.psi.jsp.JspFile;
 import com.intellij.psi.jsp.JspSpiUtil;
@@ -289,10 +290,10 @@ public class PsiLocalVariableImpl extends CompositePsiElement implements PsiLoca
         }
 
         final Set<PsiFile> allIncluded = new THashSet<PsiFile>(10);
-        final JspFile rootContext = contextManager.getRootContextFile(jspFile);
+        final BaseJspFile rootContext = contextManager.getRootContextFile(jspFile);
         allIncluded.add(rootContext);
-        JspSpiUtil.visitAllIncludedFilesRecursively(rootContext, new Processor<JspFile>()  {
-          public boolean process(final JspFile file) {
+        JspSpiUtil.visitAllIncludedFilesRecursively(rootContext, new Processor<BaseJspFile>()  {
+          public boolean process(final BaseJspFile file) {
             allIncluded.add(file);
             return true;
           }
diff --git a/java/jsp-spi/src/com/intellij/psi/impl/source/jsp/JspContextManager.java b/java/jsp-spi/src/com/intellij/psi/impl/source/jsp/JspContextManager.java
index 763f100865ea..976932ac0ad7 100644
--- a/java/jsp-spi/src/com/intellij/psi/impl/source/jsp/JspContextManager.java
+++ b/java/jsp-spi/src/com/intellij/psi/impl/source/jsp/JspContextManager.java
@@ -18,6 +18,7 @@ package com.intellij.psi.impl.source.jsp;
 
 import com.intellij.openapi.project.Project;
 import com.intellij.psi.PsiFile;
+import com.intellij.psi.jsp.BaseJspFile;
 import com.intellij.psi.jsp.JspFile;
 import com.intellij.util.containers.HashSet;
 import org.jetbrains.annotations.NotNull;
@@ -32,20 +33,22 @@ public abstract class JspContextManager {
     return project.getComponent(JspContextManager.class);
   }
 
-  public abstract JspFile[] getSuitableContextFiles(@NotNull PsiFile file);
+  public abstract BaseJspFile[] getSuitableContextFiles(@NotNull PsiFile file);
 
-  public abstract void setContextFile(@NotNull PsiFile file, @Nullable JspFile contextFile, final boolean userDefined);
+  public abstract void setContextFile(@NotNull PsiFile file, @Nullable BaseJspFile contextFile, final boolean userDefined);
 
-  public abstract @Nullable JspFile getContextFile(@NotNull PsiFile file);
+  public abstract @Nullable
+  BaseJspFile getContextFile(@NotNull PsiFile file);
 
   public abstract @Nullable JspFile getConfiguredContextFile(@NotNull PsiFile file);
 
-  public @NotNull JspFile getRootContextFile(@NotNull JspFile file) {
-    JspFile rootContext = file;
-    HashSet<JspFile> recursionPreventer = new HashSet<JspFile>();
+  public @NotNull
+  BaseJspFile getRootContextFile(@NotNull BaseJspFile file) {
+    BaseJspFile rootContext = file;
+    HashSet<BaseJspFile> recursionPreventer = new HashSet<BaseJspFile>();
     do {
       recursionPreventer.add(rootContext);
-      JspFile context = getContextFile(rootContext);
+      BaseJspFile context = getContextFile(rootContext);
       if (context == null || recursionPreventer.contains(context)) break;
       rootContext = context;
     }
diff --git a/java/jsp-spi/src/com/intellij/psi/jsp/JspSpiUtil.java b/java/jsp-spi/src/com/intellij/psi/jsp/JspSpiUtil.java
index 542fdd95908e..01ba9e47b174 100644
--- a/java/jsp-spi/src/com/intellij/psi/jsp/JspSpiUtil.java
+++ b/java/jsp-spi/src/com/intellij/psi/jsp/JspSpiUtil.java
@@ -62,14 +62,14 @@ public abstract class JspSpiUtil {
 
   protected abstract int _escapeCharsInJspContext(JspFile file, int offset, String toEscape) throws IncorrectOperationException;
 
-  public static void visitAllIncludedFilesRecursively(JspFile jspFile, Processor<JspFile> visitor) {
+  public static void visitAllIncludedFilesRecursively(BaseJspFile jspFile, Processor<BaseJspFile> visitor) {
     final JspSpiUtil util = getJspSpiUtil();
     if (util != null) {
       util._visitAllIncludedFilesRecursively(jspFile, visitor);
     }
   }
 
-  protected abstract void _visitAllIncludedFilesRecursively(JspFile jspFile, Processor<JspFile> visitor);
+  protected abstract void _visitAllIncludedFilesRecursively(BaseJspFile jspFile, Processor<BaseJspFile> visitor);
 
   @Nullable
   public static PsiElement resolveMethodPropertyReference(@NotNull PsiReference reference, @Nullable PsiClass resolvedClass, boolean readable) {

From d1e3929c84f73180c660f02d00bc834ebf75ca4d Mon Sep 17 00:00:00 2001
From: Dmitry Avdeev <Dmitry.Avdeev@jetbrains.com>
Date: Fri, 30 Jul 2010 19:04:28 +0400
Subject: [PATCH 05/42] JspFileIndex refactored to use FBI

---
 .../impl/source/jsp/JspContextManager.java    |   2 +-
 .../psi/impl/include/FileIncludeInfo.java     |  10 +-
 .../psi/impl/include/FileIncludeManager.java  |   6 +-
 .../psi/impl/include/FileIncludeIndex.java    |   2 +-
 .../psi/impl/include/FileIncludeInfoImpl.java |   4 +-
 .../impl/include/FileIncludeManagerImpl.java  | 130 ++++++++++--------
 .../psi/impl/include/FileIncludeProvider.java |   9 --
 .../impl/providers/FileReferenceSet.java      |  20 +--
 8 files changed, 85 insertions(+), 98 deletions(-)

diff --git a/java/jsp-spi/src/com/intellij/psi/impl/source/jsp/JspContextManager.java b/java/jsp-spi/src/com/intellij/psi/impl/source/jsp/JspContextManager.java
index 976932ac0ad7..21d1701b096d 100644
--- a/java/jsp-spi/src/com/intellij/psi/impl/source/jsp/JspContextManager.java
+++ b/java/jsp-spi/src/com/intellij/psi/impl/source/jsp/JspContextManager.java
@@ -35,7 +35,7 @@ public abstract class JspContextManager {
 
   public abstract BaseJspFile[] getSuitableContextFiles(@NotNull PsiFile file);
 
-  public abstract void setContextFile(@NotNull PsiFile file, @Nullable BaseJspFile contextFile, final boolean userDefined);
+  public abstract void setContextFile(@NotNull PsiFile file, @Nullable BaseJspFile contextFile);
 
   public abstract @Nullable
   BaseJspFile getContextFile(@NotNull PsiFile file);
diff --git a/platform/lang-api/src/com/intellij/psi/impl/include/FileIncludeInfo.java b/platform/lang-api/src/com/intellij/psi/impl/include/FileIncludeInfo.java
index 82ed4f5c4c1c..f4b925897175 100644
--- a/platform/lang-api/src/com/intellij/psi/impl/include/FileIncludeInfo.java
+++ b/platform/lang-api/src/com/intellij/psi/impl/include/FileIncludeInfo.java
@@ -35,16 +35,12 @@ public class FileIncludeInfo {
     this.runtimeOnly = runtimeOnly;
   }
 
-  public FileIncludeInfo(@NotNull String fileName, @NotNull String path, int offset) {
-    this(fileName, path, offset, false);
-  }
-
-  public FileIncludeInfo(@NotNull String fileName, @NotNull String path) {
-    this(fileName, path, -1, false);
+  public FileIncludeInfo(@NotNull String path, int offset) {
+    this(getFileName(path), path, offset, false);
   }
 
   public FileIncludeInfo(@NotNull String path) {
-    this(getFileName(path), path, -1, false);
+    this(path, -1);
   }
 
   private static String getFileName(String path) {
diff --git a/platform/lang-api/src/com/intellij/psi/impl/include/FileIncludeManager.java b/platform/lang-api/src/com/intellij/psi/impl/include/FileIncludeManager.java
index 834f6772f29d..7d56a7e75cb2 100644
--- a/platform/lang-api/src/com/intellij/psi/impl/include/FileIncludeManager.java
+++ b/platform/lang-api/src/com/intellij/psi/impl/include/FileIncludeManager.java
@@ -18,9 +18,11 @@ package com.intellij.psi.impl.include;
 
 import com.intellij.openapi.components.ServiceManager;
 import com.intellij.openapi.project.Project;
+import com.intellij.openapi.util.Pair;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.psi.PsiFile;
 import com.intellij.psi.PsiFileSystemItem;
+import com.intellij.util.Processor;
 import org.jetbrains.annotations.Nullable;
 
 /**
@@ -36,6 +38,8 @@ public abstract class FileIncludeManager {
 
   public abstract VirtualFile[] getIncludingFiles(VirtualFile file, boolean compileTimeOnly);
 
+  public abstract void processIncludingFiles(PsiFile context, Processor<Pair<VirtualFile, FileIncludeInfo>> processor);
+
   @Nullable
-  public abstract PsiFileSystemItem resolveFileReference(String text, PsiFile context);
+  public abstract PsiFileSystemItem resolveFileInclude(FileIncludeInfo info, PsiFile context);
 }
diff --git a/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeIndex.java b/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeIndex.java
index 997c4578e2f4..e12030ffd4cf 100644
--- a/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeIndex.java
+++ b/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeIndex.java
@@ -163,7 +163,7 @@ public class FileIncludeIndex extends FileBasedIndexExtension<FileIncludeIndex.K
   }
 
   public int getVersion() {
-    return 0;
+    return 1;
   }
 
   interface Key {
diff --git a/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeInfoImpl.java b/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeInfoImpl.java
index d2685a46f322..0519a1b0a66c 100644
--- a/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeInfoImpl.java
+++ b/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeInfoImpl.java
@@ -18,6 +18,8 @@ package com.intellij.psi.impl.include;
 
 import org.jetbrains.annotations.NotNull;
 
+import java.io.File;
+
 /**
  * @author Dmitry Avdeev
  */
@@ -26,7 +28,7 @@ class FileIncludeInfoImpl extends FileIncludeInfo {
   public final String providerId;
 
   public FileIncludeInfoImpl(@NotNull String path, int offset, boolean runtimeOnly, String providerId) {
-    super("", path, offset, runtimeOnly);
+    super(new File(path).getName(), path, offset, runtimeOnly);
     this.providerId = providerId;
   }
 
diff --git a/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeManagerImpl.java b/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeManagerImpl.java
index ab190374b613..b15bbcc6829a 100644
--- a/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeManagerImpl.java
+++ b/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeManagerImpl.java
@@ -19,6 +19,7 @@ package com.intellij.psi.impl.include;
 import com.intellij.openapi.extensions.Extensions;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.Key;
+import com.intellij.openapi.util.Pair;
 import com.intellij.openapi.vfs.VfsUtil;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.openapi.vfs.VirtualFileWithId;
@@ -34,12 +35,11 @@ import com.intellij.psi.util.CachedValuesManager;
 import com.intellij.psi.util.ParameterizedCachedValue;
 import com.intellij.psi.util.ParameterizedCachedValueProvider;
 import com.intellij.util.ArrayUtil;
+import com.intellij.util.Processor;
 import com.intellij.util.containers.HashMap;
 import com.intellij.util.containers.MultiMap;
 
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 
 /**
  * @author Dmitry Avdeev
@@ -54,46 +54,68 @@ public class FileIncludeManagerImpl extends FileIncludeManager {
 
   private final IncludeCacheHolder myIncludedHolder = new IncludeCacheHolder("compile time includes", "runtime includes") {
     @Override
-    protected VirtualFile[] computeFiles(PsiFile file, boolean compileTimeOnly) {
-      GlobalSearchScope scope = GlobalSearchScope.allScope(myProject);
-      List<FileIncludeInfoImpl> infoList = FileIncludeIndex.getIncludes(file.getVirtualFile(), scope);
-      ArrayList<VirtualFile> files = new ArrayList<VirtualFile>();
-      for (FileIncludeInfoImpl info : infoList) {
-        if (compileTimeOnly && info.runtimeOnly) {
-          continue;
-        }
-        FileIncludeProvider includeProvider = myProviderMap.get(info.providerId);
-        if (includeProvider != null) {
-          PsiFileSystemItem virtualFile = includeProvider.resolveInclude(info, file, myProject);
-          if (virtualFile != null) {
-            files.add(virtualFile.getVirtualFile());
+    protected VirtualFile[] computeFiles(final PsiFile file, final boolean compileTimeOnly) {
+      final ArrayList<VirtualFile> files = new ArrayList<VirtualFile>();
+      processIncludes(file, new Processor<FileIncludeInfo>() {
+        @Override
+        public boolean process(FileIncludeInfo info) {
+          if (compileTimeOnly != info.runtimeOnly) {
+            PsiFileSystemItem virtualFile = resolveFileInclude(info, file);
+            if (virtualFile != null) {
+              files.add(virtualFile.getVirtualFile());
+            }
           }
+          return true;
         }
+
+      });
+      return files.toArray(new VirtualFile[files.size()]);
+    }
+  };
+
+  public void processIncludes(PsiFile file, Processor<FileIncludeInfo> processor) {
+    GlobalSearchScope scope = GlobalSearchScope.allScope(myProject);
+    List<FileIncludeInfoImpl> infoList = FileIncludeIndex.getIncludes(file.getVirtualFile(), scope);
+    for (FileIncludeInfoImpl info : infoList) {
+      if (!processor.process(info)) {
+        return;
       }
+    }
+  }
+
+  private final IncludeCacheHolder myIncludingHolder = new IncludeCacheHolder("compile time contexts", "runtime contexts") {
+    @Override
+    protected VirtualFile[] computeFiles(PsiFile context, boolean compileTimeOnly) {
+      final ArrayList<VirtualFile> files = new ArrayList<VirtualFile>();
+      processIncludingFiles(context, new Processor<Pair<VirtualFile, FileIncludeInfo>>() {
+        @Override
+        public boolean process(Pair<VirtualFile, FileIncludeInfo> virtualFileFileIncludeInfoPair) {
+          files.add(virtualFileFileIncludeInfoPair.first);
+          return true;
+        }
+      });
       return VfsUtil.toVirtualFileArray(files);
     }
   };
 
-  private final IncludeCacheHolder myIncludingHolder = new IncludeCacheHolder("compile time contexts", "runtime contexts") {
-    @Override
-    protected VirtualFile[] computeFiles(PsiFile file, boolean compileTimeOnly) {
-      MultiMap<VirtualFile,FileIncludeInfoImpl> infoList = FileIncludeIndex.getIncludingFileCandidates(file.getName(), GlobalSearchScope.allScope(myProject));
-      ArrayList<VirtualFile> files = new ArrayList<VirtualFile>();
-      for (VirtualFile candidate : infoList.keySet()) {
-        PsiFile psiFile = myPsiManager.findFile(candidate);
-        if (psiFile == null) continue;
-        for (FileIncludeInfoImpl info : infoList.get(candidate)) {
-          FileIncludeProvider includeProvider = myProviderMap.get(info.providerId);
-          if (includeProvider != null) {
-            if (file.equals(includeProvider.resolveInclude(info, psiFile, myProject))) {
-              files.add(candidate);
-            }
+  public void processIncludingFiles(PsiFile context, Processor<Pair<VirtualFile, FileIncludeInfo>> processor) {
+    context = context.getOriginalFile();
+    VirtualFile contextFile = context.getVirtualFile();
+    if (contextFile == null) return;
+    MultiMap<VirtualFile,FileIncludeInfoImpl> infoList = FileIncludeIndex.getIncludingFileCandidates(context.getName(), GlobalSearchScope.allScope(myProject));
+    for (VirtualFile candidate : infoList.keySet()) {
+      PsiFile psiFile = myPsiManager.findFile(candidate);
+      if (psiFile == null || context.equals(psiFile)) continue;
+      for (FileIncludeInfo info : infoList.get(candidate)) {
+        PsiFileSystemItem item = resolveFileInclude(info, psiFile);
+        if (item != null && contextFile.equals(item.getVirtualFile())) {
+          if (!processor.process(Pair.create(candidate, info))) {
+            return;
           }
         }
       }
-      return VfsUtil.toVirtualFileArray(files);
     }
-  };
+  }
 
   public FileIncludeManagerImpl(Project project, PsiManager psiManager, PsiFileFactory psiFileFactory,
                                 CachedValuesManager cachedValuesManager) {
@@ -120,19 +142,23 @@ public class FileIncludeManagerImpl extends FileIncludeManager {
     }
   }
 
-
   @Override
   public VirtualFile[] getIncludingFiles(VirtualFile file, boolean compileTimeOnly) {
     return myIncludingHolder.getAllFiles(file, compileTimeOnly);
   }
 
   @Override
-  public PsiFileSystemItem resolveFileReference(String text, PsiFile context) {
-        
-    PsiFileImpl psiFile = (PsiFileImpl)myPsiFileFactory.createFileFromText("dummy.txt", text);
+  public PsiFileSystemItem resolveFileInclude(FileIncludeInfo info, PsiFile context) {
+
+    PsiFileImpl psiFile = (PsiFileImpl)myPsiFileFactory.createFileFromText("dummy.txt", info.path);
     psiFile.setOriginalFile(context);
 
-    return new FileReferenceSet(psiFile).resolve();
+    return new FileReferenceSet(psiFile) {
+      @Override
+      protected boolean useIncludingFileAsContext() {
+        return false;
+      }
+    }.resolve();
   }
 
   private abstract class IncludeCacheHolder {
@@ -140,14 +166,14 @@ public class FileIncludeManagerImpl extends FileIncludeManager {
     private final Key<ParameterizedCachedValue<VirtualFile[], PsiFile>> COMPILE_TIME_KEY;
     private final Key<ParameterizedCachedValue<VirtualFile[], PsiFile>> RUNTIME_KEY;
 
-    private final ParameterizedCachedValueProvider<VirtualFile[], PsiFile> COMPILE_TIME_PROVIDER = new IncludedFilesProvider(false) {
+    private final ParameterizedCachedValueProvider<VirtualFile[], PsiFile> COMPILE_TIME_PROVIDER = new IncludedFilesProvider(true) {
       @Override
       protected VirtualFile[] computeFiles(PsiFile file, boolean compileTimeOnly) {
         return IncludeCacheHolder.this.computeFiles(file, compileTimeOnly);
       }
     };
 
-    private final ParameterizedCachedValueProvider<VirtualFile[], PsiFile> RUNTIME_PROVIDER = new IncludedFilesProvider(true) {
+    private final ParameterizedCachedValueProvider<VirtualFile[], PsiFile> RUNTIME_PROVIDER = new IncludedFilesProvider(false) {
       @Override
       protected VirtualFile[] computeFiles(PsiFile file, boolean compileTimeOnly) {
         return IncludeCacheHolder.this.computeFiles(file, compileTimeOnly);
@@ -160,36 +186,20 @@ public class FileIncludeManagerImpl extends FileIncludeManager {
     }
 
     public VirtualFile[] getAllFiles(VirtualFile file, boolean compileTimeOnly) {
-      ArrayList<VirtualFile[]> result = new ArrayList<VirtualFile[]>();
+      Set<VirtualFile> result = new HashSet<VirtualFile>();
       getFilesRecursively(file, compileTimeOnly, result);
-      switch (result.size()) {
-        case 0:
-          return VirtualFile.EMPTY_ARRAY;
-        case 1:
-          return result.get(0);
-        default:
-          int size = 0;
-          for (VirtualFile[] files : result) {
-            size+=files.length;
-          }
-          VirtualFile[] files = new VirtualFile[size];
-          int pos = 0;
-          for (VirtualFile[] virtualFiles : result) {
-            System.arraycopy(virtualFiles, 0, files, pos, virtualFiles.length);
-            pos += virtualFiles.length;
-          }
-          return files;
-      }
+      return result.toArray(new VirtualFile[result.size()]);
     }
 
-    private void getFilesRecursively(VirtualFile file, boolean compileTimeOnly, List<VirtualFile[]> result) {
+    private void getFilesRecursively(VirtualFile file, boolean compileTimeOnly, Set<VirtualFile> result) {
+      if (result.contains(file)) return;
       PsiFile psiFile = myPsiManager.findFile(file);
       if (psiFile == null) return;
       VirtualFile[] includes = compileTimeOnly
                                ? myCachedValuesManager.getParameterizedCachedValue(psiFile, COMPILE_TIME_KEY, COMPILE_TIME_PROVIDER, false, psiFile)
                                : myCachedValuesManager.getParameterizedCachedValue(psiFile, RUNTIME_KEY, RUNTIME_PROVIDER, false, psiFile);
       if (includes.length != 0) {
-        result.add(includes);
+        result.addAll(Arrays.asList(includes));
         for (VirtualFile include : includes) {
           getFilesRecursively(include, compileTimeOnly, result);
         }
diff --git a/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeProvider.java b/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeProvider.java
index 031865cffb30..2161f95fa29f 100644
--- a/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeProvider.java
+++ b/platform/lang-impl/src/com/intellij/psi/impl/include/FileIncludeProvider.java
@@ -17,13 +17,9 @@
 package com.intellij.psi.impl.include;
 
 import com.intellij.openapi.extensions.ExtensionPointName;
-import com.intellij.openapi.project.Project;
 import com.intellij.openapi.vfs.VirtualFile;
-import com.intellij.psi.PsiFile;
-import com.intellij.psi.PsiFileSystemItem;
 import com.intellij.util.indexing.FileContent;
 import org.jetbrains.annotations.NotNull;
-import org.jetbrains.annotations.Nullable;
 
 /**
  * @author Dmitry Avdeev
@@ -39,9 +35,4 @@ public abstract class FileIncludeProvider {
   
   @NotNull
   public abstract FileIncludeInfo[] getIncludeInfos(FileContent content);
-
-  @Nullable
-  public PsiFileSystemItem resolveInclude(FileIncludeInfo include, PsiFile context, Project project) {
-    return FileIncludeManager.getManager(project).resolveFileReference(include.path, context);
-  }
 }
diff --git a/platform/lang-impl/src/com/intellij/psi/impl/source/resolve/reference/impl/providers/FileReferenceSet.java b/platform/lang-impl/src/com/intellij/psi/impl/source/resolve/reference/impl/providers/FileReferenceSet.java
index 828fdc42cc23..6de47a442bf5 100644
--- a/platform/lang-impl/src/com/intellij/psi/impl/source/resolve/reference/impl/providers/FileReferenceSet.java
+++ b/platform/lang-impl/src/com/intellij/psi/impl/source/resolve/reference/impl/providers/FileReferenceSet.java
@@ -22,15 +22,10 @@ import com.intellij.openapi.module.Module;
 import com.intellij.openapi.module.ModuleUtil;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.Condition;
-import com.intellij.openapi.util.Key;
 import com.intellij.openapi.util.TextRange;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.psi.*;
 import com.intellij.psi.impl.source.tree.injected.InjectedLanguageUtil;
-import com.intellij.psi.util.CachedValue;
-import com.intellij.psi.util.CachedValueProvider;
-import com.intellij.psi.util.CachedValuesManager;
-import com.intellij.psi.util.PsiModificationTracker;
 import com.intellij.util.Function;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
@@ -46,7 +41,6 @@ public class FileReferenceSet {
   private static final FileType[] EMPTY_FILE_TYPES = {};
   private static final char SEPARATOR = '/';
   private static final String SEPARATOR_STRING = "/";
-  private static final Key<CachedValue<Collection<PsiFileSystemItem>>> DEFAULT_CONTEXTS_KEY = new Key<CachedValue<Collection<PsiFileSystemItem>>>("default file contexts");
   public static final CustomizableReferenceProvider.CustomizationKey<Function<PsiFile, Collection<PsiFileSystemItem>>> DEFAULT_PATH_EVALUATOR_OPTION =
     new CustomizableReferenceProvider.CustomizationKey<Function<PsiFile, Collection<PsiFileSystemItem>>>(PsiBundle.message("default.path.evaluator.option"));
   public static final Function<PsiFile, Collection<PsiFileSystemItem>> ABSOLUTE_TOP_LEVEL = new Function<PsiFile, Collection<PsiFileSystemItem>>() {
@@ -262,17 +256,7 @@ public class FileReferenceSet {
       return getAbsoluteTopLevelDirLocations(file);
     }
 
-    final CachedValueProvider<Collection<PsiFileSystemItem>> myDefaultContextProvider = new CachedValueProvider<Collection<PsiFileSystemItem>>() {
-      public Result<Collection<PsiFileSystemItem>> compute() {
-        final Collection<PsiFileSystemItem> contexts = getContextByFile(file);
-        return Result.createSingleDependency(contexts,
-                                             PsiModificationTracker.OUT_OF_CODE_BLOCK_MODIFICATION_COUNT);
-      }
-    };
-    final CachedValuesManager cachedValuesManager = CachedValuesManager.getManager(myElement.getProject());
-    final Collection<PsiFileSystemItem> value =
-      cachedValuesManager.getCachedValue(file, DEFAULT_CONTEXTS_KEY, myDefaultContextProvider, false);
-    return value == null ? Collections.<PsiFileSystemItem>emptyList() : value;
+    return getContextByFile(file);
   }
 
   @Nullable
@@ -285,7 +269,7 @@ public class FileReferenceSet {
     return file.getOriginalFile();
   }
 
-  @Nullable
+  @NotNull
   private Collection<PsiFileSystemItem> getContextByFile(@NotNull PsiFile file) {
     final PsiElement context = file.getContext();
     if (context != null) file = context.getContainingFile();

From f4a133189655519d44ec019fc68daaea2ce6611c Mon Sep 17 00:00:00 2001
From: Dmitry Trofimov <dmitry.trofimov@jetbrains.com>
Date: Mon, 2 Aug 2010 16:17:58 +0400
Subject: [PATCH 06/42] added convenient method

---
 .../src/com/intellij/psi/util/PsiTreeUtil.java         | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/platform/lang-api/src/com/intellij/psi/util/PsiTreeUtil.java b/platform/lang-api/src/com/intellij/psi/util/PsiTreeUtil.java
index f5c174dea4b5..4199ce90d337 100644
--- a/platform/lang-api/src/com/intellij/psi/util/PsiTreeUtil.java
+++ b/platform/lang-api/src/com/intellij/psi/util/PsiTreeUtil.java
@@ -229,6 +229,16 @@ public class PsiTreeUtil {
     return result == null ? null : ArrayUtil.toObjectArray(result, aClass);
   }
 
+  @NotNull public static <T extends PsiElement> List<T> getChildrenOfTypeAsList(@NotNull PsiElement element, @NotNull Class<T> aClass) {
+    List<T> result = new SmartList<T>();
+    for(PsiElement child = element.getFirstChild(); child != null; child = child.getNextSibling()){
+      if (instanceOf(aClass, child)) {
+        result.add((T)child);
+      }
+    }
+    return result;
+  }
+
 
   private static boolean instanceOf(final Class aClass, final PsiElement child) {
     /*

From fa331e88ea2f902be17eb041ee47f0f22e6a4d43 Mon Sep 17 00:00:00 2001
From: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Date: Mon, 2 Aug 2010 15:44:56 +0400
Subject: [PATCH 07/42] git4idea: Fixed NPE during dispose

---
 .../checkout/branches/GitBranchesWidget.java  | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
index 94657453bc93..ae33d38f7c98 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
@@ -76,6 +76,10 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
    * The project
    */
   final Project myProject;
+  /**
+   * The status bar
+   */
+  private final StatusBar myStatusBar;
   /**
    * The configurations instance
    */
@@ -88,10 +92,6 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
    * The candidate remote configurations. Null if invalidated or non-initialized
    */
   private AnAction[] myRemoveConfigurations;
-  /**
-   * The status bar
-   */
-  private StatusBar myStatusBar;
   /**
    * If true, the popup is enabled
    */
@@ -113,12 +113,14 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
   /**
    * The constructor
    *
-   * @param project the project instance
+   * @param project        the project instance
+   * @param statusBar      the status bar
+   * @param configurations the configuration settings
    */
-  public GitBranchesWidget(Project project, GitBranchConfigurations configurations) {
+  public GitBranchesWidget(Project project, StatusBar statusBar, GitBranchConfigurations configurations) {
     myProject = project;
+    myStatusBar = statusBar;
     setBorder(WidgetBorder.INSTANCE);
-    //setBorder(BorderFactory.createEtchedBorder());
     myConfigurations = configurations;
     myDefaultForeground = getForeground();
     myConfigurationsListener = new MyGitBranchConfigurationsListener();
@@ -148,7 +150,7 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
       public void run() {
         StatusBar statusBar = WindowManager.getInstance().getStatusBar(project);
         if (statusBar != null) {
-          final GitBranchesWidget w = new GitBranchesWidget(project, configurations);
+          final GitBranchesWidget w = new GitBranchesWidget(project, statusBar, configurations);
           statusBar.addWidget(w, "after " + (SystemInfo.isMac ? "Encoding" : "InsertOverwrite"), project);
           widget.set(w);
         }
@@ -200,7 +202,6 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
    */
   @Override
   public void install(@NotNull StatusBar statusBar) {
-    myStatusBar = statusBar;
   }
 
   /**
@@ -550,5 +551,4 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
       });
     }
   }
-
 }

From 3990642f9fb6972c06bcd31b81f6e8798258727f Mon Sep 17 00:00:00 2001
From: nik <Nikolay.Chashnikov@jetbrains.com>
Date: Mon, 2 Aug 2010 16:46:35 +0400
Subject: [PATCH 08/42] check ZipFile in "IO Resource not safely closed"
 inspection

---
 .../src/com/siyeh/ig/resources/IOResourceInspection.java        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/InspectionGadgets/src/com/siyeh/ig/resources/IOResourceInspection.java b/plugins/InspectionGadgets/src/com/siyeh/ig/resources/IOResourceInspection.java
index 8dfa5c619ffa..e7a1520bcba0 100644
--- a/plugins/InspectionGadgets/src/com/siyeh/ig/resources/IOResourceInspection.java
+++ b/plugins/InspectionGadgets/src/com/siyeh/ig/resources/IOResourceInspection.java
@@ -174,7 +174,7 @@ public class IOResourceInspection extends ResourceInspection {
     public boolean isIOResource(PsiExpression expression){
         return TypeUtils.expressionHasTypeOrSubtype(expression,
                 "java.io.InputStream", "java.io.Writer", "java.io.Reader",
-                "java.io.RandomAccessFile", "java.io.OutputStream") != null &&
+                "java.io.RandomAccessFile", "java.io.OutputStream", "java.util.zip.ZipFile") != null &&
                !isIgnoredType(expression);
     }
 

From d31fba13b9f31f37835ddaa6476ff3b7a3cbd49b Mon Sep 17 00:00:00 2001
From: nik <Nikolay.Chashnikov@jetbrains.com>
Date: Mon, 2 Aug 2010 16:51:59 +0400
Subject: [PATCH 09/42] IDEA-51729: Ability to include exploded JARs in
 artifacts

---
 .../ArchiveAntCopyInstructionCreator.java     |  11 +-
 .../DirectoryAntCopyInstructionCreator.java   |  20 ++-
 .../impl/packagingCompiler/JarsBuilder.java   |  43 ++++++-
 .../impl/artifacts/ArtifactUtil.java          |   5 +-
 .../impl/compiler/ArtifactCompilerUtil.java   |  68 ++++++++++
 .../compiler/ArtifactsCompilerInstance.java   |  50 ++++++--
 .../DirectoryCopyPackagingElement.java        |   2 +-
 .../ExtractedDirectoryElementType.java        |  80 ++++++++++++
 .../ExtractedDirectoryPackagingElement.java   | 116 ++++++++++++++++++
 .../elements/FileCopyPackagingElement.java    |   2 +-
 .../elements/PackagingElementFactoryImpl.java |  10 +-
 .../ui/ExtractedDirectoryPresentation.java    |  65 ++++++++++
 .../impl/ui/FileCopyPresentation.java         |   7 +-
 .../compiler/ant/taskdefs/Include.java        |   4 +-
 .../compiler/ant/taskdefs/PatternSet.java     |   4 +-
 .../intellij/compiler/ant/taskdefs/Unzip.java |  27 ++++
 .../compiler/ant/taskdefs/ZipFileSet.java     |  13 ++
 .../elements/AntCopyInstructionCreator.java   |   9 +-
 .../elements/PackagingElementFactory.java     |   4 +
 .../packaging/ui/PackagingElementWeights.java |   1 +
 platform/icons/src/nodes/copyOfFolder.png     | Bin 727 -> 588 bytes
 platform/icons/src/nodes/extractedFolder.png  | Bin 0 -> 657 bytes
 .../intellij/openapi/util/io/FileUtil.java    |   2 +-
 23 files changed, 498 insertions(+), 45 deletions(-)
 create mode 100644 java/compiler/impl/src/com/intellij/packaging/impl/compiler/ArtifactCompilerUtil.java
 create mode 100644 java/compiler/impl/src/com/intellij/packaging/impl/elements/ExtractedDirectoryElementType.java
 create mode 100644 java/compiler/impl/src/com/intellij/packaging/impl/elements/ExtractedDirectoryPackagingElement.java
 create mode 100644 java/compiler/impl/src/com/intellij/packaging/impl/ui/ExtractedDirectoryPresentation.java
 create mode 100644 java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/Unzip.java
 create mode 100644 platform/icons/src/nodes/extractedFolder.png

diff --git a/java/compiler/impl/src/com/intellij/compiler/ant/artifacts/ArchiveAntCopyInstructionCreator.java b/java/compiler/impl/src/com/intellij/compiler/ant/artifacts/ArchiveAntCopyInstructionCreator.java
index 8343e9f86b52..1857676997c0 100644
--- a/java/compiler/impl/src/com/intellij/compiler/ant/artifacts/ArchiveAntCopyInstructionCreator.java
+++ b/java/compiler/impl/src/com/intellij/compiler/ant/artifacts/ArchiveAntCopyInstructionCreator.java
@@ -43,11 +43,18 @@ public class ArchiveAntCopyInstructionCreator implements AntCopyInstructionCreat
   }
 
   @NotNull
-  public AntCopyInstructionCreator subFolder(String directoryName) {
+  public AntCopyInstructionCreator subFolder(@NotNull String directoryName) {
     return new ArchiveAntCopyInstructionCreator(myPrefix + "/" + directoryName);
   }
 
-  public Generator createSubFolderCommand(String directoryName) {
+  public Generator createSubFolderCommand(@NotNull String directoryName) {
     return null;
   }
+
+  @NotNull
+  @Override
+  public Generator createExtractedDirectoryInstruction(@NotNull String jarPath, @NotNull String pathInJar) {
+    final String pattern = pathInJar.length() == 0 ? null : pathInJar + "**";
+    return ZipFileSet.createUnpackedSet(jarPath, pathInJar, true, pattern);
+  }
 }
diff --git a/java/compiler/impl/src/com/intellij/compiler/ant/artifacts/DirectoryAntCopyInstructionCreator.java b/java/compiler/impl/src/com/intellij/compiler/ant/artifacts/DirectoryAntCopyInstructionCreator.java
index ad9c41d49398..0d8d08c4a41a 100644
--- a/java/compiler/impl/src/com/intellij/compiler/ant/artifacts/DirectoryAntCopyInstructionCreator.java
+++ b/java/compiler/impl/src/com/intellij/compiler/ant/artifacts/DirectoryAntCopyInstructionCreator.java
@@ -17,9 +17,7 @@ package com.intellij.compiler.ant.artifacts;
 
 import com.intellij.compiler.ant.Generator;
 import com.intellij.compiler.ant.Tag;
-import com.intellij.compiler.ant.taskdefs.Copy;
-import com.intellij.compiler.ant.taskdefs.FileSet;
-import com.intellij.compiler.ant.taskdefs.Mkdir;
+import com.intellij.compiler.ant.taskdefs.*;
 import com.intellij.packaging.elements.AntCopyInstructionCreator;
 import org.jetbrains.annotations.NotNull;
 
@@ -50,11 +48,23 @@ public class DirectoryAntCopyInstructionCreator implements AntCopyInstructionCre
   }
 
   @NotNull
-  public AntCopyInstructionCreator subFolder(String directoryName) {
+  public AntCopyInstructionCreator subFolder(@NotNull String directoryName) {
     return new DirectoryAntCopyInstructionCreator(myOutputDirectory + "/" + directoryName);
   }
 
-  public Generator createSubFolderCommand(String directoryName) {
+  public Generator createSubFolderCommand(@NotNull String directoryName) {
     return new Mkdir(myOutputDirectory + "/" + directoryName);
   }
+
+  @NotNull
+  @Override
+  public Generator createExtractedDirectoryInstruction(@NotNull String jarPath, @NotNull String pathInJar) {
+    final Unzip unzip = new Unzip(jarPath, myOutputDirectory);
+    if (pathInJar.length() > 0) {
+      final PatternSet patterns = new PatternSet(null);
+      patterns.add(new Include(pathInJar + "**"));
+      unzip.add(patterns);
+    }
+    return unzip;
+  }
 }
diff --git a/java/compiler/impl/src/com/intellij/compiler/impl/packagingCompiler/JarsBuilder.java b/java/compiler/impl/src/com/intellij/compiler/impl/packagingCompiler/JarsBuilder.java
index 7e1a218a04a1..10b387d762ec 100644
--- a/java/compiler/impl/src/com/intellij/compiler/impl/packagingCompiler/JarsBuilder.java
+++ b/java/compiler/impl/src/com/intellij/compiler/impl/packagingCompiler/JarsBuilder.java
@@ -25,6 +25,7 @@ import com.intellij.openapi.util.Pair;
 import com.intellij.openapi.util.io.FileUtil;
 import com.intellij.openapi.vfs.VfsUtil;
 import com.intellij.openapi.vfs.VirtualFile;
+import com.intellij.packaging.impl.compiler.ArtifactCompilerUtil;
 import com.intellij.util.ArrayUtil;
 import com.intellij.util.graph.CachingSemiGraph;
 import com.intellij.util.graph.DFSTBuilder;
@@ -159,8 +160,14 @@ public class JarsBuilder {
     try {
       final THashSet<String> writtenPaths = new THashSet<String>();
       for (Pair<String, VirtualFile> pair : jar.getPackedFiles()) {
-        File file = VfsUtil.virtualToIoFile(pair.getSecond());
-        addFileToJar(jarOutputStream, file, pair.getFirst(), writtenPaths);
+        final VirtualFile sourceFile = pair.getSecond();
+        if (sourceFile.isInLocalFileSystem()) {
+          File file = VfsUtil.virtualToIoFile(sourceFile);
+          addFileToJar(jarOutputStream, file, pair.getFirst(), writtenPaths);
+        }
+        else {
+          extractFileAndAddToJar(jarOutputStream, sourceFile, pair.getFirst(), writtenPaths);
+        }
       }
 
       for (Pair<String, JarInfo> nestedJar : jar.getPackedJars()) {
@@ -178,9 +185,35 @@ public class JarsBuilder {
     }
   }
 
+  private void extractFileAndAddToJar(JarOutputStream jarOutputStream, VirtualFile sourceFile, String relativePath, THashSet<String> writtenPaths)
+    throws IOException {
+    relativePath = addParentDirectories(jarOutputStream, writtenPaths, relativePath);
+    myContext.getProgressIndicator().setText2(relativePath);
+    if (!writtenPaths.add(relativePath)) return;
+
+    final BufferedInputStream input = ArtifactCompilerUtil.getJarEntryInputStream(sourceFile, myContext);
+    if (input == null) return;
+
+    ZipEntry entry = new ZipEntry(relativePath);
+    entry.setTime(ArtifactCompilerUtil.getJarFile(sourceFile).lastModified());
+    jarOutputStream.putNextEntry(entry);
+    FileUtil.copy(input, jarOutputStream);
+    jarOutputStream.closeEntry();
+  }
+
   private void addFileToJar(final @NotNull JarOutputStream jarOutputStream, final @NotNull File file, @NotNull String relativePath,
                             final @NotNull THashSet<String> writtenPaths) throws IOException {
-    //todo[nik] check file exists?
+    if (!file.exists()) {
+      return;
+    }
+
+    relativePath = addParentDirectories(jarOutputStream, writtenPaths, relativePath);
+    myContext.getProgressIndicator().setText2(relativePath);
+    ZipUtil.addFileToZip(jarOutputStream, file, relativePath, writtenPaths, myFileFilter);
+  }
+
+  private static String addParentDirectories(JarOutputStream jarOutputStream, THashSet<String> writtenPaths, String relativePath)
+    throws IOException {
     while (relativePath.startsWith("/")) {
       relativePath = relativePath.substring(1);
     }
@@ -193,9 +226,7 @@ public class JarsBuilder {
       }
       i = relativePath.indexOf('/', i + 1);
     }
-
-    myContext.getProgressIndicator().setText2(relativePath);
-    ZipUtil.addFileToZip(jarOutputStream, file, relativePath, writtenPaths, myFileFilter);
+    return relativePath;
   }
 
   private static void addEntry(final ZipOutputStream output, @NonNls final String relativePath) throws IOException {
diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/artifacts/ArtifactUtil.java b/java/compiler/impl/src/com/intellij/packaging/impl/artifacts/ArtifactUtil.java
index 3d246a41c078..da39774c3698 100644
--- a/java/compiler/impl/src/com/intellij/packaging/impl/artifacts/ArtifactUtil.java
+++ b/java/compiler/impl/src/com/intellij/packaging/impl/artifacts/ArtifactUtil.java
@@ -320,6 +320,7 @@ public class ArtifactUtil {
                                                          boolean processSubstitutions) {
     processPackagingElements(artifact, PackagingElementFactoryImpl.FILE_COPY_ELEMENT_TYPE, processor, context, processSubstitutions);
     processPackagingElements(artifact, PackagingElementFactoryImpl.DIRECTORY_COPY_ELEMENT_TYPE, processor, context, processSubstitutions);
+    processPackagingElements(artifact, PackagingElementFactoryImpl.EXTRACTED_DIRECTORY_ELEMENT_TYPE, processor, context, processSubstitutions);
   }
 
   public static Collection<Trinity<Artifact, PackagingElementPath, String>> findContainingArtifactsWithOutputPaths(@NotNull final VirtualFile file, @NotNull Project project) {
@@ -417,8 +418,8 @@ public class ArtifactUtil {
             ContainerUtil.addIfNotNull(fileCopyElement.findFile(), result);
           }
         }
-        else if (element instanceof DirectoryCopyPackagingElement) {
-          final VirtualFile sourceRoot = ((DirectoryCopyPackagingElement)element).findFile();
+        else if (element instanceof DirectoryCopyPackagingElement || element instanceof ExtractedDirectoryPackagingElement) {
+          final VirtualFile sourceRoot = ((FileOrDirectoryCopyPackagingElement<?>)element).findFile();
           if (sourceRoot != null) {
             ContainerUtil.addIfNotNull(sourceRoot.findFileByRelativePath(path), result);
           }
diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/compiler/ArtifactCompilerUtil.java b/java/compiler/impl/src/com/intellij/packaging/impl/compiler/ArtifactCompilerUtil.java
new file mode 100644
index 000000000000..f512c68e7a0b
--- /dev/null
+++ b/java/compiler/impl/src/com/intellij/packaging/impl/compiler/ArtifactCompilerUtil.java
@@ -0,0 +1,68 @@
+/*
+ * Copyright 2000-2010 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.packaging.impl.compiler;
+
+import com.intellij.openapi.compiler.CompileContext;
+import com.intellij.openapi.compiler.CompilerMessageCategory;
+import com.intellij.openapi.diagnostic.Logger;
+import com.intellij.openapi.util.io.FileUtil;
+import com.intellij.openapi.vfs.JarFileSystem;
+import com.intellij.openapi.vfs.VirtualFile;
+import org.jetbrains.annotations.Nullable;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.util.zip.ZipEntry;
+import java.util.zip.ZipFile;
+
+/**
+ * @author nik
+ */
+public class ArtifactCompilerUtil {
+  private static final Logger LOG = Logger.getInstance("#com.intellij.packaging.impl.compiler.ArtifactCompilerUtil");
+
+  private ArtifactCompilerUtil() {
+  }
+
+  @Nullable
+  public static BufferedInputStream getJarEntryInputStream(VirtualFile sourceFile, final CompileContext context) throws IOException {
+    final String fullPath = sourceFile.getPath();
+    final int jarEnd = fullPath.indexOf(JarFileSystem.JAR_SEPARATOR);
+    LOG.assertTrue(jarEnd != -1, fullPath);
+    String pathInJar = fullPath.substring(jarEnd + JarFileSystem.JAR_SEPARATOR.length());
+    String jarPath = fullPath.substring(0, jarEnd);
+    final ZipFile jarFile = new ZipFile(new File(FileUtil.toSystemDependentName(jarPath)));
+    final ZipEntry entry = jarFile.getEntry(pathInJar);
+    if (entry == null) {
+      context.addMessage(CompilerMessageCategory.ERROR, "Cannot extract '" + pathInJar + "' from '" + jarFile.getName() + "': entry not found", null, -1, -1);
+      return null;
+    }
+
+    return new BufferedInputStream(jarFile.getInputStream(entry)) {
+      @Override
+      public void close() throws IOException {
+        super.close();
+        jarFile.close();
+      }
+    };
+  }
+
+  public static File getJarFile(VirtualFile jarEntry) {
+    String fullPath = jarEntry.getPath();
+    return new File(FileUtil.toSystemDependentName(fullPath.substring(fullPath.indexOf(JarFileSystem.JAR_SEPARATOR))));
+  }
+}
diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/compiler/ArtifactsCompilerInstance.java b/java/compiler/impl/src/com/intellij/packaging/impl/compiler/ArtifactsCompilerInstance.java
index f2746de16b45..46c1ed0bab25 100644
--- a/java/compiler/impl/src/com/intellij/packaging/impl/compiler/ArtifactsCompilerInstance.java
+++ b/java/compiler/impl/src/com/intellij/packaging/impl/compiler/ArtifactsCompilerInstance.java
@@ -31,7 +31,7 @@ import com.intellij.openapi.deployment.DeploymentUtil;
 import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.module.ModuleManager;
-import com.intellij.openapi.progress.ProcessCanceledException;
+import com.intellij.openapi.progress.ProcessCanceledException;                                          
 import com.intellij.openapi.util.Pair;
 import com.intellij.openapi.util.Ref;
 import com.intellij.openapi.util.SystemInfo;
@@ -53,9 +53,7 @@ import com.intellij.util.text.CaseInsensitiveStringHashingStrategy;
 import gnu.trove.THashSet;
 import org.jetbrains.annotations.NotNull;
 
-import java.io.File;
-import java.io.FileFilter;
-import java.io.IOException;
+import java.io.*;
 import java.util.*;
 
 /**
@@ -164,7 +162,7 @@ public class ArtifactsCompilerInstance extends CompilerInstance<ArtifactBuildTar
 
   private boolean doBuild(final List<Pair<ArtifactCompilerCompileItem, ArtifactPackagingItemOutputState>> changedItems,
                           final Set<ArtifactCompilerCompileItem> processedItems,
-                          final Set<String> writtenPaths, final Set<String> deletedJars) {
+                          final @NotNull Set<String> writtenPaths, final Set<String> deletedJars) {
     final boolean testMode = ApplicationManager.getApplication().isUnitTestMode();
 
     final DeploymentUtil deploymentUtil = DeploymentUtil.getInstance();
@@ -188,20 +186,26 @@ public class ArtifactsCompilerInstance extends CompilerInstance<ArtifactBuildTar
         final Ref<IOException> exception = Ref.create(null);
         new ReadAction() {
           protected void run(final Result result) {
-            final File fromFile = VfsUtil.virtualToIoFile(sourceItem.getFile());
+            final VirtualFile sourceFile = sourceItem.getFile();
             for (DestinationInfo destination : sourceItem.getDestinations()) {
               if (destination instanceof ExplodedDestinationInfo) {
                 final ExplodedDestinationInfo explodedDestination = (ExplodedDestinationInfo)destination;
                 File toFile = new File(FileUtil.toSystemDependentName(explodedDestination.getOutputPath()));
-                if (fromFile.exists()) {
-                  try {
-                    deploymentUtil.copyFile(fromFile, toFile, myContext, writtenPaths, fileFilter);
+                try {
+                  if (sourceFile.isInLocalFileSystem()) {
+                    final File ioFromFile = VfsUtil.virtualToIoFile(sourceFile);
+                    if (ioFromFile.exists()) {
+                      deploymentUtil.copyFile(ioFromFile, toFile, myContext, writtenPaths, fileFilter);
+                    }
                   }
-                  catch (IOException e) {
-                    exception.set(e);
-                    return;
+                  else {
+                    extractFile(sourceFile, toFile, writtenPaths, fileFilter);
                   }
                 }
+                catch (IOException e) {
+                  exception.set(e);
+                  return;
+                }
               }
               else {
                 changedJars.add(((JarDestinationInfo)destination).getJarInfo());
@@ -254,6 +258,28 @@ public class ArtifactsCompilerInstance extends CompilerInstance<ArtifactBuildTar
     return true;
   }
 
+  private void extractFile(VirtualFile sourceFile, File toFile, Set<String> writtenPaths, FileFilter fileFilter) throws IOException {
+    if (!writtenPaths.add(toFile.getPath())) {
+      return;
+    }
+
+    if (!FileUtil.createParentDirs(toFile)) {
+      myContext.addMessage(CompilerMessageCategory.ERROR, "Cannot create directory for '" + toFile.getAbsolutePath() + "' file", null, -1, -1);
+      return;
+    }
+
+    final BufferedInputStream input = ArtifactCompilerUtil.getJarEntryInputStream(sourceFile, myContext);
+    if (input == null) return;
+    final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(toFile));
+    try {
+      FileUtil.copy(input, output);
+    }
+    finally {
+      input.close();
+      output.close();
+    }
+  }
+
   private void onBuildStartedOrFinished(final boolean finished) throws Exception {
     final Set<Artifact> artifacts = myContext.getUserData(ArtifactsCompiler.AFFECTED_ARTIFACTS);
     if (artifacts != null) {
diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/elements/DirectoryCopyPackagingElement.java b/java/compiler/impl/src/com/intellij/packaging/impl/elements/DirectoryCopyPackagingElement.java
index 3721180f6a32..77ad2d567313 100644
--- a/java/compiler/impl/src/com/intellij/packaging/impl/elements/DirectoryCopyPackagingElement.java
+++ b/java/compiler/impl/src/com/intellij/packaging/impl/elements/DirectoryCopyPackagingElement.java
@@ -51,7 +51,7 @@ public class DirectoryCopyPackagingElement extends FileOrDirectoryCopyPackagingE
                                                           @NotNull ArtifactAntGenerationContext generationContext,
                                                           @NotNull ArtifactType artifactType) {
     final String path = generationContext.getSubstitutedPath(myFilePath);
-    return Collections.singletonList((Generator)creator.createDirectoryContentCopyInstruction(path));
+    return Collections.singletonList(creator.createDirectoryContentCopyInstruction(path));
   }
 
   @Override
diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/elements/ExtractedDirectoryElementType.java b/java/compiler/impl/src/com/intellij/packaging/impl/elements/ExtractedDirectoryElementType.java
new file mode 100644
index 000000000000..34be7a6e00bf
--- /dev/null
+++ b/java/compiler/impl/src/com/intellij/packaging/impl/elements/ExtractedDirectoryElementType.java
@@ -0,0 +1,80 @@
+/*
+ * Copyright 2000-2010 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.packaging.impl.elements;
+
+import com.intellij.openapi.fileChooser.FileChooserDescriptor;
+import com.intellij.openapi.fileChooser.FileChooserDialog;
+import com.intellij.openapi.fileChooser.FileChooserFactory;
+import com.intellij.openapi.project.Project;
+import com.intellij.openapi.util.IconLoader;
+import com.intellij.openapi.vfs.JarFileSystem;
+import com.intellij.openapi.vfs.VirtualFile;
+import com.intellij.packaging.artifacts.Artifact;
+import com.intellij.packaging.elements.CompositePackagingElement;
+import com.intellij.packaging.elements.PackagingElementType;
+import com.intellij.packaging.ui.ArtifactEditorContext;
+import org.jetbrains.annotations.NotNull;
+
+import javax.swing.*;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+* @author nik
+*/
+public class ExtractedDirectoryElementType extends PackagingElementType<ExtractedDirectoryPackagingElement> {
+  public static final Icon EXTRACTED_FOLDER_ICON = IconLoader.getIcon("/nodes/extractedFolder.png");
+
+  ExtractedDirectoryElementType() {
+    super("extracted-dir", "Extracted Directory");
+  }
+
+  @Override
+  public Icon getCreateElementIcon() {
+    return EXTRACTED_FOLDER_ICON;
+  }
+
+  @Override
+  public boolean canCreate(@NotNull ArtifactEditorContext context, @NotNull Artifact artifact) {
+    return true;
+  }
+
+  @NotNull
+  public List<? extends ExtractedDirectoryPackagingElement> chooseAndCreate(@NotNull ArtifactEditorContext context, @NotNull Artifact artifact,
+                                                                   @NotNull CompositePackagingElement<?> parent) {
+    final FileChooserDescriptor descriptor = new FileChooserDescriptor(false, true, true, false, true, true) {
+      @Override
+      public boolean isFileSelectable(VirtualFile file) {
+        if (file.isInLocalFileSystem() && file.isDirectory()) return false;
+        return super.isFileSelectable(file);
+      }
+    };
+    final FileChooserDialog chooser = FileChooserFactory.getInstance().createFileChooser(descriptor, context.getProject());
+    final VirtualFile[] files = chooser.choose(null, context.getProject());
+    final List<ExtractedDirectoryPackagingElement> list = new ArrayList<ExtractedDirectoryPackagingElement>();
+    for (VirtualFile file : files) {
+      final String fullPath = file.getPath();
+      final int jarEnd = fullPath.indexOf(JarFileSystem.JAR_SEPARATOR);
+      list.add(new ExtractedDirectoryPackagingElement(fullPath.substring(0, jarEnd), fullPath.substring(jarEnd + 1)));
+    }
+    return list;
+  }
+
+  @NotNull
+  public ExtractedDirectoryPackagingElement createEmpty(@NotNull Project project) {
+    return new ExtractedDirectoryPackagingElement();
+  }
+}
diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/elements/ExtractedDirectoryPackagingElement.java b/java/compiler/impl/src/com/intellij/packaging/impl/elements/ExtractedDirectoryPackagingElement.java
new file mode 100644
index 000000000000..32ccc9396a19
--- /dev/null
+++ b/java/compiler/impl/src/com/intellij/packaging/impl/elements/ExtractedDirectoryPackagingElement.java
@@ -0,0 +1,116 @@
+/*
+ * Copyright 2000-2010 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.packaging.impl.elements;
+
+import com.intellij.compiler.ant.Generator;
+import com.intellij.openapi.util.Comparing;
+import com.intellij.openapi.util.text.StringUtil;
+import com.intellij.openapi.vfs.JarFileSystem;
+import com.intellij.openapi.vfs.VirtualFile;
+import com.intellij.packaging.artifacts.ArtifactType;
+import com.intellij.packaging.elements.*;
+import com.intellij.packaging.impl.ui.ExtractedDirectoryPresentation;
+import com.intellij.packaging.ui.ArtifactEditorContext;
+import com.intellij.packaging.ui.PackagingElementPresentation;
+import com.intellij.util.xmlb.annotations.Attribute;
+import org.jetbrains.annotations.NotNull;
+
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * @author nik
+ */
+public class ExtractedDirectoryPackagingElement extends FileOrDirectoryCopyPackagingElement<ExtractedDirectoryPackagingElement> {
+  private String myPathInJar;
+
+  public ExtractedDirectoryPackagingElement() {
+    super(PackagingElementFactoryImpl.EXTRACTED_DIRECTORY_ELEMENT_TYPE);
+  }
+
+  public ExtractedDirectoryPackagingElement(String jarPath, String pathInJar) {
+    super(PackagingElementFactoryImpl.EXTRACTED_DIRECTORY_ELEMENT_TYPE, jarPath);
+    myPathInJar = pathInJar;
+    if (!StringUtil.startsWithChar(myPathInJar, '/')) {
+      myPathInJar = "/" + myPathInJar;
+    }
+    if (!StringUtil.endsWithChar(myPathInJar, '/')) {
+      myPathInJar += "/";
+    }
+  }
+
+  @Override
+  public PackagingElementPresentation createPresentation(@NotNull ArtifactEditorContext context) {
+    return new ExtractedDirectoryPresentation(this); 
+  }
+
+  @Override
+  public VirtualFile findFile() {
+    final VirtualFile jarFile = super.findFile();
+    if (jarFile == null) return null;
+
+    final VirtualFile jarRoot = JarFileSystem.getInstance().getJarRootForLocalFile(jarFile);
+    if ("/".equals(myPathInJar)) return jarRoot;
+    return jarRoot != null ? jarRoot.findFileByRelativePath(myPathInJar) : null;
+  }
+
+  @Override
+  public List<? extends Generator> computeAntInstructions(@NotNull PackagingElementResolvingContext resolvingContext,
+                                                          @NotNull AntCopyInstructionCreator creator,
+                                                          @NotNull ArtifactAntGenerationContext generationContext,
+                                                          @NotNull ArtifactType artifactType) {
+    final String jarPath = generationContext.getSubstitutedPath(myFilePath);
+    return Collections.singletonList(creator.createExtractedDirectoryInstruction(jarPath, StringUtil.trimStart(myPathInJar, "/")));
+  }
+
+
+  @Override
+  public void computeIncrementalCompilerInstructions(@NotNull IncrementalCompilerInstructionCreator creator,
+                                                     @NotNull PackagingElementResolvingContext resolvingContext,
+                                                     @NotNull ArtifactIncrementalCompilerContext compilerContext,
+                                                     @NotNull ArtifactType artifactType) {
+    final VirtualFile file = findFile();
+    if (file != null && file.isValid() && file.isDirectory()) {
+      creator.addDirectoryCopyInstructions(file);
+    }
+  }
+
+  @Override
+  public boolean isEqualTo(@NotNull PackagingElement<?> element) {
+    return element instanceof ExtractedDirectoryPackagingElement && super.isEqualTo(element)
+           && Comparing.equal(myPathInJar, ((ExtractedDirectoryPackagingElement)element).getPathInJar());
+  }
+
+  @Override
+  public ExtractedDirectoryPackagingElement getState() {
+    return this;
+  }
+
+  @Override
+  public void loadState(ExtractedDirectoryPackagingElement state) {
+    myFilePath = state.getFilePath();
+    myPathInJar = state.getPathInJar();
+  }
+
+  @Attribute("path-in-jar")
+  public String getPathInJar() {
+    return myPathInJar;
+  }
+
+  public void setPathInJar(String pathInJar) {
+    myPathInJar = pathInJar;
+  }
+}
diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/elements/FileCopyPackagingElement.java b/java/compiler/impl/src/com/intellij/packaging/impl/elements/FileCopyPackagingElement.java
index 8835d077beec..6513c765e76e 100644
--- a/java/compiler/impl/src/com/intellij/packaging/impl/elements/FileCopyPackagingElement.java
+++ b/java/compiler/impl/src/com/intellij/packaging/impl/elements/FileCopyPackagingElement.java
@@ -58,7 +58,7 @@ public class FileCopyPackagingElement extends FileOrDirectoryCopyPackagingElemen
   }
 
   public PackagingElementPresentation createPresentation(@NotNull ArtifactEditorContext context) {
-    return new FileCopyPresentation(myFilePath, getOutputFileName(), context);
+    return new FileCopyPresentation(myFilePath, getOutputFileName());
   }
 
   @Override
diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/elements/PackagingElementFactoryImpl.java b/java/compiler/impl/src/com/intellij/packaging/impl/elements/PackagingElementFactoryImpl.java
index 1d527a257ddc..be6c0b32993f 100644
--- a/java/compiler/impl/src/com/intellij/packaging/impl/elements/PackagingElementFactoryImpl.java
+++ b/java/compiler/impl/src/com/intellij/packaging/impl/elements/PackagingElementFactoryImpl.java
@@ -51,11 +51,12 @@ public class PackagingElementFactoryImpl extends PackagingElementFactory {
   public static final PackagingElementType<ArchivePackagingElement> ARCHIVE_ELEMENT_TYPE = new ArchiveElementType();
   public static final PackagingElementType<FileCopyPackagingElement> FILE_COPY_ELEMENT_TYPE = new FileCopyElementType();
   public static final PackagingElementType<DirectoryCopyPackagingElement> DIRECTORY_COPY_ELEMENT_TYPE = new DirectoryCopyElementType();
+  public static final PackagingElementType<ExtractedDirectoryPackagingElement> EXTRACTED_DIRECTORY_ELEMENT_TYPE = new ExtractedDirectoryElementType();
   public static final PackagingElementType<ArtifactRootElement<?>> ARTIFACT_ROOT_ELEMENT_TYPE = new ArtifactRootElementType();
   private static final PackagingElementType[] STANDARD_TYPES = {
       DIRECTORY_ELEMENT_TYPE, ARCHIVE_ELEMENT_TYPE,
       LibraryElementType.LIBRARY_ELEMENT_TYPE, ModuleOutputElementType.MODULE_OUTPUT_ELEMENT_TYPE,
-      ArtifactElementType.ARTIFACT_ELEMENT_TYPE, FILE_COPY_ELEMENT_TYPE, DIRECTORY_COPY_ELEMENT_TYPE
+      ArtifactElementType.ARTIFACT_ELEMENT_TYPE, FILE_COPY_ELEMENT_TYPE, DIRECTORY_COPY_ELEMENT_TYPE, EXTRACTED_DIRECTORY_ELEMENT_TYPE
   };
 
   @NotNull
@@ -253,6 +254,13 @@ public class PackagingElementFactoryImpl extends PackagingElementFactory {
     return createParentDirectories(relativeOutputPath, new DirectoryCopyPackagingElement(filePath));
   }
 
+  @Override
+  @NotNull
+  public PackagingElement<?> createExtractedDirectoryWithParentDirectories(@NotNull String jarPath, @NotNull String pathInJar,
+                                                                           @NotNull String relativeOutputPath) {
+    return createParentDirectories(relativeOutputPath, new ExtractedDirectoryPackagingElement(jarPath, pathInJar));
+  }
+
   @NotNull
   @Override
   public PackagingElement<?> createFileCopyWithParentDirectories(@NotNull String filePath, @NotNull String relativeOutputPath) {
diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/ui/ExtractedDirectoryPresentation.java b/java/compiler/impl/src/com/intellij/packaging/impl/ui/ExtractedDirectoryPresentation.java
new file mode 100644
index 000000000000..3649f0cc7ec8
--- /dev/null
+++ b/java/compiler/impl/src/com/intellij/packaging/impl/ui/ExtractedDirectoryPresentation.java
@@ -0,0 +1,65 @@
+/*
+ * Copyright 2000-2010 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.packaging.impl.ui;
+
+import com.intellij.ide.projectView.PresentationData;
+import com.intellij.openapi.vfs.LocalFileSystem;
+import com.intellij.openapi.vfs.VirtualFile;
+import com.intellij.packaging.impl.elements.ExtractedDirectoryElementType;
+import com.intellij.packaging.impl.elements.ExtractedDirectoryPackagingElement;
+import com.intellij.packaging.ui.PackagingElementPresentation;
+import com.intellij.packaging.ui.PackagingElementWeights;
+import com.intellij.ui.SimpleTextAttributes;
+import com.intellij.util.PathUtil;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * @author nik
+ */
+public class ExtractedDirectoryPresentation extends PackagingElementPresentation {
+  private final String myJarPath;
+  private final String myPathInJar;
+  private final VirtualFile myFile;
+
+  public ExtractedDirectoryPresentation(ExtractedDirectoryPackagingElement element) {
+    myFile = element.findFile();
+    myJarPath = element.getFilePath();
+    myPathInJar = element.getPathInJar();
+  }
+
+  public String getPresentableName() {
+    return PathUtil.getFileName(myJarPath) + myPathInJar;
+  }
+
+  public void render(@NotNull PresentationData presentationData, SimpleTextAttributes mainAttributes, SimpleTextAttributes commentAttributes) {
+    presentationData.setIcons(ExtractedDirectoryElementType.EXTRACTED_FOLDER_ICON);
+    final String parentPath = PathUtil.getParentPath(myJarPath);
+    if (myFile == null || !myFile.isDirectory()) {
+      mainAttributes = SimpleTextAttributes.ERROR_ATTRIBUTES;
+      final VirtualFile parentFile = LocalFileSystem.getInstance().findFileByPath(parentPath);
+      if (parentFile == null) {
+        commentAttributes = SimpleTextAttributes.ERROR_ATTRIBUTES;
+      }
+    }
+    presentationData.addText("Unpacked '" + PathUtil.getFileName(myJarPath) + myPathInJar + "'", mainAttributes);
+    presentationData.addText(" (" + parentPath + ")", commentAttributes);
+  }
+
+  @Override
+  public int getWeight() {
+    return PackagingElementWeights.EXTRACTED_DIRECTORY;
+  }
+}
\ No newline at end of file
diff --git a/java/compiler/impl/src/com/intellij/packaging/impl/ui/FileCopyPresentation.java b/java/compiler/impl/src/com/intellij/packaging/impl/ui/FileCopyPresentation.java
index 853f72c87b9d..a48648ddf913 100644
--- a/java/compiler/impl/src/com/intellij/packaging/impl/ui/FileCopyPresentation.java
+++ b/java/compiler/impl/src/com/intellij/packaging/impl/ui/FileCopyPresentation.java
@@ -20,7 +20,6 @@ import com.intellij.openapi.util.io.FileUtil;
 import com.intellij.openapi.vfs.LocalFileSystem;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.packaging.impl.elements.FileCopyElementType;
-import com.intellij.packaging.ui.ArtifactEditorContext;
 import com.intellij.packaging.ui.PackagingElementPresentation;
 import com.intellij.packaging.ui.PackagingElementWeights;
 import com.intellij.ui.SimpleTextAttributes;
@@ -33,12 +32,10 @@ import org.jetbrains.annotations.NotNull;
 public class FileCopyPresentation extends PackagingElementPresentation {
   private final String mySourcePath;
   private final String myOutputFileName;
-  private final ArtifactEditorContext myContext;
   private final VirtualFile myFile;
 
-  public FileCopyPresentation(String filePath, String outputFileName, ArtifactEditorContext context) {
+  public FileCopyPresentation(String filePath, String outputFileName) {
     myOutputFileName = outputFileName;
-    myContext = context;
 
     String parentPath;
     myFile = LocalFileSystem.getInstance().findFileByPath(filePath);
@@ -65,7 +62,7 @@ public class FileCopyPresentation extends PackagingElementPresentation {
 
   public void render(@NotNull PresentationData presentationData, SimpleTextAttributes mainAttributes, SimpleTextAttributes commentAttributes) {
     if (myFile != null && !myFile.isDirectory()) {
-      presentationData.setIcons(myFile != null ? myFile.getIcon() : FileCopyElementType.ICON);
+      presentationData.setIcons(myFile.getIcon());
       presentationData.addText(myOutputFileName, mainAttributes);
       presentationData.addText(" (" + mySourcePath + ")", commentAttributes);
     }
diff --git a/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/Include.java b/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/Include.java
index b0a5cff3c0ba..73352a24d983 100644
--- a/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/Include.java
+++ b/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/Include.java
@@ -17,7 +17,6 @@
 package com.intellij.compiler.ant.taskdefs;
 
 import com.intellij.compiler.ant.Tag;
-import com.intellij.openapi.util.Pair;
 import org.jetbrains.annotations.NonNls;
 
 /**
@@ -27,8 +26,7 @@ import org.jetbrains.annotations.NonNls;
 public class Include extends Tag {
 
   public Include(@NonNls final String name) {
-    //noinspection HardCodedStringLiteral
-    super("include", new Pair[] {new Pair<String, String>("name", name)});
+    super("include", pair("name", name));
   }
 
 }
diff --git a/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/PatternSet.java b/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/PatternSet.java
index eee85abbd7ad..6a1d2375e6bb 100644
--- a/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/PatternSet.java
+++ b/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/PatternSet.java
@@ -17,7 +17,6 @@
 package com.intellij.compiler.ant.taskdefs;
 
 import com.intellij.compiler.ant.Tag;
-import com.intellij.openapi.util.Pair;
 import org.jetbrains.annotations.NonNls;
 
 /**
@@ -26,7 +25,6 @@ import org.jetbrains.annotations.NonNls;
  */
 public class PatternSet extends Tag{
   public PatternSet(@NonNls final String id) {
-    //noinspection HardCodedStringLiteral
-    super("patternset", new Pair[] {new Pair<String, String>("id", id)});
+    super("patternset", pair("id", id));
   }
 }
diff --git a/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/Unzip.java b/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/Unzip.java
new file mode 100644
index 000000000000..8e3a4e7d2369
--- /dev/null
+++ b/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/Unzip.java
@@ -0,0 +1,27 @@
+/*
+ * Copyright 2000-2010 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.compiler.ant.taskdefs;
+
+import com.intellij.compiler.ant.Tag;
+
+/**
+ * @author nik
+ */
+public class Unzip extends Tag {
+  public Unzip(String archivePath, String dest) {
+    super("unzip", pair("src", archivePath), pair("dest", dest));
+  }
+}
diff --git a/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/ZipFileSet.java b/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/ZipFileSet.java
index 50991595783b..9970a9d004d5 100644
--- a/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/ZipFileSet.java
+++ b/java/compiler/openapi/src/com/intellij/compiler/ant/taskdefs/ZipFileSet.java
@@ -17,9 +17,11 @@
 package com.intellij.compiler.ant.taskdefs;
 
 import com.intellij.compiler.ant.Tag;
+import com.intellij.openapi.util.Pair;
 import com.intellij.openapi.util.io.FileUtil;
 import com.intellij.openapi.util.text.StringUtil;
 import org.jetbrains.annotations.NonNls;
+import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
 import java.io.File;
@@ -31,12 +33,23 @@ import java.io.File;
 public class ZipFileSet extends Tag{
   public static final ZipFileSet[] EMPTY_ARRAY = new ZipFileSet[0];
 
+  private ZipFileSet(@NonNls String tagName, Pair... tagOptions) {
+    super(tagName, tagOptions);
+  }
+
   public ZipFileSet(@NonNls String fileOrDir, @NonNls final String relativePath, boolean isDir) {
     super("zipfileset",
           pair(isDir ? "dir" : "file", fileOrDir),
           pair("prefix", prefix(isDir, relativePath)));
   }
 
+  public static ZipFileSet createUnpackedSet(@NonNls String zipFilePath, @NotNull String relativePath, final boolean isDir, String pattern) {
+    return new ZipFileSet("zipfileset",
+                          pair("src", zipFilePath),
+                          pair("prefix", prefix(isDir, relativePath)),
+                          pair("includes", pattern));
+  }
+
   @Nullable
   private static String prefix(final boolean isDir, final String relativePath) {
     String path;
diff --git a/java/compiler/openapi/src/com/intellij/packaging/elements/AntCopyInstructionCreator.java b/java/compiler/openapi/src/com/intellij/packaging/elements/AntCopyInstructionCreator.java
index 33dccf956950..0c20bb61c4b8 100644
--- a/java/compiler/openapi/src/com/intellij/packaging/elements/AntCopyInstructionCreator.java
+++ b/java/compiler/openapi/src/com/intellij/packaging/elements/AntCopyInstructionCreator.java
@@ -15,8 +15,8 @@
  */
 package com.intellij.packaging.elements;
 
-import com.intellij.compiler.ant.Tag;
 import com.intellij.compiler.ant.Generator;
+import com.intellij.compiler.ant.Tag;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
@@ -32,8 +32,11 @@ public interface AntCopyInstructionCreator {
   Tag createFileCopyInstruction(@NotNull String filePath, String outputFileName);
 
   @NotNull
-  AntCopyInstructionCreator subFolder(String directoryName);
+  AntCopyInstructionCreator subFolder(@NotNull String directoryName);
 
   @Nullable
-  Generator createSubFolderCommand(String directoryName);
+  Generator createSubFolderCommand(@NotNull String directoryName);
+
+  @NotNull
+  Generator createExtractedDirectoryInstruction(@NotNull String jarPath, @NotNull String pathInJar);
 }
diff --git a/java/compiler/openapi/src/com/intellij/packaging/elements/PackagingElementFactory.java b/java/compiler/openapi/src/com/intellij/packaging/elements/PackagingElementFactory.java
index 88364671f4da..2cbad503ce6a 100644
--- a/java/compiler/openapi/src/com/intellij/packaging/elements/PackagingElementFactory.java
+++ b/java/compiler/openapi/src/com/intellij/packaging/elements/PackagingElementFactory.java
@@ -67,6 +67,10 @@ public abstract class PackagingElementFactory {
   @NotNull
   public abstract PackagingElement<?> createDirectoryCopyWithParentDirectories(@NotNull String filePath, @NotNull String relativeOutputPath);
 
+  @NotNull
+  public abstract PackagingElement<?> createExtractedDirectoryWithParentDirectories(@NotNull String jarPath, @NotNull String pathInJar,
+                                                                                    @NotNull String relativeOutputPath);
+
   @NotNull
   public abstract PackagingElement<?> createFileCopyWithParentDirectories(@NotNull String filePath, @NotNull String relativeOutputPath,
                                                                           @Nullable String outputFileName);
diff --git a/java/compiler/openapi/src/com/intellij/packaging/ui/PackagingElementWeights.java b/java/compiler/openapi/src/com/intellij/packaging/ui/PackagingElementWeights.java
index e36ac1229052..f193e9be3490 100644
--- a/java/compiler/openapi/src/com/intellij/packaging/ui/PackagingElementWeights.java
+++ b/java/compiler/openapi/src/com/intellij/packaging/ui/PackagingElementWeights.java
@@ -22,6 +22,7 @@ public class PackagingElementWeights {
   public static final int ARTIFACT = 100;
   public static final int DIRECTORY = 50;
   public static final int DIRECTORY_COPY = 40;
+  public static final int EXTRACTED_DIRECTORY = 39;
   public static final int LIBRARY = 30;
   public static final int MODULE = 20;
   public static final int FACET = 10;
diff --git a/platform/icons/src/nodes/copyOfFolder.png b/platform/icons/src/nodes/copyOfFolder.png
index b4c66afd4e8698202cab596ad0d74f15a97c7442..eaa813b50df2edcccc95c7bf8477cee38055ae20 100644
GIT binary patch
delta 530
zcmV+t0`2|R1<VAHB#|^Ee*x}EL_t(|+G70w|33pIfYH@IKF~?$YYQWY1H}Kq7-HzY
zD?IJ5zA!EUu`leIkKKf}ilD0>&*l98_w@({?yvW`3vwYo%mOmx=A+LHPw%W_`2YJG
z!~cKZ8UFwI4mMm#iCd|yD)c5JBgC?QK$rdc^=*1%_qGWz2e5!7f7Ru98I1Mn85o&3
zAfEXD5AGRXhJR`d|3N1FX885#Fhh6m$~+(kVE`-)85#dG96h{+;rh8f43O{ug#?KF
z3zk>Vv|zAQe~J+VEN~Xk*6U|>F@!s^GVrQLU?^NLa~cDqwlagMg`*6*0Z<?Q0o#cy
zJcNZA85S+Q&G7Tje`D5j$9LX@g$D~f75x7Lb}%?RbZda&!43(Be}91VUuc;81H1J9
z|DS5VJ|1M~nYbg5h4KGC#_ylrGcep;0aW`FsE8eC(07KvANNBI{tq#Lk%i&^-;Y2u
zegpAOhEI=n0mb<kSeRM4_Ac7|lHJ(qx6F^9|5+jN^%vqXf1vIE|NjCS0@U;uNHhEd
zI^YLT{0A`5KSB&BYhIcI^To;2!PgiV_%%UM_W$oUtQsL<0>r>DLX8EeFCh$|f<Ip&
z8vjBy{)K7;^8f$)i6t6A(E$yQ?<d-c$VM7qD^U!9g$J=Yk(-lq79*wE86dy_qV*wb
U%nYZ3000002uVdwM6N<$f^pyi9{>OV

delta 668
zcmV;N0%QHm1lI+SBn<>-K}|sb0I$e51&ZmBAt!$VX-PyuRCwBA{Qv(y12$lvzuW5X
zuTKsCetu&A_v`bF6HD@zV^aqZKnx%Quwm=;RcBV-{r4Y)O@o`x;8F(=Kuioc!0!(a
zzJciJhZq_De0}~6mpXs|!f5~yaN=O20Du5uLFQPeESdE0*C&I2KR+}4`~Bq)O#I)U
zAAf%gToMmKxeqSvnI8v}0|+1#1OEQ_pj*_GZ42Xn{lmzhB+0;FGj*N?i2v$21H<y>
zL=-&$0mO(N3$evh{`+QUGwi(0h)@J%KD!RYn-k9hZ8t$y4-i0L1Fm+PGcd7of-!@#
z?f;6!PZ%Pbr!wpS8Uixr`3(jJrsLTRc>#Z#3>#LjJp1b(3&ZdK%nS=R>@fidAaEeU
zG@rTp@XX(rI~m%Ngcw%TXELaBKs0k-$Y)sI?#*DU^N(S2cdBts6ua@ye-NJl1Q3{H
zV&h^sckSUBJtJP@8xKA)usq$x&=&8(P(3Gufs2WWVP=sY!>0?Y7}z;^8D4(A&G3KZ
z@@0l!{|&(g00a=&fOFR#or!E)Y0U8dAA|0{zd(^cprB`1YbC+J@E^$kdWV5QTpGy!
z&2VMv1_lleHiqB-n85}B1Q6JOKMbru_1_r&zr6s|_!ATzQ2ZSQGqVdZu&}W(u&^?N
z!vF*T0tjrtZ=eCdhzBYHCb+*pF*JWdFi@P8i-C)mlYyB9VE{k?ferZ1zzs?T5JUd`
z!h(N8@m~gJRu+cbEm~)LlvjeI6Ci+?U|s<G6{`VI&HsOc)xb0xb-x3<03d*%USMO`
zwf8#1x>Y;jaSWqj_|JcCApXh#)6B%e1~vd7zyO-@NU(z`{Bi&Q002ovPDBK*LSTaC
C^)O-p

diff --git a/platform/icons/src/nodes/extractedFolder.png b/platform/icons/src/nodes/extractedFolder.png
new file mode 100644
index 0000000000000000000000000000000000000000..6526ba4f8db2369fde0dc7565a36f26b782444b3
GIT binary patch
literal 657
zcmV;C0&e|@P)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV0000PbVXQnQ*UN;
zcVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBU!Gf6~2RCwB?Q%h(QK^XqFyW2n;)Y2lP
z(GsN8U=Tb+@ggE3DM~!F2zn4fdQxviy;$*e@Bt#U2a7^I)l#IDdXSoeh#*0*sbJI4
zLqQ29+XtI$b+hkrcGBu*i3jnApPiqb|9kv1!x2J|INb+NoS``iUrdiZ<xnRCU%lB}
zcXPeqd<uxSSz5J|yLWAy(hLKJVZw17=%yo=%H-VK%*ZRR0^(z3_1;+M`Q!csgr*Pz
zGnalWER};<zO!X`wrPU?7u}5wn@TpCem6G;Tl(5#dz!Q3g9x;B;luD-OigN-&xf%i
zyj?ha_R2smm*c!M;Jiw@5AA<)>|_tx#2%=Ig~-eG=5Kim#Zm<wmI!rv<W@8qz0CmP
z_Pg&JAO)IiEv05L{{B%F)i%(3;TpG?F|iUpg0cnJe6aQuu0OaOsv2+r%LLI?KwYP)
z;Obxstz-cQ^Fw%3xer86)IUZ`P6Lh&7#fIL2Fj~|ybNAw#iz7{NasGtqc<R*KMs-b
z@D8!c>^9RRHq~gkI;j#`+m?o-y)jHqWYO4_sJRD!0H|!ntXBY*)Pk;6LHI3rHnxOf
zM>oD67{HpM!EO+0Ex4YUY?qn&R{-rNtqt%zkDaIPkkm(+Ta!wV7U!X^<R8|~z#W+D
znKCkF+RO%N8c=l;>CYL?&U}GbC}OK356!)}*Y5*R*uY%R41_Yf&F<GyONE=scsr8u
rzdxpncVE*x5Wv3%drbcmzXTWnVPO+zeP#wZ00000NkvXXu0mjfvI8lR

literal 0
HcmV?d00001

diff --git a/platform/util/src/com/intellij/openapi/util/io/FileUtil.java b/platform/util/src/com/intellij/openapi/util/io/FileUtil.java
index 69ab692e7607..24dcca73eddc 100644
--- a/platform/util/src/com/intellij/openapi/util/io/FileUtil.java
+++ b/platform/util/src/com/intellij/openapi/util/io/FileUtil.java
@@ -510,7 +510,7 @@ public class FileUtil {
         return parentFile.exists() && parentFile.isDirectory() || parentFile.mkdirs();
       }
     }
-    return false;
+    return true;
   }
 
   public static boolean createIfDoesntExist(File file) {

From ee78879e9d5d37d03a617652df7bb824a3c0314e Mon Sep 17 00:00:00 2001
From: Anton Makeev <Anton.Makeev@jetbrains.com>
Date: Mon, 2 Aug 2010 17:05:15 +0400
Subject: [PATCH 10/42] CIDR-debugger: evaluate expression

---
 .../com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
index 55506b23d6dc..e4f7f9940d90 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
@@ -239,7 +239,7 @@ public class IdeStatusBarImpl extends JComponent implements StatusBarEx {
         }
       }
 
-      throw new IllegalArgumentException("unable to find widget with id: " + parts.get(1));
+      //throw new IllegalArgumentException("unable to find widget with id: " + parts.get(1));
     }
 
     if (Position.LEFT == pos && panel.getComponentCount() == 0) {

From 68b4b2157e31703a1fb7667279e5228ec7621f7d Mon Sep 17 00:00:00 2001
From: Anton Makeev <Anton.Makeev@jetbrains.com>
Date: Mon, 2 Aug 2010 17:25:52 +0400
Subject: [PATCH 11/42] CIDR-debugger: evaluate expression

---
 .../com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
index e4f7f9940d90..55506b23d6dc 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
@@ -239,7 +239,7 @@ public class IdeStatusBarImpl extends JComponent implements StatusBarEx {
         }
       }
 
-      //throw new IllegalArgumentException("unable to find widget with id: " + parts.get(1));
+      throw new IllegalArgumentException("unable to find widget with id: " + parts.get(1));
     }
 
     if (Position.LEFT == pos && panel.getComponentCount() == 0) {

From f8bdc7d04172be51523b2d38fada6f31f21a5654 Mon Sep 17 00:00:00 2001
From: Alexey Pegov <alexey.pegov@jetbrains.com>
Date: Mon, 2 Aug 2010 17:31:04 +0400
Subject: [PATCH 12/42] IDEA-56931 unable to remove components added to status
 bar using com.intellij.openapi.wm.StatusBar#addCustomIndicationComponent +
 IDEA-56927 Wrong tooltip for readonly status button + StatusBarWidget.Type ->
 StatusBarWidget.PlatformType

---
 .../wm/impl/status/TogglePopupHintsPanel.java |  2 +-
 .../InspectionProjectProfileManager.java      | 11 ++++
 .../com/intellij/openapi/wm/StatusBar.java    |  4 ++
 .../intellij/openapi/wm/StatusBarWidget.java  |  4 +-
 .../intellij/diagnostic/IdeMessagePanel.java  |  2 +-
 .../impl/IdeNotificationArea.java             |  2 +-
 .../intellij/openapi/wm/impl/IdeRootPane.java |  2 +-
 .../openapi/wm/impl/status/EncodingPanel.java |  2 +-
 .../wm/impl/status/IdeStatusBarImpl.java      | 51 +++++++++++--------
 .../wm/impl/status/InfoAndProgressPanel.java  |  7 +--
 .../wm/impl/status/InsertOverwritePanel.java  |  2 +-
 .../wm/impl/status/MemoryUsagePanel.java      |  2 +-
 .../openapi/wm/impl/status/PositionPanel.java |  2 +-
 .../status/ToggleReadOnlyAttributePanel.java  |  2 +-
 .../src/messages/UIBundle.properties          |  2 +-
 .../committed/IncomingChangesIndicator.java   |  2 +-
 .../checkout/branches/GitBranchesWidget.java  |  2 +-
 .../zmlx/hg4idea/ui/HgChangesetStatus.java    |  2 +-
 .../hg4idea/ui/HgCurrentBranchStatus.java     |  2 +-
 19 files changed, 63 insertions(+), 42 deletions(-)

diff --git a/platform/lang-impl/src/com/intellij/openapi/wm/impl/status/TogglePopupHintsPanel.java b/platform/lang-impl/src/com/intellij/openapi/wm/impl/status/TogglePopupHintsPanel.java
index 2449862dfd81..3d064a03baee 100644
--- a/platform/lang-impl/src/com/intellij/openapi/wm/impl/status/TogglePopupHintsPanel.java
+++ b/platform/lang-impl/src/com/intellij/openapi/wm/impl/status/TogglePopupHintsPanel.java
@@ -112,7 +112,7 @@ public class TogglePopupHintsPanel implements StatusBarWidget, StatusBarWidget.I
     return "InspectionProfile";
   }
 
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return this;
   }
 
diff --git a/platform/lang-impl/src/com/intellij/profile/codeInspection/InspectionProjectProfileManager.java b/platform/lang-impl/src/com/intellij/profile/codeInspection/InspectionProjectProfileManager.java
index e7483e56ede1..0c98dd6700a8 100644
--- a/platform/lang-impl/src/com/intellij/profile/codeInspection/InspectionProjectProfileManager.java
+++ b/platform/lang-impl/src/com/intellij/profile/codeInspection/InspectionProjectProfileManager.java
@@ -38,6 +38,7 @@ import org.jdom.Element;
 import org.jetbrains.annotations.NonNls;
 import org.jetbrains.annotations.NotNull;
 
+import javax.swing.*;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
@@ -168,6 +169,16 @@ public class InspectionProjectProfileManager extends DefaultProjectProfileManage
         } else {
           app.executeOnPooledThread(initInspectionProfilesRunnable);
         }
+
+
+        final JLabel statusLabel = new JLabel("YEAH");
+        try {
+          WindowManager.getInstance().getStatusBar(myProject).addCustomIndicationComponent(statusLabel);
+        }
+        finally {
+          WindowManager.getInstance().getStatusBar(myProject).removeCustomIndicationComponent(statusLabel);
+        }
+
       }
     });
   }
diff --git a/platform/platform-api/src/com/intellij/openapi/wm/StatusBar.java b/platform/platform-api/src/com/intellij/openapi/wm/StatusBar.java
index 9037bf52a414..d2697cb7331a 100644
--- a/platform/platform-api/src/com/intellij/openapi/wm/StatusBar.java
+++ b/platform/platform-api/src/com/intellij/openapi/wm/StatusBar.java
@@ -70,6 +70,10 @@ public interface StatusBar extends StatusBarInfo {
   @Deprecated
   void addCustomIndicationComponent(@NotNull JComponent c);
 
+  /**
+   * @deprecated use removeWidget instead
+   */
+  @Deprecated
   void removeCustomIndicationComponent(@NotNull JComponent c);
 
   void removeWidget(@NotNull String id);
diff --git a/platform/platform-api/src/com/intellij/openapi/wm/StatusBarWidget.java b/platform/platform-api/src/com/intellij/openapi/wm/StatusBarWidget.java
index 46e8a86b12e0..4a8528808d5c 100644
--- a/platform/platform-api/src/com/intellij/openapi/wm/StatusBarWidget.java
+++ b/platform/platform-api/src/com/intellij/openapi/wm/StatusBarWidget.java
@@ -33,7 +33,7 @@ import java.awt.event.MouseEvent;
  */
 public interface StatusBarWidget extends Disposable {
 
-  enum Type {
+  enum PlatformType {
     DEFAULT, MAC
   }
 
@@ -75,7 +75,7 @@ public interface StatusBarWidget extends Disposable {
   String ID();
 
   @Nullable
-  WidgetPresentation getPresentation(@NotNull Type type);
+  WidgetPresentation getPresentation(@NotNull PlatformType type);
 
   void install(@NotNull final StatusBar statusBar);
 
diff --git a/platform/platform-impl/src/com/intellij/diagnostic/IdeMessagePanel.java b/platform/platform-impl/src/com/intellij/diagnostic/IdeMessagePanel.java
index cdbe815d8a61..46e40f5d4a9f 100644
--- a/platform/platform-impl/src/com/intellij/diagnostic/IdeMessagePanel.java
+++ b/platform/platform-impl/src/com/intellij/diagnostic/IdeMessagePanel.java
@@ -74,7 +74,7 @@ public class IdeMessagePanel extends JPanel implements MessagePoolListener, Cust
     return "FatalError";
   }
 
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return null;
   }
 
diff --git a/platform/platform-impl/src/com/intellij/notification/impl/IdeNotificationArea.java b/platform/platform-impl/src/com/intellij/notification/impl/IdeNotificationArea.java
index 3760b008a439..ed51be8b0f56 100644
--- a/platform/platform-impl/src/com/intellij/notification/impl/IdeNotificationArea.java
+++ b/platform/platform-impl/src/com/intellij/notification/impl/IdeNotificationArea.java
@@ -50,7 +50,7 @@ public class IdeNotificationArea implements StatusBarWidget, StatusBarWidget.Ico
   public IdeNotificationArea() {
   }
 
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return this;
   }
 
diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/IdeRootPane.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/IdeRootPane.java
index ae59c2a7beff..e1440cf46d22 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/IdeRootPane.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/IdeRootPane.java
@@ -239,7 +239,7 @@ public class IdeRootPane extends JRootPane implements UISettingsListener {
             return c.getClass().getSimpleName();
           }
 
-          public WidgetPresentation getPresentation(@NotNull Type type) {
+          public WidgetPresentation getPresentation(@NotNull PlatformType type) {
             return null;
           }
 
diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/EncodingPanel.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/EncodingPanel.java
index 7de4893f367a..5035c39d2b00 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/EncodingPanel.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/EncodingPanel.java
@@ -64,7 +64,7 @@ public class EncodingPanel implements StatusBarWidget, StatusBarWidget.MultipleT
     return "Encoding";
   }
 
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return this;
   }
 
diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
index 55506b23d6dc..0bfeb2ab9664 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
@@ -16,6 +16,7 @@
 package com.intellij.openapi.wm.impl.status;
 
 import com.intellij.openapi.Disposable;
+import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.progress.TaskInfo;
 import com.intellij.openapi.ui.MessageType;
 import com.intellij.openapi.ui.popup.BalloonHandler;
@@ -42,15 +43,15 @@ import javax.swing.event.HyperlinkListener;
 import java.awt.*;
 import java.awt.event.MouseAdapter;
 import java.awt.event.MouseEvent;
-import java.util.ArrayList;
+import java.util.*;
 import java.util.List;
-import java.util.Map;
-import java.util.Random;
 
 /**
  * User: spLeaner
  */
 public class IdeStatusBarImpl extends JComponent implements StatusBarEx {
+  private static final Logger LOG = Logger.getInstance("#com.intellij.openapi.wm.impl.status.IdeStatusBarImpl");
+
   private InfoAndProgressPanel myInfoAndProgressPanel;
 
   private enum Position {LEFT, RIGHT, CENTER}
@@ -93,7 +94,7 @@ public class IdeStatusBarImpl extends JComponent implements StatusBarEx {
   }
 
   public void addWidget(@NotNull final StatusBarWidget widget) {
-    addWidget(widget, Position.RIGHT, "before Notifications");
+    addWidget(widget, Position.RIGHT, "__AUTODETECT__");
   }
 
   public void addWidget(@NotNull final StatusBarWidget widget, @NotNull String anchor) {
@@ -139,7 +140,7 @@ public class IdeStatusBarImpl extends JComponent implements StatusBarEx {
       }
 
       @Nullable
-      public WidgetPresentation getPresentation(@NotNull Type type) {
+      public WidgetPresentation getPresentation(@NotNull PlatformType type) {
         return null;
       }
 
@@ -158,19 +159,22 @@ public class IdeStatusBarImpl extends JComponent implements StatusBarEx {
   }
 
   public void removeCustomIndicationComponent(@NotNull final JComponent c) {
-    for (final String key : myWidgetMap.keySet()) {
-      final WidgetBean bean = myWidgetMap.get(key);
-      if (bean.component instanceof CustomStatusBarWidget && ((CustomStatusBarWidget)bean.component).getComponent() == c) {
+    for (final Map.Entry<String, WidgetBean> entry : myWidgetMap.entrySet()) {
+      final WidgetBean value = entry.getValue();
+      if (value.widget instanceof CustomStatusBarWidget && value.component == c) {
+        final String key = entry.getKey();
         removeWidget(key);
+        myCustomComponentIds.remove(key);
       }
     }
   }
 
   public void dispose() {
-    for (final String key : myWidgetMap.keySet()) {
-      final WidgetBean bean = myWidgetMap.get(key);
+    for (final WidgetBean bean : myWidgetMap.values()) {
       Disposer.dispose(bean.widget);
     }
+
+    myWidgetMap.clear();
   }
 
   private void addWidget(@NotNull final StatusBarWidget widget, @NotNull final Position pos, @NotNull String anchor) {
@@ -207,20 +211,29 @@ public class IdeStatusBarImpl extends JComponent implements StatusBarEx {
 
     final JComponent c = widget instanceof CustomStatusBarWidget ? ((CustomStatusBarWidget)widget).getComponent() : wrap(widget);
     if (Position.RIGHT == pos && panel.getComponentCount() > 0) {
-      final List<String> parts = StringUtil.split(anchor, " ");
-      if (parts.size() < 2) {
-        throw new IllegalArgumentException(
-          "anchor should be a relative position ('before' or 'after') and widget ID, like 'after Encoding'");
+      String wid;
+      boolean before;
+      if (!anchor.equals("__AUTODETECT__")) {
+        final List<String> parts = StringUtil.split(anchor, " ");
+        if (parts.size() < 2 || !myWidgetMap.keySet().contains(parts.get(1))) {
+          wid = "Notifications";
+          before = true;
+        } else {
+          wid = parts.get(1);
+          before = "before".equalsIgnoreCase(parts.get(0));
+        }
+      } else {
+        wid = "Notifications";
+        before = true;
       }
 
       for (final String id : myWidgetMap.keySet()) {
-        if (id.equalsIgnoreCase(parts.get(1))) {
+        if (id.equalsIgnoreCase(wid)) {
           final WidgetBean bean = myWidgetMap.get(id);
           int i = 0;
           for (final Component component : myRightPanel.getComponents()) {
             if (component == bean.component) {
-              final String _relative = parts.get(0);
-              if ("before".equalsIgnoreCase(_relative)) {
+              if (before) {
                 panel.add(c, i);
                 updateBorder(i);
               }
@@ -238,8 +251,6 @@ public class IdeStatusBarImpl extends JComponent implements StatusBarEx {
           }
         }
       }
-
-      throw new IllegalArgumentException("unable to find widget with id: " + parts.get(1));
     }
 
     if (Position.LEFT == pos && panel.getComponentCount() == 0) {
@@ -323,7 +334,7 @@ public class IdeStatusBarImpl extends JComponent implements StatusBarEx {
 
   private static JComponent wrap(@NotNull final StatusBarWidget widget) {
     final StatusBarWidget.WidgetPresentation presentation =
-      widget.getPresentation(SystemInfo.isMac ? StatusBarWidget.Type.MAC : StatusBarWidget.Type.DEFAULT);
+      widget.getPresentation(SystemInfo.isMac ? StatusBarWidget.PlatformType.MAC : StatusBarWidget.PlatformType.DEFAULT);
     assert presentation != null : "Presentation should not be null!";
 
     JComponent wrapper;
diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InfoAndProgressPanel.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InfoAndProgressPanel.java
index 5c3f01c4c1a6..cfa169289027 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InfoAndProgressPanel.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InfoAndProgressPanel.java
@@ -18,15 +18,12 @@ package com.intellij.openapi.wm.impl.status;
 import com.intellij.idea.ActionsBundle;
 import com.intellij.openapi.actionSystem.*;
 import com.intellij.openapi.application.ApplicationManager;
-import com.intellij.openapi.application.ex.ApplicationManagerEx;
 import com.intellij.openapi.progress.TaskInfo;
-import com.intellij.openapi.progress.impl.ProgressManagerImpl;
 import com.intellij.openapi.ui.MessageType;
 import com.intellij.openapi.ui.popup.Balloon;
 import com.intellij.openapi.ui.popup.BalloonHandler;
 import com.intellij.openapi.ui.popup.JBPopupFactory;
 import com.intellij.openapi.util.MultiValuesMap;
-import com.intellij.openapi.util.Pair;
 import com.intellij.openapi.util.SystemInfo;
 import com.intellij.openapi.util.registry.Registry;
 import com.intellij.openapi.wm.CustomStatusBarWidget;
@@ -52,9 +49,7 @@ import javax.swing.event.HyperlinkListener;
 import java.awt.*;
 import java.awt.event.MouseAdapter;
 import java.awt.event.MouseEvent;
-import java.text.SimpleDateFormat;
 import java.util.*;
-import java.util.List;
 
 public class InfoAndProgressPanel extends JPanel implements CustomStatusBarWidget {
   private final ProcessPopup myPopup;
@@ -142,7 +137,7 @@ public class InfoAndProgressPanel extends JPanel implements CustomStatusBarWidge
     return "InfoAndProgress";
   }
 
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return null;
   }
 
diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InsertOverwritePanel.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InsertOverwritePanel.java
index 1489302b1356..a5aa101cfd54 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InsertOverwritePanel.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InsertOverwritePanel.java
@@ -42,7 +42,7 @@ public class InsertOverwritePanel implements StatusBarWidget, StatusBarWidget.Te
     return "InsertOverwrite";
   }
 
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return this;
   }
 
diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/MemoryUsagePanel.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/MemoryUsagePanel.java
index 14a87704e865..2bfba9d2f5a4 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/MemoryUsagePanel.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/MemoryUsagePanel.java
@@ -70,7 +70,7 @@ public class MemoryUsagePanel extends JButton implements CustomStatusBarWidget {
   }
 
   @Nullable
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return null;
   }
 
diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/PositionPanel.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/PositionPanel.java
index 0deea4849100..01bcf900f2f0 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/PositionPanel.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/PositionPanel.java
@@ -61,7 +61,7 @@ public class PositionPanel implements StatusBarWidget, StatusBarWidget.TextPrese
     return "Position";
   }
 
-  public WidgetPresentation getPresentation(@NotNull final Type type) {
+  public WidgetPresentation getPresentation(@NotNull final PlatformType type) {
     return this;
   }
 
diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/ToggleReadOnlyAttributePanel.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/ToggleReadOnlyAttributePanel.java
index 6e905a35fc5f..8e8ad69ac2d4 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/ToggleReadOnlyAttributePanel.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/ToggleReadOnlyAttributePanel.java
@@ -54,7 +54,7 @@ public class ToggleReadOnlyAttributePanel implements StatusBarWidget, StatusBarW
     return "ReadOnlyAttribute";
   }
 
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return this;
   }
 
diff --git a/platform/platform-resources-en/src/messages/UIBundle.properties b/platform/platform-resources-en/src/messages/UIBundle.properties
index bff0b3397edc..deef01709675 100644
--- a/platform/platform-resources-en/src/messages/UIBundle.properties
+++ b/platform/platform-resources-en/src/messages/UIBundle.properties
@@ -79,7 +79,7 @@ status.bar.insert.status.text=Insert
 status.bar.overwrite.status.text=Overwrite
 popup.hints.panel.click.to.configure.highlighting.tooltip.text=Click to configure highlighting for this file
 popup.hints.panel.click.to.configure.profile.text=Click to configure inspection profiles
-read.only.attr.panel.double.click.to.toggle.attr.tooltip.text=Double-click to toggle the read-only attribute
+read.only.attr.panel.double.click.to.toggle.attr.tooltip.text=Click to toggle the read-only attribute
 welcome.screen.get.from.vcs.action.no.vcs.plugins.with.check.out.action.installed.action.name=No VCS plugins with Check-out action installed.
 welcome.screen.get.from.vcs.action.checkout.from.list.popup.title=Checkout from
 welcome.screen.recent.projects.action.no.recent.projects.to.display.action.name=No recent projects to display.
diff --git a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/committed/IncomingChangesIndicator.java b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/committed/IncomingChangesIndicator.java
index c6d728b745b7..26cd7b3980eb 100644
--- a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/committed/IncomingChangesIndicator.java
+++ b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/committed/IncomingChangesIndicator.java
@@ -163,7 +163,7 @@ public class IncomingChangesIndicator implements ProjectComponent {
       return "IncomingChanges";
     }
 
-    public WidgetPresentation getPresentation(@NotNull Type type) {
+    public WidgetPresentation getPresentation(@NotNull PlatformType type) {
       return this;
     }
 
diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
index ae33d38f7c98..9ff127fb247a 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
@@ -193,7 +193,7 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
    * {@inheritDoc}
    */
   @Override
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return null;
   }
 
diff --git a/plugins/hg4idea/src/org/zmlx/hg4idea/ui/HgChangesetStatus.java b/plugins/hg4idea/src/org/zmlx/hg4idea/ui/HgChangesetStatus.java
index 4cf12657c2db..41f52870824c 100644
--- a/plugins/hg4idea/src/org/zmlx/hg4idea/ui/HgChangesetStatus.java
+++ b/plugins/hg4idea/src/org/zmlx/hg4idea/ui/HgChangesetStatus.java
@@ -53,7 +53,7 @@ public class HgChangesetStatus extends JLabel implements CustomStatusBarWidget {
     return "HgChangeSetStatus";
   }
 
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return null;
   }
 
diff --git a/plugins/hg4idea/src/org/zmlx/hg4idea/ui/HgCurrentBranchStatus.java b/plugins/hg4idea/src/org/zmlx/hg4idea/ui/HgCurrentBranchStatus.java
index dd3e6c612568..e787d7604ada 100644
--- a/plugins/hg4idea/src/org/zmlx/hg4idea/ui/HgCurrentBranchStatus.java
+++ b/plugins/hg4idea/src/org/zmlx/hg4idea/ui/HgCurrentBranchStatus.java
@@ -62,7 +62,7 @@ public class HgCurrentBranchStatus extends JLabel implements CustomStatusBarWidg
     return "HgCurrentBranchStatus";
   }
 
-  public WidgetPresentation getPresentation(@NotNull Type type) {
+  public WidgetPresentation getPresentation(@NotNull PlatformType type) {
     return null;
   }
 

From 48823a471c3fde4243374532bd5b2e527818a5cc Mon Sep 17 00:00:00 2001
From: Oleg Shpynov <oleg.shpynov@jetbrains.com>
Date: Mon, 2 Aug 2010 15:43:01 +0400
Subject: [PATCH 13/42] RUBY-6353: Commenting out lines in HAML generates
 invalid code

---
 .../CommentByLineCommentHandler.java          | 11 +++++--
 .../generation/IndentedCommenter.java         | 32 +++++++++++++++++++
 2 files changed, 41 insertions(+), 2 deletions(-)
 create mode 100644 platform/lang-impl/src/com/intellij/codeInsight/generation/IndentedCommenter.java

diff --git a/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByLineCommentHandler.java b/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByLineCommentHandler.java
index 96f723a291d6..012b2e419daf 100644
--- a/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByLineCommentHandler.java
+++ b/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByLineCommentHandler.java
@@ -224,7 +224,8 @@ public class CommentByLineCommentHandler implements CodeInsightActionHandler {
     }
 
     boolean allLineCommented = true;
-    
+    boolean commentWithIndent = CodeStyleSettingsManager.getSettings(myProject).LINE_COMMENT_AT_FIRST_COLUMN;
+
     for (int line = myStartLine; line <= myEndLine; line++) {
       Commenter commenter = blockSuitableCommenter != null ? blockSuitableCommenter : findCommenter(line);
       if (commenter == null) return;
@@ -245,12 +246,18 @@ public class CommentByLineCommentHandler implements CodeInsightActionHandler {
       myCommenters[line - myStartLine] = commenter;
       if (!isLineCommented(line, chars, commenter) && (singleline || !isLineEmpty(line))) {
         allLineCommented = false;
+        if (commenter instanceof IndentedCommenter){
+          final Boolean value = ((IndentedCommenter)commenter).forceIndentedLineComment();
+          if (value != null){
+            commentWithIndent = value;
+          }
+        }
         break;
       }
     }
 
     if (!allLineCommented) {
-      if (CodeStyleSettingsManager.getSettings(myProject).LINE_COMMENT_AT_FIRST_COLUMN) {
+      if (!commentWithIndent) {
         doDefaultCommenting(blockSuitableCommenter);
       }
       else {
diff --git a/platform/lang-impl/src/com/intellij/codeInsight/generation/IndentedCommenter.java b/platform/lang-impl/src/com/intellij/codeInsight/generation/IndentedCommenter.java
new file mode 100644
index 000000000000..5273acf6314d
--- /dev/null
+++ b/platform/lang-impl/src/com/intellij/codeInsight/generation/IndentedCommenter.java
@@ -0,0 +1,32 @@
+/*
+ * Copyright 2000-2010 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.codeInsight.generation;
+
+import com.intellij.lang.Commenter;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * @author oleg
+ */
+public interface IndentedCommenter extends Commenter {
+  /**
+   * Used to override CodeStyleSetings#LINE_COMMENT_AT_FIRST_COLUMN option
+   * @return true or false to overrride, null to use settings option
+   */
+  @Nullable
+  Boolean forceIndentedLineComment();
+  
+}

From 7bc4276ce91c5d41f39ed660c0000e80f34c70cf Mon Sep 17 00:00:00 2001
From: Oleg Shpynov <oleg.shpynov@jetbrains.com>
Date: Mon, 2 Aug 2010 17:25:39 +0400
Subject: [PATCH 14/42] RUBY-4667 Toggeling Block Comment generate new lines

---
 .../generation/CommentByBlockCommentHandler.java         | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByBlockCommentHandler.java b/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByBlockCommentHandler.java
index 6ca3e920e21f..b9f571c79a71 100644
--- a/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByBlockCommentHandler.java
+++ b/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByBlockCommentHandler.java
@@ -349,7 +349,14 @@ public class CommentByBlockCommentHandler implements CodeInsightActionHandler {
         else {
           space = "";
         }
-        TextRange range = insertNestedComments(chars, startOffset, endOffset, space + commentPrefix + "\n", space + commentSuffix + "\n", commenter);
+        final StringBuilder nestingPrefix = new StringBuilder(space).append(commentPrefix);
+        if (!commentPrefix.endsWith("\n")){
+          nestingPrefix.append("\n");
+        }
+        final StringBuilder nestingSuffix = new StringBuilder(space);
+        nestingSuffix.append(commentSuffix.startsWith("\n") ? commentSuffix.substring(1) : commentSuffix);
+        nestingSuffix.append("\n");
+        TextRange range = insertNestedComments(chars, startOffset, endOffset, nestingPrefix.toString(), nestingSuffix.toString(), commenter);
         myEditor.getSelectionModel().setSelection(range.getStartOffset(), range.getEndOffset());
         //myEditor.getSelectionModel().removeSelection();
         LogicalPosition pos = new LogicalPosition(caretPosition.line + 1, caretPosition.column);

From 06863598350ec4f9ea241b6f35cde8b1ec47ae7f Mon Sep 17 00:00:00 2001
From: Denis Zhdanov <Denis.Zhdanov@jetbrains.com>
Date: Mon, 2 Aug 2010 18:52:39 +0400
Subject: [PATCH 15/42] IDEA-56987    Throwable at
 EditorImpl.logicalToVisualPosition() on opening a database console

Soft wrap-aware mapping rules are corrected
---
 .../injected/editor/EditorWindow.java         |  12 +-
 .../intellij/openapi/editor/ex/EditorEx.java  |  12 +
 .../openapi/editor/ex/SoftWrapModelEx.java    |  24 +-
 .../openapi/editor/ex/util/EditorUtil.java    | 181 +++-
 .../openapi/editor/impl/CaretModelImpl.java   |  25 +-
 ...DefaultEditorTextRepresentationHelper.java |  19 +-
 .../openapi/editor/impl/EditorImpl.java       |  65 +-
 .../impl/EditorTextRepresentationHelper.java  |  30 +-
 .../editor/impl/SoftWrapModelImpl.java        |  48 +-
 .../DefaultSoftWrapApplianceManager.java      |   4 +-
 .../impl/softwrap/SoftWrapDataMapper.java     | 925 ++++++++----------
 .../impl/softwrap/SoftWrapDataMapperTest.java | 154 ++-
 .../openapi/util/text/StringUtil.java         |  14 +
 13 files changed, 817 insertions(+), 696 deletions(-)

diff --git a/platform/lang-impl/src/com/intellij/injected/editor/EditorWindow.java b/platform/lang-impl/src/com/intellij/injected/editor/EditorWindow.java
index 719aa3daf73e..aae8a0edaa25 100644
--- a/platform/lang-impl/src/com/intellij/injected/editor/EditorWindow.java
+++ b/platform/lang-impl/src/com/intellij/injected/editor/EditorWindow.java
@@ -195,7 +195,7 @@ public class EditorWindow implements EditorEx, UserDataHolderEx {
   }
 
   @NotNull
-  public FoldingModel getFoldingModel() {
+  public FoldingModelEx getFoldingModel() {
     return myFoldingModelWindow;
   }
 
@@ -283,6 +283,11 @@ public class EditorWindow implements EditorEx, UserDataHolderEx {
 
   @NotNull
   public LogicalPosition offsetToLogicalPosition(final int offset) {
+    return offsetToLogicalPosition(offset, true);
+  }
+
+  @NotNull
+  public LogicalPosition offsetToLogicalPosition(final int offset, boolean softWrapAware) {
     assert isValid();
     int lineNumber = myDocumentWindow.getLineNumber(offset);
     int lineStartOffset = myDocumentWindow.getLineStartOffset(lineNumber);
@@ -465,6 +470,11 @@ public class EditorWindow implements EditorEx, UserDataHolderEx {
 
   @NotNull
   public LogicalPosition visualToLogicalPosition(@NotNull final VisualPosition pos) {
+    return visualToLogicalPosition(pos, true);
+  }
+
+  @NotNull
+  public LogicalPosition visualToLogicalPosition(@NotNull final VisualPosition pos, boolean softWrapAware) {
     assert isValid();
     return new LogicalPosition(pos.line, pos.column);
   }
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/ex/EditorEx.java b/platform/platform-impl/src/com/intellij/openapi/editor/ex/EditorEx.java
index f3ac15c6c37b..7728292bd43e 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/ex/EditorEx.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/ex/EditorEx.java
@@ -21,6 +21,9 @@ import com.intellij.ide.DeleteProvider;
 import com.intellij.ide.PasteProvider;
 import com.intellij.openapi.actionSystem.DataContext;
 import com.intellij.openapi.editor.Editor;
+import com.intellij.openapi.editor.FoldingModel;
+import com.intellij.openapi.editor.LogicalPosition;
+import com.intellij.openapi.editor.VisualPosition;
 import com.intellij.openapi.editor.colors.EditorColorsScheme;
 import com.intellij.openapi.editor.highlighter.EditorHighlighter;
 import com.intellij.openapi.editor.impl.TextDrawingCallback;
@@ -124,4 +127,13 @@ public interface EditorEx extends Editor {
   int calcColumnNumber(int offset, int lineIndex);
 
   TextDrawingCallback getTextDrawingCallback();
+
+  @NotNull
+  @Override
+  FoldingModelEx getFoldingModel();
+
+  @NotNull
+  LogicalPosition visualToLogicalPosition(@NotNull VisualPosition visiblePos, boolean softWrapAware);
+
+  @NotNull LogicalPosition offsetToLogicalPosition(int offset, boolean softWrapAware);
 }
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/ex/SoftWrapModelEx.java b/platform/platform-impl/src/com/intellij/openapi/editor/ex/SoftWrapModelEx.java
index 88d897c9d3e7..3f309e1987d9 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/ex/SoftWrapModelEx.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/ex/SoftWrapModelEx.java
@@ -35,26 +35,22 @@ import java.util.List;
 public interface SoftWrapModelEx extends SoftWrapModel {
 
   /**
-   * Asks current model to adjust logical position for the given visual position if necessary.
-   * <p/>
-   * Given logical position is allowed to be non-soft wrap aware, i.e. the one calculated as there are no soft wraps at the moment.
+   * Asks current model to map given visual position to logical.
    *
-   * @param defaultLogical    default logical position that corresponds to the given visual position
-   * @param visual            target visual position for which logical position should be adjusted if necessary
+   * @param visual            target visual position for which logical position should be mapped
    * @return                  logical position that corresponds to the given visual position
    */
   @NotNull
-  LogicalPosition adjustLogicalPosition(@NotNull LogicalPosition defaultLogical, @NotNull VisualPosition visual);
+  LogicalPosition visualToLogicalPosition(@NotNull VisualPosition visual);
 
   /**
-   * Asks current model to adjust logical position for the given document offset.
+   * Asks current model to map given document offset to logical position.
    *
-   * @param defaultLogical  default logical position that corresponds to the given document offset
    * @param offset    target editor document offset
    * @return          logical position for the given editor document offset
    */
   @NotNull
-  LogicalPosition adjustLogicalPosition(LogicalPosition defaultLogical, int offset);
+  LogicalPosition offsetToLogicalPosition(int offset);
 
   /**
    * Asks current model to adjust visual position that corresponds to the given logical position if necessary.
@@ -103,7 +99,15 @@ public interface SoftWrapModelEx extends SoftWrapModel {
    * @param drawingType   target drawing type
    * @return              width in pixels required for the painting of the given type
    */
-  int getMinDrawingWidth(@NotNull SoftWrapDrawingType drawingType);
+  int getMinDrawingWidthInPixels(@NotNull SoftWrapDrawingType drawingType);
+
+  /**
+   * Allows to ask for the minimal width in columns required for painting of the given type.
+   *
+   * @param drawingType   target drawing type
+   * @return              width in columns required for the painting of the given type
+   */
+  int getMinDrawingWidthInColumns(@NotNull SoftWrapDrawingType drawingType);
 
   /**
    * Registers given listener within the current model
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java b/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
index a12865d77d70..11763b6fb1ce 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
@@ -28,6 +28,7 @@ import org.jetbrains.annotations.NotNull;
 
 import java.awt.*;
 import java.util.List;
+import java.util.concurrent.atomic.AtomicInteger;
 
 public class EditorUtil {
   private EditorUtil() { }
@@ -178,54 +179,69 @@ public class EditorUtil {
    */
   public static int calcOffset(Editor editor, CharSequence text, int start, int end, int columnNumber, int tabSize) {
     final int maxScanIndex = Math.min(start + columnNumber + 1, end);
-    if (editor == null) {
-      return calcSoftWrapUnawareOffset(text, start, maxScanIndex, columnNumber, tabSize);
-    }
-
-    EditorEx editorImpl = (EditorEx)editor;
-    int offset = start;
-    IterationState state = new IterationState(editorImpl, offset, false);
-    int fontType = state.getMergedAttributes().getFontType();
-    int column = 0;
-    int x = 0;
-    int spaceSize = getSpaceWidth(fontType, editorImpl);
     SoftWrapModel softWrapModel = editor.getSoftWrapModel();
-    while (column < columnNumber) {
-      TextChange softWrap = softWrapModel.getSoftWrap(offset);
-      if (softWrap != null) {
-        x = softWrapModel.getSoftWrapIndentWidthInPixels(softWrap);
+    List<? extends TextChange> softWraps = softWrapModel.getSoftWrapsForRange(start, maxScanIndex);
+    int startToUse = start;
+    int x = 0;
+    AtomicInteger currentColumn = new AtomicInteger();
+    for (TextChange softWrap : softWraps) {
+      // There is a possible case that target column points inside soft wrap-introduced virtual space.
+      if (currentColumn.get() >= columnNumber) {
+        return startToUse;
       }
-      if (offset >= state.getEndOffset()) {
-        state.advance();
-        fontType = state.getMergedAttributes().getFontType();
+      int result = calcSoftWrapUnawareOffset(editor, text, startToUse, softWrap.getEnd(), columnNumber, tabSize, x, currentColumn);
+      if (result >= 0) {
+        return result;
       }
 
-      char c = offset < end ? text.charAt(offset++) : ' ';
-      int prevX = x;
-      if (c == '\t') {
-        x = nextTabStop(x, editorImpl);
-      }
-      else {
-        x += charWidth(c, fontType, editorImpl);
-      }
-      column += columnsNumber(c, x, prevX,  spaceSize);
+      startToUse = softWrap.getStart();
+      x = softWrapModel.getSoftWrapIndentWidthInPixels(softWrap);
     }
-    //if (column == columnNumber && offset < end && text.charAt(offset) == '\t' && (nextTabStop(x, editorImpl) - x) / spaceSize == 0) {
-    //  offset++;
-    //}
-    if (column > columnNumber) offset--;
 
-    return offset;
+    // There is a possible case that target column points inside soft wrap-introduced virtual space.
+    if (currentColumn.get() >= columnNumber) {
+      return startToUse;
+    }
+
+    int result = calcSoftWrapUnawareOffset(editor, text, startToUse, end, columnNumber, tabSize, x, currentColumn);
+    if (result >= 0) {
+      return result;
+    }
+
+    // We assume that given column points to the virtual space after the line end if control flow reaches this place,
+    // hence, just return end of line offset then.
+    return end;
   }
 
-  private static int calcSoftWrapUnawareOffset(CharSequence text, int start, int end, int columnNumber, int tabSize) {
+  /**
+   * Tries to match given logical column to the document offset assuming that it's located at <code>[start; end)</code> region.
+   *
+   * @param editor          editor that is used to represent target document
+   * @param text            target document text
+   * @param start           start offset to check (inclusive)
+   * @param end             end offset to check (exclusive)
+   * @param columnNumber    target logical column number
+   * @param tabSize         user-defined desired number of columns to use for tabulation symbol representation
+   * @param x               <code>'x'</code> coordinate that corresponds to the given <code>'start'</code> offset
+   * @param currentColumn   logical column that corresponds to the given <code>'start'</code> offset
+   * @return                target offset that belongs to the <code>[start; end)</code> range and points to the target logical
+   *                        column if any; <code>-1</code> otherwise
+   */
+  private static int calcSoftWrapUnawareOffset(Editor editor, CharSequence text, int start, int end, int columnNumber, int tabSize, int x,
+                                               AtomicInteger currentColumn)
+  {
+    // The main problem in a calculation is that target text may contain tabulation symbols and every such symbol may take different
+    // number of logical columns to represent. E.g. it takes two columns if tab size is four and current column is two; three columns
+    // if tab size is four and current column is one etc. So, first of all we check if there are tabulation symbols at the target
+    // text fragment.
+    boolean useOptimization = true;
     boolean hasNonTabs = false;
     boolean hasTabs = false;
-
     for (int i = start; i < end; i++) {
       if (text.charAt(i) == '\t') {
         hasTabs = true;
         if (hasNonTabs) {
+          useOptimization = false;
           break;
         }
       } else {
@@ -233,20 +249,77 @@ public class EditorUtil {
       }
     }
 
-    if (!hasTabs) return Math.min(start + columnNumber, end);
+    // Perform optimized processing if possible. 'Optimized' here means the processing when we exactly know how many logical
+    // columns are occupied by tabulation symbols.
+    if (editor == null || useOptimization) {
+      if (!hasTabs) {
+        int result = start + columnNumber - currentColumn.get();
+        if (result < end) {
+          return result;
+        }
+        else {
+          currentColumn.addAndGet(end - start);
+          return -1;
+        }
+      }
 
-    int shift = 0;
-    int offset = start;
-    for (; offset < end && offset + shift < start + columnNumber; offset++) {
-      if (text.charAt(offset) == '\t') {
-        shift += getTabLength(offset + shift - start, tabSize) - 1;
+      int shift = 0;
+      int offset = start;
+      int prevX = x;
+      for (; offset < end && offset + shift + currentColumn.get() < start + columnNumber; offset++) {
+        if (text.charAt(offset) == '\t') {
+          int nextX = nextTabStop(prevX, editor, tabSize);
+          shift += columnsNumber(nextX - prevX, getSpaceWidth(Font.PLAIN, editor));
+          prevX = nextX;
+        }
+      }
+      int diff = start + columnNumber - offset - shift - currentColumn.get();
+      if (diff < 0) {
+        return offset - 1;
+      }
+      else if (diff == 0) {
+        return offset;
+      }
+      else {
+        currentColumn.addAndGet(offset - start + shift);
+        return -1;
       }
     }
-    if (offset + shift > start + columnNumber) {
-      offset--;
+
+    // It means that there are tabulation symbols that can't be explicitly mapped to the occupied logical columns number,
+    // hence, we need to perform special calculations to get know that.
+    EditorEx editorImpl = (EditorEx)editor;
+    int offset = start;
+    IterationState state = new IterationState(editorImpl, offset, false);
+    int fontType = state.getMergedAttributes().getFontType();
+    int column = currentColumn.get();
+    int spaceSize = getSpaceWidth(fontType, editorImpl);
+    for (; column <= columnNumber && offset < end; offset++) {
+      if (offset >= state.getEndOffset()) {
+        state.advance();
+        fontType = state.getMergedAttributes().getFontType();
+      }
+
+      char c = text.charAt(offset);
+      if (c == '\t') {
+        int prevX = x;
+        x = nextTabStop(x, editorImpl);
+        column += columnsNumber(x - prevX, spaceSize);
+      }
+      else {
+        x += charWidth(c, fontType, editorImpl);
+        column++;
+      }
     }
 
-    return offset;
+    if (column == columnNumber) {
+      return offset;
+    }
+    if (column > columnNumber && text.charAt(offset) == '\t') {
+      return offset - 1;
+    }
+    currentColumn.set(column);
+    return -1;
   }
 
   private static int getTabLength(int colNumber, int tabSize) {
@@ -328,7 +401,10 @@ public class EditorUtil {
     if (tabSize <= 0) {
       tabSize = 1;
     }
+    return nextTabStop(x, editor, tabSize);
+  }
 
+  public static int nextTabStop(int x, Editor editor, int tabSize) {
     tabSize *= getSpaceWidth(Font.PLAIN, editor);
 
     int nTabs = x / tabSize;
@@ -371,6 +447,21 @@ public class EditorUtil {
     return result;
   }
 
+  /**
+   * Allows to answer how many visual columns are occupied by the given width.
+   *
+   * @param width       target width
+   * @param spaceSize   width of the single space symbol within the target editor
+   * @return            number of visual columns are occupied by the given width
+   */
+  public static int columnsNumber(int width, int spaceSize) {
+    int result = width / spaceSize;
+    if (width % spaceSize > 0) {
+      result++;
+    }
+    return result;
+  }
+
   /**
    * Allows to answer what width in pixels is required to draw fragment of the given char array from <code>[start; end)</code> interval
    * at the given editor.
@@ -390,10 +481,10 @@ public class EditorUtil {
    *                  from <code>[1; tab size]</code> (check {@link #nextTabStop(int, Editor)} for more details)
    * @return          width in pixels required for target text representation
    */
-  public static int textWidth(@NotNull Editor editor, char[] text, int start, int end, int fontType, int x) {
+  public static int textWidth(@NotNull Editor editor, CharSequence text, int start, int end, int fontType, int x) {
     int result = 0;
     for (int i = start; i < end; i++) {
-      char c = text[i];
+      char c = text.charAt(i);
       if (c != '\t') {
         FontInfo font = fontForChar(c, fontType, editor);
         result += font.charWidth(c, editor.getContentComponent());
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/CaretModelImpl.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/CaretModelImpl.java
index 6f4d4290843a..2870ab265133 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/CaretModelImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/CaretModelImpl.java
@@ -470,24 +470,27 @@ public class CaretModelImpl implements CaretModel, PrioritizedDocumentListener {
 
   private VerticalInfo createVerticalInfo(LogicalPosition position) {
     Document document = myEditor.getDocument();
-    int line = position.line;
+    int logicalLine = position.line;
 
     // There is a possible case that active logical line is represented on multiple lines due to soft wraps processing.
     // We want to highlight those visual lines as 'active' then, so, we calculate 'y' position for the logical line start
     // and height in accordance with the number of occupied visual lines.
-    int y = myEditor.logicalPositionToXY(myEditor.offsetToLogicalPosition(document.getLineStartOffset(line))).y;
+    LogicalPosition logicalPosition = myEditor.offsetToLogicalPosition(document.getLineStartOffset(logicalLine));
+    VisualPosition visualPosition = myEditor.logicalToVisualPosition(logicalPosition);
+    int y = myEditor.visualPositionToXY(visualPosition).y;
     int height = myEditor.getLineHeight();
-    if (line < document.getLineCount() - 1) {
-      int nextLineY = myEditor.logicalPositionToXY(myEditor.offsetToLogicalPosition(document.getLineStartOffset(line + 1))).y;
-      int heightCandidate = nextLineY - y;
-
-      // There is a possible case that active line is the one that ends with folding, so, 'y' position
-      // of its next logical line is the same as the previous. We explicitly check that in order to use non-standard
-      // line height only in case of visible soft-wrapped line.
-      if (heightCandidate > height) {
-        height = heightCandidate;
+    int visualLine = visualPosition.line + 1;
+    while (true) {
+      LogicalPosition logical = myEditor.visualToLogicalPosition(new VisualPosition(visualLine, 0));
+      if (logical.line == logicalLine) {
+        height += myEditor.getLineHeight();
+        visualLine++;
+      }
+      else {
+        break;
       }
     }
+
     return new VerticalInfo(y, height);
   }
 
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/DefaultEditorTextRepresentationHelper.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/DefaultEditorTextRepresentationHelper.java
index ca7ef098ee32..a866ba0daa4f 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/DefaultEditorTextRepresentationHelper.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/DefaultEditorTextRepresentationHelper.java
@@ -17,6 +17,9 @@ package com.intellij.openapi.editor.impl;
 
 import com.intellij.openapi.editor.Editor;
 import com.intellij.openapi.editor.ex.util.EditorUtil;
+import org.jetbrains.annotations.NotNull;
+
+import java.awt.*;
 
 /**
  * @author Denis Zhdanov
@@ -31,17 +34,17 @@ public class DefaultEditorTextRepresentationHelper implements EditorTextRepresen
   }
 
   @Override
-  public int toVisualColumnSymbolsNumber(CharSequence text, int start, int end, int x) {
+  public int toVisualColumnSymbolsNumber(@NotNull CharSequence text, int start, int end, int x) {
     return EditorUtil.textWidthInColumns(myEditor, text, start, end, x);
   }
 
   @Override
-  public int charWidth(char c, int x, int fontType) {
-    if (c == '\t') {
-      return EditorUtil.nextTabStop(x, myEditor) - x;
-    }
-    else {
-      return EditorUtil.charWidth(c, fontType, myEditor);
-    }
+  public int toVisualColumnSymbolsNumber(int width) {
+    return EditorUtil.columnsNumber(width, EditorUtil.getSpaceWidth(Font.PLAIN, myEditor));
+  }
+
+  @Override
+  public int textWidth(@NotNull CharSequence text, int start, int end, int x) {
+    return EditorUtil.textWidth(myEditor, text, start, end, Font.PLAIN, x);
   }
 }
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
index 122d1f28fcca..5bda19660b94 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
@@ -440,7 +440,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
   }
 
   @NotNull
-  public FoldingModel getFoldingModel() {
+  public FoldingModelEx getFoldingModel() {
     return myFoldingModel;
   }
 
@@ -902,7 +902,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
 
           // Process 'after soft wrap' sign.
           prevX = x;
-          charWidth = mySoftWrapModel.getMinDrawingWidth(SoftWrapDrawingType.AFTER_SOFT_WRAP);
+          charWidth = mySoftWrapModel.getMinDrawingWidthInPixels(SoftWrapDrawingType.AFTER_SOFT_WRAP);
           x += charWidth;
           if (x >= px) {
             break outer;
@@ -983,16 +983,15 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
     return offsetToLogicalPosition(offset, true);
   }
 
+  @NotNull
+  @Override
   public LogicalPosition offsetToLogicalPosition(int offset, boolean softWrapAware) {
+    if (softWrapAware) {
+      return mySoftWrapModel.offsetToLogicalPosition(offset);
+    }
     int line = calcLogicalLineNumber(offset, false);
     int column = calcColumnNumber(offset, line, false);
-    LogicalPosition position = new LogicalPosition(line, column);
-    if (softWrapAware) {
-      return mySoftWrapModel.adjustLogicalPosition(position, offset);
-    }
-    else {
-      return position;
-    }
+    return new LogicalPosition(line, column);
   }
 
   @NotNull
@@ -1055,7 +1054,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
           if (i >= 0) {
             start = i + 1;
           }
-          return new Point(EditorUtil.textWidth(this, softWrapChars, start, column + 1, Font.PLAIN, 0), y);
+          return new Point(EditorUtil.textWidth(this, softWrap.getText(), start, column + 1, Font.PLAIN, 0), y);
         }
         break;
       }
@@ -1319,6 +1318,8 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
   }
 
   void paint(Graphics g) {
+    //TODO den remove
+    System.out.printf("EditorImpl.paint(): (%d; %d) - [%d; %d]%n", g.getClipBounds().x, g.getClipBounds().y, g.getClipBounds().width, g.getClipBounds().height);
     startOptimizedScrolling();
 
     if (myCursorUpdater != null) {
@@ -2667,10 +2668,16 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
 
   @NotNull
   public LogicalPosition visualToLogicalPosition(@NotNull VisualPosition visiblePos) {
-    assertReadAccess();
-    if (!myFoldingModel.isFoldingEnabled() && !mySoftWrapModel.isSoftWrappingEnabled()) {
-      return new LogicalPosition(visiblePos.line, visiblePos.column);
+    return visualToLogicalPosition(visiblePos, true);
+  }
+
+  @NotNull
+  public LogicalPosition visualToLogicalPosition(@NotNull VisualPosition visiblePos, boolean softWrapAware) {
+    if (softWrapAware) {
+      return mySoftWrapModel.visualToLogicalPosition(visiblePos);
     }
+    assertReadAccess();
+    if (!myFoldingModel.isFoldingEnabled()) return new LogicalPosition(visiblePos.line, visiblePos.column);
 
     int line = visiblePos.line;
     int column = visiblePos.column;
@@ -2678,35 +2685,23 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
     FoldRegion lastCollapsedBefore = getLastCollapsedBeforePosition(visiblePos);
 
     if (lastCollapsedBefore != null) {
-      LogicalPosition softWrapAwareLogFoldEnd = offsetToLogicalPosition(lastCollapsedBefore.getEndOffset());
-      VisualPosition softWrapAwareVisFoldEnd = logicalToVisualPosition(softWrapAwareLogFoldEnd);
-      if (softWrapAwareVisFoldEnd.line == visiblePos.line) {
-        if (visiblePos.column == softWrapAwareVisFoldEnd.column) {
-          return softWrapAwareLogFoldEnd;
-        }
-        else if (visiblePos.column > softWrapAwareVisFoldEnd.column) {
-          int columnToUse = softWrapAwareLogFoldEnd.column + visiblePos.column - softWrapAwareVisFoldEnd.column;
-          return new LogicalPosition(
-            softWrapAwareLogFoldEnd.line, columnToUse, softWrapAwareLogFoldEnd.softWrapLinesBeforeCurrentLogicalLine,
-            softWrapAwareLogFoldEnd.softWrapLinesOnCurrentLogicalLine, visiblePos.column - columnToUse - softWrapAwareLogFoldEnd.foldingColumnDiff,
-            softWrapAwareLogFoldEnd.foldedLines, softWrapAwareLogFoldEnd.foldingColumnDiff
-          );
+      LogicalPosition logFoldEnd = offsetToLogicalPosition(lastCollapsedBefore.getEndOffset(), false);
+      VisualPosition visFoldEnd = logicalToVisualPosition(logFoldEnd, false);
+
+      line = logFoldEnd.line + (visiblePos.line - visFoldEnd.line);
+      if (visFoldEnd.line == visiblePos.line) {
+        if (visiblePos.column >= visFoldEnd.column) {
+          column = logFoldEnd.column + (visiblePos.column - visFoldEnd.column);
         }
         else {
-          return offsetToLogicalPosition(lastCollapsedBefore.getStartOffset());
+          return offsetToLogicalPosition(lastCollapsedBefore.getStartOffset(), false);
         }
       }
-
-      LogicalPosition softWrapUnawareLogFoldEnd = offsetToLogicalPosition(lastCollapsedBefore.getEndOffset(), false);
-      VisualPosition softWrapUnawareVisFoldEnd = logicalToVisualPosition(softWrapUnawareLogFoldEnd, false);
-      line = softWrapUnawareLogFoldEnd.line + (visiblePos.line - softWrapUnawareVisFoldEnd.line);
     }
 
     if (column < 0) column = 0;
-    line = Math.min(line, myDocument.getLineCount() - 1);
 
-    LogicalPosition softWrapUnawareResult = new LogicalPosition(line, column);
-    return mySoftWrapModel.adjustLogicalPosition(softWrapUnawareResult, visiblePos);
+    return new LogicalPosition(line, column);
   }
 
   private int calcLogicalLineNumber(int offset) {
@@ -4844,7 +4839,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
       TextChange softWrap = getSoftWrapModel().getSoftWrap(i);
       if (softWrap != null) {
         column++; // For 'after soft wrap' drawing.
-        x = getSoftWrapModel().getMinDrawingWidth(SoftWrapDrawingType.AFTER_SOFT_WRAP);
+        x = getSoftWrapModel().getMinDrawingWidthInPixels(SoftWrapDrawingType.AFTER_SOFT_WRAP);
       }
 
       char c = text.charAt(i);
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorTextRepresentationHelper.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorTextRepresentationHelper.java
index da31f72de73f..6e391667b15e 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorTextRepresentationHelper.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorTextRepresentationHelper.java
@@ -15,6 +15,8 @@
  */
 package com.intellij.openapi.editor.impl;
 
+import org.jetbrains.annotations.NotNull;
+
 /**
  * Strategy interface for various utility methods used for representing document text at the editor.
  * <p/>
@@ -37,16 +39,28 @@ public interface EditorTextRepresentationHelper {
    * @param x       <code>'x'</code> offset from the visual line start
    * @return        number of visual columns necessary for the target text sub-sequence representation
    */
-  int toVisualColumnSymbolsNumber(CharSequence text, int start, int end, int x);
+  int toVisualColumnSymbolsNumber(@NotNull CharSequence text, int start, int end, int x);
 
   /**
-   * Allows to retrieve width (in pixels) necessary to represent given symbol at the given <code>'x'</code> offset from
-   * visual line start using given font type.
+   * Allows to answer how many visual columns is necessary for representing text of the given width.
    *
-   * @param c         target symbol which width should be calculated
-   * @param x         current <code>'x'</code> of the visual line start to use for the target symbol representation
-   * @param fontType  font type to use for representing given symbol
-   * @return          number of pixels necessary for the given symbol representation
+   * @param width   target width
+   * @return        number of visual columns necessary for representation of the text with the given width
    */
-  int charWidth(char c, int x, int fontType);
+  int toVisualColumnSymbolsNumber(int width);
+
+  /**
+   * Allows to retrieve width (in pixels) necessary to represent given region (<code>[start; end)</code>) starting
+   * at the given <code>'x'</code> offset from visual line start using given font type.
+   * <p/>
+   * <b>Note:</b> target region is allows to contain line feeds, the width is calculated as a difference between <code>'x'</code>
+   * coordinates of the last and first symbols.
+   *
+   * @param text    target text holder
+   * @param start   start offset of the target text sub-sequence (inclusive)
+   * @param end     end offset of the target text sub-sequence (exclusive)
+   * @param x       <code>'x'</code> offset from the visual line start
+   * @return        width in pixels necessary for the target text sub-sequence representation
+   */
+  int textWidth(@NotNull CharSequence text, int start, int end, int x);
 }
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/SoftWrapModelImpl.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/SoftWrapModelImpl.java
index 8dc8a3acfb08..3dd07cde9a4b 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/SoftWrapModelImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/SoftWrapModelImpl.java
@@ -43,7 +43,7 @@ import java.util.List;
  */
 public class SoftWrapModelImpl implements SoftWrapModelEx {
 
-  private final SoftWrapDataMapper            myDataAdjuster;
+  private final SoftWrapDataMapper            myDataMapper;
   private final SoftWrapsStorage              myStorage;
   private final SoftWrapPainter               myPainter;
   private final SoftWrapApplianceManager      myApplianceManager;
@@ -60,20 +60,20 @@ public class SoftWrapModelImpl implements SoftWrapModelEx {
   public SoftWrapModelImpl(@NotNull final EditorEx editor, @NotNull SoftWrapsStorage storage, @NotNull SoftWrapPainter painter) {
     this(
       editor, storage, painter, new DefaultSoftWrapApplianceManager(storage, editor, painter),
-      new SoftWrapDataMapper(editor, storage, painter, new DefaultEditorTextRepresentationHelper(editor)),
+      new SoftWrapDataMapper(editor, storage, new DefaultEditorTextRepresentationHelper(editor)),
       new SoftWrapDocumentChangeManager(editor, storage)
     );
   }
 
   public SoftWrapModelImpl(@NotNull EditorEx editor, @NotNull SoftWrapsStorage storage, @NotNull SoftWrapPainter painter,
-                           @NotNull SoftWrapApplianceManager applianceManager, @NotNull SoftWrapDataMapper dataAdjuster,
+                           @NotNull SoftWrapApplianceManager applianceManager, @NotNull SoftWrapDataMapper dataMapper,
                            @NotNull SoftWrapDocumentChangeManager documentChangeManager)
   {
     myEditor = editor;
     myStorage = storage;
     myPainter = painter;
     myApplianceManager = applianceManager;
-    myDataAdjuster = dataAdjuster;
+    myDataMapper = dataMapper;
     myDocumentChangeManager = documentChangeManager;
   }
 
@@ -184,25 +184,39 @@ public class SoftWrapModelImpl implements SoftWrapModelEx {
   }
 
   @Override
-  public int getMinDrawingWidth(@NotNull SoftWrapDrawingType drawingType) {
+  public int getMinDrawingWidthInPixels(@NotNull SoftWrapDrawingType drawingType) {
     return myPainter.getMinDrawingWidth(drawingType);
   }
 
+  @Override
+  public int getMinDrawingWidthInColumns(@NotNull SoftWrapDrawingType drawingType) {
+    return myPainter.getMinDrawingWidth(drawingType) > 0 ? 1 : 0;
+  }
+
   @NotNull
-  public LogicalPosition adjustLogicalPosition(@NotNull LogicalPosition defaultLogical, @NotNull VisualPosition visual) {
+  @Override
+  public LogicalPosition visualToLogicalPosition(@NotNull VisualPosition visual) {
     if (myActive > 0 || !isSoftWrappingEnabled() || myStorage.isEmpty() || myEditor.getDocument().getTextLength() <= 0) {
-      return defaultLogical;
+      return myEditor.visualToLogicalPosition(visual, false);
     }
-
-    if (defaultLogical.visualPositionAware) {
-      return defaultLogical;
-    }
-
     myActive++;
     try {
-      return myDataAdjuster.adjustLogicalPosition(defaultLogical, visual);
+      return myDataMapper.visualToLogical(visual);
+    } finally {
+      myActive--;
     }
-    finally {
+  }
+
+  @NotNull
+  @Override
+  public LogicalPosition offsetToLogicalPosition(int offset) {
+    if (myActive > 0 || !isSoftWrappingEnabled() || myStorage.isEmpty() || myEditor.getDocument().getTextLength() <= 0) {
+      return myEditor.offsetToLogicalPosition(offset, false);
+    }
+    myActive++;
+    try {
+      return myDataMapper.offsetToLogicalPosition(offset);
+    } finally {
       myActive--;
     }
   }
@@ -215,7 +229,7 @@ public class SoftWrapModelImpl implements SoftWrapModelEx {
 
     myActive++;
     try {
-      return myDataAdjuster.offsetToLogicalPosition(offset);
+      return myDataMapper.offsetToLogicalPosition(offset);
     } finally {
       myActive--;
     }
@@ -229,7 +243,7 @@ public class SoftWrapModelImpl implements SoftWrapModelEx {
 
     myActive++;
     try {
-      return myDataAdjuster.adjustVisualPosition(logical, defaultVisual);
+      return myDataMapper.adjustVisualPosition(logical, defaultVisual);
     }
     finally {
       myActive--;
@@ -292,7 +306,7 @@ public class SoftWrapModelImpl implements SoftWrapModelEx {
     }
 
     if (start < end) {
-      result += EditorUtil.textWidth(myEditor, chars, start, end, Font.PLAIN, 0);
+      result += EditorUtil.textWidth(myEditor, softWrap.getText(), start, end, Font.PLAIN, 0);
     }
 
     return result;
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/DefaultSoftWrapApplianceManager.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/DefaultSoftWrapApplianceManager.java
index 876d7bd3ea71..9b7a7fdd8ee2 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/DefaultSoftWrapApplianceManager.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/DefaultSoftWrapApplianceManager.java
@@ -29,6 +29,8 @@ import gnu.trove.TIntArrayList;
 import gnu.trove.TIntHashSet;
 import org.jetbrains.annotations.NotNull;
 
+import java.nio.CharBuffer;
+
 /**
  * Default {@link SoftWrapApplianceManager} implementation that is built with the following design guide lines:
  * <pre>
@@ -214,7 +216,7 @@ public class DefaultSoftWrapApplianceManager implements SoftWrapApplianceManager
     int x = myPainter.getMinDrawingWidth(SoftWrapDrawingType.BEFORE_SOFT_WRAP_LINE_FEED);
     int prevSoftWrapOffset = start;
     for (int i = start; i < end; i++) {
-      int symbolWidth = EditorUtil.textWidth(myEditor, text, i, i + 1, fontType, x);
+      int symbolWidth = EditorUtil.textWidth(myEditor, CharBuffer.wrap(text), i, i + 1, fontType, x);
       if (x + symbolWidth >= myVisibleAreaWidth) {
         int offset = calculateSoftWrapOffset(text, i - 1, prevSoftWrapOffset, end);
         if (offset >= end || offset <= prevSoftWrapOffset) {
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapper.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapper.java
index 99cd59788f5f..cc965b8ff252 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapper.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapper.java
@@ -18,14 +18,11 @@ package com.intellij.openapi.editor.impl.softwrap;
 import com.intellij.openapi.editor.*;
 import com.intellij.openapi.editor.ex.EditorEx;
 import com.intellij.openapi.editor.impl.EditorTextRepresentationHelper;
-import com.intellij.openapi.editor.impl.IterationState;
 import com.intellij.openapi.util.text.StringUtil;
 import com.intellij.util.text.CharArrayUtil;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
-import java.awt.*;
-import java.nio.CharBuffer;
 import java.util.List;
 
 /**
@@ -37,171 +34,44 @@ import java.util.List;
  */
 public class SoftWrapDataMapper {
 
-  private static final VisualPosition  DUMMY_VISUAL  = new VisualPosition(Integer.MAX_VALUE, Integer.MAX_VALUE);
-
-  private final CharBuffer myCharBuffer = CharBuffer.allocate(1);
-
   private final EditorTextRepresentationHelper myTextRepresentationHelper;
   private final EditorEx                       myEditor;
   private final SoftWrapsStorage               myStorage;
-  private final SoftWrapPainter                myPainter;
-  private final FontTypeProvider               myFontTypeProvider;
+  //private final FontTypeProvider               myFontTypeProvider;
+
+  //public SoftWrapDataMapper(EditorEx editor,
+  //                          SoftWrapsStorage storage,
+  //                          EditorTextRepresentationHelper textRepresentationHelper)
+  //{
+  //  this(editor, storage, textRepresentationHelper, new IterationStateFontTypeProvider(editor));
+  //}
 
   public SoftWrapDataMapper(EditorEx editor,
                             SoftWrapsStorage storage,
-                            SoftWrapPainter painter,
-                            EditorTextRepresentationHelper textRepresentationHelper)
-  {
-    this(editor, storage, painter, textRepresentationHelper, new IterationStateFontTypeProvider(editor));
-  }
-
-  SoftWrapDataMapper(EditorEx editor,
-                            SoftWrapsStorage storage,
-                            SoftWrapPainter painter,
-                            EditorTextRepresentationHelper textRepresentationHelper,
-                            FontTypeProvider fontTypeProvider)
+                            EditorTextRepresentationHelper textRepresentationHelper/*,
+                            FontTypeProvider fontTypeProvider*/)
   {
     myEditor = editor;
     myStorage = storage;
-    myPainter = painter;
     myTextRepresentationHelper = textRepresentationHelper;
-    myFontTypeProvider = fontTypeProvider;
+    //myFontTypeProvider = fontTypeProvider;
   }
 
   @NotNull
-  public LogicalPosition adjustLogicalPosition(@NotNull LogicalPosition defaultLogical, @NotNull VisualPosition visual) {
-    try {
-      return doAdjustLogicalPosition(defaultLogical, visual);
-    }
-    finally {
-      myFontTypeProvider.cleanup();
-    }
+  public LogicalPosition visualToLogical(@NotNull VisualPosition visual) {
+    return toLogical(new VisualPositionBasedStrategy(visual));
   }
 
-  @SuppressWarnings({"AssignmentToForLoopParameter"})
   @NotNull
-  private LogicalPosition doAdjustLogicalPosition(@NotNull LogicalPosition defaultLogical, @NotNull VisualPosition visual) {
-    Document document = myEditor.getDocument();
-    int maxOffset = document.getLineEndOffset(Math.min(defaultLogical.line, document.getLineCount() - 1));
+  public LogicalPosition offsetToLogicalPosition(int offset) {
+    OffsetBasedStrategy strategy = new OffsetBasedStrategy(myTextRepresentationHelper, myEditor.getDocument(), offset);
+    return toLogical(strategy);
+  }
 
-    // This index points to registered soft wrap that is guaranteed to be located after the target visual line.
-    int endIndex = myStorage.getSoftWrapIndex(maxOffset + 1);
-    if (endIndex < 0) {
-      endIndex = -endIndex - 1;
-    }
-
-    int softWrapLinesBeforeCurrentLogicalLine = 0;
-    int softWrapLinesOnCurrentLogicalLine = 0;
-    int lastSoftWrapLogicalLine = -1;
-
-    FoldingModel foldingModel = myEditor.getFoldingModel();
-    int i = 0;
-    List<TextChangeImpl> softWraps = myStorage.getSoftWraps();
-    int max = Math.min(softWraps.size(), endIndex);
-    for (; i < max; i++) {
-      TextChange softWrap = softWraps.get(i);
-      if (!isVisible(softWrap)) {
-        continue;
-      }
-
-      int currentSoftWrapLineFeeds = StringUtil.countNewLines(softWrap.getText());
-      int softWrapLine = document.getLineNumber(softWrap.getStart());
-      int visualLineBeforeSoftWrapAppliance = myEditor.logicalToVisualPosition(new LogicalPosition(softWrapLine, 0)).line
-                                              + softWrapLinesBeforeCurrentLogicalLine + softWrapLinesOnCurrentLogicalLine;
-      if (visualLineBeforeSoftWrapAppliance > visual.line) {
-        softWrapLinesBeforeCurrentLogicalLine += softWrapLinesOnCurrentLogicalLine;
-        int logicalLine = defaultLogical.line - softWrapLinesBeforeCurrentLogicalLine;
-        return new LogicalPosition(
-          logicalLine, defaultLogical.column, softWrapLinesBeforeCurrentLogicalLine, 0, 0,
-          getFoldedLinesBefore(document.getLineStartOffset(logicalLine)),
-          visual.column - defaultLogical.column
-        );
-      }
-
-      if (lastSoftWrapLogicalLine >= 0 && lastSoftWrapLogicalLine != softWrapLine) {
-        softWrapLinesBeforeCurrentLogicalLine += softWrapLinesOnCurrentLogicalLine;
-        softWrapLinesOnCurrentLogicalLine = 0;
-      }
-      lastSoftWrapLogicalLine = softWrapLine;
-
-      int visualLineAfterSoftWrapAppliance = visualLineBeforeSoftWrapAppliance + currentSoftWrapLineFeeds;
-      if (visualLineAfterSoftWrapAppliance < visual.line) {
-        softWrapLinesOnCurrentLogicalLine += currentSoftWrapLineFeeds;
-        continue;
-      }
-
-      int startLineOffset = document.getLineStartOffset(softWrapLine);
-      int endLineOffset = document.getLineEndOffset(softWrapLine);
-      FoldRegion region = foldingModel.getCollapsedRegionAtOffset(endLineOffset);
-      while (region != null) {
-        int line = document.getLineNumber(region.getEndOffset());
-        endLineOffset = document.getLineEndOffset(line);
-        region = foldingModel.getCollapsedRegionAtOffset(endLineOffset);
-      }
-      CharSequence documentText = document.getCharsSequence();
-
-      // If we're here that means that current soft wrap affects logical line that is matched to the given visual line.
-      // We iterate from the logical line start then in order to calculate resulting logical position.
-      Context context = new Context(
-        visual, softWrapLine, softWrapLinesBeforeCurrentLogicalLine, softWrapLinesOnCurrentLogicalLine,
-        visualLineBeforeSoftWrapAppliance, getFoldedLinesBefore(startLineOffset)
-      );
-      myFontTypeProvider.init(startLineOffset);
-
-      for (int j = startLineOffset; j < endLineOffset; j++) {
-
-        // Process soft wrap at the current offset if any.
-        TextChange softWrapToProcess = myStorage.getSoftWrap(j);
-        if (softWrapToProcess != null && isVisible(softWrapToProcess)) {
-          context.beforeSoftWrap();
-          if (j >= softWrap.getStart()) {
-            CharSequence softWrapText = softWrapToProcess.getText();
-            for (int k = 0; k < softWrapText.length(); k++) {
-              LogicalPosition result = context.onSoftWrapSymbol(softWrapText.charAt(k));
-              if (result != null) {
-                return result;
-              }
-            }
-          }
-          context.afterSoftWrap();
-        }
-
-        context.fontType = myFontTypeProvider.getFontType(j);
-
-        FoldRegion foldRegion = foldingModel.getCollapsedRegionAtOffset(j);
-        if (foldRegion != null) {
-          LogicalPosition result = context.onCollapsedFolding(foldRegion);
-          if (result != null) {
-            return result;
-          }
-          j = foldRegion.getEndOffset();
-        }
-
-        // Process document symbol.
-        LogicalPosition result = context.onNonSoftWrapSymbol(documentText.charAt(j));
-        if (result != null) {
-          return result;
-        }
-      }
-
-      // If we are here that means that target visual position is located at virtual space after the line end.
-      context.logicalColumn += visual.column - context.visualColumn;
-      return context.build();     
-    }
-
-    // If we are here that means that there is no soft wrap on a logical line that corresponds to the target visual line.
-    softWrapLinesBeforeCurrentLogicalLine += softWrapLinesOnCurrentLogicalLine;
-    int logicalLine = defaultLogical.line - softWrapLinesBeforeCurrentLogicalLine;
-    // There is a possible case that we can't count on given default logical position - e.g. if given visual position line
-    // is more than total document lines count.
-    if (logicalLine < 0) {
-      logicalLine = Math.min(lastSoftWrapLogicalLine + 1, document.getLineCount() - 1);
-    }
-    int foldedLines = getFoldedLinesBefore(document.getLineStartOffset(logicalLine));
-    int foldingColumnDiff = visual.column - defaultLogical.column;
-    return new LogicalPosition(
-      logicalLine, defaultLogical.column, softWrapLinesBeforeCurrentLogicalLine, 0, 0, foldedLines, foldingColumnDiff
-    );
+  @NotNull
+  private LogicalPosition toLogical(LogicalPositionCalculatorStrategy strategy) {
+    LogicalPositionCalculator calculator = new LogicalPositionCalculator(strategy);
+    return calculator.calculate();
   }
 
   @NotNull
@@ -263,175 +133,6 @@ public class SoftWrapDataMapper {
     return new VisualPosition(visual.line + lineDiff, columnToUse);
   }
 
-  public LogicalPosition offsetToLogicalPosition(int offset) {
-    try {
-      return doOffsetToLogicalPosition(offset);
-    }
-    finally {
-      myFontTypeProvider.cleanup();
-    }
-  }
-
-  @SuppressWarnings({"AssignmentToForLoopParameter"})
-  private LogicalPosition doOffsetToLogicalPosition(int offset) {
-    FoldingModel foldingModel = myEditor.getFoldingModel();
-    Document document = myEditor.getDocument();
-    CharSequence text = document.getCharsSequence();
-    int line = document.getLineNumber(offset);
-    int lineStartOffset = document.getLineStartOffset(line);
-    FoldRegion region = foldingModel.getCollapsedRegionAtOffset(lineStartOffset);
-    while (region != null && region.getStartOffset() != lineStartOffset) {
-      line = document.getLineNumber(region.getStartOffset());
-      lineStartOffset = document.getLineStartOffset(line);
-      region = foldingModel.getCollapsedRegionAtOffset(lineStartOffset);
-    }
-
-    Context context = new Context(line, getSoftWrapIntroducedLinesBefore(lineStartOffset), getFoldedLinesBefore(lineStartOffset));
-    myFontTypeProvider.init(lineStartOffset);
-    context.fontType = myFontTypeProvider.getFontType(lineStartOffset);
-    for (int i = lineStartOffset; i <= offset; i++) {
-      TextChangeImpl softWrap = myStorage.getSoftWrap(i);
-      if (softWrap != null) {
-        context.beforeSoftWrap();
-        CharSequence softWrapText = softWrap.getText();
-        for (int k = 0; k < softWrapText.length(); k++) {
-          context.onSoftWrapSymbol(softWrapText.charAt(k));
-        }
-        context.afterSoftWrap();
-      }
-
-      if (i == offset) {
-        // We want to count soft wrap that is registered at target offset if any but not exceeding document symbols.
-        break;
-      }
-
-      region = foldingModel.getCollapsedRegionAtOffset(i);
-      if (region != null) {
-        processFoldRegion(context, region, offset);
-        if (offset <= region.getEndOffset()) {
-          break;
-        }
-        i = region.getEndOffset();
-      }
-      context.fontType = myFontTypeProvider.getFontType(i);
-      context.onNonSoftWrapSymbol(text.charAt(i));
-    }
-    return new LogicalPosition(
-      context.logicalLine,
-      context.logicalColumn,
-      context.softWrapLinesBefore,
-      context.targetSoftWrapLines,
-      context.softWrapColumnDiff,
-      getFoldedLinesBefore(offset),
-      context.foldingColumnDiff
-    );
-  }
-
-  /**
-   * Processes given collapsed fold region assuming that we need to stop at a target offset.
-   * <p/>
-   * Processing result is updated state of the given context object.
-   *
-   * @param context   processing data holder
-   * @param region    collapsed fold region to process
-   * @param offset    target stop offset
-   */
-  @SuppressWarnings({"AssignmentToForLoopParameter"})
-  private void processFoldRegion(Context context, FoldRegion region, int offset) {
-    CharSequence text = myEditor.getDocument().getCharsSequence();
-    int max = Math.min(offset, region.getEndOffset());
-    boolean multilineFolding = false;
-    for (int i = region.getStartOffset(); i < max;) {
-      int lineFeedOffset = CharArrayUtil.shiftForwardUntil(text, i, "\n");
-      if (lineFeedOffset < max) {
-        context.softWrapLinesBefore += context.targetSoftWrapLines;
-        context.targetSoftWrapLines = 0;
-        context.softWrapColumnDiff = 0;
-        context.foldedLines++;
-        context.logicalColumn = 0;
-        context.foldingColumnDiff = context.visualColumn;
-        context.logicalLine++;
-        i = lineFeedOffset + 1;
-        multilineFolding = true;
-      }
-      else {
-        if (multilineFolding) {
-          context.logicalColumn = myTextRepresentationHelper.toVisualColumnSymbolsNumber(text, i, max, 0);
-          context.foldingColumnDiff = context.visualColumn - context.logicalColumn;
-          break;
-        }
-        else {
-          int foldedColumns = myTextRepresentationHelper.toVisualColumnSymbolsNumber(text, region.getStartOffset(), max, context.x);
-          context.logicalColumn += foldedColumns;
-          context.foldingColumnDiff -= foldedColumns;
-          if (offset >= region.getEndOffset()) {
-            context.foldingColumnDiff += region.getPlaceholderText().length();
-          }
-          return;
-        }
-      }
-    }
-
-    if (offset >= region.getEndOffset()) {
-      int foldPlaceholderColumns = region.getPlaceholderText().length();
-      context.visualColumn += foldPlaceholderColumns;
-      context.foldingColumnDiff += foldPlaceholderColumns;
-      context.x += foldPlaceholderColumns * myTextRepresentationHelper.charWidth(' ', context.x, Font.PLAIN);
-    }
-  }
-
-  /**
-   * Allows to answer how many soft wrap-introduced visual lines are located before the given offset.
-   *
-   * @param offset    target offset
-   * @return          number of soft wrap-introduced visual lines are located before the given offset
-   */
-  private int getSoftWrapIntroducedLinesBefore(int offset) {
-    int result = 0;
-    List<? extends TextChange> softWraps = myStorage.getSoftWraps();
-
-    // Calculate number of soft wrap-introduced lines before the line that holds target offset.
-    int index = myStorage.getSoftWrapIndex(offset);
-    if (index < 0) {
-      index = -index - 1;
-    }
-    int max = Math.min(index, softWraps.size());
-    for (int j = 0; j < max; j++) {
-      TextChange softWrap = softWraps.get(j);
-      if (isVisible(softWrap)) {
-        result += StringUtil.countNewLines(softWrap.getText());
-      }
-    }
-    return result;
-  }
-
-  /**
-   * Allows to answer how many folded lines are located before the logical line that contains given offset.
-   *
-   * @param offset    target offset
-   * @return          number of folded lines are located before the logical line that contains given offset.
-   */
-  private int getFoldedLinesBefore(int offset) {
-    Document document = myEditor.getDocument();
-    int line = document.getLineNumber(offset);
-    int lineStartOffset = document.getLineStartOffset(line);
-    int result = 0;
-    for (FoldRegion foldRegion : myEditor.getFoldingModel().getAllFoldRegions()) {
-      if (foldRegion.getStartOffset() >= lineStartOffset) {
-        break;
-      }
-
-      if (foldRegion.isExpanded() || !foldRegion.isValid()) {
-        continue;
-      }
-
-      int foldingStartLine = document.getLineNumber(foldRegion.getStartOffset());
-      int foldingEndLine = document.getLineNumber(foldRegion.getEndOffset());
-      result += Math.min(line, foldingEndLine) - foldingStartLine;
-    }
-    return result;
-  }
-
   private boolean isVisible(TextChange softWrap) {
     FoldingModel foldingModel = myEditor.getFoldingModel();
     int start = softWrap.getStart();
@@ -441,219 +142,345 @@ public class SoftWrapDataMapper {
     return !foldingModel.isOffsetCollapsed(start) || !foldingModel.isOffsetCollapsed(start - 1);
   }
 
-  private int toVisualColumnSymbolsNumber(char c, int x) {
-    myCharBuffer.clear();
-    myCharBuffer.put(c);
-    myCharBuffer.flip();
-    return myTextRepresentationHelper.toVisualColumnSymbolsNumber(myCharBuffer, 0, 1, x);
-  }
-
-  private class Context {
-
-    public final VisualPosition  targetVisualPosition;
-    public final int             visualLineBeforeSoftWrapAppliance;
-    public final int             softWrapLinesOnCurrentLineBeforeTargetSoftWrap;
+  private static class Context implements Cloneable {
 
     public int logicalLine;
-    public int visualLine;
-    public int softWrapLinesBefore;
-    public int targetSoftWrapLines;
-    public int softWrapColumnDiff;
     public int logicalColumn;
+    public int visualLine;
     public int visualColumn;
+    public int offset;
+    public int softWrapLinesBefore;
+    public int softWrapLinesCurrent;
+    public int softWrapColumnDiff;
     public int foldedLines;
     public int foldingColumnDiff;
     public int x;
-    public int fontType;
 
-    Context(int logicalLine, int softWrapLinesBefore, int foldedLines) {
-      this(DUMMY_VISUAL, logicalLine, softWrapLinesBefore, 0, 0, foldedLines);
+    @NotNull
+    public LogicalPosition build() {
+      return new LogicalPosition(
+        logicalLine, logicalColumn, softWrapLinesBefore, softWrapLinesCurrent, softWrapColumnDiff, foldedLines, foldingColumnDiff
+      );
     }
 
-    Context(VisualPosition targetVisualPosition, int logicalLine, int softWrapLinesBefore,
-            int softWrapLinesOnCurrentLineBeforeTargetSoftWrap, int visualLineBeforeSoftWrapAppliance, int foldedLines)
-    {
-      this.targetVisualPosition = targetVisualPosition;
-      this.softWrapLinesBefore = softWrapLinesBefore;
-      this.softWrapLinesOnCurrentLineBeforeTargetSoftWrap = softWrapLinesOnCurrentLineBeforeTargetSoftWrap;
-      this.visualLineBeforeSoftWrapAppliance = visualLineBeforeSoftWrapAppliance;
-      this.foldedLines = foldedLines;
-      this.logicalLine = logicalLine;
-      visualLine = visualLineBeforeSoftWrapAppliance + targetSoftWrapLines;
+    @Override
+    protected Context clone() {
+      Context result = new Context();
+      result.logicalLine = logicalLine;
+      result.logicalColumn = logicalColumn;
+      result.visualLine = visualLine;
+      result.visualColumn = visualColumn;
+      result.offset = offset;
+      result.softWrapLinesBefore = softWrapLinesBefore;
+      result.softWrapLinesCurrent = softWrapLinesCurrent;
+      result.softWrapColumnDiff = softWrapColumnDiff;
+      result.foldedLines = foldedLines;
+      result.foldingColumnDiff = foldingColumnDiff;
+      result.x = x;
+      return result;
     }
 
-    /**
-     * Updates current context within the soft wrap symbol.
-     *
-     * @param c   soft wrap symbol to process
-     * @return    logical position that matches target visual position if given symbol processing makes it possible to calculate it;
-     *            <code>null</code> otherwise
-     */
-    @Nullable
-    public LogicalPosition onSoftWrapSymbol(char c) {
-      // Process line feed inside soft wrap.
-      if (c == '\n') {
-        if (targetVisualPosition.line == visualLineBeforeSoftWrapAppliance + targetSoftWrapLines) {
-          softWrapColumnDiff = targetVisualPosition.column - logicalColumn;
-          return build();
+    private void onNewLine() {
+      softWrapLinesBefore += softWrapLinesCurrent;
+      softWrapLinesCurrent = 0;
+      softWrapColumnDiff = 0;
+      foldingColumnDiff = 0;
+    }
+  }
+
+  private class LogicalPositionCalculator {
+
+    public final LogicalPositionCalculatorStrategy strategy;
+
+    public Context context = new Context();
+
+    LogicalPositionCalculator(LogicalPositionCalculatorStrategy strategy) {
+      this.strategy = strategy;
+    }
+
+    @NotNull
+    public LogicalPosition calculate() {
+      FoldingProvider foldRegions = new FoldingProvider();
+      SoftWrapsProvider softWraps = new SoftWrapsProvider();
+
+      FoldRegion foldRegion = foldRegions.get();
+      TextChange softWrap = softWraps.get();
+
+      LogicalPosition result = null;
+      while (true) {
+        if (foldRegion == null && softWrap == null || strategy.exceeds(context)) {
+          return strategy.build(context);
         }
-        else {
-          x = 0;
-          softWrapColumnDiff = -logicalColumn;
-          targetSoftWrapLines++;
-          visualLine++;
-          visualColumn = 0;
-          return null;
-        }
-      }
 
-      softWrapColumnDiff++;
-
-      // Just update information about tracked symbols number if current visual line is too low.
-      if (targetVisualPosition.line > visualLineBeforeSoftWrapAppliance + targetSoftWrapLines) {
-        visualColumn += toVisualColumnSymbolsNumber(c, x);
-        x += myTextRepresentationHelper.charWidth(c, x, fontType);
-        return null;
-      }
-
-      // There is a possible case that, for example, target visual column is zero and it points to the soft-wrapped line,
-      // i.e. soft wrap are. We shouldn't count symbols then. Hence, we perform this preliminary examination with eager
-      // return if necessary.
-      if (targetVisualPosition.column <= visualColumn) {
-        return build();
-      }
-
-      // Process non-line feed inside soft wrap.
-      visualColumn++; // Don't expect tabulation to be used inside soft wrap text.
-      x += myTextRepresentationHelper.charWidth(c, x, fontType);
-
-      if (targetVisualPosition.column <= visualColumn) {
-        return build();
-      }
-      else {
-        return null;
-      }
-    }
-
-    public void beforeSoftWrap() {
-      x = 0;
-    }
-
-    public void afterSoftWrap() {
-      x += myPainter.getMinDrawingWidth(SoftWrapDrawingType.AFTER_SOFT_WRAP);
-      visualColumn++;
-      softWrapColumnDiff++;
-    }
-
-    @SuppressWarnings({"AssignmentToForLoopParameter"})
-    @Nullable
-    public LogicalPosition onCollapsedFolding(FoldRegion region) {
-      int visualFoldingPlaceholderWidth = region.getPlaceholderText().length(); // Assuming that no tabs are used as placeholder
-
-      // Process situation when target visual position points to collapsed folding placeholder.
-      if (visualLine == targetVisualPosition.line && visualColumn + visualFoldingPlaceholderWidth > targetVisualPosition.column) {
-        return build();
-      }
-
-      // If control flow reaches this point that means that we should process whole folded region and update current object state.
-      CharSequence text = myEditor.getDocument().getCharsSequence();
-      boolean multiline = false;
-      for (int i = region.getStartOffset(); i < region.getEndOffset();) {
-        int lineFeedOffset = CharArrayUtil.shiftForwardUntil(text, i, "\n");
-        // Process multiline folded text.
-        if (lineFeedOffset < region.getEndOffset()) {
-          logicalLine++;
-          foldedLines++;
-          logicalColumn = 0;
-          softWrapLinesBefore += targetSoftWrapLines;
-          targetSoftWrapLines = 0;
-          softWrapColumnDiff = 0;
-          i = lineFeedOffset + 1;
-          multiline = true;
-        }
-        else {
-          if (multiline) {
-            logicalColumn = myTextRepresentationHelper.toVisualColumnSymbolsNumber(text, i, region.getEndOffset(), 0);
+        if (foldRegion != null && softWrap != null) {
+          if (softWrap.getStart() <= foldRegion.getStartOffset()) {
+            result = process(softWrap);
+            softWrap = softWraps.get();
           }
           else {
-            logicalColumn += myTextRepresentationHelper.toVisualColumnSymbolsNumber(text, i, region.getEndOffset(), x);
+            result = process(foldRegion);
+            foldRegion = foldRegions.get();
           }
-          foldingColumnDiff = visualColumn + visualFoldingPlaceholderWidth - logicalColumn - softWrapColumnDiff;
-          i = region.getEndOffset();
+        }
+        else {
+          if (foldRegion != null) {
+            result = process(foldRegion);
+            foldRegion = foldRegions.get();
+          }
+          if (softWrap != null) {
+            result = process(softWrap);
+            softWrap = softWraps.get();
+          }
+        }
+        if (result != null) {
+          return result;
         }
       }
-
-      visualColumn += visualFoldingPlaceholderWidth;
-      x += visualFoldingPlaceholderWidth * myTextRepresentationHelper.charWidth(' ', x, Font.PLAIN);
-      if (visualLine == targetVisualPosition.line && visualColumn == targetVisualPosition.column) {
-        return build();
-      }
-      return null;
     }
 
-    /**
-     * Updates current context within the non-soft wrap symbol.
-     *
-     * @param c   soft wrap symbol to process
-     * @return    logical position that matches target visual position if given symbol processing makes it possible to calculate it;
-     *            <code>null</code> otherwise
-     */
     @Nullable
-    public LogicalPosition onNonSoftWrapSymbol(char c) {
-      // Don't expect line feed symbol to be delivered to this method in assumption that we process only one logical line here.
-      if (c == '\n') {
-        x = 0;
-        assert false;
+    private LogicalPosition process(@NotNull FoldRegion region) {
+      if (region.getStartOffset() > context.offset) {
+        Context newContext = advanceToOffset(region.getStartOffset());
+        if (strategy.exceeds(newContext)) {
+          return strategy.build(context);
+        }
+        context = newContext;
+      }
+
+      Document document = myEditor.getDocument();
+      CharSequence text = document.getCharsSequence();
+      int foldingStartLine = document.getLineNumber(region.getStartOffset());
+
+      Context afterFolding = context.clone();
+      afterFolding.logicalLine += document.getLineNumber(region.getEndOffset()) - foldingStartLine;
+      int visualColumnInc = region.getPlaceholderText().length();  // Assuming that no tabulations are used at placeholder.
+      afterFolding.visualColumn += visualColumnInc;
+
+      int i = CharArrayUtil.shiftBackwardUntil(text, region.getEndOffset() - 1, "\n");
+      // Process multi-line folding.
+      if (i >= region.getStartOffset()) {
+        int width = myTextRepresentationHelper.textWidth(text, i + 1, region.getEndOffset(), 0);
+        afterFolding.logicalColumn = myTextRepresentationHelper.toVisualColumnSymbolsNumber(width);
+        afterFolding.x = width;
+        afterFolding.softWrapLinesBefore += afterFolding.softWrapLinesCurrent;
+        afterFolding.softWrapLinesCurrent = 0;
+        afterFolding.softWrapColumnDiff = 0;
+        afterFolding.foldedLines += document.getLineNumber(region.getEndOffset()) - foldingStartLine;
+        afterFolding.foldingColumnDiff = afterFolding.visualColumn - afterFolding.logicalColumn;
+      }
+      // Process single-line folding
+      else {
+        int width = myTextRepresentationHelper.textWidth(text, region.getStartOffset(), region.getEndOffset(), context.x);
+        int logicalColumnInc = myTextRepresentationHelper.toVisualColumnSymbolsNumber(width);
+        afterFolding.logicalColumn += logicalColumnInc;
+        afterFolding.x += width;
+        afterFolding.foldingColumnDiff += visualColumnInc - logicalColumnInc;
+      }
+      afterFolding.offset = region.getEndOffset();
+
+      if (!strategy.exceeds(afterFolding)) {
+        context = afterFolding;
         return null;
       }
 
-      // Just update information about tracked symbols number if current visual line is too low.
-      if (targetVisualPosition.line > visualLine) {
-        int columnsForSymbol = toVisualColumnSymbolsNumber(c, x);
-        visualColumn += columnsForSymbol;
-        logicalColumn += columnsForSymbol;
-        x += myTextRepresentationHelper.charWidth(c, x, fontType);
-        return null;
-      }
+      return strategy.build(context, region);
+    }
 
-      // There is a possible case that, for example, target visual column is zero. We shouldn't count symbols then.
-      // Hence, we perform this preliminary examination with eager return if necessary.
-      if (targetVisualPosition.column <= visualColumn) {
-        return build();
+    @Nullable
+    private LogicalPosition process(@NotNull TextChange softWrap) {
+      Context newContext = advanceToOffset(softWrap.getStart());
+      if (strategy.exceeds(newContext)) {
+        return strategy.build(context);
       }
+      Document document = myEditor.getDocument();
+      int lastUsedLogicalLine = document.getLineNumber(context.offset);
+      context = newContext;
 
-      int columnsForSymbol = toVisualColumnSymbolsNumber(c, x);
-      int diffInColumns = targetVisualPosition.column - visualColumn;
-      int incrementToUse = columnsForSymbol;
-      if (columnsForSymbol >= diffInColumns) {
-        incrementToUse = Math.min(columnsForSymbol, diffInColumns);
-      }
-      visualColumn += incrementToUse;
-      logicalColumn += incrementToUse;
-      x += myTextRepresentationHelper.charWidth(c, x, fontType);
-
-      if (targetVisualPosition.column <= visualColumn) {
-        return build();
+      // Create context that points to the soft wrap end visual position.
+      Context afterSoftWrap = context.clone();
+      int lineFeeds = StringUtil.countNewLines(softWrap.getText());
+      afterSoftWrap.visualLine += lineFeeds;
+      afterSoftWrap.visualColumn = myEditor.getSoftWrapModel().getSoftWrapIndentWidthInColumns(softWrap);
+      afterSoftWrap.x = myEditor.getSoftWrapModel().getSoftWrapIndentWidthInPixels(softWrap);
+      if (lastUsedLogicalLine == context.logicalLine) {
+        afterSoftWrap.softWrapLinesCurrent += lineFeeds;
       }
       else {
+        afterSoftWrap.softWrapLinesBefore += context.softWrapLinesCurrent;
+        afterSoftWrap.softWrapLinesCurrent = lineFeeds;
+      }
+      afterSoftWrap.softWrapColumnDiff = afterSoftWrap.visualColumn - afterSoftWrap.logicalColumn;
+      afterSoftWrap.foldingColumnDiff = 0;
+
+      if (!strategy.exceeds(afterSoftWrap)) {
+        context = afterSoftWrap;
         return null;
       }
+      return strategy.build(context, softWrap);
     }
 
-    private LogicalPosition build() {
-      return build(foldingColumnDiff);
+    private Context advanceToOffset(int newOffset) {
+      Context result = context.clone();
+      if (result.offset == newOffset) {
+        return result;
+      }
+
+      Document document = myEditor.getDocument();
+      CharSequence text = document.getCharsSequence();
+      int lastUsedLogicalLine = document.getLineNumber(context.offset);
+      int currentLogicalLine = document.getLineNumber(newOffset);
+
+      // Update state to the offset that corresponds to the same logical line that was used last time.
+      if (currentLogicalLine == lastUsedLogicalLine) {
+        int width = myTextRepresentationHelper.textWidth(text, result.offset, newOffset, result.x);
+        int columnDiff = myTextRepresentationHelper.toVisualColumnSymbolsNumber(width);
+        result.x += width;
+        result.logicalColumn += columnDiff;
+        result.visualColumn += columnDiff;
+      }
+      // Update state to the start of the folding that doesn't belong to the same logical line that was used last time.
+      else {
+        int lineDiff = currentLogicalLine - lastUsedLogicalLine;
+        result.logicalLine += lineDiff;
+        result.visualLine += lineDiff;
+        int startLineOffset = document.getLineStartOffset(currentLogicalLine);
+        result.x = myTextRepresentationHelper.textWidth(text, startLineOffset, newOffset, result.x);
+        result.visualColumn = myTextRepresentationHelper.toVisualColumnSymbolsNumber(result.x);
+        result.logicalColumn = result.visualColumn;
+        result.onNewLine();
+      }
+      result.offset = newOffset;
+      return result;
+    }
+  }
+
+  private interface LogicalPositionCalculatorStrategy {
+    boolean exceeds(Context context);
+    @NotNull LogicalPosition build(Context context);
+    @NotNull LogicalPosition build(Context context, FoldRegion region);
+    @NotNull LogicalPosition build(Context context, TextChange softWrap);
+  }
+
+  private static class VisualPositionBasedStrategy implements LogicalPositionCalculatorStrategy {
+
+    private final VisualPosition myTargetVisual;
+
+    VisualPositionBasedStrategy(VisualPosition visual) {
+      myTargetVisual = visual;
     }
 
-    private LogicalPosition build(int foldingColumnDiff) {
-      return new LogicalPosition(
-        logicalLine,
-        logicalColumn,
-        softWrapLinesBefore,
-        softWrapLinesOnCurrentLineBeforeTargetSoftWrap  + targetSoftWrapLines,
-        softWrapColumnDiff,
-        foldedLines,
-        foldingColumnDiff
-      );
+    @Override
+    public boolean exceeds(Context context) {
+      return context.visualLine > myTargetVisual.line
+        || (context.visualLine == myTargetVisual.line && context.visualColumn > myTargetVisual.column);
+    }
+
+    @NotNull
+    @Override
+    public LogicalPosition build(Context context) {
+      if (context.visualLine == myTargetVisual.line) {
+        context.logicalColumn += myTargetVisual.column - context.visualColumn;
+        return context.build();
+      }
+      context.logicalLine += myTargetVisual.line - context.visualLine;
+      context.logicalColumn = myTargetVisual.column;
+      context.onNewLine();
+      return context.build();
+    }
+
+    @NotNull
+    @Override
+    public LogicalPosition build(Context context, FoldRegion region) {
+      // We just point to the logical position of folding region start if visual position points to collapsed fold region placeholder.
+      return context.build();
+    }
+
+    @NotNull
+    @Override
+    public LogicalPosition build(Context context, TextChange softWrap) {
+      if (myTargetVisual.line == context.visualLine) {
+        context.softWrapColumnDiff = myTargetVisual.column - context.logicalColumn - context.foldingColumnDiff;
+      }
+      else {
+        context.foldingColumnDiff = 0;
+        context.softWrapLinesCurrent += myTargetVisual.line - context.visualLine;
+        context.softWrapColumnDiff = myTargetVisual.column - context.logicalColumn;
+      }
+      return context.build();
+    }
+  }
+
+  private static class OffsetBasedStrategy implements LogicalPositionCalculatorStrategy {
+
+    private final EditorTextRepresentationHelper myRepresentationHelper;
+    private final Document                       myDocument;
+
+    private final int myOffset;
+
+    OffsetBasedStrategy(EditorTextRepresentationHelper representationHelper, Document document, int offset) {
+      myRepresentationHelper = representationHelper;
+      myDocument = document;
+      myOffset = offset;
+    }
+
+    @Override
+    public boolean exceeds(Context context) {
+      return context.offset > myOffset;
+    }
+
+    @NotNull
+    @Override
+    public LogicalPosition build(Context context) {
+      int targetLogicalLine = myDocument.getLineNumber(myOffset);
+      if (targetLogicalLine == context.logicalLine) {
+        context.logicalColumn
+          += myRepresentationHelper.toVisualColumnSymbolsNumber(myDocument.getCharsSequence(), context.offset, myOffset, context.x);
+        return context.build();
+      }
+      context.logicalLine = targetLogicalLine;
+      int i = CharArrayUtil.shiftBackwardUntil(myDocument.getCharsSequence(), myOffset - 1, "\n");
+      if (i >= context.offset) {
+        context.logicalColumn = myRepresentationHelper.toVisualColumnSymbolsNumber(myDocument.getCharsSequence(), i + 1, myOffset, 0);
+      }
+      else {
+        context.logicalColumn
+          = myRepresentationHelper.toVisualColumnSymbolsNumber(myDocument.getCharsSequence(), context.offset, myOffset, context.x);
+      }
+      context.onNewLine();
+      return context.build();
+    }
+
+    @NotNull
+    @Override
+    public LogicalPosition build(Context context, FoldRegion region) {
+      // We want to return logical position that corresponds to the visual start of the given folding region.
+      int startLine = myDocument.getLineNumber(region.getStartOffset());
+      int endLine = myDocument.getLineNumber(myOffset);
+      int lineFeeds = endLine - startLine;
+
+      if (lineFeeds > 0) {
+        context.logicalLine += lineFeeds;
+        context.foldedLines += lineFeeds;
+        context.onNewLine();
+        int i = CharArrayUtil.shiftBackwardUntil(myDocument.getCharsSequence(), myOffset - 1, "\n");
+        context.logicalColumn = myRepresentationHelper.toVisualColumnSymbolsNumber(myDocument.getCharsSequence(), i + 1, myOffset, 0);
+        context.foldingColumnDiff = context.visualColumn - context.logicalColumn;
+      }
+      else {
+        int logicalColumns
+          = myRepresentationHelper.toVisualColumnSymbolsNumber(myDocument.getCharsSequence(), region.getStartOffset(), myOffset, context.x);
+        context.logicalColumn += logicalColumns;
+        context.foldingColumnDiff -= logicalColumns;
+      }
+      return context.build();
+    }
+
+    @NotNull
+    @Override
+    public LogicalPosition build(Context context, TextChange softWrap) {
+      assert false; // Don't expect soft wrap do affect offset-based mapping request.
+      return new LogicalPosition(0, 0);
     }
   }
 
@@ -662,41 +489,89 @@ public class SoftWrapDataMapper {
    * <p/>
    * It's primary purpose is to relief unit testing.
    */
-  interface FontTypeProvider {
-    void init(int start);
-    int getFontType(int offset);
-    void cleanup();
+  //interface FontTypeProvider {
+  //  void init(int start);
+  //  int getFontType(int offset);
+  //  void cleanup();
+  //}
+
+  //private static class IterationStateFontTypeProvider implements FontTypeProvider {
+  //
+  //  private final EditorEx myEditor;
+  //
+  //  private IterationState myState;
+  //  private int            myFontType;
+  //
+  //  private IterationStateFontTypeProvider(EditorEx editor) {
+  //    myEditor = editor;
+  //  }
+  //
+  //  @Override
+  //  public void init(int start) {
+  //    myState = new IterationState(myEditor, start, false);
+  //    myFontType = myState.getMergedAttributes().getFontType();
+  //  }
+  //
+  //  @Override
+  //  public int getFontType(int offset) {
+  //    if (offset >= myState.getEndOffset()) {
+  //      myState.advance();
+  //      myFontType = myState.getMergedAttributes().getFontType();
+  //    }
+  //    return myFontType;
+  //  }
+  //
+  //  @Override
+  //  public void cleanup() {
+  //    myState = null;
+  //  }
+  //}
+
+  private class SoftWrapsProvider {
+
+    private final List<? extends TextChange> mySoftWraps;
+    private int myIndex;
+
+    SoftWrapsProvider() {
+      mySoftWraps = myStorage.getSoftWraps();
+    }
+
+    @Nullable
+    public TextChange get() {
+      if (myIndex < 0 || myIndex >= mySoftWraps.size()) {
+        return null;
+      }
+      TextChange result = mySoftWraps.get(myIndex++);
+      if (isVisible(result)) {
+        return result;
+      }
+      else {
+        return get();
+      }
+    }
   }
 
-  private static class IterationStateFontTypeProvider implements FontTypeProvider {
+  private class FoldingProvider {
 
-    private final EditorEx myEditor;
+    private final FoldRegion[] myFoldRegions;
+    private int myIndex;
 
-    private IterationState myState;
-    private int            myFontType;
-
-    private IterationStateFontTypeProvider(EditorEx editor) {
-      myEditor = editor;
+    FoldingProvider() {
+      myFoldRegions = myEditor.getFoldingModel().fetchTopLevel();
     }
 
-    @Override
-    public void init(int start) {
-      myState = new IterationState(myEditor, start, false);
-      myFontType = myState.getMergedAttributes().getFontType();
-    }
-
-    @Override
-    public int getFontType(int offset) {
-      if (offset >= myState.getEndOffset()) {
-        myState.advance();
-        myFontType = myState.getMergedAttributes().getFontType();
+    @Nullable
+    public FoldRegion get() {
+      if (myFoldRegions == null || myIndex < 0 || myIndex >= myFoldRegions.length) {
+        return null;
+      }
+      FoldRegion result = myFoldRegions[myIndex++];
+      if (result.isExpanded()) {
+        return get();
+      }
+      else {
+        return result;
       }
-      return myFontType;
-    }
-
-    @Override
-    public void cleanup() {
-      myState = null;
     }
   }
 }
diff --git a/platform/platform-impl/testSrc/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapperTest.java b/platform/platform-impl/testSrc/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapperTest.java
index b65c3c88755c..39b69460cdaa 100644
--- a/platform/platform-impl/testSrc/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapperTest.java
+++ b/platform/platform-impl/testSrc/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapperTest.java
@@ -3,10 +3,13 @@ package com.intellij.openapi.editor.impl.softwrap;
 import com.intellij.mock.MockFoldRegion;
 import com.intellij.openapi.editor.*;
 import com.intellij.openapi.editor.ex.EditorEx;
+import com.intellij.openapi.editor.ex.FoldingModelEx;
+import com.intellij.openapi.editor.ex.SoftWrapModelEx;
 import com.intellij.openapi.editor.impl.EditorTextRepresentationHelper;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.TextRange;
 import gnu.trove.TIntHashSet;
+import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 import org.jmock.Expectations;
 import org.jmock.Mockery;
@@ -18,7 +21,6 @@ import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 
-import java.awt.*;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
@@ -88,7 +90,8 @@ public class SoftWrapDataMapperTest {
   private EditorEx                           myEditor;
   private Document                           myDocument;
   private SoftWrapsStorage                   myStorage;
-  private FoldingModel                       myFoldingModel;
+  private SoftWrapModelEx                    mySoftWrapModel;
+  private FoldingModelEx                     myFoldingModel;
   private MockEditorTextRepresentationHelper myRepresentationHelper;
     
   @Before
@@ -100,7 +103,8 @@ public class SoftWrapDataMapperTest {
     myEditor = myMockery.mock(EditorEx.class);
     myDocument = myMockery.mock(Document.class);
     myStorage = new SoftWrapsStorage();
-    myFoldingModel = myMockery.mock(FoldingModel.class);
+    mySoftWrapModel = myMockery.mock(SoftWrapModelEx.class);
+    myFoldingModel = myMockery.mock(FoldingModelEx.class);
     final EditorSettings settings = myMockery.mock(EditorSettings.class);
     final Project project = myMockery.mock(Project.class);
     final SoftWrapPainter painter = myMockery.mock(SoftWrapPainter.class);
@@ -140,6 +144,23 @@ public class SoftWrapDataMapperTest {
       allowing(settings).isWhitespacesShown();will(returnValue(true));
       allowing(myEditor).getProject();will(returnValue(project));
 
+      // Soft wraps.
+      allowing(myEditor).getSoftWrapModel(); will(returnValue(mySoftWrapModel));
+      allowing(mySoftWrapModel).getSoftWrapIndentWidthInColumns(with(any(TextChange.class)));
+      will(new CustomAction("getSoftWrapIndentWidthInColumns") {
+        @Override
+        public Object invoke(Invocation invocation) throws Throwable {
+          return getSoftWrapIndentWidthInColumns((TextChange)invocation.getParameter(0));
+        }
+      });
+      allowing(mySoftWrapModel).getSoftWrapIndentWidthInPixels(with(any(TextChange.class)));
+      will(new CustomAction("getSoftWrapIndentWidthInPixels") {
+        @Override
+        public Object invoke(Invocation invocation) throws Throwable {
+          return getSoftWrapIndentWidthInPixels((TextChange)invocation.getParameter(0));
+        }
+      });
+
       // Folding.
       allowing(myEditor).getFoldingModel();will(returnValue(myFoldingModel));
       allowing(myFoldingModel).isOffsetCollapsed(with(any(int.class))); will(new CustomAction("isOffsetCollapsed()") {
@@ -155,7 +176,7 @@ public class SoftWrapDataMapperTest {
           return getCollapsedFoldRegion((Integer)invocation.getParameter(0));
         }
       });
-      allowing(myFoldingModel).getAllFoldRegions(); will(new CustomAction("getAllFoldRegions()") {
+      allowing(myFoldingModel).fetchTopLevel(); will(new CustomAction("fetchTopLevel()") {
         @Override
         public Object invoke(Invocation invocation) throws Throwable {
           return myFoldRegions.toArray(new FoldRegion[myFoldRegions.size()]);
@@ -188,7 +209,7 @@ public class SoftWrapDataMapperTest {
 
     myRepresentationHelper = new MockEditorTextRepresentationHelper();
 
-    myAdjuster = new SoftWrapDataMapper(myEditor, myStorage, painter, myRepresentationHelper, new MockFontTypeProvider());
+    myAdjuster = new SoftWrapDataMapper(myEditor, myStorage, myRepresentationHelper/*, new MockFontTypeProvider()*/);
   }
   
   @After
@@ -196,6 +217,16 @@ public class SoftWrapDataMapperTest {
     myMockery.assertIsSatisfied();
   }
 
+  @Test
+  public void noSoftWrapsAndFolding() {
+    String document =
+      "class Test { \n" +
+      "  public void foo() {}  \n" +
+      "  \n" +
+      "}";
+    test(document);
+  }
+
   @Test
   public void softWrapHasSymbolBeforeFirstLineFeed() {
     String document =
@@ -216,13 +247,13 @@ public class SoftWrapDataMapperTest {
     String document =
       "public class Test {\n" +
       "  public void foo(int[] data) {\n" +
-      "    bar(data[0], data[1], <WRAP>\n" +
-      "       </WRAP>data[2], data[3], <WRAP> \n" +
-      "       </WRAP>data[4], data[5],     \n" +
-      "       data[6], data[7], \n" +
-      "       data[8], data[9], <WRAP>\n" +
-      "       </WRAP>data[10], data[11], <WRAP> \n" +
-      "       </WRAP>data[12], data[13]);     \n" +
+      "    bar(data[0], <WRAP>\n" +
+      "       </WRAP>data[1] <WRAP> \n" +
+      "       </WRAP>data[2]     \n" +
+      "       data[3], \n" +
+      "       data[4], <WRAP>\n" +
+      "       </WRAP>data[5] <WRAP> \n" +
+      "       </WRAP>data[6]);     \n" +
       "  }\n" +
       "  public void bar(int ... i) {\n" +
       "  }\n" +
@@ -345,6 +376,34 @@ public class SoftWrapDataMapperTest {
     test(document);
   }
 
+  private static int getSoftWrapIndentWidthInColumns(TextChange softWrap) {
+    int result = 0;
+    CharSequence text = softWrap.getText();
+    for (int i = text.length() - 1; i >= 0; i--) {
+      if (text.charAt(i) == '\n') {
+        break;
+      }
+      result++;
+    }
+    if (SOFT_WRAP_DRAWING_WIDTH > 0) {
+      result++;
+    }
+    return result;
+  }
+
+  private int getSoftWrapIndentWidthInPixels(TextChange softWrap) {
+    int result = 0;
+    CharSequence text = softWrap.getText();
+    for (int i = text.length() - 1; i >= 0; i--) {
+      if (text.charAt(i) == '\n') {
+        break;
+      }
+      result += myRepresentationHelper.textWidth(text, i, i + 1, 0);
+    }
+    result += SOFT_WRAP_DRAWING_WIDTH;
+    return result;
+  }
+
   private int getLineNumber(int offset) {
     int line = 0;
     for (TextRange range : myLineRanges) {
@@ -430,10 +489,12 @@ public class SoftWrapDataMapperTest {
     for (DataEntry data : myExpectedData) {
 
       // Check logical by visual.
-      LogicalPosition actualLogicalByVisual = myAdjuster.adjustLogicalPosition(toSoftWrapUnawareLogicalByVisual(data), data.visual);
+      LogicalPosition actualLogicalByVisual = myAdjuster.visualToLogical(data.visual);
       // We don't want to perform the check for logical positions that correspond to the folded space because all of them relate to
       // the same logical position of the folding start.
       if (!data.foldedSpace && !data.insideTab && !equals(data.logical, actualLogicalByVisual)) {
+        //TODO den remove
+        myAdjuster.visualToLogical(data.visual);
         throw new AssertionError(
           String.format("Detected unmatched logical position by visual (%s). Expected: '%s', actual: '%s'. Calculation was performed "
                         + "against soft wrap-unaware logical: '%s'",
@@ -446,6 +507,8 @@ public class SoftWrapDataMapperTest {
       // We don't to perform the check for the data that points to soft wrap location here. The reason is that it shares offset
       // with the first document symbol after soft wrap, hence, examination always fails.
       if (!data.virtualSpace && !data.insideTab && !equals(data.logical, actualLogicalByOffset)) {
+        //TODO den remove
+        myAdjuster.offsetToLogicalPosition(data.offset);
         throw new AssertionError(
           String.format("Detected unmatched logical position by offset. Expected: '%s', actual: '%s'. Calculation was performed "
                         + "against offset: '%d' and soft wrap-unaware logical: '%s'",
@@ -635,7 +698,7 @@ public class SoftWrapDataMapperTest {
         }
         else if (c == '\t') {
           int tabWidthInColumns = myRepresentationHelper.toVisualColumnSymbolsNumber(c, x);
-          x += myRepresentationHelper.charWidth(c, x, Font.PLAIN);
+          x += MockEditorTextRepresentationHelper.charWidth(c, x);
 
           // There is a possible case that single tabulation symbols is shown in more than one visual column at IntelliJ editor.
           // We store data entry only for the first tab column without 'inside tab' flag then.
@@ -652,7 +715,7 @@ public class SoftWrapDataMapperTest {
         } else {
           logicalColumn++;
           offset++;
-          x += myRepresentationHelper.charWidth(c, x, Font.PLAIN);
+          x += MockEditorTextRepresentationHelper.charWidth(c, x);
           foldingColumnDiff--;
         }
         return;
@@ -685,7 +748,7 @@ public class SoftWrapDataMapperTest {
           visualColumn++;
           softWrapColumnDiff++;
           softWrapSymbolsOnCurrentVisualLine++;
-          x += myRepresentationHelper.charWidth(c, x, Font.PLAIN);
+          x += MockEditorTextRepresentationHelper.charWidth(c, x);
         }
         return;
       }
@@ -706,7 +769,7 @@ public class SoftWrapDataMapperTest {
       }
       else if (c == '\t') {
         int tabWidthInColumns = myRepresentationHelper.toVisualColumnSymbolsNumber(c, x);
-        x += myRepresentationHelper.charWidth(c, x, Font.PLAIN);
+        x += MockEditorTextRepresentationHelper.charWidth(c, x);
 
         // There is a possible case that single tabulation symbols is shown in more than one visual column at IntelliJ editor.
         // We store data entry only for the first tab column without 'inside tab' flag then.
@@ -726,7 +789,7 @@ public class SoftWrapDataMapperTest {
         visualColumn++;
         logicalColumn++;
         offset++;
-        x += myRepresentationHelper.charWidth(c, x, Font.PLAIN);
+        x += MockEditorTextRepresentationHelper.charWidth(c, x);
       }
     }
 
@@ -782,10 +845,10 @@ public class SoftWrapDataMapperTest {
     }
 
     @Override
-    public int toVisualColumnSymbolsNumber(CharSequence text, int start, int end, int x) {
+    public int toVisualColumnSymbolsNumber(@NotNull CharSequence text, int start, int end, int x) {
       int result = 0;
       for (int i = start; i < end; i++) {
-        int width = charWidth(text.charAt(i), x, Font.PLAIN);
+        int width = charWidth(text.charAt(i), x);
         result += width / SPACE_SIZE;
         if (width % SPACE_SIZE > 0) {
           result++;
@@ -796,7 +859,28 @@ public class SoftWrapDataMapperTest {
     }
 
     @Override
-    public int charWidth(char c, int x, int fontType) {
+    public int toVisualColumnSymbolsNumber(int width) {
+      int result = width / SPACE_SIZE;
+      if (width % SPACE_SIZE > 0) {
+        result++;
+      }
+      return result;
+    }
+
+    @Override
+    public int textWidth(@NotNull CharSequence text, int start, int end, int x) {
+      int result = 0;
+      for (int i = start; i < end; i++) {
+        char c = text.charAt(i);
+        switch (c) {
+          case '\n': result = 0; break;
+          default: result += charWidth(c, result);
+        }
+      }
+      return result;
+    }
+
+    public static int charWidth(char c, int x) {
       if (c == '\t') {
         int tabWidth = SPACE_SIZE * TAB_SIZE;
         int tabsNumber = x / tabWidth;
@@ -808,18 +892,18 @@ public class SoftWrapDataMapperTest {
     }
   }
 
-  private static class MockFontTypeProvider implements SoftWrapDataMapper.FontTypeProvider {
-    @Override
-    public void init(int start) {
-    }
-
-    @Override
-    public int getFontType(int offset) {
-      return Font.PLAIN;
-    }
-
-    @Override
-    public void cleanup() {
-    }
-  }
+  //private static class MockFontTypeProvider implements SoftWrapDataMapper.FontTypeProvider {
+  //  @Override
+  //  public void init(int start) {
+  //  }
+  //
+  //  @Override
+  //  public int getFontType(int offset) {
+  //    return Font.PLAIN;
+  //  }
+  //
+  //  @Override
+  //  public void cleanup() {
+  //  }
+  //}
 }
diff --git a/platform/util/src/com/intellij/openapi/util/text/StringUtil.java b/platform/util/src/com/intellij/openapi/util/text/StringUtil.java
index fe4299e6e766..119a720c0803 100644
--- a/platform/util/src/com/intellij/openapi/util/text/StringUtil.java
+++ b/platform/util/src/com/intellij/openapi/util/text/StringUtil.java
@@ -1236,6 +1236,20 @@ public class StringUtil {
     return i;
   }
 
+  /**
+   * Allows to answer if target symbol is contained at given char sequence at <code>[start; end)</code> interval.
+   *
+   * @param s       target char sequence to check
+   * @param start   start offset to use within the given char sequence (inclusive)
+   * @param end     end offset to use within the given char sequence (exclusive)
+   * @param c       target symbol to check
+   * @return        <code>true</code> if given symbol is contained at the target range of the given char sequence;
+   *                <code>false</code> otherwise
+   */
+  public static boolean contains(CharSequence s, int start, int end, char c) {
+    return indexOf(s, c, start, end) >= 0;
+  }
+
   public static int indexOf(@NotNull CharSequence s, char c) {
     return indexOf(s, c, 0, s.length());
   }

From 2195a2f451cc91b033ffbf880ec6f648178009ed Mon Sep 17 00:00:00 2001
From: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Date: Mon, 2 Aug 2010 18:41:15 +0400
Subject: [PATCH 16/42] git4idea: Added possiblity to disable git branch widget

---
 plugins/git4idea/src/git4idea/GitVcs.java     |  14 ++
 .../branches/GitBranchConfigurations.java     |  93 +++++++--
 .../src/git4idea/config/GitVcsPanel.form      | 183 +++++++++++-------
 .../src/git4idea/config/GitVcsPanel.java      |  11 +-
 4 files changed, 215 insertions(+), 86 deletions(-)

diff --git a/plugins/git4idea/src/git4idea/GitVcs.java b/plugins/git4idea/src/git4idea/GitVcs.java
index e4fffdff6da5..4f69c496b5c5 100644
--- a/plugins/git4idea/src/git4idea/GitVcs.java
+++ b/plugins/git4idea/src/git4idea/GitVcs.java
@@ -207,6 +207,11 @@ public class GitVcs extends AbstractVcs<CommittedChangeList> {
    * The reference tracker
    */
   private GitReferenceTracker myReferenceTracker;
+  /**
+   * If true, the vcs was activated
+   */
+  private boolean isActivated;
+
 
   public static GitVcs getInstance(@NotNull Project project) {
     return (GitVcs)ProjectLevelVcsManager.getInstance(project).findVcsByName(NAME);
@@ -496,6 +501,7 @@ public class GitVcs extends AbstractVcs<CommittedChangeList> {
    */
   @Override
   protected void activate() {
+    isActivated = true;
     if (!myProject.isDefault() && myRootTracker == null) {
       myRootTracker = new GitRootTracker(this, myProject, myRootListeners.getMulticaster());
     }
@@ -519,6 +525,7 @@ public class GitVcs extends AbstractVcs<CommittedChangeList> {
    */
   @Override
   protected void deactivate() {
+    isActivated = false;
     GitBranchConfigurations.getInstance(myProject).deactivate();
     if (myRootTracker != null) {
       myRootTracker.dispose();
@@ -768,4 +775,11 @@ public class GitVcs extends AbstractVcs<CommittedChangeList> {
     final VirtualFile vcsRoot = GitUtil.getGitRoot(file);
     return GitChangeUtils.getRevisionChanges(project, vcsRoot, revision.getRevisionNumber().asString(), false);
   }
+
+  /**
+   * @return true if vcs was activated
+   */
+  public boolean isActivated() {
+    return isActivated;
+  }
 }
diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchConfigurations.java b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchConfigurations.java
index 35cdcb832a12..ef2bc44d9d85 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchConfigurations.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchConfigurations.java
@@ -49,6 +49,7 @@ import git4idea.vfs.GitReferenceListener;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
+import javax.swing.*;
 import java.util.*;
 
 /**
@@ -147,6 +148,10 @@ public class GitBranchConfigurations implements PersistentStateComponent<GitBran
    * Listener for changes
    */
   private final ChangeListAdapter myChangesListener;
+  /**
+   * If true, the widget is enabled
+   */
+  private boolean myWidgetEnabled = true;
 
   /**
    * The constructor used to dependency injection
@@ -268,8 +273,20 @@ public class GitBranchConfigurations implements PersistentStateComponent<GitBran
       }
       referencesChanged();
     }
+    if (isWidgetEnabled()) {
+      installWidget();
+    }
+  }
+
+  /**
+   * Install widget
+   */
+  private void installWidget() {
     if (!ApplicationManager.getApplication().isHeadlessEnvironment()) {
-      myWidgetUninstall = GitBranchesWidget.install(myProject, this);
+      final Runnable r = GitBranchesWidget.install(myProject, this);
+      synchronized (myStateLock) {
+        myWidgetUninstall = r;
+      }
     }
   }
 
@@ -279,10 +296,18 @@ public class GitBranchConfigurations implements PersistentStateComponent<GitBran
   public void deactivate() {
     myVcs.removeGitReferenceListener(myReferenceListener);
     myChangeManager.removeChangeListListener(myChangesListener);
-    if (myWidgetUninstall != null) {
-      myWidgetUninstall.run();
+    uninstallWidget();
+  }
+
+  private void uninstallWidget() {
+    final Runnable r;
+    synchronized (myStateLock) {
+      r = myWidgetUninstall;
       myWidgetUninstall = null;
     }
+    if (r != null) {
+      r.run();
+    }
   }
 
   /**
@@ -310,6 +335,7 @@ public class GitBranchConfigurations implements PersistentStateComponent<GitBran
   public State getState() {
     synchronized (myStateLock) {
       State rc = new State();
+      rc.IS_WIDGET_ENABLED = myWidgetEnabled;
       rc.CURRENT = myCurrentConfiguration == null ? null : myCurrentConfiguration.getName();
       ArrayList<BranchConfiguration> cs = new ArrayList<BranchConfiguration>(myConfigurations.size());
       for (GitBranchConfiguration ci : myConfigurations.values()) {
@@ -363,9 +389,54 @@ public class GitBranchConfigurations implements PersistentStateComponent<GitBran
       }
       fireCurrentConfigurationChanged();
       fireConfigurationsChanged();
+      if (state.IS_WIDGET_ENABLED != myWidgetEnabled) {
+        myWidgetEnabled = state.IS_WIDGET_ENABLED;
+        updateWidgetState();
+      }
     }
   }
 
+  /**
+   * Update widget state after update
+   */
+  private void updateWidgetState() {
+    SwingUtilities.invokeLater(new Runnable() {
+      @Override
+      public void run() {
+        if (isWidgetEnabled()) {
+          if (myVcs.isActivated() && myWidgetUninstall == null) {
+            installWidget();
+          }
+        }
+        else {
+          uninstallWidget();
+        }
+      }
+    });
+  }
+
+  /**
+   * @return true if widget is enabled
+   */
+  public boolean isWidgetEnabled() {
+    synchronized (myStateLock) {
+      return myWidgetEnabled;
+    }
+  }
+
+  /**
+   * Update widget state
+   *
+   * @param value true to enable widget
+   */
+  public void setWidgetEnabled(boolean value) {
+    synchronized (myStateLock) {
+      myWidgetEnabled = value;
+      updateWidgetState();
+    }
+  }
+
+
   /**
    * @return the candidate remote configurations
    */
@@ -632,18 +703,6 @@ public class GitBranchConfigurations implements PersistentStateComponent<GitBran
     return myStateLock;
   }
 
-  /**
-   * Check if configuration with specified name already exists
-   *
-   * @param name the name to check
-   * @return true if the configuration exists
-   */
-  boolean hasConfigurationName(String name) {
-    synchronized (myStateLock) {
-      return myConfigurations.containsKey(name);
-    }
-  }
-
   /**
    * Set current configuration
    *
@@ -765,6 +824,10 @@ public class GitBranchConfigurations implements PersistentStateComponent<GitBran
    * The configuration state
    */
   public static class State {
+    /**
+     * If true, branches widget is enabled
+     */
+    public boolean IS_WIDGET_ENABLED = true;
     /**
      * The current configuration
      */
diff --git a/plugins/git4idea/src/git4idea/config/GitVcsPanel.form b/plugins/git4idea/src/git4idea/config/GitVcsPanel.form
index d134d7bb3804..fdfdc001fb15 100644
--- a/plugins/git4idea/src/git4idea/config/GitVcsPanel.form
+++ b/plugins/git4idea/src/git4idea/config/GitVcsPanel.form
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <form xmlns="http://www.intellij.com/uidesigner/form/" version="1" bind-to-class="git4idea.config.GitVcsPanel">
-  <grid id="27dc6" binding="myPanel" layout-manager="GridLayoutManager" row-count="6" column-count="2" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
+  <grid id="27dc6" binding="myPanel" layout-manager="GridLayoutManager" row-count="4" column-count="1" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
     <margin top="0" left="0" bottom="0" right="0"/>
     <constraints>
       <xy x="20" y="20" width="500" height="400"/>
@@ -10,107 +10,150 @@
     </properties>
     <border type="none"/>
     <children>
-      <component id="b1a9d" class="javax.swing.JLabel">
-        <constraints>
-          <grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
-        </constraints>
-        <properties>
-          <text resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.path.label"/>
-          <verifyInputWhenFocusTarget value="false"/>
-        </properties>
-      </component>
-      <component id="25af7" class="com.intellij.openapi.ui.TextFieldWithBrowseButton" binding="myGitField">
-        <constraints>
-          <grid row="0" column="1" row-span="1" col-span="1" vsize-policy="3" hsize-policy="7" anchor="0" fill="1" indent="0" use-parent-layout="false"/>
-        </constraints>
-        <properties/>
-      </component>
-      <vspacer id="4c83d">
-        <constraints>
-          <grid row="5" column="1" row-span="1" col-span="1" vsize-policy="6" hsize-policy="1" anchor="0" fill="2" indent="0" use-parent-layout="false"/>
-        </constraints>
-      </vspacer>
-      <component id="563b2" class="javax.swing.JButton" binding="myTestButton">
-        <constraints>
-          <grid row="1" column="1" row-span="1" col-span="1" vsize-policy="2" hsize-policy="0" anchor="4" fill="0" indent="0" use-parent-layout="false"/>
-        </constraints>
-        <properties>
-          <horizontalAlignment value="0"/>
-          <label resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.test.label"/>
-          <text resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.test"/>
-        </properties>
-      </component>
-      <component id="5a909" class="javax.swing.JLabel">
-        <constraints>
-          <grid row="2" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
-        </constraints>
-        <properties>
-          <labelFor value="f5de9"/>
-          <text resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.ssh.mode"/>
-        </properties>
-      </component>
-      <grid id="97c7d" layout-manager="GridLayoutManager" row-count="1" column-count="2" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
+      <grid id="b95e2" layout-manager="GridLayoutManager" row-count="1" column-count="2" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
         <margin top="0" left="0" bottom="0" right="0"/>
         <constraints>
-          <grid row="2" column="1" row-span="1" col-span="1" vsize-policy="3" hsize-policy="3" anchor="0" fill="3" indent="0" use-parent-layout="false"/>
+          <grid row="2" column="0" row-span="1" col-span="1" vsize-policy="3" hsize-policy="3" anchor="0" fill="3" indent="0" use-parent-layout="false"/>
         </constraints>
         <properties/>
-        <border type="none"/>
+        <border type="etched" title="Interface Options">
+          <font/>
+        </border>
         <children>
-          <component id="f5de9" class="javax.swing.JComboBox" binding="mySSHExecutableComboBox" default-binding="true">
+          <component id="26b57" class="javax.swing.JCheckBox" binding="myEnableBranchesWidgetCheckBox" default-binding="true">
             <constraints>
-              <grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="2" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
+              <grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
             </constraints>
+            <properties>
+              <selected value="true"/>
+              <text value="Enable &amp;branches widget"/>
+              <toolTipText value="Enables status widget in status bar"/>
+            </properties>
           </component>
-          <hspacer id="9eafb">
+          <hspacer id="a6134">
             <constraints>
               <grid row="0" column="1" row-span="1" col-span="1" vsize-policy="1" hsize-policy="6" anchor="0" fill="1" indent="0" use-parent-layout="false"/>
             </constraints>
           </hspacer>
         </children>
       </grid>
-      <component id="a6d8e" class="javax.swing.JLabel">
-        <constraints>
-          <grid row="3" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
-        </constraints>
-        <properties>
-          <labelFor value="7a626"/>
-          <text resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.convert.crlf"/>
-        </properties>
-      </component>
-      <grid id="a4472" layout-manager="GridLayoutManager" row-count="1" column-count="2" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
+      <grid id="e7668" layout-manager="GridLayoutManager" row-count="2" column-count="3" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
         <margin top="0" left="0" bottom="0" right="0"/>
         <constraints>
-          <grid row="3" column="1" row-span="1" col-span="1" vsize-policy="3" hsize-policy="3" anchor="0" fill="3" indent="0" use-parent-layout="false"/>
+          <grid row="1" column="0" row-span="1" col-span="1" vsize-policy="3" hsize-policy="3" anchor="0" fill="3" indent="0" use-parent-layout="false"/>
         </constraints>
         <properties/>
-        <border type="none"/>
+        <border type="etched" title="File Conversion"/>
         <children>
+          <component id="a6d8e" class="javax.swing.JLabel">
+            <constraints>
+              <grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
+            </constraints>
+            <properties>
+              <labelFor value="7a626"/>
+              <text resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.convert.crlf"/>
+            </properties>
+          </component>
+          <hspacer id="9e883">
+            <constraints>
+              <grid row="0" column="2" row-span="1" col-span="1" vsize-policy="1" hsize-policy="6" anchor="0" fill="1" indent="0" use-parent-layout="false"/>
+            </constraints>
+          </hspacer>
+          <vspacer id="8bedb">
+            <constraints>
+              <grid row="1" column="0" row-span="1" col-span="1" vsize-policy="6" hsize-policy="1" anchor="0" fill="2" indent="0" use-parent-layout="false"/>
+            </constraints>
+          </vspacer>
           <component id="7a626" class="javax.swing.JComboBox" binding="myConvertTextFilesComboBox" default-binding="true">
             <constraints>
-              <grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="2" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
+              <grid row="0" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="2" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
             </constraints>
             <properties>
               <toolTipText resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.convert.tooltip"/>
             </properties>
           </component>
-          <hspacer id="3c6b8">
+          <component id="a8818" class="javax.swing.JCheckBox" binding="myAskBeforeConversionsCheckBox" default-binding="true">
             <constraints>
-              <grid row="0" column="1" row-span="1" col-span="1" vsize-policy="1" hsize-policy="6" anchor="0" fill="1" indent="0" use-parent-layout="false"/>
+              <grid row="1" column="1" row-span="1" col-span="2" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
             </constraints>
-          </hspacer>
+            <properties>
+              <selected value="true"/>
+              <text resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.convert.ask"/>
+              <toolTipText resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.convert.ask.tooltip"/>
+            </properties>
+          </component>
         </children>
       </grid>
-      <component id="a8818" class="javax.swing.JCheckBox" binding="myAskBeforeConversionsCheckBox" default-binding="true">
+      <grid id="c9e6b" layout-manager="GridLayoutManager" row-count="3" column-count="2" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
+        <margin top="0" left="0" bottom="0" right="0"/>
         <constraints>
-          <grid row="4" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
+          <grid row="0" column="0" row-span="1" col-span="1" vsize-policy="3" hsize-policy="3" anchor="0" fill="3" indent="0" use-parent-layout="false"/>
         </constraints>
-        <properties>
-          <selected value="true"/>
-          <text resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.convert.ask"/>
-          <toolTipText resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.convert.ask.tooltip"/>
-        </properties>
-      </component>
+        <properties/>
+        <border type="etched" title="Git"/>
+        <children>
+          <component id="b1a9d" class="javax.swing.JLabel">
+            <constraints>
+              <grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
+            </constraints>
+            <properties>
+              <text resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.path.label"/>
+              <verifyInputWhenFocusTarget value="false"/>
+            </properties>
+          </component>
+          <component id="25af7" class="com.intellij.openapi.ui.TextFieldWithBrowseButton" binding="myGitField">
+            <constraints>
+              <grid row="0" column="1" row-span="1" col-span="1" vsize-policy="3" hsize-policy="7" anchor="0" fill="1" indent="0" use-parent-layout="false"/>
+            </constraints>
+            <properties/>
+          </component>
+          <component id="563b2" class="javax.swing.JButton" binding="myTestButton">
+            <constraints>
+              <grid row="1" column="1" row-span="1" col-span="1" vsize-policy="2" hsize-policy="0" anchor="4" fill="0" indent="0" use-parent-layout="false"/>
+            </constraints>
+            <properties>
+              <horizontalAlignment value="0"/>
+              <label resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.test.label"/>
+              <text resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.test"/>
+            </properties>
+          </component>
+          <component id="5a909" class="javax.swing.JLabel">
+            <constraints>
+              <grid row="2" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
+            </constraints>
+            <properties>
+              <labelFor value="f5de9"/>
+              <text resource-bundle="git4idea/i18n/GitBundle" key="git.vcs.config.ssh.mode"/>
+            </properties>
+          </component>
+          <grid id="97c7d" layout-manager="GridLayoutManager" row-count="1" column-count="2" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
+            <margin top="0" left="0" bottom="0" right="0"/>
+            <constraints>
+              <grid row="2" column="1" row-span="1" col-span="1" vsize-policy="3" hsize-policy="3" anchor="0" fill="3" indent="0" use-parent-layout="false"/>
+            </constraints>
+            <properties/>
+            <border type="none"/>
+            <children>
+              <hspacer id="9eafb">
+                <constraints>
+                  <grid row="0" column="1" row-span="1" col-span="1" vsize-policy="1" hsize-policy="6" anchor="0" fill="1" indent="0" use-parent-layout="false"/>
+                </constraints>
+              </hspacer>
+              <component id="f5de9" class="javax.swing.JComboBox" binding="mySSHExecutableComboBox" default-binding="true">
+                <constraints>
+                  <grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="2" anchor="8" fill="1" indent="0" use-parent-layout="false"/>
+                </constraints>
+                <properties/>
+              </component>
+            </children>
+          </grid>
+        </children>
+      </grid>
+      <vspacer id="4c83d">
+        <constraints>
+          <grid row="3" column="0" row-span="1" col-span="1" vsize-policy="6" hsize-policy="1" anchor="0" fill="2" indent="0" use-parent-layout="false"/>
+        </constraints>
+      </vspacer>
     </children>
   </grid>
 </form>
diff --git a/plugins/git4idea/src/git4idea/config/GitVcsPanel.java b/plugins/git4idea/src/git4idea/config/GitVcsPanel.java
index 128a0d4cb5be..8e5bbf8e5b57 100644
--- a/plugins/git4idea/src/git4idea/config/GitVcsPanel.java
+++ b/plugins/git4idea/src/git4idea/config/GitVcsPanel.java
@@ -22,6 +22,7 @@ import com.intellij.openapi.ui.Messages;
 import com.intellij.openapi.ui.TextFieldWithBrowseButton;
 import com.intellij.openapi.vcs.VcsException;
 import git4idea.GitVcs;
+import git4idea.checkout.branches.GitBranchConfigurations;
 import git4idea.i18n.GitBundle;
 import org.jetbrains.annotations.NotNull;
 
@@ -57,6 +58,10 @@ public class GitVcsPanel {
    * The confirmation checkbox
    */
   private JCheckBox myAskBeforeConversionsCheckBox;
+  /**
+   * The if selected, the branches widget is enabled in the status bar
+   */
+  private JCheckBox myEnableBranchesWidgetCheckBox;
   /**
    * The project
    */
@@ -107,6 +112,7 @@ public class GitVcsPanel {
     myConvertTextFilesComboBox.setSelectedItem(CRLF_CONVERT_TO_PROJECT);
     myGitField.addBrowseFolderListener(GitBundle.getString("find.git.title"), GitBundle.getString("find.git.description"), project,
                                        new FileChooserDescriptor(true, false, false, false, false, false));
+    myEnableBranchesWidgetCheckBox.setSelected(GitBranchConfigurations.getInstance(myProject).isWidgetEnabled());
   }
 
   /**
@@ -148,6 +154,7 @@ public class GitVcsPanel {
     mySSHExecutableComboBox.setSelectedItem(settings.isIdeaSsh() ? IDEA_SSH : NATIVE_SSH);
     myAskBeforeConversionsCheckBox.setSelected(settings.askBeforeLineSeparatorConversion());
     myConvertTextFilesComboBox.setSelectedItem(crlfPolicyItem(settings));
+    myEnableBranchesWidgetCheckBox.setSelected(GitBranchConfigurations.getInstance(myProject).isWidgetEnabled());
   }
 
   /**
@@ -181,7 +188,8 @@ public class GitVcsPanel {
     return !settings.getGitExecutable().equals(myGitField.getText()) ||
            (settings.isIdeaSsh() != IDEA_SSH.equals(mySSHExecutableComboBox.getSelectedItem())) ||
            !crlfPolicyItem(settings).equals(myConvertTextFilesComboBox.getSelectedItem()) ||
-           settings.askBeforeLineSeparatorConversion() != myAskBeforeConversionsCheckBox.isSelected();
+           settings.askBeforeLineSeparatorConversion() != myAskBeforeConversionsCheckBox.isSelected() ||
+           GitBranchConfigurations.getInstance(myProject).isWidgetEnabled() != myEnableBranchesWidgetCheckBox.isSelected();
   }
 
   /**
@@ -205,5 +213,6 @@ public class GitVcsPanel {
     }
     settings.setLineSeparatorsConversion(conversionPolicy);
     settings.setAskBeforeLineSeparatorConversion(myAskBeforeConversionsCheckBox.isSelected());
+    GitBranchConfigurations.getInstance(myProject).setWidgetEnabled(myEnableBranchesWidgetCheckBox.isSelected());
   }
 }

From 6f40e869c4b6774a216263dbc709c2e1edb64a91 Mon Sep 17 00:00:00 2001
From: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Date: Mon, 2 Aug 2010 18:46:58 +0400
Subject: [PATCH 17/42] git4idea: Removing clearing readonly flag on
 changelists

---
 .../src/git4idea/checkout/branches/GitCheckoutProcess.java   | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitCheckoutProcess.java b/plugins/git4idea/src/git4idea/checkout/branches/GitCheckoutProcess.java
index ee3f381920c9..2b61f51044d3 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitCheckoutProcess.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitCheckoutProcess.java
@@ -585,10 +585,7 @@ public class GitCheckoutProcess {
       LocalChangeList defaultList = myChangeManager.getDefaultChangeList();
       for (ChangeListInfo changeListInfo : changes.CHANGE_LISTS) {
         LocalChangeList changeList = lists.get(changeListInfo.NAME);
-        if (changeList != null) {
-          myChangeManager.setReadOnly(changeList.getName(), false);
-        }
-        else {
+        if (changeList == null) {
           changeList = myChangeManager.addChangeList(changeListInfo.NAME, changeListInfo.COMMENT);
           lists.put(changeListInfo.NAME, changeList);
         }

From 44510f6c7655357e93f5843a6134f315dcaa8001 Mon Sep 17 00:00:00 2001
From: Alexey Pegov <alexey.pegov@jetbrains.com>
Date: Mon, 2 Aug 2010 20:05:58 +0400
Subject: [PATCH 18/42] ConcurrentModificationException in StatusBar

---
 .../InspectionProjectProfileManager.java               | 10 ----------
 .../openapi/wm/impl/status/IdeStatusBarImpl.java       |  7 ++++---
 2 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/platform/lang-impl/src/com/intellij/profile/codeInspection/InspectionProjectProfileManager.java b/platform/lang-impl/src/com/intellij/profile/codeInspection/InspectionProjectProfileManager.java
index 0c98dd6700a8..6ee071f2a6e3 100644
--- a/platform/lang-impl/src/com/intellij/profile/codeInspection/InspectionProjectProfileManager.java
+++ b/platform/lang-impl/src/com/intellij/profile/codeInspection/InspectionProjectProfileManager.java
@@ -169,16 +169,6 @@ public class InspectionProjectProfileManager extends DefaultProjectProfileManage
         } else {
           app.executeOnPooledThread(initInspectionProfilesRunnable);
         }
-
-
-        final JLabel statusLabel = new JLabel("YEAH");
-        try {
-          WindowManager.getInstance().getStatusBar(myProject).addCustomIndicationComponent(statusLabel);
-        }
-        finally {
-          WindowManager.getInstance().getStatusBar(myProject).removeCustomIndicationComponent(statusLabel);
-        }
-
       }
     });
   }
diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
index 0bfeb2ab9664..64d085a2ca1c 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/IdeStatusBarImpl.java
@@ -159,10 +159,11 @@ public class IdeStatusBarImpl extends JComponent implements StatusBarEx {
   }
 
   public void removeCustomIndicationComponent(@NotNull final JComponent c) {
-    for (final Map.Entry<String, WidgetBean> entry : myWidgetMap.entrySet()) {
-      final WidgetBean value = entry.getValue();
+    final Set<String> keySet = myWidgetMap.keySet();
+    final String[] keys = keySet.toArray(new String[keySet.size()]);
+    for (final String key : keys) {
+      final WidgetBean value = myWidgetMap.get(key);
       if (value.widget instanceof CustomStatusBarWidget && value.component == c) {
-        final String key = entry.getKey();
         removeWidget(key);
         myCustomComponentIds.remove(key);
       }

From 3433c6a752c07caf2aab864ee46d20d1858d104b Mon Sep 17 00:00:00 2001
From: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Date: Mon, 2 Aug 2010 20:03:14 +0400
Subject: [PATCH 19/42] git4idea: Push active branches dialog will now rebase
 all vcs roots that needs update

---
 .../src/git4idea/checkin/GitPushActiveBranchesDialog.java       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/git4idea/src/git4idea/checkin/GitPushActiveBranchesDialog.java b/plugins/git4idea/src/git4idea/checkin/GitPushActiveBranchesDialog.java
index f6176c9878ac..a92a8336da29 100644
--- a/plugins/git4idea/src/git4idea/checkin/GitPushActiveBranchesDialog.java
+++ b/plugins/git4idea/src/git4idea/checkin/GitPushActiveBranchesDialog.java
@@ -256,7 +256,7 @@ public class GitPushActiveBranchesDialog extends DialogWrapper {
       if (seenMerges) {
         rootsWithMerges.add(r.root);
       }
-      if (r.remoteCommits > 0 && seenCheckedNode || reorderNeeded) {
+      if (r.remoteCommits > 0 || reorderNeeded) {
         roots.add(r.root);
       }
       if (reorderNeeded) {

From a70ea3cc1aa0e5713a97c59ddc1aad0df1aaa198 Mon Sep 17 00:00:00 2001
From: "Kirill.Safonov" <kirill.safonov@swiftteams.com>
Date: Mon, 2 Aug 2010 20:43:45 +0400
Subject: [PATCH 20/42] Export test results: remove idea.jar dependency on Ant,
 rather make a copy of some constants and resource file

---
 .../export/ExportTestResultsAction.java       |   3 +-
 .../export/TestResultsXmlFormatter.java       |  14 +-
 .../testframework/export/junit-noframes.xsl   | 467 ++++++++++++++++++
 platform/testRunner/testRunner.iml            |   1 -
 4 files changed, 480 insertions(+), 5 deletions(-)
 create mode 100644 platform/testRunner/src/com/intellij/execution/testframework/export/junit-noframes.xsl

diff --git a/platform/testRunner/src/com/intellij/execution/testframework/export/ExportTestResultsAction.java b/platform/testRunner/src/com/intellij/execution/testframework/export/ExportTestResultsAction.java
index 7e46e475477d..7c7f932a8785 100644
--- a/platform/testRunner/src/com/intellij/execution/testframework/export/ExportTestResultsAction.java
+++ b/platform/testRunner/src/com/intellij/execution/testframework/export/ExportTestResultsAction.java
@@ -45,7 +45,6 @@ import com.intellij.openapi.vfs.VfsUtil;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.openapi.wm.ToolWindowManager;
 import com.intellij.util.io.URLUtil;
-import org.apache.tools.ant.taskdefs.optional.junit.XMLConstants;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 import org.xml.sax.SAXException;
@@ -258,7 +257,7 @@ public class ExportTestResultsAction extends DumbAwareAction {
     else {
       Source xslSource;
       if (config.getExportFormat() == ExportTestResultsConfiguration.ExportFormat.BundledTemplate) {
-        URL bundledXsltUrl = XMLConstants.class.getResource("/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-noframes.xsl");
+        URL bundledXsltUrl = getClass().getResource("junit-noframes.xsl");
         xslSource = new StreamSource(URLUtil.openStream(bundledXsltUrl));
       }
       else {
diff --git a/platform/testRunner/src/com/intellij/execution/testframework/export/TestResultsXmlFormatter.java b/platform/testRunner/src/com/intellij/execution/testframework/export/TestResultsXmlFormatter.java
index 889584fa9745..cb7863226a23 100644
--- a/platform/testRunner/src/com/intellij/execution/testframework/export/TestResultsXmlFormatter.java
+++ b/platform/testRunner/src/com/intellij/execution/testframework/export/TestResultsXmlFormatter.java
@@ -24,7 +24,6 @@ import com.intellij.execution.ui.ConsoleViewContentType;
 import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.util.Ref;
 import com.intellij.util.PairProcessor;
-import org.apache.tools.ant.taskdefs.optional.junit.XMLConstants;
 import org.xml.sax.ContentHandler;
 import org.xml.sax.SAXException;
 import org.xml.sax.helpers.AttributesImpl;
@@ -34,7 +33,18 @@ import java.util.Map;
 
 // this class generates resulting XML compatible to that of XMLJUnitResultFormatter
 
-public class TestResultsXmlFormatter implements XMLConstants {
+public class TestResultsXmlFormatter {
+
+  // see org.apache.tools.ant.taskdefs.optional.junit.XmlConstants
+  private static final String TESTSUITES = "testsuites";
+  private static final String TESTSUITE = "testsuite";
+  private static final String TESTCASE = "testcase";
+  private static final String FAILURE = "failure";
+  private static final String ATTR_NAME = "name";
+  private static final String ATTR_FAILURES = "failures";
+  private static final String ATTR_TESTS = "tests";
+
+  
   private static final Logger LOG = Logger.getInstance(TestResultsXmlFormatter.class.getName());
 
   private final RuntimeConfiguration myRuntimeConfiguration;
diff --git a/platform/testRunner/src/com/intellij/execution/testframework/export/junit-noframes.xsl b/platform/testRunner/src/com/intellij/execution/testframework/export/junit-noframes.xsl
new file mode 100644
index 000000000000..f0ab96416c70
--- /dev/null
+++ b/platform/testRunner/src/com/intellij/execution/testframework/export/junit-noframes.xsl
@@ -0,0 +1,467 @@
+<?xml version="1.0"?>
+<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0"
+        xmlns:lxslt="http://xml.apache.org/xslt"
+        xmlns:stringutils="xalan://org.apache.tools.ant.util.StringUtils">
+<xsl:output method="html" indent="yes" encoding="US-ASCII"
+  doctype-public="-//W3C//DTD HTML 4.01 Transitional//EN" />
+<xsl:decimal-format decimal-separator="." grouping-separator="," />
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+ -->
+
+<xsl:param name="TITLE">Unit Test Results.</xsl:param>
+
+<!--
+
+ Sample stylesheet to be used with Ant JUnitReport output.
+
+ It creates a non-framed report that can be useful to send via
+ e-mail or such.
+
+-->
+<xsl:template match="testsuites">
+    <html>
+        <head>
+            <title><xsl:value-of select="$TITLE"/></title>
+    <style type="text/css">
+      body {
+        font:normal 68% verdana,arial,helvetica;
+        color:#000000;
+      }
+      table tr td, table tr th {
+          font-size: 68%;
+      }
+      table.details tr th{
+        font-weight: bold;
+        text-align:left;
+        background:#a6caf0;
+      }
+      table.details tr td{
+        background:#eeeee0;
+      }
+
+      p {
+        line-height:1.5em;
+        margin-top:0.5em; margin-bottom:1.0em;
+      }
+      h1 {
+        margin: 0px 0px 5px; font: 165% verdana,arial,helvetica
+      }
+      h2 {
+        margin-top: 1em; margin-bottom: 0.5em; font: bold 125% verdana,arial,helvetica
+      }
+      h3 {
+        margin-bottom: 0.5em; font: bold 115% verdana,arial,helvetica
+      }
+      h4 {
+        margin-bottom: 0.5em; font: bold 100% verdana,arial,helvetica
+      }
+      h5 {
+        margin-bottom: 0.5em; font: bold 100% verdana,arial,helvetica
+      }
+      h6 {
+        margin-bottom: 0.5em; font: bold 100% verdana,arial,helvetica
+      }
+      .Error {
+        font-weight:bold; color:red;
+      }
+      .Failure {
+        font-weight:bold; color:purple;
+      }
+      .Properties {
+        text-align:right;
+      }
+      </style>
+      <script type="text/javascript" language="JavaScript">
+        var TestCases = new Array();
+        var cur;
+        <xsl:for-each select="./testsuite">
+            <xsl:apply-templates select="properties"/>
+        </xsl:for-each>
+
+       </script>
+       <script type="text/javascript" language="JavaScript"><![CDATA[
+        function displayProperties (name) {
+          var win = window.open('','JUnitSystemProperties','scrollbars=1,resizable=1');
+          var doc = win.document;
+          doc.open();
+          doc.write("<html><head><title>Properties of " + name + "</title>");
+          doc.write("<style>")
+          doc.write("body {font:normal 68% verdana,arial,helvetica; color:#000000; }");
+          doc.write("table tr td, table tr th { font-size: 68%; }");
+          doc.write("table.properties { border-collapse:collapse; border-left:solid 1 #cccccc; border-top:solid 1 #cccccc; padding:5px; }");
+          doc.write("table.properties th { text-align:left; border-right:solid 1 #cccccc; border-bottom:solid 1 #cccccc; background-color:#eeeeee; }");
+          doc.write("table.properties td { font:normal; text-align:left; border-right:solid 1 #cccccc; border-bottom:solid 1 #cccccc; background-color:#fffffff; }");
+          doc.write("h3 { margin-bottom: 0.5em; font: bold 115% verdana,arial,helvetica }");
+          doc.write("</style>");
+          doc.write("</head><body>");
+          doc.write("<h3>Properties of " + name + "</h3>");
+          doc.write("<div align=\"right\"><a href=\"javascript:window.close();\">Close</a></div>");
+          doc.write("<table class='properties'>");
+          doc.write("<tr><th>Name</th><th>Value</th></tr>");
+          for (prop in TestCases[name]) {
+            doc.write("<tr><th>" + prop + "</th><td>" + TestCases[name][prop] + "</td></tr>");
+          }
+          doc.write("</table>");
+          doc.write("</body></html>");
+          doc.close();
+          win.focus();
+        }
+      ]]>
+      </script>
+        </head>
+        <body>
+            <a name="top"></a>
+            <xsl:call-template name="pageHeader"/>
+
+            <!-- Summary part -->
+            <xsl:call-template name="summary"/>
+            <hr size="1" width="95%" align="left"/>
+
+            <!-- Package List part -->
+            <xsl:call-template name="packagelist"/>
+            <hr size="1" width="95%" align="left"/>
+
+            <!-- For each package create its part -->
+            <xsl:call-template name="packages"/>
+            <hr size="1" width="95%" align="left"/>
+
+            <!-- For each class create the  part -->
+            <xsl:call-template name="classes"/>
+
+        </body>
+    </html>
+</xsl:template>
+
+
+
+    <!-- ================================================================== -->
+    <!-- Write a list of all packages with an hyperlink to the anchor of    -->
+    <!-- of the package name.                                               -->
+    <!-- ================================================================== -->
+    <xsl:template name="packagelist">
+        <h2>Packages</h2>
+        Note: package statistics are not computed recursively, they only sum up all of its testsuites numbers.
+        <table class="details" border="0" cellpadding="5" cellspacing="2" width="95%">
+            <xsl:call-template name="testsuite.test.header"/>
+            <!-- list all packages recursively -->
+            <xsl:for-each select="./testsuite[not(./@package = preceding-sibling::testsuite/@package)]">
+                <xsl:sort select="@package"/>
+                <xsl:variable name="testsuites-in-package" select="/testsuites/testsuite[./@package = current()/@package]"/>
+                <xsl:variable name="testCount" select="sum($testsuites-in-package/@tests)"/>
+                <xsl:variable name="errorCount" select="sum($testsuites-in-package/@errors)"/>
+                <xsl:variable name="failureCount" select="sum($testsuites-in-package/@failures)"/>
+                <xsl:variable name="timeCount" select="sum($testsuites-in-package/@time)"/>
+
+                <!-- write a summary for the package -->
+                <tr valign="top">
+                    <!-- set a nice color depending if there is an error/failure -->
+                    <xsl:attribute name="class">
+                        <xsl:choose>
+                            <xsl:when test="$failureCount &gt; 0">Failure</xsl:when>
+                            <xsl:when test="$errorCount &gt; 0">Error</xsl:when>
+                        </xsl:choose>
+                    </xsl:attribute>
+                    <td><a href="#{@package}"><xsl:value-of select="@package"/></a></td>
+                    <td><xsl:value-of select="$testCount"/></td>
+                    <td><xsl:value-of select="$errorCount"/></td>
+                    <td><xsl:value-of select="$failureCount"/></td>
+                    <td>
+                    <xsl:call-template name="display-time">
+                        <xsl:with-param name="value" select="$timeCount"/>
+                    </xsl:call-template>
+                    </td>
+                    <td><xsl:value-of select="$testsuites-in-package/@timestamp"/></td>
+                    <td><xsl:value-of select="$testsuites-in-package/@hostname"/></td>
+                </tr>
+            </xsl:for-each>
+        </table>
+    </xsl:template>
+
+
+    <!-- ================================================================== -->
+    <!-- Write a package level report                                       -->
+    <!-- It creates a table with values from the document:                  -->
+    <!-- Name | Tests | Errors | Failures | Time                            -->
+    <!-- ================================================================== -->
+    <xsl:template name="packages">
+        <!-- create an anchor to this package name -->
+        <xsl:for-each select="/testsuites/testsuite[not(./@package = preceding-sibling::testsuite/@package)]">
+            <xsl:sort select="@package"/>
+                <a name="{@package}"></a>
+                <h3>Package <xsl:value-of select="@package"/></h3>
+
+                <table class="details" border="0" cellpadding="5" cellspacing="2" width="95%">
+                    <xsl:call-template name="testsuite.test.header"/>
+
+                    <!-- match the testsuites of this package -->
+                    <xsl:apply-templates select="/testsuites/testsuite[./@package = current()/@package]" mode="print.test"/>
+                </table>
+                <a href="#top">Back to top</a>
+                <p/>
+                <p/>
+        </xsl:for-each>
+    </xsl:template>
+
+    <xsl:template name="classes">
+        <xsl:for-each select="testsuite">
+            <xsl:sort select="@name"/>
+            <!-- create an anchor to this class name -->
+            <a name="{@name}"></a>
+            <h3>TestCase <xsl:value-of select="@name"/></h3>
+
+            <table class="details" border="0" cellpadding="5" cellspacing="2" width="95%">
+              <xsl:call-template name="testcase.test.header"/>
+              <!--
+              test can even not be started at all (failure to load the class)
+              so report the error directly
+              -->
+                <xsl:if test="./error">
+                    <tr class="Error">
+                        <td colspan="4"><xsl:apply-templates select="./error"/></td>
+                    </tr>
+                </xsl:if>
+                <xsl:apply-templates select="./testcase" mode="print.test"/>
+            </table>
+            <div class="Properties">
+                <a>
+                    <xsl:attribute name="href">javascript:displayProperties('<xsl:value-of select="@package"/>.<xsl:value-of select="@name"/>');</xsl:attribute>
+                    Properties &#187;
+                </a>
+            </div>
+            <p/>
+
+            <a href="#top">Back to top</a>
+        </xsl:for-each>
+    </xsl:template>
+
+    <xsl:template name="summary">
+        <h2>Summary</h2>
+        <xsl:variable name="testCount" select="sum(testsuite/@tests)"/>
+        <xsl:variable name="errorCount" select="sum(testsuite/@errors)"/>
+        <xsl:variable name="failureCount" select="sum(testsuite/@failures)"/>
+        <xsl:variable name="timeCount" select="sum(testsuite/@time)"/>
+        <xsl:variable name="successRate" select="($testCount - $failureCount - $errorCount) div $testCount"/>
+        <table class="details" border="0" cellpadding="5" cellspacing="2" width="95%">
+        <tr valign="top">
+            <th>Tests</th>
+            <th>Failures</th>
+            <th>Errors</th>
+            <th>Success rate</th>
+            <th>Time</th>
+        </tr>
+        <tr valign="top">
+            <xsl:attribute name="class">
+                <xsl:choose>
+                    <xsl:when test="$failureCount &gt; 0">Failure</xsl:when>
+                    <xsl:when test="$errorCount &gt; 0">Error</xsl:when>
+                </xsl:choose>
+            </xsl:attribute>
+            <td><xsl:value-of select="$testCount"/></td>
+            <td><xsl:value-of select="$failureCount"/></td>
+            <td><xsl:value-of select="$errorCount"/></td>
+            <td>
+                <xsl:call-template name="display-percent">
+                    <xsl:with-param name="value" select="$successRate"/>
+                </xsl:call-template>
+            </td>
+            <td>
+                <xsl:call-template name="display-time">
+                    <xsl:with-param name="value" select="$timeCount"/>
+                </xsl:call-template>
+            </td>
+
+        </tr>
+        </table>
+        <table border="0" width="95%">
+        <tr>
+        <td style="text-align: justify;">
+        Note: <i>failures</i> are anticipated and checked for with assertions while <i>errors</i> are unanticipated.
+        </td>
+        </tr>
+        </table>
+    </xsl:template>
+
+  <!--
+   Write properties into a JavaScript data structure.
+   This is based on the original idea by Erik Hatcher (ehatcher@apache.org)
+   -->
+  <xsl:template match="properties">
+    cur = TestCases['<xsl:value-of select="../@package"/>.<xsl:value-of select="../@name"/>'] = new Array();
+    <xsl:for-each select="property">
+    <xsl:sort select="@name"/>
+        cur['<xsl:value-of select="@name"/>'] = '<xsl:call-template name="JS-escape"><xsl:with-param name="string" select="@value"/></xsl:call-template>';
+    </xsl:for-each>
+  </xsl:template>
+
+<!-- Page HEADER -->
+<xsl:template name="pageHeader">
+    <h1><xsl:value-of select="$TITLE"/></h1>
+    <table width="100%">
+    <tr>
+        <td align="left"></td>
+        <td align="right">Designed for use with <a href='http://www.junit.org'>JUnit</a> and <a href='http://ant.apache.org/ant'>Ant</a>.</td>
+    </tr>
+    </table>
+    <hr size="1"/>
+</xsl:template>
+
+<xsl:template match="testsuite" mode="header">
+    <tr valign="top">
+        <th width="80%">Name</th>
+        <th>Tests</th>
+        <th>Errors</th>
+        <th>Failures</th>
+        <th nowrap="nowrap">Time(s)</th>
+    </tr>
+</xsl:template>
+
+<!-- class header -->
+<xsl:template name="testsuite.test.header">
+    <tr valign="top">
+        <th width="80%">Name</th>
+        <th>Tests</th>
+        <th>Errors</th>
+        <th>Failures</th>
+        <th nowrap="nowrap">Time(s)</th>
+        <th nowrap="nowrap">Time Stamp</th>
+        <th>Host</th>
+    </tr>
+</xsl:template>
+
+<!-- method header -->
+<xsl:template name="testcase.test.header">
+    <tr valign="top">
+        <th>Name</th>
+        <th>Status</th>
+        <th width="80%">Type</th>
+        <th nowrap="nowrap">Time(s)</th>
+    </tr>
+</xsl:template>
+
+
+<!-- class information -->
+<xsl:template match="testsuite" mode="print.test">
+    <tr valign="top">
+        <!-- set a nice color depending if there is an error/failure -->
+        <xsl:attribute name="class">
+            <xsl:choose>
+                <xsl:when test="@failures[.&gt; 0]">Failure</xsl:when>
+                <xsl:when test="@errors[.&gt; 0]">Error</xsl:when>
+            </xsl:choose>
+        </xsl:attribute>
+
+        <!-- print testsuite information -->
+        <td><a href="#{@name}"><xsl:value-of select="@name"/></a></td>
+        <td><xsl:value-of select="@tests"/></td>
+        <td><xsl:value-of select="@errors"/></td>
+        <td><xsl:value-of select="@failures"/></td>
+        <td>
+            <xsl:call-template name="display-time">
+                <xsl:with-param name="value" select="@time"/>
+            </xsl:call-template>
+        </td>
+        <td><xsl:apply-templates select="@timestamp"/></td>
+        <td><xsl:apply-templates select="@hostname"/></td>
+    </tr>
+</xsl:template>
+
+<xsl:template match="testcase" mode="print.test">
+    <tr valign="top">
+        <xsl:attribute name="class">
+            <xsl:choose>
+                <xsl:when test="failure | error">Error</xsl:when>
+            </xsl:choose>
+        </xsl:attribute>
+        <td><xsl:value-of select="@name"/></td>
+        <xsl:choose>
+            <xsl:when test="failure">
+                <td>Failure</td>
+                <td><xsl:apply-templates select="failure"/></td>
+            </xsl:when>
+            <xsl:when test="error">
+                <td>Error</td>
+                <td><xsl:apply-templates select="error"/></td>
+            </xsl:when>
+            <xsl:otherwise>
+                <td>Success</td>
+                <td></td>
+            </xsl:otherwise>
+        </xsl:choose>
+        <td>
+            <xsl:call-template name="display-time">
+                <xsl:with-param name="value" select="@time"/>
+            </xsl:call-template>
+        </td>
+    </tr>
+</xsl:template>
+
+
+<xsl:template match="failure">
+    <xsl:call-template name="display-failures"/>
+</xsl:template>
+
+<xsl:template match="error">
+    <xsl:call-template name="display-failures"/>
+</xsl:template>
+
+<!-- Style for the error and failure in the tescase template -->
+<xsl:template name="display-failures">
+    <xsl:choose>
+        <xsl:when test="not(@message)">N/A</xsl:when>
+        <xsl:otherwise>
+            <xsl:value-of select="@message"/>
+        </xsl:otherwise>
+    </xsl:choose>
+    <!-- display the stacktrace -->
+    <code>
+        <br/><br/>
+        <xsl:call-template name="br-replace">
+            <xsl:with-param name="word" select="."/>
+        </xsl:call-template>
+    </code>
+    <!-- the later is better but might be problematic for non-21" monitors... -->
+    <!--pre><xsl:value-of select="."/></pre-->
+</xsl:template>
+
+<xsl:template name="JS-escape">
+    <xsl:param name="string"/>
+    <xsl:param name="tmp1" select="stringutils:replace(string($string),'\','\\')"/>
+    <xsl:param name="tmp2" select="stringutils:replace(string($tmp1),&quot;'&quot;,&quot;\&apos;&quot;)"/>
+    <xsl:value-of select="$tmp2"/>
+</xsl:template>
+
+
+<!--
+    template that will convert a carriage return into a br tag
+    @param word the text from which to convert CR to BR tag
+-->
+<xsl:template name="br-replace">
+    <xsl:param name="word"/>
+    <xsl:value-of disable-output-escaping="yes" select='stringutils:replace(string($word),"&#xA;","&lt;br/>")'/>
+</xsl:template>
+
+<xsl:template name="display-time">
+    <xsl:param name="value"/>
+    <xsl:value-of select="format-number($value,'0.000')"/>
+</xsl:template>
+
+<xsl:template name="display-percent">
+    <xsl:param name="value"/>
+    <xsl:value-of select="format-number($value,'0.00%')"/>
+</xsl:template>
+
+</xsl:stylesheet>
diff --git a/platform/testRunner/testRunner.iml b/platform/testRunner/testRunner.iml
index 01430add824a..5c2b923541d0 100644
--- a/platform/testRunner/testRunner.iml
+++ b/platform/testRunner/testRunner.iml
@@ -11,7 +11,6 @@
     <orderEntry type="module" module-name="lang-impl" />
     <orderEntry type="module" module-name="platform-impl" />
     <orderEntry type="module" module-name="xdebugger-api" />
-    <orderEntry type="library" name="Ant" level="project" />
   </component>
 </module>
 

From bc72987f4755525598f0fb9e34c9886e4db486f0 Mon Sep 17 00:00:00 2001
From: Dmitry Trofimov <dmitry.trofimov@jetbrains.com>
Date: Mon, 2 Aug 2010 21:06:16 +0400
Subject: [PATCH 21/42] added pythonunbuffered=1 to appengine run configuration

---
 .../src/com/intellij/psi/util/PsiTreeUtil.java    | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/platform/lang-api/src/com/intellij/psi/util/PsiTreeUtil.java b/platform/lang-api/src/com/intellij/psi/util/PsiTreeUtil.java
index 4199ce90d337..48648543f6dc 100644
--- a/platform/lang-api/src/com/intellij/psi/util/PsiTreeUtil.java
+++ b/platform/lang-api/src/com/intellij/psi/util/PsiTreeUtil.java
@@ -590,7 +590,8 @@ public class PsiTreeUtil {
     while (true);
   }
 
-  public static PsiElement prevLeaf(PsiElement current){
+  @Nullable
+  public static PsiElement prevLeaf(@NotNull PsiElement current){
     final PsiElement prevSibling = current.getPrevSibling();
     if(prevSibling != null) return lastChild(prevSibling);
     final PsiElement parent = current.getParent();
@@ -598,7 +599,8 @@ public class PsiTreeUtil {
     return prevLeaf(parent);
   }
 
-  public static PsiElement nextLeaf(PsiElement current){
+  @Nullable
+  public static PsiElement nextLeaf(@NotNull PsiElement current){
     final PsiElement nextSibling = current.getNextSibling();
     if(nextSibling != null) return firstChild(nextSibling);
     final PsiElement parent = current.getParent();
@@ -612,17 +614,20 @@ public class PsiTreeUtil {
     return element;
   }
 
-  public static PsiElement firstChild(final PsiElement element) {
-    if(element.getFirstChild() != null) return firstChild(element.getFirstChild());
+  public static PsiElement firstChild(@NotNull final PsiElement element) {
+    PsiElement child = element.getFirstChild();
+    if(child != null) return firstChild(child);
     return element;
   }
 
-  public static PsiElement prevLeaf(final PsiErrorElement element, final boolean skipEmptyElements) {
+  @Nullable
+  public static PsiElement prevLeaf(@NotNull final PsiErrorElement element, final boolean skipEmptyElements) {
     PsiElement prevLeaf = prevLeaf(element);
     while (skipEmptyElements && prevLeaf != null && prevLeaf.getTextLength() == 0) prevLeaf = prevLeaf(prevLeaf);
     return prevLeaf;
   }
 
+  @Nullable
   public static PsiElement nextLeaf(final PsiErrorElement element, final boolean skipEmptyElements) {
     PsiElement nextLeaf = nextLeaf(element);
     while (skipEmptyElements && nextLeaf != null && nextLeaf.getTextLength() == 0) nextLeaf = nextLeaf(nextLeaf);

From de67683f0656f301e532680acb540758733e09bf Mon Sep 17 00:00:00 2001
From: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Date: Mon, 2 Aug 2010 22:15:18 +0400
Subject: [PATCH 22/42] git4idea: IDEA-57034: improved presentation for git
 branches widget

---
 .../openapi/wm/impl/status/TextPanel.java     | 22 ++++--
 .../checkout/branches/GitBranchesWidget.java  | 73 +++++++++++++++----
 2 files changed, 73 insertions(+), 22 deletions(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/TextPanel.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/TextPanel.java
index 83a400d1f9dd..f44066feb8f0 100644
--- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/TextPanel.java
+++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/TextPanel.java
@@ -30,16 +30,16 @@ public class TextPanel extends JComponent {
   private boolean myDecorate = true;
   private float myAlignment;
 
-  TextPanel() {
+  protected TextPanel() {
     this(null);
   }
 
-  TextPanel(final boolean decorate) {
+  protected TextPanel(final boolean decorate) {
     this(null);
     myDecorate = decorate;
   }
 
-  TextPanel(@Nullable final String maxPossibleString) {
+  protected TextPanel(@Nullable final String maxPossibleString) {
     myMaxPossibleString = maxPossibleString;
 
     setFont(SystemInfo.isMac ? UIUtil.getLabelFont().deriveFont(11.0f) : UIUtil.getLabelFont());
@@ -93,7 +93,7 @@ public class TextPanel extends JComponent {
       final int y = UIUtil.getStringY(s, bounds, g2);
       if (SystemInfo.isMac && myDecorate) {
         g2.setColor(new Color(215, 215, 215));
-        g2.drawString(s, x, y+1);
+        g2.drawString(s, x, y + 1);
       }
 
       g2.setColor(getForeground());
@@ -105,7 +105,7 @@ public class TextPanel extends JComponent {
     myAlignment = alignment;
   }
 
-  private static String splitText(final JLabel label, final String text, final int widthLimit){
+  private static String splitText(final JLabel label, final String text, final int widthLimit) {
     final FontMetrics fontMetrics = label.getFontMetrics(label.getFont());
 
     final String[] lines = UIUtil.splitText(text, fontMetrics, widthLimit, ' ');
@@ -130,9 +130,10 @@ public class TextPanel extends JComponent {
     return myText;
   }
 
-  public Dimension getPreferredSize(){
+  public Dimension getPreferredSize() {
     int max = 0;
-    if (myMaxPossibleString != null) max = getFontMetrics(getFont()).stringWidth(myMaxPossibleString);
+    String text = getTextForPreferredSize();
+    if (text != null) max = getFontMetrics(getFont()).stringWidth(text);
 
     if (myPrefSize != null) {
       return new Dimension(20 + max, myPrefSize.height);
@@ -140,4 +141,11 @@ public class TextPanel extends JComponent {
 
     return new Dimension(20 + max, getMinimumSize().height);
   }
+
+  /**
+   * @return the text that is used to calculate the preferred size
+   */
+  protected String getTextForPreferredSize() {
+    return myMaxPossibleString;
+  }
 }
diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
index 9ff127fb247a..4513bf8c7ba3 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
@@ -37,6 +37,7 @@ import com.intellij.openapi.wm.CustomStatusBarWidget;
 import com.intellij.openapi.wm.StatusBar;
 import com.intellij.openapi.wm.ToolWindowManager;
 import com.intellij.openapi.wm.WindowManager;
+import com.intellij.openapi.wm.impl.status.TextPanel;
 import com.intellij.ui.awt.RelativePoint;
 import com.intellij.util.ui.UIUtil;
 import git4idea.GitUtil;
@@ -58,7 +59,11 @@ import java.util.Collection;
 /**
  * The git branches widget
  */
-public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
+public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidget {
+  /**
+   * The arrows icon
+   */
+  private static final Icon ARROWS_ICON = IconLoader.getIcon("/ide/statusbar_arrows.png");
   /**
    * The logger
    */
@@ -125,7 +130,6 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
     myDefaultForeground = getForeground();
     myConfigurationsListener = new MyGitBranchConfigurationsListener();
     myConfigurations.addConfigurationListener(myConfigurationsListener);
-    setIcon(IconLoader.findIcon("/icons/branch.png", getClass()));
     Disposer.register(myConfigurations, this);
     addMouseListener(new MouseAdapter() {
       @Override
@@ -241,12 +245,11 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
     final DataContext parent = DataManager.getInstance().getDataContext((Component)myStatusBar);
     final DataContext dataContext = SimpleDataContext.getSimpleContext(PlatformDataKeys.PROJECT.getName(), myProject, parent);
     myPopup = JBPopupFactory.getInstance()
-      .createActionGroupPopup("Checkout", getPopupActionGroup(), dataContext, JBPopupFactory.ActionSelectionAid.SPEEDSEARCH, true,
+      .createActionGroupPopup(null, getPopupActionGroup(), dataContext, JBPopupFactory.ActionSelectionAid.SPEEDSEARCH, true,
                               new Runnable() {
                                 @Override
                                 public void run() {
                                   myPopup = null;
-
                                 }
                               }, 20);
     final Dimension dimension = myPopup.getContent().getPreferredSize();
@@ -341,23 +344,32 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
   private void updateLabel() {
     cancelPopup();
     final GitBranchConfigurations.SpecialStatus status = myConfigurations.getSpecialStatus();
-    String t;
+    String text;
     myPopupEnabled = false;
+    Color color = Color.RED;
+    String tooltip;
     switch (status) {
       case CHECKOUT_IN_PROGRESS:
-        t = "Checkout in progress...";
+        text = "Checkout...";
+        color = Color.BLUE;
+        tooltip = "A checkout operation is in progress.";
         break;
       case MERGING:
-        t = "Merging...";
+        text = "Merging...";
+        tooltip = "Merge is in progress in some vcs roots.";
         break;
       case REBASING:
-        t = "Rebasing...";
+        tooltip = "Rebase is in progress in some vcs roots.";
+        text = "Rebasing...";
         break;
       case NON_GIT:
-        t = "Non-Git project";
+        tooltip = "No valid vcs roots are configuration for the project.";
+        text = "Non-Git project";
         break;
       case SUBMODULES:
-        t = "Submodules unsupported";
+        tooltip =
+          "<html>The submodules are unsupported in the current version.<br/>It is possible to disable widget in Git Vcs settings.</html>";
+        text = "Submodules unsupported";
         break;
       case NORMAL:
         GitBranchConfiguration current;
@@ -368,18 +380,49 @@ public class GitBranchesWidget extends JLabel implements CustomStatusBarWidget {
           current = null;
         }
         if (current == null) {
-          t = "Detection in progress";
+          tooltip = "The branch configurations are not yet detected.";
+          text = "Detecting...";
         }
         else {
           myPopupEnabled = true;
-          t = current.getName();
+          text = current.getName();
+          tooltip = "<html>The Git branch configuration <b>" + text + "</b> is selected.<br/>Click to select other configuration.</html>";
+          color = myDefaultForeground;
         }
         break;
       default:
-        t = "Unknown status: " + status;
+        tooltip = "Unknown status: " + status;
+        text = "Unknown status: " + status;
     }
-    setForeground(myPopupEnabled ? myDefaultForeground : Color.RED);
-    setText(t);
+    if (!SystemInfo.isMac) {
+      setForeground(color);
+    }
+    setToolTipText(tooltip);
+    setText(text);
+    invalidate();
+  }
+
+  @Override
+  protected void paintComponent(@NotNull final Graphics g) {
+    super.paintComponent(g);
+
+    if (getText() != null && myPopupEnabled) {
+      final Rectangle r = getBounds();
+      final Insets insets = getInsets();
+      ARROWS_ICON
+        .paintIcon(this, g, r.width - insets.right - ARROWS_ICON.getIconWidth() - 2, r.height / 2 - ARROWS_ICON.getIconHeight() / 2);
+    }
+  }
+
+  @Override
+  public Dimension getPreferredSize() {
+    final Dimension preferredSize = super.getPreferredSize();
+    return new Dimension(preferredSize.width + ARROWS_ICON.getIconWidth() + 4, preferredSize.height);
+  }
+
+  @Override
+  protected String getTextForPreferredSize() {
+    return getText();
   }
 
   /**

From 7b970fc76b087ab7983e6b7788e608c5e6778fc1 Mon Sep 17 00:00:00 2001
From: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Date: Mon, 2 Aug 2010 22:37:38 +0400
Subject: [PATCH 23/42] git4idea: Actions in branches widget are now dumb-aware

---
 .../checkout/branches/GitBranchesWidget.java  | 29 ++++++++++++++-----
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
index 4513bf8c7ba3..9d312adc7849 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
@@ -22,6 +22,7 @@ import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.progress.ProgressIndicator;
 import com.intellij.openapi.progress.ProgressManager;
 import com.intellij.openapi.progress.Task;
+import com.intellij.openapi.project.DumbAwareAction;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.ui.MessageType;
 import com.intellij.openapi.ui.popup.JBPopupFactory;
@@ -109,6 +110,10 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
    * The current popup
    */
   private ListPopup myPopup;
+  /**
+   * The key for the last popup, used to determine if disposed popup is the actually the last pop up.
+   */
+  private Object myPopupKey;
   /**
    * The default foreground color
    */
@@ -225,7 +230,7 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
     if (myRemoveConfigurations == null) {
       ArrayList<AnAction> rc = new ArrayList<AnAction>();
       for (final String c : myConfigurations.getRemotesCandidates()) {
-        rc.add(new AnAction(c) {
+        rc.add(new DumbAwareAction(c) {
           @Override
           public void actionPerformed(AnActionEvent e) {
             myConfigurations.startCheckout(null, c, false);
@@ -238,18 +243,28 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
     return myRemoveConfigurations;
   }
 
+  /**
+   * Show popup is if it is not shown.
+   */
   void showPopup() {
     if (!myPopupEnabled) {
       return;
     }
+    if (myPopup != null) {
+      myPopup.cancel();
+    }
     final DataContext parent = DataManager.getInstance().getDataContext((Component)myStatusBar);
     final DataContext dataContext = SimpleDataContext.getSimpleContext(PlatformDataKeys.PROJECT.getName(), myProject, parent);
+    final Object key = new Object();
+    myPopupKey = key;
     myPopup = JBPopupFactory.getInstance()
       .createActionGroupPopup(null, getPopupActionGroup(), dataContext, JBPopupFactory.ActionSelectionAid.SPEEDSEARCH, true,
                               new Runnable() {
                                 @Override
                                 public void run() {
-                                  myPopup = null;
+                                  if (key == myPopupKey) {
+                                    myPopup = null;
+                                  }
                                 }
                               }, 20);
     final Dimension dimension = myPopup.getContent().getPreferredSize();
@@ -280,7 +295,7 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
           // skip current config
           continue;
         }
-        rc.add(new AnAction(c) {
+        rc.add(new DumbAwareAction(c) {
           @Override
           public void actionPerformed(AnActionEvent e) {
             try {
@@ -307,13 +322,13 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
   ActionGroup getPopupActionGroup() {
     if (myPopupActionGroup == null) {
       myPopupActionGroup = new DefaultActionGroup(null, false);
-      myPopupActionGroup.addAction(new AnAction("Manage Configurations ...") {
+      myPopupActionGroup.addAction(new DumbAwareAction("Manage Configurations ...") {
         @Override
         public void actionPerformed(AnActionEvent e) {
           GitManageConfigurationsDialog.showDialog(myProject, myConfigurations);
         }
       });
-      myPopupActionGroup.addAction(new AnAction("Modify Current Configuration ...") {
+      myPopupActionGroup.addAction(new DumbAwareAction("Modify Current Configuration ...") {
         @Override
         public void actionPerformed(AnActionEvent e) {
           try {
@@ -325,7 +340,7 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
           }
         }
       });
-      myPopupActionGroup.addAction(new AnAction("New Configuration ...") {
+      myPopupActionGroup.addAction(new DumbAwareAction("New Configuration ...") {
         @Override
         public void actionPerformed(AnActionEvent e) {
           myConfigurations.startCheckout(null, null, false);
@@ -543,7 +558,7 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
   /**
    * Refresh git remotes
    */
-  class RefreshRemotesAction extends AnAction {
+  class RefreshRemotesAction extends DumbAwareAction {
     /**
      * The constructor
      */

From b79ad325361d1f11b1567d81f052599d2a4adb4a Mon Sep 17 00:00:00 2001
From: Denis Zhdanov <Denis.Zhdanov@jetbrains.com>
Date: Tue, 3 Aug 2010 10:16:04 +0400
Subject: [PATCH 24/42] IDEA-56987    Throwable at
 EditorImpl.logicalToVisualPosition() on opening a database console

Column -> offset mapping is corrected in case of tabulation symbols presence
---
 .../src/com/intellij/openapi/editor/ex/util/EditorUtil.java   | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java b/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
index 11763b6fb1ce..494eb95ac112 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
@@ -263,13 +263,15 @@ public class EditorUtil {
         }
       }
 
+      // This variable holds number of 'virtual' tab-introduced columns, e.g. there is a possible case that particular tab owns
+      // three columns, hence, it increases 'shift' by two (3 - 1).
       int shift = 0;
       int offset = start;
       int prevX = x;
       for (; offset < end && offset + shift + currentColumn.get() < start + columnNumber; offset++) {
         if (text.charAt(offset) == '\t') {
           int nextX = nextTabStop(prevX, editor, tabSize);
-          shift += columnsNumber(nextX - prevX, getSpaceWidth(Font.PLAIN, editor));
+          shift += columnsNumber(nextX - prevX, getSpaceWidth(Font.PLAIN, editor)) - 1;
           prevX = nextX;
         }
       }

From 31d8a6cedc935c292c994c6ca50c3e3fcb0b7f34 Mon Sep 17 00:00:00 2001
From: Denis Zhdanov <Denis.Zhdanov@jetbrains.com>
Date: Tue, 3 Aug 2010 11:15:34 +0400
Subject: [PATCH 25/42] IDEA-56987    Throwable at
 EditorImpl.logicalToVisualPosition() on opening a database console

Column -> offset mapping is corrected in case of tabulation symbols presence
---
 .../src/com/intellij/openapi/editor/ex/util/EditorUtil.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java b/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
index 494eb95ac112..caa6447c085f 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
@@ -296,7 +296,7 @@ public class EditorUtil {
     int fontType = state.getMergedAttributes().getFontType();
     int column = currentColumn.get();
     int spaceSize = getSpaceWidth(fontType, editorImpl);
-    for (; column <= columnNumber && offset < end; offset++) {
+    for (; column < columnNumber && offset < end; offset++) {
       if (offset >= state.getEndOffset()) {
         state.advance();
         fontType = state.getMergedAttributes().getFontType();

From 9d21522d3403cca0d07ed70f2613d23f5b57016b Mon Sep 17 00:00:00 2001
From: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Date: Tue, 3 Aug 2010 11:27:14 +0400
Subject: [PATCH 26/42] git4idea: Added possibly of checkout with changes from
 menu

---
 .../checkout/branches/GitBranchesWidget.java  | 99 +++++++++++++------
 1 file changed, 71 insertions(+), 28 deletions(-)

diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
index 9d312adc7849..4c773f29e6e7 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchesWidget.java
@@ -69,7 +69,6 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
    * The logger
    */
   private static final Logger LOG = Logger.getInstance(GitBranchesWidget.class.getName());
-
   /**
    * The ID of the widget
    */
@@ -94,6 +93,10 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
    * The selectable configurations. Null if invalidated or non-initialized
    */
   private AnAction[] mySelectableConfigurations;
+  /**
+   * The selectable configurations. Null if invalidated or non-initialized
+   */
+  private AnAction[] mySelectableWithChangesConfigurations;
   /**
    * The candidate remote configurations. Null if invalidated or non-initialized
    */
@@ -273,13 +276,13 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
   }
 
   /**
+   * Ensure that action for checking out configurations are crated
+   *
    * @return get or create selectable configuration group
    */
-  private AnAction[] getSelectable() {
+  private AnAction[] ensureSelectableCreated() {
     assert myPopupEnabled : "pop should be enabled";
-    if (mySelectableConfigurations == null) {
-      ArrayList<AnAction> rc = new ArrayList<AnAction>();
-
+    if (mySelectableConfigurations == null || mySelectableWithChangesConfigurations == null) {
       GitBranchConfiguration current;
       try {
         current = myConfigurations.getCurrentConfiguration();
@@ -287,35 +290,50 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
       catch (VcsException e) {
         LOG.error("Unexpected error at this point", e);
         mySelectableConfigurations = new AnAction[0];
+        mySelectableWithChangesConfigurations = new AnAction[0];
+
         return mySelectableConfigurations;
       }
       String name = current == null ? "" : current.getName();
-      for (final String c : myConfigurations.getConfigurationNames()) {
-        if (name.equals(c)) {
-          // skip current config
-          continue;
-        }
-        rc.add(new DumbAwareAction(c) {
-          @Override
-          public void actionPerformed(AnActionEvent e) {
-            try {
-              final GitBranchConfiguration toCheckout = myConfigurations.getConfiguration(c);
-              if (toCheckout == null) {
-                throw new VcsException("The configuration " + c + " cannot be found.");
-              }
-              myConfigurations.startCheckout(toCheckout, null, true);
-            }
-            catch (VcsException e1) {
-              GitUIUtil.showOperationError(myProject, e1, "Unable to load: " + c);
-            }
-          }
-        });
-      }
-      mySelectableConfigurations = rc.toArray(new AnAction[rc.size()]);
+      mySelectableConfigurations = checkoutActions(name, true);
+      mySelectableWithChangesConfigurations = checkoutActions(name, false);
     }
     return mySelectableConfigurations;
   }
 
+  /**
+   * Checkout actions
+   *
+   * @param name  the excluded name
+   * @param quick true, if quick checkout actions
+   * @return an array of actions for the configurations
+   */
+  private AnAction[] checkoutActions(String name, final boolean quick) {
+    ArrayList<AnAction> rc = new ArrayList<AnAction>();
+    for (final String c : myConfigurations.getConfigurationNames()) {
+      if (name.equals(c)) {
+        // skip current config
+        continue;
+      }
+      rc.add(new DumbAwareAction(c) {
+        @Override
+        public void actionPerformed(AnActionEvent e) {
+          try {
+            final GitBranchConfiguration toCheckout = myConfigurations.getConfiguration(c);
+            if (toCheckout == null) {
+              throw new VcsException("The configuration " + c + " cannot be found.");
+            }
+            myConfigurations.startCheckout(toCheckout, null, quick);
+          }
+          catch (VcsException e1) {
+            GitUIUtil.showOperationError(myProject, e1, "Unable to load: " + c);
+          }
+        }
+      });
+    }
+    return rc.toArray(new AnAction[rc.size()]);
+  }
+
   /**
    * @return the action group for popup
    */
@@ -347,6 +365,7 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
         }
       });
       myPopupActionGroup.add(new MyRemotesActionGroup());
+      myPopupActionGroup.add(new MySelectableWithChangesActionGroup());
       myPopupActionGroup.addSeparator("Branch Configurations");
       myPopupActionGroup.add(new MySelectableActionGroup());
     }
@@ -466,7 +485,29 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
     @NotNull
     @Override
     public AnAction[] getChildren(@Nullable AnActionEvent e) {
-      return getSelectable();
+      return ensureSelectableCreated();
+    }
+  }
+
+  /**
+   * Remotes action group
+   */
+  class MySelectableWithChangesActionGroup extends ActionGroup {
+    /**
+     * The constructor
+     */
+    public MySelectableWithChangesActionGroup() {
+      super("Check out with Selected Changes...", true);
+    }
+
+    /**
+     * {@inheritDoc}
+     */
+    @NotNull
+    @Override
+    public AnAction[] getChildren(@Nullable AnActionEvent e) {
+      ensureSelectableCreated();
+      return mySelectableWithChangesConfigurations;
     }
   }
 
@@ -504,6 +545,7 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
         @Override
         public void run() {
           mySelectableConfigurations = null;
+          mySelectableWithChangesConfigurations = null;
         }
       });
     }
@@ -535,6 +577,7 @@ public class GitBranchesWidget extends TextPanel implements CustomStatusBarWidge
         @Override
         public void run() {
           mySelectableConfigurations = null;
+          mySelectableWithChangesConfigurations = null;
           updateLabel();
         }
       });

From d0fb4c417cfed348343c171e09063e596d06535e Mon Sep 17 00:00:00 2001
From: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Date: Tue, 3 Aug 2010 11:28:00 +0400
Subject: [PATCH 27/42] git4idea: IDEA-57050: fixed ISE

---
 .../branches/GitBranchConfigurationChangedDialog.java      | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchConfigurationChangedDialog.java b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchConfigurationChangedDialog.java
index 717ae4931284..3e545187dfbf 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitBranchConfigurationChangedDialog.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitBranchConfigurationChangedDialog.java
@@ -89,7 +89,7 @@ public class GitBranchConfigurationChangedDialog extends DialogWrapper {
     myTable.setModel(new DescriptorTableModel());
     myNameTextField.setText(config.getName());
     myNewAction = new DialogWrapperExitAction("New Configuration", NEW_CONFIGURATION);
-    myNameTextField.getDocument().addDocumentListener(new DocumentAdapter() {
+    final DocumentAdapter l = new DocumentAdapter() {
       @Override
       protected void textChanged(DocumentEvent e) {
         String text = myNameTextField.getText().trim();
@@ -113,8 +113,9 @@ public class GitBranchConfigurationChangedDialog extends DialogWrapper {
         setOKActionEnabled(s == null);
         myNewAction.setEnabled(s == null);
       }
-    });
-
+    };
+    myNameTextField.getDocument().addDocumentListener(l);
+    l.changedUpdate(null);
     setOKButtonText("Update");
     init();
   }

From c95e4238ce040411c46af1af4fb8825595d3ae4b Mon Sep 17 00:00:00 2001
From: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Date: Tue, 3 Aug 2010 11:32:39 +0400
Subject: [PATCH 28/42] git4idea: IDEA-57049: fixed AE

---
 .../checkout/branches/GitManageConfigurationsDialog.java        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitManageConfigurationsDialog.java b/plugins/git4idea/src/git4idea/checkout/branches/GitManageConfigurationsDialog.java
index 4103b5a826de..87524ef50334 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitManageConfigurationsDialog.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitManageConfigurationsDialog.java
@@ -173,7 +173,7 @@ public class GitManageConfigurationsDialog extends DialogWrapper {
                                          "</td></tr></html>");
       }
     }
-    boolean isNonCurrent = selected != null || selected != current;
+    boolean isNonCurrent = selected != null && selected != current;
     myDeleteButton.setEnabled(isNonCurrent);
     setOKActionEnabled(isNonCurrent && myConfigurations.getSpecialStatus() == GitBranchConfigurations.SpecialStatus.NORMAL);
   }

From d13ea31903501f8e7ea8108ba08338b674a2b09d Mon Sep 17 00:00:00 2001
From: Constantine Plotnikov <Constantine.Plotnikov@jetbrains.com>
Date: Tue, 3 Aug 2010 11:38:35 +0400
Subject: [PATCH 29/42] git4idea: Fixed error highlighting in branch name
 editor

---
 .../git4idea/checkout/branches/GitSwitchBranchesDialog.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/git4idea/src/git4idea/checkout/branches/GitSwitchBranchesDialog.java b/plugins/git4idea/src/git4idea/checkout/branches/GitSwitchBranchesDialog.java
index b7e2965e8596..b90987d5186f 100644
--- a/plugins/git4idea/src/git4idea/checkout/branches/GitSwitchBranchesDialog.java
+++ b/plugins/git4idea/src/git4idea/checkout/branches/GitSwitchBranchesDialog.java
@@ -205,6 +205,7 @@ public class GitSwitchBranchesDialog extends DialogWrapper {
         verify();
       }
     });
+    verify();
     init();
   }
 
@@ -819,8 +820,7 @@ public class GitSwitchBranchesDialog extends DialogWrapper {
         @Override
         protected void textChanged(DocumentEvent e) {
           String s = myTextField.getText();
-          if (s.length() == 0 &&
-              (myInvalidValues == null || !myInvalidValues.contains(s)) &&
+          if ((myInvalidValues == null || !myInvalidValues.contains(s)) &&
               (s.length() == 0 || GitBranchNameValidator.INSTANCE.checkInput(s))) {
             myTextField.setForeground(myDefaultForeground);
           }

From e3d8d23be2db483e7a8824be52f057ba1890757a Mon Sep 17 00:00:00 2001
From: Roman Shevchenko <roman.shevchenko@jetbrains.com>
Date: Tue, 3 Aug 2010 11:44:25 +0400
Subject: [PATCH 30/42] New Java parser (multiline hack)

---
 .../lang/java/parser/DeclarationParser.java   | 73 +++++++++++++------
 .../lang/java/parser/JavaParserUtil.java      | 19 +++++
 .../declarations/MultiLineUnclosed.txt        |  2 +-
 .../parser/partial/DeclarationParserTest.java |  3 +-
 4 files changed, 70 insertions(+), 27 deletions(-)

diff --git a/java/java-impl/src/com/intellij/lang/java/parser/DeclarationParser.java b/java/java-impl/src/com/intellij/lang/java/parser/DeclarationParser.java
index 34f5ae8bda41..cd7a35024b76 100644
--- a/java/java-impl/src/com/intellij/lang/java/parser/DeclarationParser.java
+++ b/java/java-impl/src/com/intellij/lang/java/parser/DeclarationParser.java
@@ -24,6 +24,7 @@ import com.intellij.psi.impl.source.tree.JavaElementType;
 import com.intellij.psi.tree.IElementType;
 import com.intellij.psi.tree.ILazyParseableElementType;
 import com.intellij.psi.tree.TokenSet;
+import com.intellij.util.text.CharArrayUtil;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
@@ -43,6 +44,9 @@ public class DeclarationParser {
   private static final TokenSet APPEND_TO_METHOD_SET = TokenSet.create(
     JavaTokenType.IDENTIFIER, JavaTokenType.COMMA, JavaTokenType.THROWS_KEYWORD);
 
+  private static final String WHITESPACES = "\n\r \t";
+  private static final String LINE_ENDS = "\n\r";
+
   private DeclarationParser() { }
 
   public static void parseClassBodyWithBraces(final PsiBuilder builder, final boolean isAnnotation, final boolean isEnum) {
@@ -209,6 +213,7 @@ public class DeclarationParser {
     }
 
     final PsiBuilder.Marker declaration = builder.mark();
+    final int declarationStart = builder.getCurrentOffset();
 
     final Pair<PsiBuilder.Marker, Boolean> modListInfo = parseModifierList(builder);
     final PsiBuilder.Marker modList = modListInfo.first;
@@ -225,7 +230,7 @@ public class DeclarationParser {
     else if (ElementType.CLASS_KEYWORD_BIT_SET.contains(builder.getTokenType())) {
       final PsiBuilder.Marker root = parseClassFromKeyword(builder, declaration, false);
       if (context == Context.FILE) {
-        // todo: append following declarations to root
+        // todo: append following declarations to root (?)
         boolean declarationsAfterEnd = false;
 
         while (builder.getTokenType() != null && builder.getTokenType() != JavaTokenType.RBRACE) {
@@ -344,7 +349,7 @@ public class DeclarationParser {
     if (typeParams != null) {
       typeParams.precede().errorBefore(JavaErrorMessages.message("unexpected.token"), type);
     }
-    return parseFieldOrLocalVariable(builder, declaration, context);
+    return parseFieldOrLocalVariable(builder, declaration, declarationStart, context);
   }
 
   @NotNull
@@ -538,7 +543,7 @@ public class DeclarationParser {
 
   @Nullable
   private static PsiBuilder.Marker parseFieldOrLocalVariable(final PsiBuilder builder, final PsiBuilder.Marker declaration,
-                                                             final Context context) {
+                                                             final int declarationStart, final Context context) {
     final IElementType varType;
     if (context == Context.CLASS || context == Context.ANNOTATION_INTERFACE) {
       varType = JavaElementType.FIELD;
@@ -553,46 +558,66 @@ public class DeclarationParser {
     }
 
     PsiBuilder.Marker variable = declaration;
-    boolean openMarker = true;
+    boolean unclosed = false;
     boolean eatSemicolon = true;
-    boolean expectSemicolon = true;
+    boolean shouldRollback;
+    boolean openMarker = true;
     while (true) {
+      shouldRollback = true;
+
       if (!eatBrackets(builder)) {
-        expectSemicolon = false;
+        unclosed = true;
       }
 
       if (expect(builder, JavaTokenType.EQ)) {
         final PsiBuilder.Marker expr = ExpressionParser.parse(builder);
-        if (expr == null) {
+        if (expr != null) {
+          shouldRollback = false;
+        }
+        else {
           error(builder, JavaErrorMessages.message("expected.expression"));
-          expectSemicolon = false;
+          unclosed = true;
           break;
         }
       }
 
-      if (builder.getTokenType() == JavaTokenType.COMMA) {
-        variable.done(varType);
-        builder.advanceLexer();
-        variable = builder.mark();
-      }
-      else {
+      if (builder.getTokenType() != JavaTokenType.COMMA) break;
+      variable.done(varType);
+      builder.advanceLexer();
+
+      if (builder.getTokenType() != JavaTokenType.IDENTIFIER) {
+        error(builder, JavaErrorMessages.message("expected.identifier"));
+        unclosed = true;
+        eatSemicolon = false;
+        openMarker = false;
         break;
       }
 
-      if (!expect(builder, JavaTokenType.IDENTIFIER)) {
-        variable.drop();
-        error(builder, JavaErrorMessages.message("expected.identifier"));
-        openMarker = false;
-        eatSemicolon = false;
-        break;
-      }
+      variable = builder.mark();
+      builder.advanceLexer();
     }
 
-    if (eatSemicolon) {
-      if (!expect(builder, JavaTokenType.SEMICOLON) && expectSemicolon) {
+    if (builder.getTokenType() == JavaTokenType.SEMICOLON && eatSemicolon) {
+      builder.advanceLexer();
+    }
+    else {
+      // special treatment (see DeclarationParserTest.testMultiLineUnclosed())
+      if (!builder.eof() && shouldRollback) {
+        final CharSequence text = builder.getOriginalText();
+        final int spaceEnd = builder.getCurrentOffset();
+        final int spaceStart = CharArrayUtil.shiftBackward(text, spaceEnd-1, WHITESPACES);
+        final int lineStart = CharArrayUtil.shiftBackwardUntil(text, spaceEnd, LINE_ENDS);
+
+        if (declarationStart < lineStart && lineStart < spaceStart) {
+          final int newBufferEnd = CharArrayUtil.shiftForward(text, lineStart, WHITESPACES);
+          declaration.rollbackTo();
+          return parse(stoppingBuilder(builder, newBufferEnd), context);
+        }
+      }
+
+      if (!unclosed) {
         error(builder, JavaErrorMessages.message("expected.semicolon"));
       }
-      // todo: special treatment - see DeclarationParserTest.testMultiLineUnclosed()
     }
 
     if (openMarker) {
diff --git a/java/java-impl/src/com/intellij/lang/java/parser/JavaParserUtil.java b/java/java-impl/src/com/intellij/lang/java/parser/JavaParserUtil.java
index 6f949120096a..21e08de575e1 100644
--- a/java/java-impl/src/com/intellij/lang/java/parser/JavaParserUtil.java
+++ b/java/java-impl/src/com/intellij/lang/java/parser/JavaParserUtil.java
@@ -107,6 +107,25 @@ public class JavaParserUtil {
         }
         return (braceCount == 0 ? null : tokenType);
       }
+
+      @Override
+      public boolean eof() {
+        return braceCount == 0 || super.eof();
+      }
+    };
+  }
+
+  public static PsiBuilder stoppingBuilder(final PsiBuilder builder, final int stopAt) {
+    return new PsiBuilderAdapter(builder) {
+      @Override
+      public IElementType getTokenType() {
+        return getCurrentOffset() < stopAt ? super.getTokenType() : null;
+      }
+
+      @Override
+      public boolean eof() {
+        return getCurrentOffset() < stopAt || super.eof();
+      }
     };
   }
 
diff --git a/java/java-tests/testData/psi/parser-partial/declarations/MultiLineUnclosed.txt b/java/java-tests/testData/psi/parser-partial/declarations/MultiLineUnclosed.txt
index d44d8913422d..0f35986c3364 100644
--- a/java/java-tests/testData/psi/parser-partial/declarations/MultiLineUnclosed.txt
+++ b/java/java-tests/testData/psi/parser-partial/declarations/MultiLineUnclosed.txt
@@ -7,7 +7,7 @@ PsiJavaFile:MultiLineUnclosed.java
     PsiKeyword:int('int')
   PsiErrorElement:Identifier expected
     <empty list>
-  PsiWhiteSpace(' \n  ')
+  PsiWhiteSpace(' \n ')
   PsiField:o
     PsiModifierList:
       <empty list>
diff --git a/java/java-tests/testSrc/com/intellij/lang/java/parser/partial/DeclarationParserTest.java b/java/java-tests/testSrc/com/intellij/lang/java/parser/partial/DeclarationParserTest.java
index 8a51afbf9b6d..99a5853442a8 100644
--- a/java/java-tests/testSrc/com/intellij/lang/java/parser/partial/DeclarationParserTest.java
+++ b/java/java-tests/testSrc/com/intellij/lang/java/parser/partial/DeclarationParserTest.java
@@ -21,7 +21,6 @@ import com.intellij.lang.java.parser.JavaParsingTestCase;
 import com.intellij.pom.java.LanguageLevel;
 
 
-// todo: fix parser and uncomment tests
 public class DeclarationParserTest extends JavaParsingTestCase {
   public DeclarationParserTest() {
     super("parser-partial/declarations");
@@ -78,7 +77,7 @@ public class DeclarationParserTest extends JavaParsingTestCase {
   public void testUnclosedComma() { doParserTest("{ int field, }", false, false); }
   public void testUnclosedSemicolon() { doParserTest("{ int field }", false, false); }
   public void testMissingInitializerExpression() { doParserTest("{ int field=; }", false, false); }
-  //public void testMultiLineUnclosed() { doParserTest("{ int \n  Object o; }", false, false); }
+  public void testMultiLineUnclosed() { doParserTest("{ int \n Object o; }", false, false); }
 
   public void testMethodNormal0() { doParserTest("{ void f() {} }", false, false); }
   public void testMethodNormal1() { doParserTest("{ void f(); }", false, false); }

From caa601d62b2888b631764aa0e6afa0fd50179b40 Mon Sep 17 00:00:00 2001
From: Denis Zhdanov <Denis.Zhdanov@jetbrains.com>
Date: Tue, 3 Aug 2010 12:14:54 +0400
Subject: [PATCH 31/42] IDEA-56987    Throwable at
 EditorImpl.logicalToVisualPosition() on opening a database console

Accidently added debug output is removed
---
 .../src/com/intellij/openapi/editor/impl/EditorImpl.java        | 2 --
 1 file changed, 2 deletions(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
index 5bda19660b94..b6710317b8c0 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
@@ -1318,8 +1318,6 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
   }
 
   void paint(Graphics g) {
-    //TODO den remove
-    System.out.printf("EditorImpl.paint(): (%d; %d) - [%d; %d]%n", g.getClipBounds().x, g.getClipBounds().y, g.getClipBounds().width, g.getClipBounds().height);
     startOptimizedScrolling();
 
     if (myCursorUpdater != null) {

From 8779d6299a8703d7cfd224f5ee3cbb364387c934 Mon Sep 17 00:00:00 2001
From: Denis Zhdanov <Denis.Zhdanov@jetbrains.com>
Date: Tue, 3 Aug 2010 12:26:14 +0400
Subject: [PATCH 32/42] IDEA-53596 Soft wrap for editors

Text repainting algorithm is corrected for the situation of soft wrapped collapsed folding region
---
 .../openapi/editor/impl/EditorImpl.java       | 70 ++++++++++++-------
 1 file changed, 45 insertions(+), 25 deletions(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
index b6710317b8c0..ffcf6466a676 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
@@ -105,6 +105,7 @@ import java.util.List;
 import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.concurrent.ScheduledFuture;
 import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
 
 public final class EditorImpl extends UserDataHolderBase implements EditorEx, HighlighterClient, Queryable {
   private static final Logger LOG = Logger.getInstance("#com.intellij.openapi.editor.impl.EditorImpl");
@@ -122,7 +123,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
     ComplementaryFontsRegistry registry; // load costly font info
   }
 
-  private final CommandProcessor myCommandProcessor;              
+  private final CommandProcessor myCommandProcessor;
   private final MyScrollBar myVerticalScrollBar;
 
   private final CopyOnWriteArrayList<EditorMouseListener> myMouseListeners = ContainerUtil.createEmptyCOWList();
@@ -1748,7 +1749,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
 
     if (backColor != null && !backColor.equals(defaultBackground) && clip.intersects(position.x, position.y, w, getLineHeight())) {
       if (backColor.equals(myLastBackgroundColor) && myLastBackgroundPosition.y == position.y &&
-          myLastBackgroundPosition.x + myLastBackgroundWidth == position.x) {
+        myLastBackgroundPosition.x + myLastBackgroundWidth == position.x) {
         myLastBackgroundWidth += w;
       }
       else {
@@ -1793,8 +1794,14 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
 
     int visibleLineNumber = clip.y / lineHeight;
 
-    LogicalPosition logicalPosition = xyToLogicalPosition(new Point(0, clip.y));
-    int startLineNumber = logicalPosition.line;
+    // We use AtomicReference here just as a holder for LogicalPosition
+    // The main idea is that there is a possible case that we need to perform painting starting from soft-wrapped logical line.
+    // We may want to skip necessary of visual lines then. Hence, we remember logical position that corresponds to the starting
+    // visual line in order to use it for further processing. As soon as necessary number of visual lines is skipped, logical
+    // position is expected to be set to null as an indication that no soft wrap-introduced visual lines should be skipped on
+    // current painting iteration.
+    AtomicReference<LogicalPosition> logicalPosition = new AtomicReference<LogicalPosition>(xyToLogicalPosition(new Point(0, clip.y)));
+    int startLineNumber = logicalPosition.get().line;
 
     Point position = new Point(0, visibleLineNumber * lineHeight);
     if (startLineNumber == 0 && myPrefixText != null) {
@@ -1849,10 +1856,19 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
       else {
         FoldRegion collapsedFolderAt = iterationState.getCurrentFold();
         if (collapsedFolderAt != null) {
+          TextChange softWrap = mySoftWrapModel.getSoftWrap(collapsedFolderAt.getStartOffset());
+          if (softWrap != null && logicalPosition.get() != null) {
+            position.x = drawStringWithSoftWraps(
+              g, chars, collapsedFolderAt.getStartOffset(), collapsedFolderAt.getStartOffset(), position, clip, effectColor, effectType,
+              fontType, currentColor, logicalPosition
+            );
+          }
           int foldingXStart = position.x;
-          position.x =
-            drawStringWithSoftWraps(g, collapsedFolderAt.getPlaceholderText(), position, clip, effectColor, effectType,
-                                    fontType, currentColor, logicalPosition);
+          position.x = drawString(
+            g, collapsedFolderAt.getPlaceholderText(), position, clip, effectColor, effectType, fontType, currentColor
+          );
+          //drawStringWithSoftWraps(g, collapsedFolderAt.getPlaceholderText(), position, clip, effectColor, effectType,
+          //                        fontType, currentColor, logicalPosition);
           BorderEffect.paintFoldedEffect(g, foldingXStart, position.y, position.x, getLineHeight(), effectColor, effectType);
 
         }
@@ -1962,7 +1978,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
         final int lastCount = count - 1;
         final Color lastColor = color[lastCount];
         if (_data == myLastData && _start == ends[lastCount] && (_color == null || lastColor == null || _color == lastColor)
-            && _y == y[lastCount] /* there is a possible case that vertical position is adjusted because of soft wrap */) 
+          && _y == y[lastCount] /* there is a possible case that vertical position is adjusted because of soft wrap */)
         {
           ends[lastCount] = _end;
           if (lastColor == null) color[lastCount] = _color;
@@ -1995,7 +2011,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
   private void paintCaretCursor(Graphics g) {
     // There is a possible case that visual caret position is changed because of newly added or removed soft wraps.
     // We check if that's the case and ask caret model to recalculate visual position if necessary.
-    
+
     myCaretCursor.paint(g);
   }
 
@@ -2045,7 +2061,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
                                       EffectType effectType,
                                       int fontType,
                                       Color fontColor,
-                                      LogicalPosition startDrawingLogicalPosition)
+                                      AtomicReference<LogicalPosition> startDrawingLogicalPosition)
   {
     return drawStringWithSoftWraps(g, text.toCharArray(), 0, text.length(), position, clip, effectColor, effectType,
                                    fontType, fontColor, startDrawingLogicalPosition);
@@ -2061,16 +2077,19 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
                                       EffectType effectType,
                                       int fontType,
                                       Color fontColor,
-                                      LogicalPosition startDrawingLogicalPosition)
+                                      AtomicReference<LogicalPosition> startDrawingLogicalPosition)
   {
     int startToUse = start;
 
     // There is a possible case that starting logical line is split by soft-wraps and it's part after the split should be drawn.
     // We need to skip necessary number of visual lines then.
-    int softWrapLinesToSkip = startDrawingLogicalPosition.softWrapLinesOnCurrentLogicalLine;
+    int softWrapLinesToSkip = 0;
+    if (startDrawingLogicalPosition.get() != null) {
+      softWrapLinesToSkip = startDrawingLogicalPosition.get().softWrapLinesOnCurrentLogicalLine;
+    }
     TextChange lastSkippedSoftWrap = null;
     if (softWrapLinesToSkip > 0) {
-      List<? extends TextChange> softWraps = getSoftWrapModel().getSoftWrapsForLine(startDrawingLogicalPosition.line);
+      List<? extends TextChange> softWraps = getSoftWrapModel().getSoftWrapsForLine(startDrawingLogicalPosition.get().line);
       for (TextChange softWrap : softWraps) {
         softWrapLinesToSkip -= StringUtil.countNewLines(softWrap.getText());
         if (softWrapLinesToSkip <= 0) {
@@ -2079,13 +2098,14 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
           break;
         }
       }
-    }
 
+    }
     startToUse = Math.max(startToUse, start);
 
     if (startToUse >= end) {
       return position.x;
     }
+    startDrawingLogicalPosition.set(null);
 
     outer:
     for (TextChange softWrap : getSoftWrapModel().getSoftWrapsForRange(startToUse, end)) {
@@ -2739,7 +2759,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
     int column = EditorUtil.calcColumnNumber(this, text, start, offset, EditorUtil.getTabSize(this));
 
     if (softWrapAware) {
-    int line = calcLogicalLineNumber(offset, false);
+      int line = calcLogicalLineNumber(offset, false);
       return mySoftWrapModel.adjustLogicalPosition(new LogicalPosition(line, column), offset).column;
     }
     else {
@@ -2879,22 +2899,22 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
     int x = myGutterComponent.convertX(e.getX());
 
     if (x >= myGutterComponent.getLineNumberAreaOffset() &&
-        x < myGutterComponent.getLineNumberAreaOffset() + myGutterComponent.getLineNumberAreaWidth()) {
+      x < myGutterComponent.getLineNumberAreaOffset() + myGutterComponent.getLineNumberAreaWidth()) {
       return EditorMouseEventArea.LINE_NUMBERS_AREA;
     }
 
     if (x >= myGutterComponent.getAnnotationsAreaOffset() &&
-        x <= myGutterComponent.getAnnotationsAreaOffset() + myGutterComponent.getAnnotationsAreaWidth()) {
+      x <= myGutterComponent.getAnnotationsAreaOffset() + myGutterComponent.getAnnotationsAreaWidth()) {
       return EditorMouseEventArea.ANNOTATIONS_AREA;
     }
 
     if (x >= myGutterComponent.getLineMarkerAreaOffset() &&
-        x < myGutterComponent.getLineMarkerAreaOffset() + myGutterComponent.getLineMarkerAreaWidth()) {
+      x < myGutterComponent.getLineMarkerAreaOffset() + myGutterComponent.getLineMarkerAreaWidth()) {
       return EditorMouseEventArea.LINE_MARKERS_AREA;
     }
 
     if (x >= myGutterComponent.getFoldingAreaOffset() &&
-        x < myGutterComponent.getFoldingAreaOffset() + myGutterComponent.getFoldingAreaWidth()) {
+      x < myGutterComponent.getFoldingAreaOffset() + myGutterComponent.getFoldingAreaWidth()) {
       return EditorMouseEventArea.FOLDING_OUTLINE_AREA;
     }
 
@@ -2986,7 +3006,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
       int caretShift = newCaretOffset - mySavedSelectionStart;
 
       if (myMousePressedEvent != null && getMouseEventArea(myMousePressedEvent) != EditorMouseEventArea.EDITING_AREA &&
-          getMouseEventArea(myMousePressedEvent) != EditorMouseEventArea.LINE_NUMBERS_AREA) {
+        getMouseEventArea(myMousePressedEvent) != EditorMouseEventArea.LINE_NUMBERS_AREA) {
         selectionModel.setSelection(oldSelectionStart, newCaretOffset);
       }
       else {
@@ -4018,8 +4038,8 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
     public void mouseReleased(MouseEvent e) {
       runMouseReleasedCommand(e);
       if (!e.isConsumed() && myMousePressedEvent != null && !myMousePressedEvent.isConsumed() &&
-          Math.abs(e.getX() - myMousePressedEvent.getX()) < EditorUtil.getSpaceWidth(Font.PLAIN, EditorImpl.this) &&
-          Math.abs(e.getY() - myMousePressedEvent.getY()) < getLineHeight()) {
+        Math.abs(e.getX() - myMousePressedEvent.getX()) < EditorUtil.getSpaceWidth(Font.PLAIN, EditorImpl.this) &&
+        Math.abs(e.getY() - myMousePressedEvent.getY()) < getLineHeight()) {
         runMouseClickedCommand(e);
       }
       myMousePressedEvent = null;
@@ -4175,7 +4195,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
 
       myMouseSelectedRegion = myFoldingModel.getFoldingPlaceholderAt(new Point(x, y));
       myMousePressedInsideSelection = mySelectionModel.hasSelection() && caretOffset >= mySelectionModel.getSelectionStart() &&
-                                      caretOffset <= mySelectionModel.getSelectionEnd();
+        caretOffset <= mySelectionModel.getSelectionEnd();
 
       if (!myMousePressedInsideSelection && mySelectionModel.hasBlockSelection()) {
         int[] starts = mySelectionModel.getBlockSelectionStarts();
@@ -4561,7 +4581,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
       final Editor editor = getEditor(source);
       if (action == MOVE && !editor.isViewer()) {
         if (!FileDocumentManager.getInstance().requestWriting(editor.getDocument(), editor.getProject())) {
-            return;
+          return;
         }
         CommandProcessor.getInstance().executeCommand(((EditorImpl)editor).myProject, new Runnable() {
           public void run() {
@@ -4875,7 +4895,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
                                  : e.isControlDown() && !e.isMetaDown() && !e.isAltDown() && !e.isShiftDown();
         if (changeFontSize) {
           setFontSize(myScheme.getEditorFontSize() + e.getWheelRotation());
-          return;                                                            
+          return;
         }
       }
 

From 0309bfab72db52b8a899936675a314d61fc11aac Mon Sep 17 00:00:00 2001
From: Alexey Kudravtsev <cdr@intellij.com>
Date: Thu, 29 Jul 2010 16:19:20 +0400
Subject: [PATCH 33/42] misprints

---
 .../src/messages/CodeInsightBundle.properties                 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/platform/platform-resources-en/src/messages/CodeInsightBundle.properties b/platform/platform-resources-en/src/messages/CodeInsightBundle.properties
index 66a1abdcdd33..a805e1f0be06 100644
--- a/platform/platform-resources-en/src/messages/CodeInsightBundle.properties
+++ b/platform/platform-resources-en/src/messages/CodeInsightBundle.properties
@@ -224,11 +224,11 @@ javadoc.external.fetch.error.message=Cannot fetch remote documentation: {0}
 searching.for.implementations=Searching For Implementations...
 
 goto.implementation.chooserTitle=<html><body>Choose Implementation of <b>{0}</b> ({1} found)</body></html>
-goto.implementation.notFound=Not implementations found
+goto.implementation.notFound=No implementations found
 
 goto.test.chooserTitle.test=<html><body>Choose Test for <b>{0}</b> ({1} found)</body></html>
 goto.test.chooserTitle.subject=<html><body>Choose Test Subject for <b>{0}</b> ({1} found)</body></html>
-goto.test.notFound=Not test subjects found
+goto.test.notFound=No test subjects found
 
 incremental.search.tooltip.prefix=Search for:
 goto.super.method.chooser.title=Choose super method

From 0d2f3bc633c904f3fc6dced537a81fdb6a62610c Mon Sep 17 00:00:00 2001
From: Alexey Kudravtsev <cdr@intellij.com>
Date: Mon, 2 Aug 2010 13:49:50 +0400
Subject: [PATCH 34/42] diagnostics

---
 .../src/com/intellij/psi/util/TypeConversionUtil.java        | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/java/openapi/src/com/intellij/psi/util/TypeConversionUtil.java b/java/openapi/src/com/intellij/psi/util/TypeConversionUtil.java
index fde48c62adb2..8124ac523fe1 100644
--- a/java/openapi/src/com/intellij/psi/util/TypeConversionUtil.java
+++ b/java/openapi/src/com/intellij/psi/util/TypeConversionUtil.java
@@ -919,8 +919,9 @@ public class TypeConversionUtil {
       substitutor = getSuperClassSubstitutorInner(superClass, derivedClass, derivedSubstitutor, visited, manager);
     }
     if (substitutor == null) {
-      LOG.error("Not inheritor: " + derivedClass + "(" + derivedClass.getClass().getName() + ");" +
-                " super: " + superClass + "(" + derivedClass.getClass().getName() + ")");
+      LOG.error(
+        "Not inheritor: " + derivedClass + "(" + derivedClass.getClass().getName() + "; " + PsiUtil.getVirtualFile(derivedClass) + ");" +
+        "\n super: " + superClass + "(" + superClass.getClass().getName() + "; " + PsiUtil.getVirtualFile(superClass) + ")");
     }
     return substitutor;
   }

From 95cab0b06a5d6f1381206c24ec066013e6f71809 Mon Sep 17 00:00:00 2001
From: Alexey Kudravtsev <cdr@intellij.com>
Date: Mon, 2 Aug 2010 18:46:25 +0400
Subject: [PATCH 35/42] cleanup

---
 .../plugins/relaxNG/HighlightingTestBase.java | 60 ++++++-------------
 1 file changed, 17 insertions(+), 43 deletions(-)

diff --git a/plugins/relaxng/test/org/intellij/plugins/relaxNG/HighlightingTestBase.java b/plugins/relaxng/test/org/intellij/plugins/relaxNG/HighlightingTestBase.java
index 08dc74d42a96..183daee3f4a8 100644
--- a/plugins/relaxng/test/org/intellij/plugins/relaxNG/HighlightingTestBase.java
+++ b/plugins/relaxng/test/org/intellij/plugins/relaxNG/HighlightingTestBase.java
@@ -16,22 +16,20 @@
 
 package org.intellij.plugins.relaxNG;
 
-import com.intellij.codeHighlighting.TextEditorHighlightingPass;
 import com.intellij.codeInsight.daemon.QuickFixProvider;
-import com.intellij.codeInsight.daemon.impl.*;
+import com.intellij.codeInsight.daemon.impl.HighlightInfo;
+import com.intellij.codeInsight.daemon.impl.HighlightInfoType;
 import com.intellij.codeInsight.intention.IntentionAction;
 import com.intellij.codeInspection.InspectionToolProvider;
 import com.intellij.codeInspection.htmlInspections.RequiredAttributesInspection;
 import com.intellij.javaee.ExternalResourceManagerEx;
 import com.intellij.mock.MockProgressIndicator;
-import com.intellij.openapi.application.ApplicationManager;
 import com.intellij.openapi.application.PluginPathManager;
 import com.intellij.openapi.application.Result;
 import com.intellij.openapi.application.WriteAction;
 import com.intellij.openapi.command.WriteCommandAction;
 import com.intellij.openapi.editor.Document;
 import com.intellij.openapi.editor.Editor;
-import com.intellij.openapi.progress.ProgressManager;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.*;
 import com.intellij.openapi.util.io.FileUtil;
@@ -44,7 +42,7 @@ import com.intellij.testFramework.fixtures.CodeInsightTestFixture;
 import com.intellij.testFramework.fixtures.IdeaProjectTestFixture;
 import com.intellij.testFramework.fixtures.IdeaTestFixtureFactory;
 import com.intellij.testFramework.fixtures.TestFixtureBuilder;
-import com.intellij.util.ArrayUtil;
+import com.intellij.testFramework.fixtures.impl.CodeInsightTestFixtureImpl;
 import junit.framework.TestCase;
 import org.intellij.plugins.relaxNG.inspections.RngDomInspection;
 import org.intellij.plugins.testUtil.IdeaCodeInsightTestCase;
@@ -54,10 +52,7 @@ import org.jetbrains.annotations.Nullable;
 
 import java.io.File;
 import java.io.IOException;
-import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Collections;
-import java.util.List;
 
 import static com.intellij.openapi.util.io.FileUtil.delete;
 
@@ -196,44 +191,23 @@ public abstract class HighlightingTestBase extends TestCase implements IdeaCodeI
   }
 
   @NotNull
-  private Collection<HighlightInfo> doHighlighting(final Boolean includeExternalToolPass) {
+  private Collection<HighlightInfo> doHighlighting(final Boolean externalToolPass) {
     final Project project = myTestFixture.getProject();
     PsiDocumentManager.getInstance(project).commitAllDocuments();
+    final Editor editor = myTestFixture.getEditor();
 
-    return ApplicationManager.getApplication().runReadAction(new Computable<Collection<HighlightInfo>>() {
-              public Collection<HighlightInfo> compute() {
-                final Editor editor = myTestFixture.getEditor();
-                final List<TextEditorHighlightingPass> passes =
-                        TextEditorHighlightingPassRegistrarEx.getInstanceEx(project).instantiatePasses(myTestFixture.getFile(), editor, ArrayUtil.EMPTY_INT_ARRAY);
-                final MockProgressIndicator progress = new MyMockProgressIndicator();
-
-                Runnable runnable = new Runnable() {
-                  public void run() {
-                    for (TextEditorHighlightingPass pass : passes) {
-                      if (includeExternalToolPass == null) {
-                        pass.collectInformation(progress);
-                      } else {
-                        if (includeExternalToolPass == pass instanceof ExternalToolPass) {
-                          pass.collectInformation(progress);
-                        }
-                      }
-                    }
-                    for (TextEditorHighlightingPass pass : passes) {
-                      if (includeExternalToolPass == null) {
-                        pass.applyInformationToEditor();
-                      } else {
-                        if (includeExternalToolPass == pass instanceof ExternalToolPass) {
-                          pass.applyInformationToEditor();
-                        }
-                      }
-                    }
-                  }
-                };
-                ProgressManager.getInstance().runProcess(runnable, progress);
-                List<HighlightInfo> infos = DaemonCodeAnalyzerImpl.getHighlights(editor.getDocument(), project);
-                return infos == null ? Collections.<HighlightInfo>emptyList() : new ArrayList<HighlightInfo>(infos);
-              }
-            });
+    int[] ignore = externalToolPass == null || externalToolPass ? new int[]{
+      com.intellij.codeHighlighting.Pass.LINE_MARKERS,
+      com.intellij.codeHighlighting.Pass.LOCAL_INSPECTIONS,
+      com.intellij.codeHighlighting.Pass.POPUP_HINTS,
+      com.intellij.codeHighlighting.Pass.POST_UPDATE_ALL,
+      com.intellij.codeHighlighting.Pass.UPDATE_ALL,
+      com.intellij.codeHighlighting.Pass.UPDATE_FOLDING,
+      com.intellij.codeHighlighting.Pass.UPDATE_OVERRIDEN_MARKERS,
+      com.intellij.codeHighlighting.Pass.UPDATE_VISIBLE,
+      com.intellij.codeHighlighting.Pass.VISIBLE_LINE_MARKERS,
+    } : new int[]{com.intellij.codeHighlighting.Pass.EXTERNAL_TOOLS};
+    return CodeInsightTestFixtureImpl.instantiateAndRun(myTestFixture.getFile(), editor, ignore, false);
   }
 
   protected void doTestCompletion(String name, String ext) throws Throwable {

From bc862d340030bf5a01dc6d1ca109edc7af8789d3 Mon Sep 17 00:00:00 2001
From: Alexey Kudravtsev <cdr@intellij.com>
Date: Tue, 3 Aug 2010 12:22:12 +0400
Subject: [PATCH 36/42] dup line IDEA-57026

---
 .../com/intellij/openapi/editor/actions/DuplicateAction.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/actions/DuplicateAction.java b/platform/platform-impl/src/com/intellij/openapi/editor/actions/DuplicateAction.java
index bc1d90c8e724..6d9cd2083c40 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/actions/DuplicateAction.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/actions/DuplicateAction.java
@@ -61,6 +61,9 @@ public class DuplicateAction extends EditorAction {
       VisualPosition caret = editor.getCaretModel().getVisualPosition();
       LogicalPosition lineStart = editor.visualToLogicalPosition(new VisualPosition(caret.line, 0));
       LogicalPosition nextLineStart = editor.visualToLogicalPosition(new VisualPosition(caret.line + 1, 0));
+      if (nextLineStart.line == lineStart.line) {
+        nextLineStart = new LogicalPosition(lineStart.line+1, 0);
+      }
 
       int start = editor.logicalPositionToOffset(lineStart);
       int end = editor.logicalPositionToOffset(nextLineStart);
@@ -86,4 +89,4 @@ public class DuplicateAction extends EditorAction {
       presentation.setText(EditorBundle.message("action.duplicate.line"), true);
     }
   }
-}
\ No newline at end of file
+}

From 289e8164e643bb2e64348d09cf1bf71ef3dc8595 Mon Sep 17 00:00:00 2001
From: Alexey Kudravtsev <cdr@intellij.com>
Date: Tue, 3 Aug 2010 12:30:59 +0400
Subject: [PATCH 37/42] during resolve and search for inheritors prefer classes
 from my own jar

---
 .../intellij/psi/impl/PsiClassImplUtil.java   | 37 +++++++++----
 .../ClsJavaCodeReferenceElementImpl.java      | 11 +++-
 .../search/JavaDirectInheritorsSearcher.java  | 54 ++++++++++++++++++-
 3 files changed, 88 insertions(+), 14 deletions(-)

diff --git a/java/java-impl/src/com/intellij/psi/impl/PsiClassImplUtil.java b/java/java-impl/src/com/intellij/psi/impl/PsiClassImplUtil.java
index c7b5702785e1..1f065c2513a6 100644
--- a/java/java-impl/src/com/intellij/psi/impl/PsiClassImplUtil.java
+++ b/java/java-impl/src/com/intellij/psi/impl/PsiClassImplUtil.java
@@ -21,7 +21,6 @@ import com.intellij.openapi.roots.ProjectRootManager;
 import com.intellij.openapi.util.*;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.psi.*;
-import com.intellij.psi.augment.PsiAugmentProvider;
 import com.intellij.psi.filters.OrFilter;
 import com.intellij.psi.impl.compiled.ClsElementImpl;
 import com.intellij.psi.impl.source.PsiImmediateClassType;
@@ -39,10 +38,7 @@ import com.intellij.psi.search.SearchScope;
 import com.intellij.psi.util.*;
 import com.intellij.ui.IconDeferrer;
 import com.intellij.ui.RowIcon;
-import com.intellij.util.Function;
-import com.intellij.util.IncorrectOperationException;
-import com.intellij.util.ReflectionCache;
-import com.intellij.util.SmartList;
+import com.intellij.util.*;
 import com.intellij.util.containers.HashMap;
 import gnu.trove.THashSet;
 import org.jetbrains.annotations.NonNls;
@@ -864,6 +860,7 @@ public class PsiClassImplUtil {
   }
 
   public static boolean isClassEquivalentTo(PsiClass aClass, PsiElement another) {
+    if (aClass == another) return true;
     if (!(another instanceof PsiClass)) return false;
     String name1 = aClass.getName();
     if (name1 == null) return false;
@@ -900,17 +897,13 @@ public class PsiClassImplUtil {
 
     final PsiFile file1 = aClass.getContainingFile().getOriginalFile();
     final PsiFile file2 = another.getContainingFile().getOriginalFile();
-    if (file1.equals(file2)) {
-      return true;
-    }
 
     //see com.intellij.openapi.vcs.changes.PsiChangeTracker
     //see com.intellij.psi.impl.PsiFileFactoryImpl#createFileFromText(CharSequence,PsiFile)
     final PsiFile original1 = file1.getUserData(PsiFileFactory.ORIGINAL_FILE);
     final PsiFile original2 = file2.getUserData(PsiFileFactory.ORIGINAL_FILE);
-    if (original1 == original2 && original1 != null
-        || original1 == file2 || original2 == file1) {
-      return true;
+    if (original1 == original2 && original1 != null || original1 == file2 || original2 == file1 || file1 == file2) {
+      return compareClassSeqNumber(aClass, (PsiClass)another);
     }    
 
     final ProjectFileIndex fileIndex = ProjectRootManager.getInstance(aClass.getProject()).getFileIndex();
@@ -920,6 +913,28 @@ public class PsiClassImplUtil {
            (fileIndex.isInSource(vfile2) || fileIndex.isInLibraryClasses(vfile2));
   }
 
+  private static boolean compareClassSeqNumber(PsiClass aClass, PsiClass another) {
+    // there may be several classes in one file, they must not be equal
+    int index1 = getSeqNumber(aClass);
+    if (index1 == -1) return true;
+    int index2 = getSeqNumber(another);
+    return index1 == index2;
+  }
+
+  private static int getSeqNumber(PsiClass aClass) {
+    // sequence number of this class among its parent' child classes named the same
+    PsiElement parent = aClass.getParent();
+    if (parent == null) return -1;
+    int seqNo = 0;
+    for (PsiElement child : parent.getChildren()) {
+      if (child == aClass) return seqNo;
+      if (child instanceof PsiClass && Comparing.strEqual(aClass.getName(), ((PsiClass)child).getName())) {
+        seqNo++;
+      }
+    }
+    return -1;
+  }
+
   private static PsiElement originalElement(PsiClass aClass) {
     final PsiElement originalElement = aClass.getOriginalElement();
     final PsiCompiledElement compiled = originalElement.getUserData(ClsElementImpl.COMPILED_ELEMENT);
diff --git a/java/java-impl/src/com/intellij/psi/impl/compiled/ClsJavaCodeReferenceElementImpl.java b/java/java-impl/src/com/intellij/psi/impl/compiled/ClsJavaCodeReferenceElementImpl.java
index 7238fb8feccd..eb37c848fbcb 100644
--- a/java/java-impl/src/com/intellij/psi/impl/compiled/ClsJavaCodeReferenceElementImpl.java
+++ b/java/java-impl/src/com/intellij/psi/impl/compiled/ClsJavaCodeReferenceElementImpl.java
@@ -20,6 +20,7 @@ import com.intellij.openapi.util.text.StringUtil;
 import com.intellij.psi.*;
 import com.intellij.psi.impl.PsiManagerEx;
 import com.intellij.psi.impl.PsiSubstitutorImpl;
+import com.intellij.psi.impl.search.JavaDirectInheritorsSearcher;
 import com.intellij.psi.impl.source.resolve.ResolveCache;
 import com.intellij.psi.impl.source.tree.JavaElementType;
 import com.intellij.psi.impl.source.tree.TreeElement;
@@ -167,7 +168,15 @@ public class ClsJavaCodeReferenceElementImpl extends ClsElementImpl implements P
     for (PsiTypeParameter parameter : PsiUtil.typeParametersIterable((PsiTypeParameterListOwner)element)) {
       if (myQualifiedName.equals(parameter.getName())) return parameter;
     }
-    return JavaPsiFacade.getInstance(getProject()).findClass(myQualifiedName, getResolveScope());
+    return resolveClassPreferringMyJar();
+  }
+
+  private PsiClass resolveClassPreferringMyJar() {
+    PsiClass[] classes = JavaPsiFacade.getInstance(getProject()).findClasses(myQualifiedName, getResolveScope());
+    for (PsiClass aClass : classes) {
+      if (JavaDirectInheritorsSearcher.isFromTheSameJar(aClass, this)) return aClass;
+    }
+    return classes.length == 0 ? null : classes[0];
   }
 
   public void processVariants(PsiScopeProcessor processor) {
diff --git a/java/java-impl/src/com/intellij/psi/impl/search/JavaDirectInheritorsSearcher.java b/java/java-impl/src/com/intellij/psi/impl/search/JavaDirectInheritorsSearcher.java
index 5340828d80fe..8a051aefa30b 100644
--- a/java/java-impl/src/com/intellij/psi/impl/search/JavaDirectInheritorsSearcher.java
+++ b/java/java-impl/src/com/intellij/psi/impl/search/JavaDirectInheritorsSearcher.java
@@ -8,6 +8,8 @@ import com.intellij.openapi.fileTypes.StdFileTypes;
 import com.intellij.openapi.progress.ProgressManager;
 import com.intellij.openapi.util.Computable;
 import com.intellij.openapi.util.text.StringUtil;
+import com.intellij.openapi.vfs.JarFileSystem;
+import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.psi.*;
 import com.intellij.psi.impl.PsiManagerImpl;
 import com.intellij.psi.impl.java.stubs.index.JavaAnonymousClassBaseRefOccurenceIndex;
@@ -19,14 +21,17 @@ import com.intellij.psi.search.searches.AllClassesSearch;
 import com.intellij.psi.search.searches.DirectClassInheritorsSearch;
 import com.intellij.util.Processor;
 import com.intellij.util.QueryExecutor;
+import com.intellij.util.containers.HashMap;
 
+import java.util.ArrayList;
 import java.util.Collection;
+import java.util.List;
+import java.util.Map;
 
 /**
  * @author max
  */
 public class JavaDirectInheritorsSearcher implements QueryExecutor<PsiClass, DirectClassInheritorsSearch.SearchParameters> {
-
   public boolean execute(final DirectClassInheritorsSearch.SearchParameters p, final Processor<PsiClass> consumer) {
     final PsiClass aClass = p.getClassToProcess();
     final PsiManagerImpl psiManager = (PsiManagerImpl)PsiManager.getInstance(aClass.getProject());
@@ -73,10 +78,22 @@ public class JavaDirectInheritorsSearcher implements QueryExecutor<PsiClass, Dir
       }
     });
 
+    Map<String, List<PsiClass>> classes = new HashMap<String, List<PsiClass>>();
+
     for (PsiReferenceList referenceList : candidates) {
       ProgressManager.checkCanceled();
       PsiClass candidate = (PsiClass)referenceList.getParent();
-      if (!consumer.process(candidate)) return false;
+      String fqn = candidate.getQualifiedName();
+      List<PsiClass> list = classes.get(fqn);
+      if (list == null) {
+        list = new ArrayList<PsiClass>();
+        classes.put(fqn, list);
+      }
+      list.add(candidate);
+    }
+
+    for (List<PsiClass> sameNamedClasses : classes.values()) {
+      if (!processSameNamedClasses(consumer, aClass, sameNamedClasses)) return false;
     }
 
     if (p.includeAnonymous()) {
@@ -116,4 +133,37 @@ public class JavaDirectInheritorsSearcher implements QueryExecutor<PsiClass, Dir
 
     return true;
   }
+
+  private static boolean processSameNamedClasses(Processor<PsiClass> consumer, PsiClass aClass, List<PsiClass> sameNamedClasses) {
+    // if there is a class from the same jar, prefer it
+    boolean sameJarClassFound = false;
+    for (PsiClass sameNamedClass : sameNamedClasses) {
+      boolean fromSameJar = isFromTheSameJar(sameNamedClass, aClass);
+      if (fromSameJar) {
+        sameJarClassFound = true;
+        if (!consumer.process(sameNamedClass)) return false;
+      }
+    }
+
+    if (!sameJarClassFound) {
+      for (PsiClass sameNamedClass : sameNamedClasses) {
+        if (!consumer.process(sameNamedClass)) return false;
+      }
+    }
+    return true;
+  }
+
+  private static VirtualFile getJarFile(PsiElement candidate) {
+    VirtualFile file = candidate.getContainingFile().getVirtualFile();
+    if (file != null && file.getFileSystem() instanceof JarFileSystem) {
+      return JarFileSystem.getInstance().getVirtualFileForJar(file);
+    }
+    return file;
+  }
+  public static boolean isFromTheSameJar(PsiElement candidate, PsiElement other) {
+    VirtualFile c1 = getJarFile(candidate);
+    VirtualFile c2 = getJarFile(other);
+    return c1 != null && c1 == c2;
+  }
+
 }

From 3f4fb7fd78bd5e4c6cb6534738ac7d0ef110a58a Mon Sep 17 00:00:00 2001
From: Maxim Shafirov <max@jetbrains.com>
Date: Tue, 3 Aug 2010 13:04:19 +0400
Subject: [PATCH 38/42] Cheaper lock

---
 .../lang-impl/src/com/intellij/psi/impl/source/PsiFileImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/platform/lang-impl/src/com/intellij/psi/impl/source/PsiFileImpl.java b/platform/lang-impl/src/com/intellij/psi/impl/source/PsiFileImpl.java
index dbca10b833aa..c78054c1ec27 100644
--- a/platform/lang-impl/src/com/intellij/psi/impl/source/PsiFileImpl.java
+++ b/platform/lang-impl/src/com/intellij/psi/impl/source/PsiFileImpl.java
@@ -76,7 +76,7 @@ public abstract class PsiFileImpl extends ElementBase implements PsiFileEx, PsiF
   protected PsiFile myOriginalFile = null;
   private final FileViewProvider myViewProvider;
   private static final Key<Document> HARD_REFERENCE_TO_DOCUMENT = new Key<Document>("HARD_REFERENCE_TO_DOCUMENT");
-  private final Object myStubLock = new String("file's stub lock");
+  private final Object myStubLock = new Object();
   private SoftReference<StubTree> myStub;
   protected final PsiManagerEx myManager;
   private volatile Object myTreeElementPointer; // SoftReference/WeakReference to RepositoryTreeElement when has repository id, RepositoryTreeElement otherwise

From 3961971af7b456175ee0638b606d945de595aaf0 Mon Sep 17 00:00:00 2001
From: Denis Zhdanov <Denis.Zhdanov@jetbrains.com>
Date: Tue, 3 Aug 2010 13:35:13 +0400
Subject: [PATCH 39/42] IDEA-56409    Soft wrap, editing: AIOOBE at
 EditorImpl$EditorSizeContainer.changedUpdate() on removing a code that
 doesn't fit editor's width and height

1. Editor size container operates with logical lines instead of visual now;
2. Added explicit checks into soft wrap-related mapping algorithm that target situation with complete document change replacements;
---
 .../com/intellij/openapi/editor/impl/CaretModelImpl.java  | 4 ++--
 .../src/com/intellij/openapi/editor/impl/EditorImpl.java  | 8 ++++----
 .../openapi/editor/impl/softwrap/SoftWrapDataMapper.java  | 8 ++++++++
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/CaretModelImpl.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/CaretModelImpl.java
index 2870ab265133..d45828c5a68b 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/CaretModelImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/CaretModelImpl.java
@@ -480,11 +480,11 @@ public class CaretModelImpl implements CaretModel, PrioritizedDocumentListener {
     int y = myEditor.visualPositionToXY(visualPosition).y;
     int height = myEditor.getLineHeight();
     int visualLine = visualPosition.line + 1;
-    while (true) {
+    int lastVisualLine = myEditor.offsetToVisualPosition(document.getTextLength() - 1).line;
+    for (; visualLine <= lastVisualLine; visualLine++) {
       LogicalPosition logical = myEditor.visualToLogicalPosition(new VisualPosition(visualLine, 0));
       if (logical.line == logicalLine) {
         height += myEditor.getLineHeight();
-        visualLine++;
       }
       else {
         break;
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
index ffcf6466a676..c6e6602858aa 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorImpl.java
@@ -4654,7 +4654,7 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
         myMaxWidth = mySize != null ? mySize.width : -1;
       }
 
-      myOldEndLine = getVisualPositionLine(e.getOffset() + e.getOldLength());
+      myOldEndLine = offsetToLogicalPosition(e.getOffset() + e.getOldLength()).line;
     }
 
     private int getVisualPositionLine(int offset) {
@@ -4685,15 +4685,15 @@ public final class EditorImpl extends UserDataHolderBase implements EditorEx, Hi
           myLineWidths.insert(oldEndLine + 1, delta);
         }
         else if (oldEndLine > newEndLine && !toAddNewLines && newEndLine + 1 < lineWidthSize) {
-          myLineWidths.remove(newEndLine + 1, Math.min(oldEndLine, lineWidthSize) - newEndLine);
+          myLineWidths.remove(newEndLine + 1, Math.min(oldEndLine, lineWidthSize) - newEndLine - 1);
         }
         myIsDirty = true;
       }
     }
 
     public synchronized void changedUpdate(DocumentEvent e) {
-      int startLine = e.getOldLength() == 0 ? myOldEndLine : getVisualPositionLine(e.getOffset());
-      int newEndLine = e.getNewLength() == 0 ? startLine : getVisualPositionLine(e.getOffset() + e.getNewLength());
+      int startLine = e.getOldLength() == 0 ? myOldEndLine : offsetToLogicalPosition(e.getOffset()).line;
+      int newEndLine = e.getNewLength() == 0 ? startLine : offsetToLogicalPosition(e.getOffset() + e.getNewLength()).line;
       int oldEndLine = myOldEndLine;
 
       update(startLine, newEndLine, oldEndLine);
diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapper.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapper.java
index cc965b8ff252..9250d2cc4be1 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapper.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/softwrap/SoftWrapDataMapper.java
@@ -240,6 +240,10 @@ public class SoftWrapDataMapper {
 
     @Nullable
     private LogicalPosition process(@NotNull FoldRegion region) {
+      int endDocumentOffset = myEditor.getDocument().getTextLength();
+      if (region.getEndOffset() >= endDocumentOffset) {
+        return advanceToOffset(endDocumentOffset).build();
+      }
       if (region.getStartOffset() > context.offset) {
         Context newContext = advanceToOffset(region.getStartOffset());
         if (strategy.exceeds(newContext)) {
@@ -289,6 +293,10 @@ public class SoftWrapDataMapper {
 
     @Nullable
     private LogicalPosition process(@NotNull TextChange softWrap) {
+      int endDocumentOffset = myEditor.getDocument().getTextLength();
+      if (softWrap.getStart() >= endDocumentOffset) {
+        return advanceToOffset(endDocumentOffset).build();
+      }
       Context newContext = advanceToOffset(softWrap.getStart());
       if (strategy.exceeds(newContext)) {
         return strategy.build(context);

From 04b5481541b4745be623544db4b1e0ab8489ee82 Mon Sep 17 00:00:00 2001
From: Denis Zhdanov <Denis.Zhdanov@jetbrains.com>
Date: Tue, 3 Aug 2010 13:37:38 +0400
Subject: [PATCH 40/42] IDEA-53596 Soft wrap for editors

Added explicit check for invalid (non-positive) tabulation size (occurs at least at tests).
---
 .../src/com/intellij/openapi/editor/ex/util/EditorUtil.java    | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java b/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
index caa6447c085f..7e7378af51f4 100644
--- a/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
+++ b/platform/platform-impl/src/com/intellij/openapi/editor/ex/util/EditorUtil.java
@@ -407,6 +407,9 @@ public class EditorUtil {
   }
 
   public static int nextTabStop(int x, Editor editor, int tabSize) {
+    if (tabSize <= 0) {
+      return x + getSpaceWidth(Font.PLAIN, editor);
+    }
     tabSize *= getSpaceWidth(Font.PLAIN, editor);
 
     int nTabs = x / tabSize;

From 09208962c4f17e16a9208b3ddc0fd4f7ebf4d7ec Mon Sep 17 00:00:00 2001
From: Dmitry Avdeev <Dmitry.Avdeev@jetbrains.com>
Date: Mon, 2 Aug 2010 16:19:27 +0400
Subject: [PATCH 41/42] EL references are no more soft in included files

---
 .../src/messages/PsiBundle.properties                     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/platform/platform-resources-en/src/messages/PsiBundle.properties b/platform/platform-resources-en/src/messages/PsiBundle.properties
index dc1b7f09915e..9c5f405feee4 100644
--- a/platform/platform-resources-en/src/messages/PsiBundle.properties
+++ b/platform/platform-resources-en/src/messages/PsiBundle.properties
@@ -32,14 +32,14 @@ el.lparen.expected=( expected
 el.rparen.expected=) expected
 el.colon.expected=: expected
 el.value.expected=Value expected
-el.cannot.resolve.function=Cannot resolve function {0} #loc
-el.cannot.resolve.namespace=Cannot resolve namespace {0} #loc
-el.cannot.resolve.property=Cannot resolve property or method {0} (dynamic property?) #loc
+el.cannot.resolve.function=Cannot resolve function ''{0}'' #loc
+el.cannot.resolve.namespace=Cannot resolve namespace ''{0}'' #loc
+el.cannot.resolve.property=Cannot resolve property or method ''{0}'' (dynamic property?) #loc
 el.mismatched.parameters.count=Different number of formal and actual parameters
 el.declare.variable.intention.family=Declare Variable As External Data
 el.declare.variable.via.usebean.intention.name=Declare external variable as <jsp:useBean />
 el.declare.variable.via.comment.annotation.intention.name=Declare external variable in comment annotation
-el.cannot.resolve.variable=Cannot resolve variable {0} #loc
+el.cannot.resolve.variable=Cannot resolve variable ''{0}'' #loc
 jsf.el.out.of.attribute=JSF EL out of attribute #loc
 jsf.method.call.is.nonstd.extension=Method call is nonstandard extension #loc
 

From c77f71fdaee2d611ef33422b5e2e3cb7796e7108 Mon Sep 17 00:00:00 2001
From: Oleg Shpynov <oleg.shpynov@jebrains.com>
Date: Tue, 3 Aug 2010 15:29:34 +0400
Subject: [PATCH 42/42] CommentByLine Test fixes

---
 .../codeInsight/generation/CommentByLineCommentHandler.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByLineCommentHandler.java b/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByLineCommentHandler.java
index 012b2e419daf..71b1d89fac7c 100644
--- a/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByLineCommentHandler.java
+++ b/platform/lang-impl/src/com/intellij/codeInsight/generation/CommentByLineCommentHandler.java
@@ -224,7 +224,7 @@ public class CommentByLineCommentHandler implements CodeInsightActionHandler {
     }
 
     boolean allLineCommented = true;
-    boolean commentWithIndent = CodeStyleSettingsManager.getSettings(myProject).LINE_COMMENT_AT_FIRST_COLUMN;
+    boolean commentWithIndent = !CodeStyleSettingsManager.getSettings(myProject).LINE_COMMENT_AT_FIRST_COLUMN;
 
     for (int line = myStartLine; line <= myEndLine; line++) {
       Commenter commenter = blockSuitableCommenter != null ? blockSuitableCommenter : findCommenter(line);