From dfb190aed7ef8abb4ef7b848ae7f38834d993146 Mon Sep 17 00:00:00 2001 From: Alexey Kudravtsev Date: Wed, 30 Dec 2015 14:10:28 +0300 Subject: [PATCH] testCOWListPerformanceAdd: test addition instead of iteration --- .../util/containers/ContainerUtilTest.java | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/platform/platform-tests/testSrc/com/intellij/util/containers/ContainerUtilTest.java b/platform/platform-tests/testSrc/com/intellij/util/containers/ContainerUtilTest.java index 69a416aaa90d..172afcafe4aa 100644 --- a/platform/platform-tests/testSrc/com/intellij/util/containers/ContainerUtilTest.java +++ b/platform/platform-tests/testSrc/com/intellij/util/containers/ContainerUtilTest.java @@ -19,7 +19,6 @@ package com.intellij.util.containers; import com.intellij.openapi.util.Condition; import com.intellij.testFramework.PlatformTestUtil; import com.intellij.util.ArrayUtil; -import com.intellij.util.ThrowableRunnable; import gnu.trove.TIntArrayList; import junit.framework.TestCase; @@ -228,19 +227,19 @@ public class ContainerUtilTest extends TestCase { } public void testCOWListPerformanceAdd() { - PlatformTestUtil.startPerformanceTest("COWList add", 3000, new ThrowableRunnable() { - @Override - public void run() throws Throwable { - List my = ContainerUtil.createLockFreeCopyOnWriteList(); - long start = System.currentTimeMillis(); + List my = ContainerUtil.createLockFreeCopyOnWriteList(); + PlatformTestUtil.startPerformanceTest("COWList add", 3000, () -> { + List local = my; + for (int it=0; it<10; it++) { + local.clear(); for (int i = 0; i < 15000; i++) { - my.add(i); - assertEquals(i, my.indexOf(i)); + local.add(i); } - long elapsed = System.currentTimeMillis() - start; - System.out.println("elapsed = " + elapsed); } }).useLegacyScaling().assertTiming(); + for (int i = 0; i < my.size(); i++) { + assertEquals(i, my.get(i)); + } } private static void assertReallyEmpty(List my) {