From dfafd52e2102fd5dfced8055cac659ed1dcde140 Mon Sep 17 00:00:00 2001 From: Alexey Belkov Date: Tue, 28 Nov 2023 13:59:02 +0400 Subject: [PATCH] [java-analysis] NullityInferrer: don't try to add both annotations to a variable The conditions are mutually exclusive logically, and the `else` keyword makes it explicit. GitOrigin-RevId: cbb0b81fb4495f2ac74e7e190f9289a232bde2be --- .../intellij/codeInspection/inferNullity/NullityInferrer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/java-impl/src/com/intellij/codeInspection/inferNullity/NullityInferrer.java b/java/java-impl/src/com/intellij/codeInspection/inferNullity/NullityInferrer.java index d0b267ff1744..2a494da35bde 100644 --- a/java/java-impl/src/com/intellij/codeInspection/inferNullity/NullityInferrer.java +++ b/java/java-impl/src/com/intellij/codeInspection/inferNullity/NullityInferrer.java @@ -231,7 +231,7 @@ public class NullityInferrer { if (variableNeverAssignedNull(variable)) { registerNotNullAnnotation(variable); } - if (variableSometimesAssignedNull(variable)) { + else if (variableSometimesAssignedNull(variable)) { registerNullableAnnotation(variable); } }