From df1105f4b1b41ca4790b7a3d8ca4c3672937ad61 Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Mon, 14 Apr 2014 20:37:40 +0200 Subject: [PATCH] do not write new setting to profile if it has not changed from the default value --- ...egexReplaceableByCompiledPatternInspectionBase.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/DynamicRegexReplaceableByCompiledPatternInspectionBase.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/DynamicRegexReplaceableByCompiledPatternInspectionBase.java index 850b88a13789..b8b8aca2d400 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/DynamicRegexReplaceableByCompiledPatternInspectionBase.java +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/DynamicRegexReplaceableByCompiledPatternInspectionBase.java @@ -16,12 +16,13 @@ package com.siyeh.ig.performance; import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel; +import com.intellij.openapi.util.WriteExternalException; import com.intellij.psi.*; -import com.intellij.psi.util.PsiUtil; import com.siyeh.InspectionGadgetsBundle; import com.siyeh.ig.BaseInspection; import com.siyeh.ig.BaseInspectionVisitor; import com.siyeh.ig.psiutils.ExpressionUtils; +import org.jdom.Element; import org.jetbrains.annotations.Nls; import org.jetbrains.annotations.NonNls; import org.jetbrains.annotations.NotNull; @@ -66,6 +67,13 @@ public class DynamicRegexReplaceableByCompiledPatternInspectionBase extends Base return new SingleCheckboxOptionsPanel("Ignore for String.split() optimizations (since Java 7)", this, "ignoreForSplitOptimization"); } + @Override + public void writeSettings(@NotNull Element node) throws WriteExternalException { + if (!ignoreForSplitOptimization) { + node.addContent(new Element("option").setAttribute("name", "ignoreForSplitOptimization").setAttribute("value", "false")); + } + } + @Override protected boolean buildQuickFixesOnlyForOnTheFlyErrors() { return true;