From de20f3bf98d05ef853b89506c7d2bf5c6a686fd4 Mon Sep 17 00:00:00 2001 From: Denis Fokin Date: Tue, 29 Sep 2015 15:06:27 +0400 Subject: [PATCH] IDEA-144156 Goto Class popup isn't closed on click on an editor tab title --- .../ide/util/gotoByName/ChooseByNameBase.java | 10 +--------- .../src/com/intellij/ide/IdeEventQueue.java | 19 +------------------ 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/ide/util/gotoByName/ChooseByNameBase.java b/platform/lang-impl/src/com/intellij/ide/util/gotoByName/ChooseByNameBase.java index 7611d231f8af..7143de6be71c 100644 --- a/platform/lang-impl/src/com/intellij/ide/util/gotoByName/ChooseByNameBase.java +++ b/platform/lang-impl/src/com/intellij/ide/util/gotoByName/ChooseByNameBase.java @@ -540,15 +540,7 @@ public abstract class ChooseByNameBase { return; // Allow toolwindows to gain focus (used by QuickDoc shown in a toolwindow) } - EventQueue queue = Toolkit.getDefaultToolkit().getSystemEventQueue(); - if (queue instanceof IdeEventQueue) { - if (((IdeEventQueue)queue).wasRootRecentlyClicked(oppositeComponent)) { - Component root = SwingUtilities.getRoot(myTextField); - if (root == null || root.isShowing()) { - hideHint(); - } - } - } + hideHint(); } } }, 5); diff --git a/platform/platform-impl/src/com/intellij/ide/IdeEventQueue.java b/platform/platform-impl/src/com/intellij/ide/IdeEventQueue.java index 9e8ff71ded75..f04469ca18b9 100644 --- a/platform/platform-impl/src/com/intellij/ide/IdeEventQueue.java +++ b/platform/platform-impl/src/com/intellij/ide/IdeEventQueue.java @@ -53,6 +53,7 @@ import org.jetbrains.annotations.Nullable; import javax.swing.*; import javax.swing.plaf.basic.ComboPopup; +import java.applet.Applet; import java.awt.*; import java.awt.event.*; import java.beans.PropertyChangeEvent; @@ -636,11 +637,6 @@ public class IdeEventQueue extends EventQueue { } }); } - if (me.getButton() != 0) { - setLastClickEvent(me); - } else if (lastClickEvent != null && Math.abs(System.currentTimeMillis() - lastClickTime) > 200){ - setLastClickEvent(null);//Obsolete event - } if (!myMouseEventDispatcher.dispatchMouseEvent(me)) { defaultDispatchEvent(e); } @@ -684,19 +680,6 @@ public class IdeEventQueue extends EventQueue { } } - private MouseEvent lastClickEvent; - private long lastClickTime; - - private void setLastClickEvent(@Nullable MouseEvent event) { - lastClickEvent = event; - lastClickTime = System.currentTimeMillis(); - } - - public boolean wasRootRecentlyClicked(Component component) { - return component != null && lastClickEvent != null && lastClickEvent.getComponent() != null && - SwingUtilities.getRoot(lastClickEvent.getComponent()) == SwingUtilities.getRoot(component); - } - private static void fixStickyWindow(KeyboardFocusManager mgr, Window wnd, String resetMethod) { Window showingWindow = wnd;