From dd44ae22f2b7a05ef84ca1734f7ff807a8a47896 Mon Sep 17 00:00:00 2001 From: Dmitry Avdeev Date: Sat, 9 Mar 2024 16:32:04 +0100 Subject: [PATCH] IDEA-349217 Add i18n inspection/quick fix to live template setting files customize prefix: live.templates GitOrigin-RevId: b94c79fecad55770cfea261435d58647890438f5 --- .../src/LiveTemplateI18nInspection.kt | 2 +- .../intellij.devkit.i18n/src/PluginXmlI18nInspection.java | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/plugins/devkit/intellij.devkit.i18n/src/LiveTemplateI18nInspection.kt b/plugins/devkit/intellij.devkit.i18n/src/LiveTemplateI18nInspection.kt index 21c1b40c13bc..8ff51d1c5cd0 100644 --- a/plugins/devkit/intellij.devkit.i18n/src/LiveTemplateI18nInspection.kt +++ b/plugins/devkit/intellij.devkit.i18n/src/LiveTemplateI18nInspection.kt @@ -17,7 +17,7 @@ class LiveTemplateI18nInspection: BasicDomElementsInspection(Templa } } - private class Fix: PluginXmlI18nInspection.InspectionI18NQuickFix("description") { + private class Fix: PluginXmlI18nInspection.InspectionI18NQuickFix("description", "live.template") { override fun getName(xml: XmlTag): String? { return xml.getAttributeValue("name") } diff --git a/plugins/devkit/intellij.devkit.i18n/src/PluginXmlI18nInspection.java b/plugins/devkit/intellij.devkit.i18n/src/PluginXmlI18nInspection.java index c867766c4d0a..fac030955d68 100644 --- a/plugins/devkit/intellij.devkit.i18n/src/PluginXmlI18nInspection.java +++ b/plugins/devkit/intellij.devkit.i18n/src/PluginXmlI18nInspection.java @@ -98,7 +98,7 @@ final class PluginXmlI18nInspection extends DevKitPluginXmlInspectionBase { if (implementationClass == null || implementationClass.getStringValue() == null) { return; } - checkNonLocalizableAttribute(holder, extension, "displayName", new InspectionI18NQuickFix("displayName")); + checkNonLocalizableAttribute(holder, extension, "displayName", new InspectionI18NQuickFix("displayName", "inspection")); checkNonLocalizableAttribute(holder, extension, "groupName", null); //checkNonLocalizableAttribute(holder, element, "groupPath", null); } @@ -334,9 +334,11 @@ final class PluginXmlI18nInspection extends DevKitPluginXmlInspectionBase { static class InspectionI18NQuickFix implements LocalQuickFix, BatchQuickFix { private final String attributeName; + private final String prefix; - InspectionI18NQuickFix(String attributeName) { + InspectionI18NQuickFix(String attributeName, String prefix) { this.attributeName = attributeName; + this.prefix = prefix; } @Nls(capitalization = Nls.Capitalization.Sentence) @@ -400,7 +402,7 @@ final class PluginXmlI18nInspection extends DevKitPluginXmlInspectionBase { String shortName = getName(xml); if (shortName == null) return; String[] items = ArrayUtil.mergeArrays(NameUtilCore.splitNameIntoWords(shortName), NameUtilCore.splitNameIntoWords(attributeName)); - @NonNls String key = "inspection." + StringUtil.join(items, s -> StringUtil.decapitalize(s), "."); + @NonNls String key = prefix + "." + StringUtil.join(items, s -> StringUtil.decapitalize(s), "."); xml.setAttribute("key", key); String bundleQName = getBundleQName(project, propertiesFile);