From a37249c16f0ed43b3abf43d0fd1fd25061886227 Mon Sep 17 00:00:00 2001 From: Mikhail Sokolov Date: Wed, 25 Apr 2018 14:27:37 +0300 Subject: [PATCH] IDEA-190919 Increase height for popup headers with buttons --- platform/util/src/com/intellij/ui/CaptionPanel.java | 4 ++++ platform/util/src/com/intellij/ui/TitlePanel.java | 2 +- platform/util/src/com/intellij/util/ui/JBUI.java | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/platform/util/src/com/intellij/ui/CaptionPanel.java b/platform/util/src/com/intellij/ui/CaptionPanel.java index 8c88268dd045..dd02108f13b3 100644 --- a/platform/util/src/com/intellij/ui/CaptionPanel.java +++ b/platform/util/src/com/intellij/ui/CaptionPanel.java @@ -99,4 +99,8 @@ public class CaptionPanel extends JPanel { public static Color getBorderColor(boolean isActive) { return JBUI.CurrentTheme.Popup.borderColor(isActive); } + + protected boolean containsSettingsControls() { + return mySettingComponent != null; + } } diff --git a/platform/util/src/com/intellij/ui/TitlePanel.java b/platform/util/src/com/intellij/ui/TitlePanel.java index 806e0f7dfdd0..d550c5e78527 100644 --- a/platform/util/src/com/intellij/ui/TitlePanel.java +++ b/platform/util/src/com/intellij/ui/TitlePanel.java @@ -80,7 +80,7 @@ public class TitlePanel extends CaptionPanel { } final Dimension preferredSize = super.getPreferredSize(); - preferredSize.height = JBUI.CurrentTheme.Popup.headerHeight(); + preferredSize.height = JBUI.CurrentTheme.Popup.headerHeight(containsSettingsControls()); int maxWidth = JBUI.scale(350); if (!myHtml && preferredSize.width > maxWidth) { // do not allow caption to extend parent container return new Dimension(maxWidth, preferredSize.height); diff --git a/platform/util/src/com/intellij/util/ui/JBUI.java b/platform/util/src/com/intellij/util/ui/JBUI.java index b9656027d0ea..f8276196164f 100644 --- a/platform/util/src/com/intellij/util/ui/JBUI.java +++ b/platform/util/src/com/intellij/util/ui/JBUI.java @@ -1528,8 +1528,8 @@ public class JBUI { : JBColor.namedColor("Popup.Header.inactiveBackground", 0xededed); } - public static int headerHeight() { - return scale(24); + public static int headerHeight(boolean hasControls) { + return hasControls ? scale(28) : scale(24); } public static Color borderColor(boolean active) {