From dbce639756bdbb92d7b8f1382a49d0243c52db9c Mon Sep 17 00:00:00 2001 From: Eugene Zhuravlev Date: Mon, 25 Mar 2013 11:53:57 +0400 Subject: [PATCH] [r=nik] forced file recompilation fix --- .../com/intellij/compiler/impl/CompileDriver.java | 14 +++++++------- .../jps/incremental/CompileScopeImpl.java | 8 ++++---- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/java/compiler/impl/src/com/intellij/compiler/impl/CompileDriver.java b/java/compiler/impl/src/com/intellij/compiler/impl/CompileDriver.java index e5f3f74daa87..9ae7b0b150a5 100644 --- a/java/compiler/impl/src/com/intellij/compiler/impl/CompileDriver.java +++ b/java/compiler/impl/src/com/intellij/compiler/impl/CompileDriver.java @@ -466,14 +466,14 @@ public class CompileDriver { final CompileScope scope = compileContext.getCompileScope(); final Collection paths = CompileScopeUtil.fetchFiles(compileContext); List scopes = new ArrayList(); + final boolean forceBuild = !compileContext.isMake(); + if (!compileContext.isRebuild() && !CompileScopeUtil.allProjectModulesAffected(compileContext)) { + CompileScopeUtil.addScopesForModules(Arrays.asList(scope.getAffectedModules()), scopes, forceBuild); + } + else { + scopes.addAll(CmdlineProtoUtil.createAllModulesScopes(forceBuild)); + } if (paths.isEmpty()) { - boolean forceBuild = !compileContext.isMake(); - if (!compileContext.isRebuild() && !CompileScopeUtil.allProjectModulesAffected(compileContext)) { - CompileScopeUtil.addScopesForModules(Arrays.asList(scope.getAffectedModules()), scopes, forceBuild); - } - else { - scopes.addAll(CmdlineProtoUtil.createAllModulesScopes(forceBuild)); - } for (BuildTargetScopeProvider provider : BuildTargetScopeProvider.EP_NAME.getExtensions()) { scopes = CompileScopeUtil.mergeScopes(scopes, provider.getBuildTargetScopes(scope, myCompilerFilter, myProject, forceBuild)); } diff --git a/jps/jps-builders/src/org/jetbrains/jps/incremental/CompileScopeImpl.java b/jps/jps-builders/src/org/jetbrains/jps/incremental/CompileScopeImpl.java index df6058728c3c..33b49d04c6d5 100644 --- a/jps/jps-builders/src/org/jetbrains/jps/incremental/CompileScopeImpl.java +++ b/jps/jps-builders/src/org/jetbrains/jps/incremental/CompileScopeImpl.java @@ -86,11 +86,11 @@ public class CompileScopeImpl extends CompileScope { if (myFiles.isEmpty()) {//optimization return true; } - if (myTypes.contains(target.getTargetType()) || myTargets.contains(target) || isAffectedByAssociatedModule(target)) { - return true; - } final Set files = myFiles.get(target); - return files != null && files.contains(file); + if (files != null) { + return files.contains(file); + } + return myTypes.contains(target.getTargetType()) || myTargets.contains(target) || isAffectedByAssociatedModule(target); } private boolean isAffectedByAssociatedModule(BuildTarget target) {