diff --git a/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/AbstractGotoSEContributor.java b/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/AbstractGotoSEContributor.java index b98c4aa77cad..842cd750a31c 100644 --- a/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/AbstractGotoSEContributor.java +++ b/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/AbstractGotoSEContributor.java @@ -102,8 +102,8 @@ public abstract class AbstractGotoSEContributor implements SearchEverywhereCo }, progressIndicator); } - //todo param is unnecessary #UX-1 - protected abstract FilteringGotoByModel createModel(Project project); + @NotNull + protected abstract FilteringGotoByModel createModel(@NotNull Project project); @NotNull @Override diff --git a/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/ClassSearchEverywhereContributor.java b/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/ClassSearchEverywhereContributor.java index 73b87b2f66f7..f3e1fa4cc7d9 100644 --- a/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/ClassSearchEverywhereContributor.java +++ b/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/ClassSearchEverywhereContributor.java @@ -56,8 +56,9 @@ public class ClassSearchEverywhereContributor extends AbstractGotoSEContributor< return 100; } + @NotNull @Override - protected FilteringGotoByModel createModel(Project project) { + protected FilteringGotoByModel createModel(@NotNull Project project) { return new GotoClassModel2(project); } diff --git a/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/FileSearchEverywhereContributor.java b/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/FileSearchEverywhereContributor.java index 4a49947ff480..a1bebe9724b4 100644 --- a/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/FileSearchEverywhereContributor.java +++ b/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/FileSearchEverywhereContributor.java @@ -29,6 +29,7 @@ import java.util.stream.Stream; /** * @author Konstantin Bulenkov + * @author Mikhail Sokolov */ public class FileSearchEverywhereContributor extends AbstractGotoSEContributor { private final GotoFileModel myModelForRenderer; @@ -54,8 +55,9 @@ public class FileSearchEverywhereContributor extends AbstractGotoSEContributor createModel(Project project) { + protected FilteringGotoByModel createModel(@NotNull Project project) { return new GotoFileModel(project); } @@ -80,7 +82,7 @@ public class FileSearchEverywhereContributor extends AbstractGotoSEContributor pos = getLineAndColumn(searchText); OpenFileDescriptor descriptor = new OpenFileDescriptor(myProject, file, pos.first, pos.second); descriptor.setUseCurrentWindow(openInCurrentWindow(modifiers)); diff --git a/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/RecentFilesSEContributor.java b/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/RecentFilesSEContributor.java index 4dcff4b1b3f7..808a0e38dd02 100644 --- a/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/RecentFilesSEContributor.java +++ b/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/RecentFilesSEContributor.java @@ -60,6 +60,10 @@ public class RecentFilesSEContributor extends FileSearchEverywhereContributor { @Override public void fetchElements(@NotNull String pattern, boolean everywhere, @Nullable SearchEverywhereContributorFilter filter, @NotNull ProgressIndicator progressIndicator, @NotNull Function consumer) { + if (myProject == null) { + return; //nothing to search + } + String searchString = filterControlSymbols(pattern); MinusculeMatcher matcher = NameUtil.buildMatcher("*" + searchString).build(); List opened = Arrays.asList(FileEditorManager.getInstance(myProject).getSelectedFiles()); diff --git a/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/SymbolSearchEverywhereContributor.java b/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/SymbolSearchEverywhereContributor.java index cf5d7b737d12..e672e74fcd80 100644 --- a/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/SymbolSearchEverywhereContributor.java +++ b/platform/lang-impl/src/com/intellij/ide/actions/searcheverywhere/SymbolSearchEverywhereContributor.java @@ -54,8 +54,9 @@ public class SymbolSearchEverywhereContributor extends AbstractGotoSEContributor return false; } + @NotNull @Override - protected FilteringGotoByModel createModel(Project project) { + protected FilteringGotoByModel createModel(@NotNull Project project) { return new GotoSymbolModel2(project); }