From db04ad34417256fac777028b3a99e8e3dab9d418 Mon Sep 17 00:00:00 2001 From: peter Date: Tue, 3 May 2016 10:38:43 +0200 Subject: [PATCH] IDEA-155319 "Run inspection by name" should not reuse "Find Action" search pattern --- .../src/com/intellij/ide/actions/GotoActionAction.java | 6 ++++-- .../intellij/ide/util/gotoByName/ChooseByNamePopup.java | 8 ++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/ide/actions/GotoActionAction.java b/platform/lang-impl/src/com/intellij/ide/actions/GotoActionAction.java index cf6aa20e585a..896f104fe070 100644 --- a/platform/lang-impl/src/com/intellij/ide/actions/GotoActionAction.java +++ b/platform/lang-impl/src/com/intellij/ide/actions/GotoActionAction.java @@ -26,7 +26,6 @@ import com.intellij.ide.util.gotoByName.GotoActionModel; import com.intellij.openapi.Disposable; import com.intellij.openapi.actionSystem.*; import com.intellij.openapi.actionSystem.ex.ActionUtil; -import com.intellij.openapi.actionSystem.ex.QuickList; import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.application.ModalityState; import com.intellij.openapi.application.TransactionGuard; @@ -46,7 +45,6 @@ import com.intellij.openapi.ui.popup.ListPopup; import com.intellij.openapi.util.Disposer; import com.intellij.openapi.util.Pair; import com.intellij.psi.PsiFile; -import com.intellij.util.ArrayUtil; import com.intellij.util.ui.UIUtil; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -75,6 +73,10 @@ public class GotoActionAction extends GotoActionBase implements DumbAware { GotoActionCallback callback = new GotoActionCallback() { @Override public void elementChosen(@NotNull ChooseByNamePopup popup, @NotNull Object element) { + if (project != null) { + // if the chosen action displays another popup, don't populate it automatically with the text from this popup + project.putUserData(ChooseByNamePopup.CHOOSE_BY_NAME_POPUP_IN_PROJECT_KEY, null); + } String enteredText = popup.getTrimmedText(); openOptionOrPerformAction(((GotoActionModel.MatchedValue)element).value, enteredText, project, component, e); } diff --git a/platform/lang-impl/src/com/intellij/ide/util/gotoByName/ChooseByNamePopup.java b/platform/lang-impl/src/com/intellij/ide/util/gotoByName/ChooseByNamePopup.java index af1427484b11..258f0ac81695 100644 --- a/platform/lang-impl/src/com/intellij/ide/util/gotoByName/ChooseByNamePopup.java +++ b/platform/lang-impl/src/com/intellij/ide/util/gotoByName/ChooseByNamePopup.java @@ -210,6 +210,10 @@ public class ChooseByNamePopup extends ChooseByNameBase implements ChooseByNameP return; } + if (myActionListener != null && !ApplicationManager.getApplication().isUnitTestMode()) { + myActionListener.onClose(); + } + if (isOk) { myModel.saveInitialCheckBoxState(myCheckBox.isSelected()); @@ -261,10 +265,6 @@ public class ChooseByNamePopup extends ChooseByNameBase implements ChooseByNameP } cleanupUI(isOk); - if (ApplicationManager.getApplication().isUnitTestMode()) return; - if (myActionListener != null) { - myActionListener.onClose(); - } } private void cleanupUI(boolean ok) {