From dab14be03added55f189c53f890bfb115438d219 Mon Sep 17 00:00:00 2001 From: Kirill Likhodedov Date: Sun, 22 Mar 2020 18:28:46 +0300 Subject: [PATCH] cleanup: remove the unnecessary try-catch block Parsing errors are already caught inside getBoolean() IDEA-CR-60006, IDEA-233305 GitOrigin-RevId: 3f9fba106b51328908c6508cf1f1eacf69035d9b --- .../openapi/application/ConfigImportHelper.java | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/platform/platform-impl/src/com/intellij/openapi/application/ConfigImportHelper.java b/platform/platform-impl/src/com/intellij/openapi/application/ConfigImportHelper.java index 4b8191835b30..1b9757b9ff2f 100644 --- a/platform/platform-impl/src/com/intellij/openapi/application/ConfigImportHelper.java +++ b/platform/platform-impl/src/com/intellij/openapi/application/ConfigImportHelper.java @@ -90,7 +90,7 @@ public final class ConfigImportHelper { try { Pair oldConfigDirAndOldIdePath = null; - if (shouldAskForConfig(log)) { + if (shouldAskForConfig()) { oldConfigDirAndOldIdePath = showDialogAndGetOldConfigPath(guessedOldConfigDirs); } else if (customMigrationOption != null) { @@ -187,14 +187,8 @@ public final class ConfigImportHelper { return configDir.resolveSibling(configDir.getFileName().toString() + "-backup"); } - private static boolean shouldAskForConfig(@NotNull Logger log) { - try { - return Boolean.getBoolean(SHOW_IMPORT_CONFIG_DIALOG_PROPERTY); - } - catch (Throwable t) { - log.error(t); - return false; - } + private static boolean shouldAskForConfig() { + return Boolean.getBoolean(SHOW_IMPORT_CONFIG_DIALOG_PROPERTY); } @Nullable