diff --git a/xml/xml-psi-impl/src/com/intellij/ide/highlighter/HtmlFileHighlighter.java b/xml/xml-psi-impl/src/com/intellij/ide/highlighter/HtmlFileHighlighter.java index 6f366f18eaac..3638ae21b26b 100644 --- a/xml/xml-psi-impl/src/com/intellij/ide/highlighter/HtmlFileHighlighter.java +++ b/xml/xml-psi-impl/src/com/intellij/ide/highlighter/HtmlFileHighlighter.java @@ -23,62 +23,48 @@ import com.intellij.openapi.editor.colors.TextAttributesKey; import com.intellij.openapi.fileTypes.FileTypeRegistry; import com.intellij.openapi.fileTypes.SyntaxHighlighterBase; import com.intellij.psi.tree.IElementType; -import com.intellij.psi.xml.XmlTokenType; +import com.intellij.util.containers.ContainerUtil; +import com.intellij.util.containers.MultiMap; import org.jetbrains.annotations.NotNull; -import java.util.HashMap; -import java.util.Iterator; +import java.util.Arrays; +import java.util.HashSet; import java.util.Map; +import static com.intellij.psi.xml.XmlTokenType.*; + public class HtmlFileHighlighter extends SyntaxHighlighterBase { - private static final Map keys1; - private static final Map keys2; + private static final MultiMap ourMap = MultiMap.create(); static { - keys1 = new HashMap<>(); - keys2 = new HashMap<>(); + ourMap.putValue(XML_TAG_CHARACTERS, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_COMMENT_START, XmlHighlighterColors.HTML_COMMENT); - keys1.put(XmlTokenType.XML_COMMENT_END, XmlHighlighterColors.HTML_COMMENT); - keys1.put(XmlTokenType.XML_COMMENT_CHARACTERS, XmlHighlighterColors.HTML_COMMENT); - keys1.put(XmlTokenType.XML_CONDITIONAL_COMMENT_END, XmlHighlighterColors.HTML_COMMENT); - keys1.put(XmlTokenType.XML_CONDITIONAL_COMMENT_END_START, XmlHighlighterColors.HTML_COMMENT); - keys1.put(XmlTokenType.XML_CONDITIONAL_COMMENT_START, XmlHighlighterColors.HTML_COMMENT); - keys1.put(XmlTokenType.XML_CONDITIONAL_COMMENT_START_END, XmlHighlighterColors.HTML_COMMENT); + for (IElementType type : ContainerUtil.ar(XML_COMMENT_START, XML_COMMENT_END, XML_COMMENT_CHARACTERS, + XML_CONDITIONAL_COMMENT_END, XML_CONDITIONAL_COMMENT_END_START, + XML_CONDITIONAL_COMMENT_START, XML_CONDITIONAL_COMMENT_START_END)) { + ourMap.putValue(type, XmlHighlighterColors.HTML_COMMENT); + } - keys1.put(XmlTokenType.XML_START_TAG_START, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_END_TAG_START, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_TAG_END, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_EMPTY_ELEMENT_END, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_TAG_NAME, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.TAG_WHITE_SPACE, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_NAME, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_ATTRIBUTE_VALUE_TOKEN, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_TAG_CHARACTERS, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_ATTRIBUTE_VALUE_START_DELIMITER, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_ATTRIBUTE_VALUE_END_DELIMITER, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_EQ, XmlHighlighterColors.HTML_TAG); + for (IElementType type : ContainerUtil.ar(XML_START_TAG_START, XML_END_TAG_START, XML_TAG_END, XML_EMPTY_ELEMENT_END, TAG_WHITE_SPACE)) { + ourMap.putValue(type, XmlHighlighterColors.HTML_TAG); + } - keys2.put(XmlTokenType.XML_TAG_NAME, XmlHighlighterColors.HTML_TAG_NAME); - keys2.put(XmlTokenType.XML_NAME, XmlHighlighterColors.HTML_ATTRIBUTE_NAME); - keys2.put(XmlTokenType.XML_ATTRIBUTE_VALUE_TOKEN, XmlHighlighterColors.HTML_ATTRIBUTE_VALUE); - keys2.put(XmlTokenType.XML_ATTRIBUTE_VALUE_START_DELIMITER, XmlHighlighterColors.HTML_ATTRIBUTE_VALUE); - keys2.put(XmlTokenType.XML_ATTRIBUTE_VALUE_END_DELIMITER, XmlHighlighterColors.HTML_ATTRIBUTE_VALUE); - keys2.put(XmlTokenType.XML_EQ, XmlHighlighterColors.HTML_ATTRIBUTE_NAME); + ourMap.putValues(XML_TAG_NAME, Arrays.asList(XmlHighlighterColors.HTML_TAG, XmlHighlighterColors.HTML_TAG_NAME)); + for (IElementType type : ContainerUtil.ar(XML_NAME, XML_EQ, + XML_ATTRIBUTE_VALUE_TOKEN, XML_ATTRIBUTE_VALUE_START_DELIMITER, XML_ATTRIBUTE_VALUE_END_DELIMITER)) { + ourMap.putValues(type, Arrays.asList(XmlHighlighterColors.HTML_TAG, XmlHighlighterColors.HTML_ATTRIBUTE_VALUE)); + } - keys1.put(XmlTokenType.XML_PI_START, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_PI_END, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_PI_TARGET, XmlHighlighterColors.HTML_TAG); - keys2.put(XmlTokenType.XML_PI_TARGET, XmlHighlighterColors.HTML_TAG_NAME); - - keys1.put(XmlTokenType.XML_DOCTYPE_START, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_DOCTYPE_END, XmlHighlighterColors.HTML_TAG); - keys1.put(XmlTokenType.XML_DOCTYPE_PUBLIC, XmlHighlighterColors.HTML_TAG); + for (IElementType type : ContainerUtil.ar(XML_PI_START, XML_PI_END, XML_DOCTYPE_START, XML_DOCTYPE_END, XML_DOCTYPE_PUBLIC)) { + ourMap.putValue(type, XmlHighlighterColors.HTML_TAG); + } - keys2.put(XmlTokenType.XML_CHAR_ENTITY_REF, XmlHighlighterColors.HTML_ENTITY_REFERENCE); - keys2.put(XmlTokenType.XML_ENTITY_REF_TOKEN, XmlHighlighterColors.HTML_ENTITY_REFERENCE); + ourMap.putValues(XML_PI_TARGET, Arrays.asList(XmlHighlighterColors.HTML_TAG, XmlHighlighterColors.HTML_TAG_NAME)); - keys1.put(XmlTokenType.XML_BAD_CHARACTER, HighlighterColors.BAD_CHARACTER); + ourMap.putValue(XML_CHAR_ENTITY_REF, XmlHighlighterColors.HTML_ENTITY_REFERENCE); + ourMap.putValue(XML_ENTITY_REF_TOKEN, XmlHighlighterColors.HTML_ENTITY_REFERENCE); + + ourMap.putValue(XML_BAD_CHARACTER, HighlighterColors.BAD_CHARACTER); } @Override @@ -90,25 +76,13 @@ public class HtmlFileHighlighter extends SyntaxHighlighterBase { @Override @NotNull public TextAttributesKey[] getTokenHighlights(IElementType tokenType) { - return SyntaxHighlighterBase.pack(XmlHighlighterColors.HTML_CODE, pack(keys1.get(tokenType), keys2.get(tokenType))); + return SyntaxHighlighterBase.pack(XmlHighlighterColors.HTML_CODE, ourMap.get(tokenType).toArray(EMPTY)); } public static void registerEmbeddedTokenAttributes(Map _keys1, Map _keys2) { - if (_keys1 != null) { - for (IElementType iElementType : _keys1.keySet()) { - if (!keys1.containsKey(iElementType)) { - keys1.put(iElementType, _keys1.get(iElementType)); - } - } - } - - if (_keys2 != null) { - for (IElementType iElementType : _keys2.keySet()) { - if (!keys2.containsKey(iElementType)) { - keys2.put(iElementType, _keys2.get(iElementType)); - } - } - } + HashSet existingKeys = new HashSet<>(ourMap.keySet()); + XmlFileHighlighter.addMissing(_keys1, existingKeys, ourMap); + XmlFileHighlighter.addMissing(_keys2, existingKeys, ourMap); } } diff --git a/xml/xml-psi-impl/src/com/intellij/ide/highlighter/XmlFileHighlighter.java b/xml/xml-psi-impl/src/com/intellij/ide/highlighter/XmlFileHighlighter.java index 1cfc1dcbee2b..b7d9aa4cb0c3 100644 --- a/xml/xml-psi-impl/src/com/intellij/ide/highlighter/XmlFileHighlighter.java +++ b/xml/xml-psi-impl/src/com/intellij/ide/highlighter/XmlFileHighlighter.java @@ -24,97 +24,56 @@ import com.intellij.openapi.editor.XmlHighlighterColors; import com.intellij.openapi.editor.colors.TextAttributesKey; import com.intellij.openapi.fileTypes.SyntaxHighlighterBase; import com.intellij.psi.tree.IElementType; -import com.intellij.psi.xml.XmlTokenType; +import com.intellij.util.containers.ContainerUtil; +import com.intellij.util.containers.MultiMap; import org.jetbrains.annotations.NotNull; -import java.util.HashMap; +import java.util.Arrays; +import java.util.HashSet; import java.util.Map; +import java.util.Set; + +import static com.intellij.psi.xml.XmlTokenType.*; public class XmlFileHighlighter extends SyntaxHighlighterBase { - private static final Map keys1; - private static final Map keys2; + private static final MultiMap ourMap = MultiMap.create(); static { - keys1 = new HashMap<>(); - keys2 = new HashMap<>(); + ourMap.putValue(XML_DATA_CHARACTERS, XmlHighlighterColors.XML_TAG_DATA); - keys1.put(XmlTokenType.XML_DATA_CHARACTERS, XmlHighlighterColors.XML_TAG_DATA); + for (IElementType type : ContainerUtil.ar(XML_COMMENT_START, XML_COMMENT_END, XML_COMMENT_CHARACTERS, + XML_CONDITIONAL_COMMENT_END, XML_CONDITIONAL_COMMENT_END_START, + XML_CONDITIONAL_COMMENT_START, XML_CONDITIONAL_COMMENT_START_END)) { + ourMap.putValue(type, XmlHighlighterColors.XML_COMMENT); + } - keys1.put(XmlTokenType.XML_COMMENT_START, XmlHighlighterColors.XML_COMMENT); - keys1.put(XmlTokenType.XML_COMMENT_END, XmlHighlighterColors.XML_COMMENT); - keys1.put(XmlTokenType.XML_COMMENT_CHARACTERS, XmlHighlighterColors.XML_COMMENT); - keys1.put(XmlTokenType.XML_CONDITIONAL_COMMENT_END, XmlHighlighterColors.XML_COMMENT); - keys1.put(XmlTokenType.XML_CONDITIONAL_COMMENT_END_START, XmlHighlighterColors.XML_COMMENT); - keys1.put(XmlTokenType.XML_CONDITIONAL_COMMENT_START, XmlHighlighterColors.XML_COMMENT); - keys1.put(XmlTokenType.XML_CONDITIONAL_COMMENT_START_END, XmlHighlighterColors.XML_COMMENT); + for (IElementType type : ContainerUtil.ar(XML_START_TAG_START, XML_END_TAG_START, XML_TAG_END, XML_EMPTY_ELEMENT_END, TAG_WHITE_SPACE)) { + ourMap.putValue(type, XmlHighlighterColors.XML_TAG); + } + for (IElementType type : ContainerUtil.ar(XML_TAG_NAME, XML_CONDITIONAL_IGNORE, XML_CONDITIONAL_INCLUDE)) { + ourMap.putValues(type, Arrays.asList(XmlHighlighterColors.XML_TAG, XmlHighlighterColors.XML_TAG_NAME)); + } + for (IElementType type : ContainerUtil.ar(XML_NAME, XML_EQ, XML_TAG_CHARACTERS, + XML_ATTRIBUTE_VALUE_TOKEN, XML_ATTRIBUTE_VALUE_START_DELIMITER, XML_ATTRIBUTE_VALUE_END_DELIMITER)) { + ourMap.putValues(type, Arrays.asList(XmlHighlighterColors.XML_TAG, XmlHighlighterColors.XML_ATTRIBUTE_VALUE)); + } - keys1.put(XmlTokenType.XML_START_TAG_START, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_END_TAG_START, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_TAG_END, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_EMPTY_ELEMENT_END, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_TAG_NAME, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.TAG_WHITE_SPACE, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_NAME, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_CONDITIONAL_IGNORE, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_CONDITIONAL_INCLUDE, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_ATTRIBUTE_VALUE_TOKEN, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_ATTRIBUTE_VALUE_START_DELIMITER, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_ATTRIBUTE_VALUE_END_DELIMITER, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_EQ, XmlHighlighterColors.XML_TAG); - keys1.put(XmlTokenType.XML_TAG_CHARACTERS, XmlHighlighterColors.XML_TAG); + for (IElementType type : ContainerUtil.ar(XML_DECL_START, XML_DOCTYPE_START, XML_DOCTYPE_SYSTEM, XML_DOCTYPE_PUBLIC, + XML_ATTLIST_DECL_START, XML_ELEMENT_DECL_START, XML_ENTITY_DECL_START)) { + ourMap.putValues(type, Arrays.asList(XmlHighlighterColors.XML_TAG, XmlHighlighterColors.XML_TAG_NAME)); + } - keys2.put(XmlTokenType.XML_TAG_NAME, XmlHighlighterColors.XML_TAG_NAME); - keys2.put(XmlTokenType.XML_CONDITIONAL_IGNORE, XmlHighlighterColors.XML_TAG_NAME); - keys2.put(XmlTokenType.XML_CONDITIONAL_INCLUDE, XmlHighlighterColors.XML_TAG_NAME); - keys2.put(XmlTokenType.XML_NAME, XmlHighlighterColors.XML_ATTRIBUTE_NAME); - keys2.put(XmlTokenType.XML_ATTRIBUTE_VALUE_TOKEN, XmlHighlighterColors.XML_ATTRIBUTE_VALUE); - keys2.put(XmlTokenType.XML_ATTRIBUTE_VALUE_START_DELIMITER, XmlHighlighterColors.XML_ATTRIBUTE_VALUE); - keys2.put(XmlTokenType.XML_ATTRIBUTE_VALUE_END_DELIMITER, XmlHighlighterColors.XML_ATTRIBUTE_VALUE); - keys2.put(XmlTokenType.XML_EQ, XmlHighlighterColors.XML_ATTRIBUTE_NAME); - keys2.put(XmlTokenType.XML_TAG_CHARACTERS, XmlHighlighterColors.XML_ATTRIBUTE_VALUE); + for (IElementType type : ContainerUtil.ar(XML_CONDITIONAL_SECTION_START, XML_CONDITIONAL_SECTION_END, XML_DECL_END, XML_DOCTYPE_END)) { + ourMap.putValues(type, Arrays.asList(XmlHighlighterColors.XML_PROLOGUE, XmlHighlighterColors.XML_TAG_NAME)); + } - keys1.put(XmlTokenType.XML_BAD_CHARACTER, HighlighterColors.BAD_CHARACTER); + ourMap.putValue(XML_PI_START, XmlHighlighterColors.XML_PROLOGUE); + ourMap.putValue(XML_PI_END, XmlHighlighterColors.XML_PROLOGUE); - keys1.put(XmlTokenType.XML_DECL_START, XmlHighlighterColors.XML_TAG); - keys2.put(XmlTokenType.XML_DECL_START, XmlHighlighterColors.XML_TAG_NAME); + ourMap.putValue(XML_CHAR_ENTITY_REF, XmlHighlighterColors.XML_ENTITY_REFERENCE); + ourMap.putValue(XML_ENTITY_REF_TOKEN, XmlHighlighterColors.XML_ENTITY_REFERENCE); - keys1.put(XmlTokenType.XML_CONDITIONAL_SECTION_START, XmlHighlighterColors.XML_PROLOGUE); - keys2.put(XmlTokenType.XML_CONDITIONAL_SECTION_START, XmlHighlighterColors.XML_TAG_NAME); - - keys1.put(XmlTokenType.XML_CONDITIONAL_SECTION_END, XmlHighlighterColors.XML_PROLOGUE); - keys2.put(XmlTokenType.XML_CONDITIONAL_SECTION_END, XmlHighlighterColors.XML_TAG_NAME); - - keys1.put(XmlTokenType.XML_DECL_END, XmlHighlighterColors.XML_PROLOGUE); - keys2.put(XmlTokenType.XML_DECL_END, XmlHighlighterColors.XML_TAG_NAME); - - keys1.put(XmlTokenType.XML_PI_START, XmlHighlighterColors.XML_PROLOGUE); - keys1.put(XmlTokenType.XML_PI_END, XmlHighlighterColors.XML_PROLOGUE); - keys1.put(XmlTokenType.XML_DOCTYPE_END, XmlHighlighterColors.XML_PROLOGUE); - keys2.put(XmlTokenType.XML_DOCTYPE_END, XmlHighlighterColors.XML_TAG_NAME); - - keys1.put(XmlTokenType.XML_DOCTYPE_START, XmlHighlighterColors.XML_TAG); - keys2.put(XmlTokenType.XML_DOCTYPE_START, XmlHighlighterColors.XML_TAG_NAME); - - keys1.put(XmlTokenType.XML_DOCTYPE_SYSTEM, XmlHighlighterColors.XML_TAG); - keys2.put(XmlTokenType.XML_DOCTYPE_SYSTEM, XmlHighlighterColors.XML_TAG_NAME); - - keys1.put(XmlTokenType.XML_DOCTYPE_PUBLIC, XmlHighlighterColors.XML_TAG); - keys2.put(XmlTokenType.XML_DOCTYPE_PUBLIC, XmlHighlighterColors.XML_TAG_NAME); - - keys1.put(XmlTokenType.XML_DOCTYPE_PUBLIC, XmlHighlighterColors.XML_TAG); - keys2.put(XmlTokenType.XML_DOCTYPE_PUBLIC, XmlHighlighterColors.XML_TAG_NAME); - - keys1.put(XmlTokenType.XML_ATTLIST_DECL_START, XmlHighlighterColors.XML_TAG); - keys2.put(XmlTokenType.XML_ATTLIST_DECL_START, XmlHighlighterColors.XML_TAG_NAME); - - keys1.put(XmlTokenType.XML_ELEMENT_DECL_START, XmlHighlighterColors.XML_TAG); - keys2.put(XmlTokenType.XML_ELEMENT_DECL_START, XmlHighlighterColors.XML_TAG_NAME); - - keys1.put(XmlTokenType.XML_ENTITY_DECL_START, XmlHighlighterColors.XML_TAG); - keys2.put(XmlTokenType.XML_ENTITY_DECL_START, XmlHighlighterColors.XML_TAG_NAME); - - keys2.put(XmlTokenType.XML_CHAR_ENTITY_REF, XmlHighlighterColors.XML_ENTITY_REFERENCE); - keys2.put(XmlTokenType.XML_ENTITY_REF_TOKEN, XmlHighlighterColors.XML_ENTITY_REFERENCE); + ourMap.putValue(XML_BAD_CHARACTER, HighlighterColors.BAD_CHARACTER); } private final boolean myIsDtd; @@ -148,17 +107,23 @@ public class XmlFileHighlighter extends SyntaxHighlighterBase { @Override @NotNull public TextAttributesKey[] getTokenHighlights(IElementType tokenType) { - return pack(keys1.get(tokenType), keys2.get(tokenType)); + return ourMap.get(tokenType).toArray(EMPTY); } public static void registerEmbeddedTokenAttributes(Map _keys1, Map _keys2) { - if (_keys1 != null) { - keys1.putAll(_keys1); - } + HashSet existingKeys = new HashSet<>(ourMap.keySet()); + addMissing(_keys1, existingKeys, ourMap); + addMissing(_keys2, existingKeys, ourMap); + } - if (_keys2 != null) { - keys2.putAll(_keys2); + static void addMissing(Map from, Set existingKeys, MultiMap to) { + if (from != null) { + for (Map.Entry entry : from.entrySet()) { + if (!existingKeys.contains(entry.getKey())) { + to.putValue(entry.getKey(), entry.getValue()); + } + } } } }