From d9472eb5f8b472197de7cc7b49bf55e0cc07e884 Mon Sep 17 00:00:00 2001 From: Ekaterina Tuzova Date: Wed, 27 Aug 2014 16:05:19 +0400 Subject: [PATCH] fixed PY-12024 "Replace mutable default argument" quickfix outputs non-standard formatting --- .../python/inspections/quickfix/PyDefaultArgumentQuickFix.java | 2 +- python/testData/inspections/DefaultArgument_after.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/python/src/com/jetbrains/python/inspections/quickfix/PyDefaultArgumentQuickFix.java b/python/src/com/jetbrains/python/inspections/quickfix/PyDefaultArgumentQuickFix.java index 31723d3aab4e..89453451f78b 100644 --- a/python/src/com/jetbrains/python/inspections/quickfix/PyDefaultArgumentQuickFix.java +++ b/python/src/com/jetbrains/python/inspections/quickfix/PyDefaultArgumentQuickFix.java @@ -74,7 +74,7 @@ public class PyDefaultArgumentQuickFix implements LocalQuickFix { } str.append("):\n\tpass"); PyIfStatement ifStatement = elementGenerator.createFromText(LanguageLevel.forElement(function), PyIfStatement.class, - "if not " + defName + ": " + defName + " = " + defaultValue.getText()); + "if not " + defName + ":\n\t" + defName + " = " + defaultValue.getText()); PyStatement firstStatement = list.getStatements()[0]; PyStringLiteralExpression docString = function.getDocStringExpression(); diff --git a/python/testData/inspections/DefaultArgument_after.py b/python/testData/inspections/DefaultArgument_after.py index e2036d24bf53..8007f9411df1 100644 --- a/python/testData/inspections/DefaultArgument_after.py +++ b/python/testData/inspections/DefaultArgument_after.py @@ -1,3 +1,4 @@ def foo(args=None): - if not args: args = [] + if not args: + args = [] pass \ No newline at end of file