From d7c1617bc22071ad9954c52bb112c810fbba5e96 Mon Sep 17 00:00:00 2001 From: "Maxim.Mossienko" Date: Fri, 1 Jul 2016 17:07:51 +0200 Subject: [PATCH] better code after review --- .../util/io/ReadWriteDirectBufferWrapper.java | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/platform/util/src/com/intellij/util/io/ReadWriteDirectBufferWrapper.java b/platform/util/src/com/intellij/util/io/ReadWriteDirectBufferWrapper.java index eec87e80f661..99797b266acd 100644 --- a/platform/util/src/com/intellij/util/io/ReadWriteDirectBufferWrapper.java +++ b/platform/util/src/com/intellij/util/io/ReadWriteDirectBufferWrapper.java @@ -16,6 +16,7 @@ package com.intellij.util.io; import com.intellij.openapi.Disposable; +import com.intellij.openapi.util.Disposer; import com.intellij.openapi.util.io.FileUtilRt; import org.jetbrains.annotations.NonNls; import org.jetbrains.annotations.Nullable; @@ -94,14 +95,12 @@ public class ReadWriteDirectBufferWrapper extends DirectBufferWrapper { try { if (fileContext == null) fileContext = new FileContext(myFile); - if (fileContext.myFile != null) { - final FileChannel channel = fileContext.myFile.getChannel(); + final FileChannel channel = fileContext.myFile.getChannel(); - channel.position(myPosition); - buffer.rewind(); - channel.write(buffer); - myDirty = false; - } + channel.position(myPosition); + buffer.rewind(); + channel.write(buffer); + myDirty = false; } catch (IOException e) { LOG.error(e); @@ -116,8 +115,7 @@ public class ReadWriteDirectBufferWrapper extends DirectBufferWrapper { Disposable disposable = doFlush(null, buffer); if (disposable != null) { - //noinspection SSBasedInspection - disposable.dispose(); + Disposer.dispose(disposable); } } }