From d7948e9d2eafe8c4cd6997077f9aa6df8c961ba7 Mon Sep 17 00:00:00 2001 From: "Anna.Kozlova" Date: Mon, 18 Jul 2016 18:38:51 +0200 Subject: [PATCH] inplace refactoring: if test on invalid identifier, don't get into infinite recursion --- .../refactoring/rename/inplace/VariableInplaceRenamer.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/platform/lang-impl/src/com/intellij/refactoring/rename/inplace/VariableInplaceRenamer.java b/platform/lang-impl/src/com/intellij/refactoring/rename/inplace/VariableInplaceRenamer.java index f48c52468f87..d1cf309c9554 100644 --- a/platform/lang-impl/src/com/intellij/refactoring/rename/inplace/VariableInplaceRenamer.java +++ b/platform/lang-impl/src/com/intellij/refactoring/rename/inplace/VariableInplaceRenamer.java @@ -193,6 +193,9 @@ public class VariableInplaceRenamer extends InplaceRefactoring { if (variable != null) { final int offset = variable.getTextOffset(); restoreCaretOffset(offset); + if (ApplicationManager.getApplication().isUnitTestMode()) { + return; + } JBPopupFactory.getInstance() .createConfirmation("Inserted identifier is not valid", "Continue editing", "Cancel", () -> createInplaceRenamerToRestart(variable, myEditor, newName).performInplaceRefactoring(nameSuggestions), 0).showInBestPositionFor(myEditor);