From d74484e368ebfd63e008054929ea527f8ffda43c Mon Sep 17 00:00:00 2001
From: Bas Leijdekkers <basleijdekkers@gmail.com>
Date: Wed, 25 Sep 2024 10:42:46 +0200
Subject: [PATCH] Java: enable "Record pattern can be used" by default at
 warning level (IDEA-359690)

and make it a cleanup tool.

GitOrigin-RevId: 3bb400491d44ab901660d900c6ce73e76bdf6261
---
 .../DeconstructionCanBeUsedInspection.java    |  2 +-
 .../src/META-INF/InspectionGadgets.xml        |  4 ++--
 .../DeconstructionCanBeUsed.html              | 24 +++++++++----------
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/java/java-impl-inspections/src/com/intellij/codeInspection/DeconstructionCanBeUsedInspection.java b/java/java-impl-inspections/src/com/intellij/codeInspection/DeconstructionCanBeUsedInspection.java
index 98e93e130f3d..489c1725a705 100644
--- a/java/java-impl-inspections/src/com/intellij/codeInspection/DeconstructionCanBeUsedInspection.java
+++ b/java/java-impl-inspections/src/com/intellij/codeInspection/DeconstructionCanBeUsedInspection.java
@@ -22,7 +22,7 @@ import org.jetbrains.annotations.Nullable;
 
 import java.util.*;
 
-public final class DeconstructionCanBeUsedInspection extends AbstractBaseJavaLocalInspectionTool {
+public final class DeconstructionCanBeUsedInspection extends AbstractBaseJavaLocalInspectionTool implements CleanupLocalInspectionTool {
 
   @Override
   public @NotNull Set<@NotNull JavaFeature> requiredFeatures() {
diff --git a/java/java-impl/src/META-INF/InspectionGadgets.xml b/java/java-impl/src/META-INF/InspectionGadgets.xml
index d789f2952ce3..dee5ec41e992 100644
--- a/java/java-impl/src/META-INF/InspectionGadgets.xml
+++ b/java/java-impl/src/META-INF/InspectionGadgets.xml
@@ -2761,10 +2761,10 @@
                      groupBundle="messages.InspectionsBundle" groupKey="group.names.language.level.specific.issues.and.migration.aids"
                      implementationClass="com.intellij.codeInspection.ForEachWithRecordPatternCanBeUsedInspection" cleanupTool="true"/>
     <localInspection groupPathKey="group.path.names.java.language.level.specific.issues.and.migration.aids" language="JAVA"
-                     shortName="DeconstructionCanBeUsed" enabledByDefault="false" level="INFORMATION"
+                     shortName="DeconstructionCanBeUsed" enabledByDefault="true" level="WARNING"
                      bundle="messages.InspectionGadgetsBundle" key="inspection.deconstruction.can.be.used.display.name"
                      groupBundle="messages.InspectionsBundle" groupKey="group.names.language.level.specific.issues.and.migration.aids21"
-                     implementationClass="com.intellij.codeInspection.DeconstructionCanBeUsedInspection" cleanupTool="false"/>
+                     implementationClass="com.intellij.codeInspection.DeconstructionCanBeUsedInspection" cleanupTool="true"/>
     <localInspection groupPath="Java" language="JAVA" shortName="CastCanBeReplacedWithVariable" enabledByDefault="true" level="INFORMATION"
                      bundle="messages.InspectionGadgetsBundle" key="inspection.cast.can.be.replaced.with.variable.display.name"
                      groupBundle="messages.InspectionsBundle" groupKey="group.names.verbose.or.redundant.code.constructs"
diff --git a/java/java-impl/src/inspectionDescriptions/DeconstructionCanBeUsed.html b/java/java-impl/src/inspectionDescriptions/DeconstructionCanBeUsed.html
index 936983445b05..4911b801ef87 100644
--- a/java/java-impl/src/inspectionDescriptions/DeconstructionCanBeUsed.html
+++ b/java/java-impl/src/inspectionDescriptions/DeconstructionCanBeUsed.html
@@ -3,23 +3,23 @@
 Reports patterns that can be replaced with record patterns.
 <p>Example:</p>
 <pre><code>
-  record Point(int x, int y) {}
-
-  static void printSum(Object obj) {
-    if (obj instanceof Point p) {
-      int x = p.x();
-      int y = p.y();
-      System.out.println(x + y);
+  record Point(int x, int y) {
+    static void printSum(Object obj) {
+      if (obj instanceof Point p) {
+        int x = p.x();
+        int y = p.y();
+        System.out.println(x + y);
+      }
     }
   }
 </code></pre>
 <p>After the quick-fix is applied:</p>
 <pre><code>
-  record Point(int x, int y) {}
-
-  static void printSum(Object obj) {
-    if (obj instanceof Point(int x, int y)) {
-      System.out.println(x + y);
+  record Point(int x, int y) {
+    static void printSum(Object obj) {
+      if (obj instanceof Point(int x, int y)) {
+        System.out.println(x + y);
+      }
     }
   }
 </code></pre>