From d55e8e1c54dad779d6a33c5b52453759b093d4db Mon Sep 17 00:00:00 2001
From: Oleg Shpynov <oleg.shpynov@jebrains.com>
Date: Thu, 31 Mar 2011 14:17:34 +0400
Subject: [PATCH] Better usage of PasswordSafe

---
 .../plugins/github/GithubSettings.java        | 27 ++++++++++---------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/plugins/github/src/org/jetbrains/plugins/github/GithubSettings.java b/plugins/github/src/org/jetbrains/plugins/github/GithubSettings.java
index 40ea647de790..d0d614f0349f 100644
--- a/plugins/github/src/org/jetbrains/plugins/github/GithubSettings.java
+++ b/plugins/github/src/org/jetbrains/plugins/github/GithubSettings.java
@@ -25,6 +25,7 @@ import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.util.text.StringUtil;
 import org.jdom.Element;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 /**
  * @author oleg
@@ -46,7 +47,6 @@ public class GithubSettings implements PersistentStateComponent<Element> {
   private static final String GITHUB_SETTINGS_PASSWORD_KEY = "GITHUB_SETTINGS_PASSWORD_KEY";
 
   private String myLogin;
-  private String myPassword;
   private String myHost;
   private static final Logger LOG = Logger.getInstance(GithubSettings.class.getName());
 
@@ -55,15 +55,9 @@ public class GithubSettings implements PersistentStateComponent<Element> {
   }
 
   public Element getState() {
-    if (StringUtil.isEmptyOrSpaces(myLogin) && StringUtil.isEmptyOrSpaces(myPassword) && StringUtil.isEmptyOrSpaces(myHost)) {
+    if (StringUtil.isEmptyOrSpaces(myLogin) && StringUtil.isEmptyOrSpaces(myHost)) {
       return null;
     }
-    try {
-      PasswordSafe.getInstance().storePassword(null, GithubSettings.class, GITHUB_SETTINGS_PASSWORD_KEY, myPassword);
-    }
-    catch (PasswordSafeException e) {
-      LOG.error(e);
-    }
     final Element element = new Element(GITHUB_SETTINGS_TAG);
     element.setAttribute(LOGIN, getLogin());
     element.setAttribute(HOST, getHost());
@@ -74,7 +68,6 @@ public class GithubSettings implements PersistentStateComponent<Element> {
     try {
       setLogin(element.getAttributeValue(LOGIN));
       setHost(element.getAttributeValue(HOST));
-      setPassword(PasswordSafe.getInstance().getPassword(null, GithubSettings.class, GITHUB_SETTINGS_PASSWORD_KEY));
     }
     catch (Exception e) {
       // ignore
@@ -86,9 +79,14 @@ public class GithubSettings implements PersistentStateComponent<Element> {
     return myLogin != null ? myLogin : "";
   }
 
-  @NotNull
+  @Nullable
   public String getPassword() {
-    return myPassword != null ? myPassword : "";
+    try {
+      return PasswordSafe.getInstance().getPassword(null, GithubSettings.class, GITHUB_SETTINGS_PASSWORD_KEY);
+    }
+    catch (PasswordSafeException e) {
+      return "";
+    }
   }
 
   public String getHost() {
@@ -100,7 +98,12 @@ public class GithubSettings implements PersistentStateComponent<Element> {
   }
 
   public void setPassword(final String password) {
-    myPassword = password != null ? password : "";
+    try {
+      PasswordSafe.getInstance().storePassword(null, GithubSettings.class, GITHUB_SETTINGS_PASSWORD_KEY, password);
+    }
+    catch (PasswordSafeException e) {
+      LOG.error(e);
+    }
   }
 
   public void setHost(final String host) {