From d53d368a9384fea00e048414f0840825fb19755f Mon Sep 17 00:00:00 2001 From: Dave Griffith Date: Tue, 15 Mar 2005 17:54:38 +0300 Subject: [PATCH] (no message) --- ...eplaceConcatenationWithStringBufferIntention.java | 12 +++++++++++- .../description.html | 3 ++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/plugins/IntentionPowerPak/src/com/siyeh/ipp/concatenation/ReplaceConcatenationWithStringBufferIntention.java b/plugins/IntentionPowerPak/src/com/siyeh/ipp/concatenation/ReplaceConcatenationWithStringBufferIntention.java index cd1bedabe3b7..2d178d21654a 100644 --- a/plugins/IntentionPowerPak/src/com/siyeh/ipp/concatenation/ReplaceConcatenationWithStringBufferIntention.java +++ b/plugins/IntentionPowerPak/src/com/siyeh/ipp/concatenation/ReplaceConcatenationWithStringBufferIntention.java @@ -4,6 +4,7 @@ import com.intellij.openapi.editor.Editor; import com.intellij.openapi.project.Project; import com.intellij.psi.*; import com.intellij.util.IncorrectOperationException; +import com.intellij.pom.java.LanguageLevel; import com.siyeh.ipp.base.Intention; import com.siyeh.ipp.base.PsiElementPredicate; import com.siyeh.ipp.psiutils.ParenthesesUtils; @@ -48,7 +49,16 @@ public class ReplaceConcatenationWithStringBufferIntention extends Intention{ final String newExpression = expString.toString(); replaceExpression(project, newExpression, methodCallExpression); } else{ - expString.append("new StringBuffer()"); + final PsiManager manager = exp.getManager(); + final LanguageLevel languageLevel = + manager.getEffectiveLanguageLevel(); + if(languageLevel.equals(LanguageLevel.JDK_1_3) || + languageLevel.equals(LanguageLevel.JDK_1_4)) + { + expString.append("new StringBuffer()"); + }else{ + expString.append("new StringBuilder()"); + } turnExpressionIntoChainedAppends(exp, expString); expString.append(".toString()"); final String newExpression = expString.toString(); diff --git a/plugins/IntentionPowerPak/src/intentionDescriptions/Replace Plus With StringBuffer Append/description.html b/plugins/IntentionPowerPak/src/intentionDescriptions/Replace Plus With StringBuffer Append/description.html index a15f351b95d7..d85267ceced4 100644 --- a/plugins/IntentionPowerPak/src/intentionDescriptions/Replace Plus With StringBuffer Append/description.html +++ b/plugins/IntentionPowerPak/src/intentionDescriptions/Replace Plus With StringBuffer Append/description.html @@ -1,6 +1,7 @@ -This intention replaces String + concatenation operator with StringBuffer.append().
+This intention replaces String + concatenation operator with StringBuffer.append(). +For projects using J2SDK5.0, StringBuilder.append() will be used instead