From d4d49131ddc00404b660c3dca2b4ad941697cb0d Mon Sep 17 00:00:00 2001 From: Dmitry Zhuravlev Date: Thu, 7 Nov 2024 17:46:02 +0100 Subject: [PATCH] vcs: clarify read action requirement in file dirty API If the read action is needed (e.g., to avoid deadlock with inner lock) - the method should take it itself but not just because of API requirement. GitOrigin-RevId: 481d139fedd59dfd1d58b3a3fb9405d58c879685 --- .../intellij/openapi/vcs/changes/VcsDirtyScopeManager.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/platform/vcs-api/src/com/intellij/openapi/vcs/changes/VcsDirtyScopeManager.java b/platform/vcs-api/src/com/intellij/openapi/vcs/changes/VcsDirtyScopeManager.java index d1868541aa90..dd37b34f557c 100644 --- a/platform/vcs-api/src/com/intellij/openapi/vcs/changes/VcsDirtyScopeManager.java +++ b/platform/vcs-api/src/com/intellij/openapi/vcs/changes/VcsDirtyScopeManager.java @@ -1,4 +1,4 @@ -// Copyright 2000-2019 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file. +// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. package com.intellij.openapi.vcs.changes; import com.intellij.openapi.project.Project; @@ -26,14 +26,14 @@ public abstract class VcsDirtyScopeManager { public abstract void markEverythingDirty(); /** - * Requests an asynchronous file status update for the specified virtual file. Must be called from a read action. + * Requests an asynchronous file status update for the specified virtual file. * * @param file the file for which the status update is requested. */ public abstract void fileDirty(@NotNull VirtualFile file); /** - * Requests an asynchronous file status update for the specified file path. Must be called from a read action. + * Requests an asynchronous file status update for the specified file path. * * @param file the file path for which the status update is requested. */