From d26006441838854d291c500cdfa5bb4cf1be4f41 Mon Sep 17 00:00:00 2001
From: Konstantin Aleev <konstantin.aleev@jetbrains.com>
Date: Wed, 20 Sep 2017 12:59:00 +0300
Subject: [PATCH] Fix Run configurable modified tracking

- Fix modified state when 'Defaults' settings are changed
---
 .../intellij/execution/impl/RunConfigurable.kt    | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/platform/lang-impl/src/com/intellij/execution/impl/RunConfigurable.kt b/platform/lang-impl/src/com/intellij/execution/impl/RunConfigurable.kt
index 904af6831c3c..9b352086e88d 100644
--- a/platform/lang-impl/src/com/intellij/execution/impl/RunConfigurable.kt
+++ b/platform/lang-impl/src/com/intellij/execution/impl/RunConfigurable.kt
@@ -540,6 +540,12 @@ open class RunConfigurable @JvmOverloads constructor(private val myProject: Proj
     return toolbarDecorator!!.createPanel()
   }
 
+  private fun defaultsSettingsChanged() {
+    isModified = !Comparing.equal(recentsLimit.text, recentsLimit.getClientProperty(INITIAL_VALUE_KEY)) ||
+                 !Comparing.equal(confirmation.isSelected, confirmation.getClientProperty(INITIAL_VALUE_KEY)) ||
+                 !Comparing.equal(runDashboardTypes, RunDashboardManager.getInstance(myProject).types)
+  }
+
   private fun createSettingsPanel(): JPanel {
     val bottomPanel = JPanel(GridBagLayout())
     val g = GridBag()
@@ -550,11 +556,11 @@ open class RunConfigurable @JvmOverloads constructor(private val myProject: Proj
 
     recentsLimit.document.addDocumentListener(object : DocumentAdapter() {
       override fun textChanged(e: DocumentEvent) {
-        isModified = !Comparing.equal(recentsLimit.text, recentsLimit.getClientProperty(INITIAL_VALUE_KEY))
+        defaultsSettingsChanged()
       }
     })
     confirmation.addChangeListener {
-      isModified = !Comparing.equal(confirmation.isSelected, confirmation.getClientProperty(INITIAL_VALUE_KEY))
+      defaultsSettingsChanged()
     }
     return bottomPanel
   }
@@ -632,7 +638,7 @@ open class RunConfigurable @JvmOverloads constructor(private val myProject: Proj
 
     updateRunDashboardTypes()
 
-    isModified = !Comparing.equal(runDashboardTypes, RunDashboardManager.getInstance(myProject).types)
+    defaultsSettingsChanged()
   }
 
   private val selectedConfigurationType: ConfigurationType?
@@ -714,7 +720,10 @@ open class RunConfigurable @JvmOverloads constructor(private val myProject: Proj
         manager.config.recentsLimit = recentLimit
         manager.checkRecentsLimit()
       }
+      recentsLimit.text = "" + recentLimit
+      recentsLimit.putClientProperty(INITIAL_VALUE_KEY, recentsLimit.text)
       manager.config.isRestartRequiresConfirmation = confirmation.isSelected
+      confirmation.putClientProperty(INITIAL_VALUE_KEY, confirmation.isSelected)
 
       val dashboardManager = RunDashboardManager.getInstance(myProject)
       if (!Comparing.equal(runDashboardTypes, dashboardManager.types)) {