From d1b0d062b29068376d253e35943d0e7c0873381b Mon Sep 17 00:00:00 2001 From: Dmitry Trofimov Date: Thu, 13 Nov 2014 21:39:51 +0100 Subject: [PATCH] Change variable method is async now. --- .../jetbrains/python/console/PydevConsoleCommunication.java | 2 ++ .../testSrc/com/jetbrains/env/python/PythonConsoleTest.java | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/python/src/com/jetbrains/python/console/PydevConsoleCommunication.java b/python/src/com/jetbrains/python/console/PydevConsoleCommunication.java index c27cfbe0ca0a..5e516b4fbf96 100644 --- a/python/src/com/jetbrains/python/console/PydevConsoleCommunication.java +++ b/python/src/com/jetbrains/python/console/PydevConsoleCommunication.java @@ -532,6 +532,8 @@ public class PydevConsoleCommunication extends AbstractConsoleCommunication impl public void changeVariable(PyDebugValue variable, String value) throws PyDebuggerException { if (myClient != null) { try { + // NOTE: The actual change is being scheduled in the exec_queue in main thread + // This method is async now Object ret = myClient.execute(CHANGE_VARIABLE, new Object[]{variable.getEvaluationExpression(), value}); checkError(ret); } diff --git a/python/testSrc/com/jetbrains/env/python/PythonConsoleTest.java b/python/testSrc/com/jetbrains/env/python/PythonConsoleTest.java index 4134b1697851..2d9399f2587c 100644 --- a/python/testSrc/com/jetbrains/env/python/PythonConsoleTest.java +++ b/python/testSrc/com/jetbrains/env/python/PythonConsoleTest.java @@ -122,8 +122,9 @@ public class PythonConsoleTest extends PyEnvTestCase { setValue("x", "2"); - assertTrue("Variable has wrong value", - hasValue("x", "2")); + exec("print(x)"); + + waitForOutput("2"); } }); }