From d1a5e0b4761e78c3d565494ecb39e2f6dbc52488 Mon Sep 17 00:00:00 2001 From: Sebastiano Poggi Date: Tue, 21 Jan 2025 18:08:04 +0100 Subject: [PATCH] [jewel] Move thenIf modifier to foundation This helps with places like the incoming SimpleTableLayout that need it in `foundation`, but don't have access to it because it's in `ui`. It also makes semantic sense, since the other, similar, modifiers we created all live in foundation; thenIf has no "ui" specificity to it. This also marks the "old" modifier as scheduled for removal in 252. closes https://github.com/JetBrains/intellij-community/pull/2923 (cherry picked from commit e13efd3a5d33a65d88add97727be9b4f2c59a042) (cherry picked from commit 8b36ee40225829592a5c911469f7739e836c817b) IJ-MR-155570 GitOrigin-RevId: 3d089e6acab0cd6aef11496debfc881e1307520a --- .../samples/ideplugin/releasessample/ReleasesSampleCompose.kt | 2 +- .../org/jetbrains/jewel/samples/showcase/components/Tabs.kt | 2 +- .../ui/src/main/kotlin/org/jetbrains/jewel/ui/Outline.kt | 2 +- .../main/kotlin/org/jetbrains/jewel/ui/component/Button.kt | 3 +-- .../src/main/kotlin/org/jetbrains/jewel/ui/component/Chip.kt | 2 +- .../main/kotlin/org/jetbrains/jewel/ui/component/ComboBox.kt | 3 +-- .../main/kotlin/org/jetbrains/jewel/ui/component/Divider.kt | 2 +- .../main/kotlin/org/jetbrains/jewel/ui/component/Dropdown.kt | 3 +-- .../org/jetbrains/jewel/ui/component/EditableComboBox.kt | 3 +-- .../src/main/kotlin/org/jetbrains/jewel/ui/component/Icon.kt | 2 +- .../kotlin/org/jetbrains/jewel/ui/component/IconButton.kt | 2 +- .../kotlin/org/jetbrains/jewel/ui/component/InlineBanner.kt | 2 +- .../kotlin/org/jetbrains/jewel/ui/component/InputField.kt | 2 +- .../src/main/kotlin/org/jetbrains/jewel/ui/component/Link.kt | 2 +- .../kotlin/org/jetbrains/jewel/ui/component/ListComboBox.kt | 2 +- .../main/kotlin/org/jetbrains/jewel/ui/component/Scrollbar.kt | 2 +- .../org/jetbrains/jewel/ui/component/SegmentedControl.kt | 2 +- .../kotlin/org/jetbrains/jewel/ui/util/ModifierExtensions.kt | 4 +++- 18 files changed, 20 insertions(+), 22 deletions(-) diff --git a/platform/jewel/samples/ide-plugin/src/main/kotlin/org/jetbrains/jewel/samples/ideplugin/releasessample/ReleasesSampleCompose.kt b/platform/jewel/samples/ide-plugin/src/main/kotlin/org/jetbrains/jewel/samples/ideplugin/releasessample/ReleasesSampleCompose.kt index 28a9134a8aa8..c90390a57e4d 100644 --- a/platform/jewel/samples/ide-plugin/src/main/kotlin/org/jetbrains/jewel/samples/ideplugin/releasessample/ReleasesSampleCompose.kt +++ b/platform/jewel/samples/ide-plugin/src/main/kotlin/org/jetbrains/jewel/samples/ideplugin/releasessample/ReleasesSampleCompose.kt @@ -74,6 +74,7 @@ import org.jetbrains.jewel.foundation.lazy.SelectionMode import org.jetbrains.jewel.foundation.lazy.items import org.jetbrains.jewel.foundation.lazy.rememberSelectableLazyListState import org.jetbrains.jewel.foundation.modifier.onHover +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.theme.JewelTheme import org.jetbrains.jewel.ui.component.HorizontalSplitLayout import org.jetbrains.jewel.ui.component.Icon @@ -89,7 +90,6 @@ import org.jetbrains.jewel.ui.component.scrollbarContentSafePadding import org.jetbrains.jewel.ui.icons.AllIconsKeys import org.jetbrains.jewel.ui.painter.rememberResourcePainterProvider import org.jetbrains.jewel.ui.theme.iconButtonStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable internal fun ReleasesSampleCompose(project: Project) { diff --git a/platform/jewel/samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Tabs.kt b/platform/jewel/samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Tabs.kt index a3ffd54b13a2..b03505b6f820 100644 --- a/platform/jewel/samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Tabs.kt +++ b/platform/jewel/samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Tabs.kt @@ -23,6 +23,7 @@ import androidx.compose.ui.draw.drawWithCache import androidx.compose.ui.graphics.Color import androidx.compose.ui.unit.dp import kotlin.math.max +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.theme.JewelTheme import org.jetbrains.jewel.ui.component.Icon import org.jetbrains.jewel.ui.component.IconButton @@ -36,7 +37,6 @@ import org.jetbrains.jewel.ui.painter.hints.Stateful import org.jetbrains.jewel.ui.painter.rememberResourcePainterProvider import org.jetbrains.jewel.ui.theme.defaultTabStyle import org.jetbrains.jewel.ui.theme.editorTabStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun Tabs() { diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/Outline.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/Outline.kt index 4a338be61278..7c121376a147 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/Outline.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/Outline.kt @@ -6,9 +6,9 @@ import androidx.compose.ui.graphics.Shape import androidx.compose.ui.unit.Dp import org.jetbrains.jewel.foundation.Stroke import org.jetbrains.jewel.foundation.modifier.border +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.state.FocusableComponentState import org.jetbrains.jewel.foundation.theme.JewelTheme -import org.jetbrains.jewel.ui.util.thenIf public enum class Outline { None, diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Button.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Button.kt index bdef14c9cc08..efea817614ee 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Button.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Button.kt @@ -43,9 +43,9 @@ import androidx.compose.ui.platform.LocalDensity import androidx.compose.ui.semantics.Role import androidx.compose.ui.text.TextStyle import androidx.compose.ui.unit.Dp -import kotlinx.coroutines.flow.collect import org.jetbrains.jewel.foundation.Stroke import org.jetbrains.jewel.foundation.modifier.border +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Active import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Enabled import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Focused @@ -67,7 +67,6 @@ import org.jetbrains.jewel.ui.theme.defaultSplitButtonStyle import org.jetbrains.jewel.ui.theme.menuStyle import org.jetbrains.jewel.ui.theme.outlinedButtonStyle import org.jetbrains.jewel.ui.theme.outlinedSplitButtonStyle -import org.jetbrains.jewel.ui.util.thenIf /** * A button that follows the default visual styling with customizable content and behavior. diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Chip.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Chip.kt index 08b009b6fb52..10a4a65a9354 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Chip.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Chip.kt @@ -26,6 +26,7 @@ import androidx.compose.ui.graphics.takeOrElse import androidx.compose.ui.semantics.Role import org.jetbrains.jewel.foundation.Stroke import org.jetbrains.jewel.foundation.modifier.border +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Active import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Enabled import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Focused @@ -40,7 +41,6 @@ import org.jetbrains.jewel.foundation.theme.LocalTextStyle import org.jetbrains.jewel.ui.component.styling.ChipStyle import org.jetbrains.jewel.ui.focusOutline import org.jetbrains.jewel.ui.theme.chipStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun Chip( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ComboBox.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ComboBox.kt index df069fb72293..9a03a32426e5 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ComboBox.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ComboBox.kt @@ -46,10 +46,10 @@ import androidx.compose.ui.text.TextStyle import androidx.compose.ui.text.style.TextOverflow import androidx.compose.ui.unit.Dp import androidx.compose.ui.window.PopupProperties -import kotlinx.coroutines.flow.collect import org.jetbrains.jewel.foundation.Stroke import org.jetbrains.jewel.foundation.modifier.border import org.jetbrains.jewel.foundation.modifier.onHover +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.theme.JewelTheme import org.jetbrains.jewel.foundation.theme.LocalContentColor import org.jetbrains.jewel.ui.Outline @@ -57,7 +57,6 @@ import org.jetbrains.jewel.ui.component.styling.ComboBoxStyle import org.jetbrains.jewel.ui.focusOutline import org.jetbrains.jewel.ui.outline import org.jetbrains.jewel.ui.theme.comboBoxStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun ComboBox( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Divider.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Divider.kt index 2f288629dfa3..25ce01b7c665 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Divider.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Divider.kt @@ -11,11 +11,11 @@ import androidx.compose.ui.graphics.Color import androidx.compose.ui.graphics.takeOrElse import androidx.compose.ui.unit.Dp import androidx.compose.ui.unit.takeOrElse +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.theme.JewelTheme import org.jetbrains.jewel.ui.Orientation import org.jetbrains.jewel.ui.component.styling.DividerStyle import org.jetbrains.jewel.ui.theme.dividerStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun Divider( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Dropdown.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Dropdown.kt index 343296122f1b..ef7272e24d5c 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Dropdown.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Dropdown.kt @@ -33,9 +33,9 @@ import androidx.compose.ui.input.InputMode import androidx.compose.ui.layout.onSizeChanged import androidx.compose.ui.platform.LocalDensity import androidx.compose.ui.semantics.Role -import kotlinx.coroutines.flow.collect import org.jetbrains.jewel.foundation.Stroke import org.jetbrains.jewel.foundation.modifier.border +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Active import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Enabled import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Focused @@ -52,7 +52,6 @@ import org.jetbrains.jewel.ui.focusOutline import org.jetbrains.jewel.ui.outline import org.jetbrains.jewel.ui.painter.hints.Stateful import org.jetbrains.jewel.ui.theme.dropdownStyle -import org.jetbrains.jewel.ui.util.thenIf @Deprecated( message = "Use ListComboBox instead. This component will be removed in a future release.", diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/EditableComboBox.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/EditableComboBox.kt index 66c77690a883..7b7e392df2c2 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/EditableComboBox.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/EditableComboBox.kt @@ -54,10 +54,10 @@ import androidx.compose.ui.text.TextStyle import androidx.compose.ui.unit.Dp import androidx.compose.ui.window.PopupProperties import kotlinx.coroutines.coroutineScope -import kotlinx.coroutines.flow.collect import org.jetbrains.jewel.foundation.Stroke import org.jetbrains.jewel.foundation.modifier.border import org.jetbrains.jewel.foundation.modifier.onHover +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Active import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Enabled import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Focused @@ -72,7 +72,6 @@ import org.jetbrains.jewel.ui.component.styling.ComboBoxStyle import org.jetbrains.jewel.ui.focusOutline import org.jetbrains.jewel.ui.outline import org.jetbrains.jewel.ui.theme.comboBoxStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun EditableComboBox( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Icon.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Icon.kt index 32edb9bcd72d..ab8286f1944e 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Icon.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Icon.kt @@ -32,12 +32,12 @@ import org.jetbrains.compose.resources.ExperimentalResourceApi import org.jetbrains.compose.resources.decodeToImageBitmap import org.jetbrains.compose.resources.decodeToImageVector import org.jetbrains.compose.resources.decodeToSvgPainter +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.theme.JewelTheme import org.jetbrains.jewel.ui.icon.IconKey import org.jetbrains.jewel.ui.icon.newUiChecker import org.jetbrains.jewel.ui.painter.PainterHint import org.jetbrains.jewel.ui.painter.rememberResourcePainterProvider -import org.jetbrains.jewel.ui.util.thenIf @Deprecated( "Use the IconKey-based API instead", diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/IconButton.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/IconButton.kt index 9055f7381259..5088bfb20086 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/IconButton.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/IconButton.kt @@ -27,6 +27,7 @@ import androidx.compose.ui.focus.focusProperties import androidx.compose.ui.semantics.Role import androidx.compose.ui.state.ToggleableState import org.jetbrains.jewel.foundation.modifier.onActivated +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Active import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Enabled import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Focused @@ -41,7 +42,6 @@ import org.jetbrains.jewel.foundation.state.ToggleableComponentState.Companion.r import org.jetbrains.jewel.foundation.theme.JewelTheme import org.jetbrains.jewel.ui.component.styling.IconButtonStyle import org.jetbrains.jewel.ui.theme.iconButtonStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun IconButton( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InlineBanner.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InlineBanner.kt index d56a6c034a52..e5f2e7ae3caa 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InlineBanner.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InlineBanner.kt @@ -32,12 +32,12 @@ import androidx.compose.ui.platform.testTag import androidx.compose.ui.text.TextStyle import androidx.compose.ui.unit.Dp import androidx.compose.ui.unit.dp +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.theme.JewelTheme import org.jetbrains.jewel.foundation.theme.LocalContentColor import org.jetbrains.jewel.ui.component.styling.InlineBannerStyle import org.jetbrains.jewel.ui.icons.AllIconsKeys import org.jetbrains.jewel.ui.theme.inlineBannerStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun InformationInlineBanner( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InputField.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InputField.kt index a9e77425a32c..c9814a37179d 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InputField.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InputField.kt @@ -32,6 +32,7 @@ import androidx.compose.ui.unit.Density import org.jetbrains.annotations.ApiStatus.ScheduledForRemoval import org.jetbrains.jewel.foundation.Stroke import org.jetbrains.jewel.foundation.modifier.border +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Active import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Enabled import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Focused @@ -42,7 +43,6 @@ import org.jetbrains.jewel.ui.Outline import org.jetbrains.jewel.ui.component.styling.InputFieldStyle import org.jetbrains.jewel.ui.focusOutline import org.jetbrains.jewel.ui.outline -import org.jetbrains.jewel.ui.util.thenIf @Composable internal fun InputField( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Link.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Link.kt index f5f979c30954..5a54e33e561c 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Link.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Link.kt @@ -31,6 +31,7 @@ import androidx.compose.ui.text.style.TextDecoration import androidx.compose.ui.text.style.TextOverflow import java.awt.Cursor import org.jetbrains.jewel.foundation.modifier.onHover +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.state.CommonStateBitMask import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Active import org.jetbrains.jewel.foundation.state.CommonStateBitMask.Enabled @@ -50,7 +51,6 @@ import org.jetbrains.jewel.ui.disabled import org.jetbrains.jewel.ui.focusOutline import org.jetbrains.jewel.ui.icon.IconKey import org.jetbrains.jewel.ui.painter.hints.Stateful -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun Link( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ListComboBox.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ListComboBox.kt index 7df47cc8fc58..3ca6826d3583 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ListComboBox.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ListComboBox.kt @@ -32,12 +32,12 @@ import org.jetbrains.jewel.foundation.lazy.itemsIndexed import org.jetbrains.jewel.foundation.lazy.rememberSelectableLazyListState import org.jetbrains.jewel.foundation.lazy.visibleItemsRange import org.jetbrains.jewel.foundation.modifier.onMove +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.theme.JewelTheme import org.jetbrains.jewel.foundation.util.JewelLogger import org.jetbrains.jewel.ui.Outline import org.jetbrains.jewel.ui.component.styling.ComboBoxStyle import org.jetbrains.jewel.ui.theme.comboBoxStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun ListComboBox( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Scrollbar.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Scrollbar.kt index 55c30fdf138c..0ffa8f415dbe 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Scrollbar.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Scrollbar.kt @@ -69,6 +69,7 @@ import kotlinx.coroutines.delay import kotlinx.coroutines.launch import kotlinx.coroutines.sync.Mutex import kotlinx.coroutines.sync.withLock +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.theme.JewelTheme import org.jetbrains.jewel.ui.component.styling.ScrollbarStyle import org.jetbrains.jewel.ui.component.styling.ScrollbarVisibility @@ -77,7 +78,6 @@ import org.jetbrains.jewel.ui.component.styling.TrackClickBehavior import org.jetbrains.jewel.ui.component.styling.TrackClickBehavior.JumpToSpot import org.jetbrains.jewel.ui.component.styling.TrackClickBehavior.NextPage import org.jetbrains.jewel.ui.theme.scrollbarStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun VerticalScrollbar( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/SegmentedControl.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/SegmentedControl.kt index 30e9d66ff0e8..5d464d1361a2 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/SegmentedControl.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/SegmentedControl.kt @@ -27,6 +27,7 @@ import androidx.compose.ui.zIndex import org.jetbrains.jewel.foundation.GenerateDataFunctions import org.jetbrains.jewel.foundation.Stroke import org.jetbrains.jewel.foundation.modifier.border +import org.jetbrains.jewel.foundation.modifier.thenIf import org.jetbrains.jewel.foundation.state.CommonStateBitMask import org.jetbrains.jewel.foundation.state.FocusableComponentState import org.jetbrains.jewel.foundation.theme.JewelTheme @@ -35,7 +36,6 @@ import org.jetbrains.jewel.ui.component.styling.SegmentedControlStyle import org.jetbrains.jewel.ui.focusOutline import org.jetbrains.jewel.ui.theme.segmentedControlButtonStyle import org.jetbrains.jewel.ui.theme.segmentedControlStyle -import org.jetbrains.jewel.ui.util.thenIf @Composable public fun SegmentedControl( diff --git a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/util/ModifierExtensions.kt b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/util/ModifierExtensions.kt index 1ab53a57b71a..6eda2db382a0 100644 --- a/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/util/ModifierExtensions.kt +++ b/platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/util/ModifierExtensions.kt @@ -1,6 +1,7 @@ package org.jetbrains.jewel.ui.util import androidx.compose.ui.Modifier +import org.jetbrains.annotations.ApiStatus /** * Conditionally applies the [action] to the receiver [Modifier], if [precondition] is true. Returns the receiver as-is @@ -8,7 +9,8 @@ import androidx.compose.ui.Modifier */ @Deprecated( message = "This modifier has been moved to org.jetbrains.jewel.foundation.util. Please update your imports.", - ReplaceWith("thenIf(precondition, action)", "org.jetbrains.jewel.foundation.util"), + ReplaceWith("thenIf(precondition, action)", "org.jetbrains.jewel.foundation.modifier.thenIf"), ) +@ApiStatus.ScheduledForRemoval(inVersion = "2025.2") public inline fun Modifier.thenIf(precondition: Boolean, action: Modifier.() -> Modifier): Modifier = if (precondition) action() else this