diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/nullable/NullableStuffInspectionBase.java b/java/java-analysis-impl/src/com/intellij/codeInspection/nullable/NullableStuffInspectionBase.java index 736cb4dec27d..0ade64997b4a 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/nullable/NullableStuffInspectionBase.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/nullable/NullableStuffInspectionBase.java @@ -161,8 +161,7 @@ public class NullableStuffInspectionBase extends BaseJavaBatchLocalInspectionToo addAnnoFix); } if (PropertyUtil.isSimpleSetter(setter)) { - if (annotated.isDeclaredNotNull && isNullableNotInferred(parameter, false) || - annotated.isDeclaredNullable && isNotNullNotInferred(parameter, false, false)) { + if (annotated.isDeclaredNotNull && isNullableNotInferred(parameter, false)) { final PsiIdentifier nameIdentifier1 = parameter.getNameIdentifier(); assertValidElement(setter, parameter, nameIdentifier1); holder.registerProblem(nameIdentifier1, InspectionsBundle.message( diff --git a/java/java-tests/testData/inspection/nullableProblems/GetterSetterProblems.java b/java/java-tests/testData/inspection/nullableProblems/GetterSetterProblems.java index c8a5816ec741..e12d8e2de3d4 100644 --- a/java/java-tests/testData/inspection/nullableProblems/GetterSetterProblems.java +++ b/java/java-tests/testData/inspection/nullableProblems/GetterSetterProblems.java @@ -1,4 +1,7 @@ import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +import java.lang.Object; class B { @NotNull @@ -26,16 +29,16 @@ class C { this.c = c; } - C(@Nullable C c, int i) { + C(@Nullable C c, int i) { this.c = c; } - @Nullable - public C getC() { + @Nullable + public C getC() { return c; } - public void setC(@Nullable C c) { + public void setC(@Nullable C c) { this.c = c; } @@ -50,7 +53,7 @@ class C { } class D { - @Nullable Long myL; + @Nullable Long myL; D(long l) { myL = l; @@ -64,4 +67,11 @@ class E { this.c = c; } +} +class F { + @Nullable Object field; + + public void setField(@NotNull Object field) { + this.field = field; + } } \ No newline at end of file diff --git a/java/java-tests/testData/inspection/nullableProblems/HonorParameterDefaultInSetters.java b/java/java-tests/testData/inspection/nullableProblems/HonorParameterDefaultInSetters.java index a6b9b17afe42..8d74c640e574 100644 --- a/java/java-tests/testData/inspection/nullableProblems/HonorParameterDefaultInSetters.java +++ b/java/java-tests/testData/inspection/nullableProblems/HonorParameterDefaultInSetters.java @@ -7,7 +7,7 @@ class C { private String a; private String b; - public void setA(String a) { + public void setA(String a) { this.a = a; }