From ce1dd8a0fcfc2b8b0b89cfbde9aabc035d7e5d0c Mon Sep 17 00:00:00 2001 From: Dmitry Batkovich Date: Mon, 5 Feb 2018 19:02:35 +0300 Subject: [PATCH] avoid npe --- .../sameParameterValue/SameParameterValueInspectionBase.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/sameParameterValue/SameParameterValueInspectionBase.java b/java/java-analysis-impl/src/com/intellij/codeInspection/sameParameterValue/SameParameterValueInspectionBase.java index 73aa0101536e..442f26fb7be8 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/sameParameterValue/SameParameterValueInspectionBase.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/sameParameterValue/SameParameterValueInspectionBase.java @@ -8,6 +8,7 @@ import com.intellij.codeInspection.*; import com.intellij.codeInspection.deadCode.UnusedDeclarationInspectionBase; import com.intellij.codeInspection.reference.*; import com.intellij.openapi.progress.EmptyProgressIndicator; +import com.intellij.openapi.util.Comparing; import com.intellij.openapi.util.text.StringUtil; import com.intellij.psi.*; import com.intellij.util.ObjectUtils; @@ -214,7 +215,7 @@ public class SameParameterValueInspectionBase extends GlobalJavaBatchInspectionT needFurtherProcess = true; } } else if (value != VALUE_IS_NOT_CONST) { - if (!paramValues[i].equals(currentArg)) { + if (!Comparing.equal(paramValues[i], currentArg)) { paramValues[i] = VALUE_IS_NOT_CONST; } else { needFurtherProcess = true;