From cdff6032f2da30853b8e2f3f6e7268e37aee3a3b Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Mon, 21 May 2018 13:02:13 +0700 Subject: [PATCH] ContractInfo: encapsulate fields (IDEA-CR-32782) --- .../dataFlow/JavaMethodContractUtil.java | 20 ++++++++++++++++--- .../dataFlow/MutationSignature.java | 2 +- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/JavaMethodContractUtil.java b/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/JavaMethodContractUtil.java index b996a102223e..a1083ae93631 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/JavaMethodContractUtil.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/JavaMethodContractUtil.java @@ -59,15 +59,29 @@ public class JavaMethodContractUtil { static class ContractInfo { static final ContractInfo EMPTY = new ContractInfo(Collections.emptyList(), false, MutationSignature.UNKNOWN); - final @NotNull List myContracts; - final boolean myPure; - final @NotNull MutationSignature myMutationSignature; + private final @NotNull List myContracts; + private final boolean myPure; + private final @NotNull MutationSignature myMutationSignature; ContractInfo(@NotNull List contracts, boolean pure, @NotNull MutationSignature signature) { myContracts = contracts; myPure = pure; myMutationSignature = signature; } + + @NotNull + List getContracts() { + return myContracts; + } + + boolean isPure() { + return myPure; + } + + @NotNull + MutationSignature getMutationSignature() { + return myMutationSignature; + } } @NotNull diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/MutationSignature.java b/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/MutationSignature.java index 52c25f4abb5b..69d1160a1d24 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/MutationSignature.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/MutationSignature.java @@ -115,6 +115,6 @@ public class MutationSignature { @NotNull public static MutationSignature fromMethod(@Nullable PsiMethod method) { if (method == null) return UNKNOWN; - return JavaMethodContractUtil.getContractInfo(method).myMutationSignature; + return JavaMethodContractUtil.getContractInfo(method).getMutationSignature(); } }