From cd2fc5d5852326cfb32f932b21404b2a4f712593 Mon Sep 17 00:00:00 2001
From: Nikolay Chashnikov <nikolay.chashnikov@jetbrains.com>
Date: Wed, 15 Oct 2025 10:49:18 +0200
Subject: [PATCH] [plugin model tests] improve module visibility check for
 modules included in multiple plugins (IJPL-206556)

If a module depends on a private module which is included in that same plugin, no problem should be reported even if the target module is included in other plugins as well.

GitOrigin-RevId: 5179f0311c250caa8410cfabda1c882e4b0541de
---
 .../testSrc/com/intellij/ide/plugins/PluginModelValidator.kt  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/platform/platform-tests/testSrc/com/intellij/ide/plugins/PluginModelValidator.kt b/platform/platform-tests/testSrc/com/intellij/ide/plugins/PluginModelValidator.kt
index e776778cc526..ff90ece67f5c 100644
--- a/platform/platform-tests/testSrc/com/intellij/ide/plugins/PluginModelValidator.kt
+++ b/platform/platform-tests/testSrc/com/intellij/ide/plugins/PluginModelValidator.kt
@@ -525,8 +525,8 @@ class PluginModelValidator(
           if (SystemProperties.getBooleanProperty("intellij.plugin.model.check.module.visibility", false)) {
             when (moduleInfo.descriptor.moduleVisibility) {
               ModuleVisibility.PRIVATE -> {
-                val differentContainingPlugin = containingPlugins.find { it.pluginId != referencingPluginInfo.pluginId }
-                if (differentContainingPlugin != null) {
+                if (containingPlugins.all { it.pluginId != referencingPluginInfo.pluginId }) {
+                  val differentContainingPlugin = containingPlugins.first()
                   registerError("""
                   |Module '$moduleName' has 'private' (default) visibility in '${differentContainingPlugin.pluginId}' but it is used as a dependency in 
                   |a plugin '${referencingPluginInfo.pluginId}'.