From ccd4e5ef6d3360012f0f89a26233fc9bd087ad46 Mon Sep 17 00:00:00 2001 From: Vadim Salavatov Date: Fri, 21 Feb 2025 17:56:14 +0100 Subject: [PATCH] [tests] PluginDependenciesTest: more plugin alias tests GitOrigin-RevId: a83f7e54a53d3f478d9b1e7b5d3d2a6c677e1857 --- .../ide/plugins/PluginDependenciesTest.kt | 23 +++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/platform/platform-tests/testSrc/com/intellij/ide/plugins/PluginDependenciesTest.kt b/platform/platform-tests/testSrc/com/intellij/ide/plugins/PluginDependenciesTest.kt index d6367feb5648..50a8dd743d87 100644 --- a/platform/platform-tests/testSrc/com/intellij/ide/plugins/PluginDependenciesTest.kt +++ b/platform/platform-tests/testSrc/com/intellij/ide/plugins/PluginDependenciesTest.kt @@ -224,22 +224,41 @@ internal class PluginDependenciesTest { } @Test - fun `plugin is loaded when it has an dependency on plugin alias - depends`() { + fun `plugin is loaded when it has a dependency on plugin alias (depends)`() { `foo depends bar`() - PluginBuilder.empty().id("baz").pluginAlias("bar").build(pluginDirPath.resolve("baz")) + `baz with alias bar`() val pluginSet = buildPluginSet() assertThat(pluginSet).hasExactlyEnabledPlugins("foo", "baz") } + @Test + fun `plugin is loaded when it has a plugin dependency on plugin alias`() { + `foo plugin-dependency bar`() + `baz with alias bar`() + val pluginSet = buildPluginSet() + assertThat(pluginSet).hasExactlyEnabledPlugins("foo", "baz") + } + + @Test + fun `plugin is not loaded when it has a module dependency on plugin alias`() { + `foo module-dependency bar`() + `baz with alias bar`() + val pluginSet = buildPluginSet() + assertThat(pluginSet).hasExactlyEnabledPlugins("baz") + } + private fun foo() = PluginBuilder.empty().id("foo").build(pluginDirPath.resolve("foo")) private fun `foo depends bar`() = PluginBuilder.empty().id("foo").depends("bar").build(pluginDirPath.resolve("foo")) private fun `foo depends-optional bar`() = PluginBuilder.empty().id("foo") .depends("bar", PluginBuilder.empty().actions("")) .build(pluginDirPath.resolve("foo")) + private fun `foo plugin-dependency bar`() = PluginBuilder.empty().id("foo").pluginDependency("bar").build(pluginDirPath.resolve("foo")) + private fun `foo module-dependency bar`() = PluginBuilder.empty().id("foo").dependency("bar").build(pluginDirPath.resolve("foo")) private fun bar() = PluginBuilder.empty().id("bar").build(pluginDirPath.resolve("bar")) private fun baz() = PluginBuilder.empty().id("baz").build(pluginDirPath.resolve("baz")) + private fun `baz with alias bar`() = PluginBuilder.empty().id("baz").pluginAlias("bar").build(pluginDirPath.resolve("baz")) private fun buildPluginSet(expiredPluginIds: Array = emptyArray(), disabledPluginIds: Array = emptyArray()) = PluginSetTestBuilder(pluginDirPath)