From cc2a4f7bbbcae90ff73a370c25ff36977536033b Mon Sep 17 00:00:00 2001 From: Vladimir Krivosheev Date: Wed, 25 Jan 2017 15:42:00 +0100 Subject: [PATCH] cleanup (class cast) --- .../DependencyValidationManagerImpl.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/platform/analysis-impl/src/com/intellij/packageDependencies/DependencyValidationManagerImpl.java b/platform/analysis-impl/src/com/intellij/packageDependencies/DependencyValidationManagerImpl.java index 8afdc8b1e4cd..6a36bb5bc990 100644 --- a/platform/analysis-impl/src/com/intellij/packageDependencies/DependencyValidationManagerImpl.java +++ b/platform/analysis-impl/src/com/intellij/packageDependencies/DependencyValidationManagerImpl.java @@ -220,11 +220,10 @@ public class DependencyValidationManagerImpl extends DependencyValidationManager }); super.setScopes(scopes); myUnnamedScopes.clear(); - final List unnamedScopes = element.getChildren(UNNAMED_SCOPE); final PackageSetFactory packageSetFactory = PackageSetFactory.getInstance(); - for (Object unnamedScope : unnamedScopes) { + for (Element unnamedScope : element.getChildren(UNNAMED_SCOPE)) { try { - final String packageSet = ((Element)unnamedScope).getAttributeValue(VALUE); + final String packageSet = unnamedScope.getAttributeValue(VALUE); myUnnamedScopes.put(packageSet, packageSetFactory.compile(packageSet)); } catch (ParsingException ignored) { @@ -235,7 +234,7 @@ public class DependencyValidationManagerImpl extends DependencyValidationManager readRules(element); } - private void readRules(Element element) { + private void readRules(@NotNull Element element) { removeAllRules(); for (Element rule1 : element.getChildren(DENY_RULE_KEY)) { @@ -305,7 +304,7 @@ public class DependencyValidationManagerImpl extends DependencyValidationManager } @Nullable - private DependencyRule readRule(Element ruleElement) { + private DependencyRule readRule(@NotNull Element ruleElement) { String fromScope = ruleElement.getAttributeValue(FROM_SCOPE_KEY); String toScope = ruleElement.getAttributeValue(TO_SCOPE_KEY); String denyRule = ruleElement.getAttributeValue(IS_DENY_KEY);