diff --git a/platform/core-api/src/com/intellij/openapi/options/SchemesManagerFactory.java b/platform/core-api/src/com/intellij/openapi/options/SchemesManagerFactory.java index f1a090359b68..a0c0ee7dad62 100644 --- a/platform/core-api/src/com/intellij/openapi/options/SchemesManagerFactory.java +++ b/platform/core-api/src/com/intellij/openapi/options/SchemesManagerFactory.java @@ -19,14 +19,16 @@ import com.intellij.openapi.components.RoamingType; import com.intellij.openapi.components.ServiceBean; import com.intellij.openapi.components.ServiceManager; import com.intellij.openapi.extensions.ExtensionPointName; +import org.jetbrains.annotations.NotNull; public abstract class SchemesManagerFactory { - public static ExtensionPointName SCHEME_OWNER = ExtensionPointName.create("com.intellij.schemeOwner"); + public static final ExtensionPointName SCHEME_OWNER = ExtensionPointName.create("com.intellij.schemeOwner"); - public abstract SchemesManager createSchemesManager(String fileSpec, SchemeProcessor processor, - RoamingType roamingType); + public abstract SchemesManager createSchemesManager(@NotNull String fileSpec, + @NotNull SchemeProcessor processor, + @NotNull RoamingType roamingType); - public static SchemesManagerFactory getInstance(){ + public static SchemesManagerFactory getInstance() { return ServiceManager.getService(SchemesManagerFactory.class); } diff --git a/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/DefaultProjectStoreImpl.java b/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/DefaultProjectStoreImpl.java index 48247b2de866..6f0c3b8122cf 100644 --- a/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/DefaultProjectStoreImpl.java +++ b/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/DefaultProjectStoreImpl.java @@ -159,8 +159,8 @@ public class DefaultProjectStoreImpl extends ProjectStoreImpl { } @Override - public String expandMacros(final String file) { - throw new UnsupportedOperationException("Method expandMacroses not implemented in " + getClass()); + public String expandMacros(@NotNull String file) { + throw new UnsupportedOperationException("Method expandMacros not implemented in " + getClass()); } @Override diff --git a/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/StateStorageManager.java b/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/StateStorageManager.java index 0e2828e988a3..68d882d2b204 100644 --- a/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/StateStorageManager.java +++ b/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/StateStorageManager.java @@ -58,7 +58,7 @@ public interface StateStorageManager { StateStorage getOldStorage(Object component, String componentName, StateStorageOperation operation) throws StateStorageException; @Nullable - String expandMacros(String file); + String expandMacros(@NotNull String file); @Deprecated void registerStreamProvider(@SuppressWarnings("deprecation") StreamProvider streamProvider, final RoamingType type); diff --git a/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/StateStorageManagerImpl.java b/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/StateStorageManagerImpl.java index 334f9eadfd1f..97975c586108 100644 --- a/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/StateStorageManagerImpl.java +++ b/platform/platform-impl/src/com/intellij/openapi/components/impl/stores/StateStorageManagerImpl.java @@ -331,7 +331,7 @@ public abstract class StateStorageManagerImpl implements StateStorageManager, Di @Override @Nullable - public synchronized String expandMacros(final String file) { + public synchronized String expandMacros(@NotNull String file) { final Matcher matcher = MACRO_PATTERN.matcher(file); while (matcher.find()) { String m = matcher.group(1); diff --git a/platform/platform-impl/src/com/intellij/openapi/options/SchemesManagerFactoryImpl.java b/platform/platform-impl/src/com/intellij/openapi/options/SchemesManagerFactoryImpl.java index 323394ad7c94..4db0e54e02bf 100644 --- a/platform/platform-impl/src/com/intellij/openapi/options/SchemesManagerFactoryImpl.java +++ b/platform/platform-impl/src/com/intellij/openapi/options/SchemesManagerFactoryImpl.java @@ -38,9 +38,9 @@ public class SchemesManagerFactoryImpl extends SchemesManagerFactory implements private final List myRegisteredManagers = ContainerUtil.createLockFreeCopyOnWriteList(); @Override - public SchemesManager createSchemesManager(final String fileSpec, - final SchemeProcessor processor, - final RoamingType roamingType) { + public SchemesManager createSchemesManager(@NotNull String fileSpec, + @NotNull SchemeProcessor processor, + @NotNull RoamingType roamingType) { final Application application = ApplicationManager.getApplication(); if (!(application instanceof ApplicationImpl)) return null; String baseDirPath = ((ApplicationImpl)application).getStateStore().getStateStorageManager().expandMacros(fileSpec); diff --git a/platform/testFramework/src/com/intellij/testFramework/MockSchemesManagerFactory.java b/platform/testFramework/src/com/intellij/testFramework/MockSchemesManagerFactory.java index b74bb8e204b5..ab5ee3d9f7c6 100644 --- a/platform/testFramework/src/com/intellij/testFramework/MockSchemesManagerFactory.java +++ b/platform/testFramework/src/com/intellij/testFramework/MockSchemesManagerFactory.java @@ -2,16 +2,19 @@ package com.intellij.testFramework; import com.intellij.openapi.components.RoamingType; import com.intellij.openapi.options.*; +import org.jetbrains.annotations.NotNull; public class MockSchemesManagerFactory extends SchemesManagerFactory { @Override - public SchemesManager createSchemesManager(final String fileSpec, - final SchemeProcessor processor, final RoamingType roamingType) { + public SchemesManager createSchemesManager(@NotNull String fileSpec, + @NotNull SchemeProcessor processor, + @NotNull RoamingType roamingType) { + //noinspection unchecked return SchemesManager.EMPTY; } @Override public void updateConfigFilesFromStreamProviders() { - + } }