From c2a001f7e95b7be5d099502cce409c1f90dda8ff Mon Sep 17 00:00:00 2001
From: Alexey Kudravtsev <cdr@intellij.com>
Date: Mon, 13 Jan 2020 00:33:33 +0300
Subject: [PATCH] simplify, reduce memory footprint

GitOrigin-RevId: d5803b43a2387a7a97809154a022f6febb0ca1ca
---
 .../psi/JavaSOEOnReparsePerformanceTest.java  | 45 +++++++------------
 1 file changed, 15 insertions(+), 30 deletions(-)

diff --git a/java/java-tests/testSrc/com/intellij/java/psi/JavaSOEOnReparsePerformanceTest.java b/java/java-tests/testSrc/com/intellij/java/psi/JavaSOEOnReparsePerformanceTest.java
index 26fc979e3393..a71cf09095b3 100644
--- a/java/java-tests/testSrc/com/intellij/java/psi/JavaSOEOnReparsePerformanceTest.java
+++ b/java/java-tests/testSrc/com/intellij/java/psi/JavaSOEOnReparsePerformanceTest.java
@@ -25,32 +25,12 @@ import org.intellij.lang.annotations.Language;
 
 @SkipSlowTestLocally
 public class JavaSOEOnReparsePerformanceTest extends LightDaemonAnalyzerTestCase {
-  private StringBuilder myHugeExpr;
-
-  @Override
-  public void setUp() throws Exception {
-    super.setUp();
+  private StringBuilder getHugeExpr() {
     int N = 100_000;
     String expr = "+\"b\"";
-    myHugeExpr = new StringBuilder(N * expr.length() + 10);
-    myHugeExpr.append("\"-\"");
-    myHugeExpr.append(StringUtil.repeat(expr, N));
-  }
-
-  @Override
-  public void tearDown() throws Exception {
-    try {
-      if (myHugeExpr != null) {
-        myHugeExpr.setLength(0);
-        myHugeExpr = null;
-      }
-    }
-    catch (Throwable e) {
-      addSuppressedException(e);
-    }
-    finally {
-      super.tearDown();
-    }
+    return new StringBuilder(N * expr.length() + 10)
+    .append("\"-\"")
+    .append(StringUtil.repeat(expr, N));
   }
 
   public void testOnHugeBinaryExprInFile() {
@@ -70,11 +50,16 @@ public class JavaSOEOnReparsePerformanceTest extends LightDaemonAnalyzerTestCase
   private void doTest() {
     final int pos = getEditor().getDocument().getText().indexOf("\"\"");
 
-    // replace small expression with huge binary one
-    WriteCommandAction.runWriteCommandAction(null, () -> {
-      getEditor().getDocument().replaceString(pos, pos + 2, myHugeExpr);
-      PsiDocumentManager.getInstance(getProject()).commitAllDocuments();
-    });
+    int hugeExprLength;
+    {
+      // replace small expression with huge binary one
+      CharSequence myHugeExpr = getHugeExpr();
+      hugeExprLength = myHugeExpr.length();
+      WriteCommandAction.runWriteCommandAction(null, () -> {
+        getEditor().getDocument().replaceString(pos, pos + 2, myHugeExpr);
+        PsiDocumentManager.getInstance(getProject()).commitAllDocuments();
+      });
+    }
     doTestConfiguredFile(false, false, null);
 
     // modify huge binary expression (1)
@@ -93,7 +78,7 @@ public class JavaSOEOnReparsePerformanceTest extends LightDaemonAnalyzerTestCase
 
     // replace huge binary expression with small one
     ApplicationManager.getApplication().runWriteAction(() -> {
-      getEditor().getDocument().replaceString(pos, pos + myHugeExpr.length(), "\".\"");
+      getEditor().getDocument().replaceString(pos, pos + hugeExprLength, "\".\"");
       PsiDocumentManager.getInstance(getProject()).commitAllDocuments();
     });
     doTestConfiguredFile(false, false, null);