From c1c102bcd668ea3ec4c7fba2d3e71759c45b9092 Mon Sep 17 00:00:00 2001
From: Bartek Pacia <bartek.pacia@jetbrains.com>
Date: Fri, 22 Aug 2025 18:31:11 +0200
Subject: [PATCH] [java-inspections] IDEA-371645 ClassCanBeRecord: change
 option phrasing and change default option

See the linked ticket for more discussion.

GitOrigin-RevId: 7ebc61d24678bb8ed5e5f71507d12802c39b46ff
---
 .../classCanBeRecord/ClassCanBeRecordInspection.java  |  2 +-
 .../weakenAccessibility/afterNoGetters.java           |  4 ++++
 .../weakenAccessibility/beforeNoGetters.java          | 11 +++++++++++
 java/openapi/resources/messages/JavaBundle.properties |  2 +-
 4 files changed, 17 insertions(+), 2 deletions(-)
 create mode 100644 java/java-tests/testData/inspection/classCanBeRecord/weakenAccessibility/afterNoGetters.java
 create mode 100644 java/java-tests/testData/inspection/classCanBeRecord/weakenAccessibility/beforeNoGetters.java

diff --git a/java/java-impl-inspections/src/com/intellij/codeInspection/classCanBeRecord/ClassCanBeRecordInspection.java b/java/java-impl-inspections/src/com/intellij/codeInspection/classCanBeRecord/ClassCanBeRecordInspection.java
index 03716f298043..820cdbd4f5ba 100644
--- a/java/java-impl-inspections/src/com/intellij/codeInspection/classCanBeRecord/ClassCanBeRecordInspection.java
+++ b/java/java-impl-inspections/src/com/intellij/codeInspection/classCanBeRecord/ClassCanBeRecordInspection.java
@@ -38,7 +38,7 @@ import static com.intellij.codeInspection.options.OptPane.*;
 public final class ClassCanBeRecordInspection extends BaseInspection implements CleanupLocalInspectionTool {
   private static final List<String> IGNORED_ANNOTATIONS = List.of("io.micronaut.*", "jakarta.*", "javax.*", "org.springframework.*");
 
-  public @NotNull ConversionStrategy myConversionStrategy = SHOW_AFFECTED_MEMBERS;
+  public @NotNull ConversionStrategy myConversionStrategy = DO_NOT_SUGGEST;
   public boolean suggestAccessorsRenaming = true;
 
   public final List<@NlsSafe String> myIgnoredAnnotations = new ArrayList<>();
diff --git a/java/java-tests/testData/inspection/classCanBeRecord/weakenAccessibility/afterNoGetters.java b/java/java-tests/testData/inspection/classCanBeRecord/weakenAccessibility/afterNoGetters.java
new file mode 100644
index 000000000000..9dd744b17274
--- /dev/null
+++ b/java/java-tests/testData/inspection/classCanBeRecord/weakenAccessibility/afterNoGetters.java
@@ -0,0 +1,4 @@
+// "Convert to record class" "true-preview"
+
+record Person(String name, int age) {
+}
diff --git a/java/java-tests/testData/inspection/classCanBeRecord/weakenAccessibility/beforeNoGetters.java b/java/java-tests/testData/inspection/classCanBeRecord/weakenAccessibility/beforeNoGetters.java
new file mode 100644
index 000000000000..b1640aadd603
--- /dev/null
+++ b/java/java-tests/testData/inspection/classCanBeRecord/weakenAccessibility/beforeNoGetters.java
@@ -0,0 +1,11 @@
+// "Convert to record class" "true-preview"
+
+class Person<caret> {
+  private final String name;
+  private final int age;
+
+  Person(String name, int age) {
+    this.name = name;
+    this.age = age;
+  }
+}
diff --git a/java/openapi/resources/messages/JavaBundle.properties b/java/openapi/resources/messages/JavaBundle.properties
index 6a53504709c5..7c19b3eaff25 100644
--- a/java/openapi/resources/messages/JavaBundle.properties
+++ b/java/openapi/resources/messages/JavaBundle.properties
@@ -1473,7 +1473,7 @@ intention.family.name.convert.record.to.class=Convert record to class
 class.can.be.record.display.name=Class can be record class
 class.can.be.record.quick.fix=Convert to record class
 class.can.be.record.suggest.renaming.accessors=Suggest renaming accessor methods
-class.can.be.record.record.highlight.when.semantics.change=Disable highlighting if members become more accessible
+class.can.be.record.record.highlight.when.semantics.change=Don't report if members will become more accessible
 class.can.be.record.record.highlight.when.semantics.change.description=Quick-fix will still be available
 class.can.be.record.suppress.conversion.if.annotated=Suppress conversion if the class is annotated by:
 class.can.be.record.suppress.conversion.if.annotated.fix.name=Suppress record conversion if annotated by ''{0}''