From c0111a29fa8c2d75ff3356ed363fc22a3565f6a1 Mon Sep 17 00:00:00 2001 From: nik Date: Fri, 29 Aug 2014 09:31:29 +0400 Subject: [PATCH] tests: cleanup and meaningful names --- .../classes/a/a/a/a/e/f/i.class | Bin .../com/intellij/internal/a/b/a/i.class | Bin .../classes1/com/intellij/util/d/bw.class | Bin 7667 -> 0 bytes ....java => FindClassInDeepPackagesTest.java} | 19 +++++++++--------- ...java => ClassFileUnderSourceRootTest.java} | 15 ++++---------- .../{SCR14423Test.java => FindClassTest.java} | 19 ++++++------------ ...va => SameSourceRootInTwoModulesTest.java} | 9 ++------- ... => SourceRootAddedAsLibraryRootTest.java} | 15 ++------------ 8 files changed, 23 insertions(+), 54 deletions(-) rename java/java-tests/testData/psi/repositoryUse/{scr17094 => deepPackages}/classes/a/a/a/a/e/f/i.class (100%) rename java/java-tests/testData/psi/repositoryUse/{scr17094 => deepPackages}/classes2/com/intellij/internal/a/b/a/i.class (100%) delete mode 100644 java/java-tests/testData/psi/repositoryUse/scr17094/classes1/com/intellij/util/d/bw.class rename java/java-tests/testSrc/com/intellij/psi/{SCR17094Test.java => FindClassInDeepPackagesTest.java} (90%) rename java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/{SCR17650Test.java => ClassFileUnderSourceRootTest.java} (84%) rename java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/{SCR14423Test.java => FindClassTest.java} (92%) rename java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/{SCR20733Test.java => SameSourceRootInTwoModulesTest.java} (91%) rename java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/{SCR19174Test.java => SourceRootAddedAsLibraryRootTest.java} (77%) diff --git a/java/java-tests/testData/psi/repositoryUse/scr17094/classes/a/a/a/a/e/f/i.class b/java/java-tests/testData/psi/repositoryUse/deepPackages/classes/a/a/a/a/e/f/i.class similarity index 100% rename from java/java-tests/testData/psi/repositoryUse/scr17094/classes/a/a/a/a/e/f/i.class rename to java/java-tests/testData/psi/repositoryUse/deepPackages/classes/a/a/a/a/e/f/i.class diff --git a/java/java-tests/testData/psi/repositoryUse/scr17094/classes2/com/intellij/internal/a/b/a/i.class b/java/java-tests/testData/psi/repositoryUse/deepPackages/classes2/com/intellij/internal/a/b/a/i.class similarity index 100% rename from java/java-tests/testData/psi/repositoryUse/scr17094/classes2/com/intellij/internal/a/b/a/i.class rename to java/java-tests/testData/psi/repositoryUse/deepPackages/classes2/com/intellij/internal/a/b/a/i.class diff --git a/java/java-tests/testData/psi/repositoryUse/scr17094/classes1/com/intellij/util/d/bw.class b/java/java-tests/testData/psi/repositoryUse/scr17094/classes1/com/intellij/util/d/bw.class deleted file mode 100644 index 46b8238fc620d6c0b8e487ac2fd0d27c07805437..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 7667 zcmb_g3s_uNo&TN8ow+b`lMs@DOkfCkmdp@nXiHllv?&dSCJ&&mKw~tGkBx49?7Cg+`&n1leZSmYT@`=-doRpoxYSQS zKR(Vq=br!jedqb#eBvU2E7h7}G~mOsJSEFVWcg^2%g2J)fwOXaT9#*I`M50SbWG@& z48p+KB23BiSy|4@@`)fqxDdoA@u?zQlsC@_&Lth6mgi@*8*T)I{AWYxz~_SaOI()Y z=ZjH}F9h*dcwTm24B<=ovhSYh>1jEBMV7w~;cxJ~0Dm>ejBlDN$1RDI*}c% z-##*Crjog1Eqiu0w-QzLEkt;Px4(nf4s-NiTV^0JORQgE)2@yuiu`|Wi18w^iW4j%R>rf zE~vIlDwXKZB{OL4j`5 zY)VEG*`%53p%=*a_Kus0aEsrsf9unqE!+Q9g+NO(oy@f=Tvg*~!Nbj-uSc3Y+Bfwm zXyOR5BmLYpHq@8M?lJpPd{cDL@sh%;y(ljj93JdkuycKH%h2FOUqaM_)IdEY7s2oJ zLUJ*h8?hdgT(AW~3HdEv_Mze2G3&gKDdKP+wNgYOTw_y8nd!m$-F=6cZOxkq z=Uv34I+V^wPzcSC-I)+pgNdBNMlaG{$VD|2e-q`mgro+(;W6T0=Yc;Tebf9`6h|nM zpiMN8O$=r3qDjg}@svI%p@vPE$F(f-7+)bCLp z|DzD(&A<$LRUvvu+KsK_f30|6^Qrerqk;OqBdkm=ZCrv@EQldVu|WMJy-f>u#RUqK zAbAu!DVwb6E&VB{TRhmZvuS>)_ISK&b*Z$iZ#0)R`*V!M*&KIW&wp*@aa)R!Ctao4 zhNXkLt)`Z|+j>h!bZ5r0{fYLZbRNC$NS$! zgDsU!x4O+7Hv2jDG*uh;Km0i0ZW2#teLaaS< z9TdfBj1d(wR23f8m0_sGYKg9v8ma^*3{{Os6qe`5Bs$4XGD9uHBZeyFg16v71Md*X zGA}{jzHawik<`M%gaIyiG?(`IUWHk+Y!Jt_BdLgk=7qLwcJ z(8tp2jY*#$25Y3JX@`a83SET_RYv=$a<$UH<0_)7RfejNH@sc=If5#E~{1Nt=5(@M@MPg_RLt?ZP9 z)wD~`uHa)~v6ke~JIx$NdEbzElr(BOI;1A9n-hi^YHkiE?K!_KGc;^U+7db;-z5rH zxMg(41{Z7BAmQojkpeAe;3qx(L1sA&`9mEc2 z^*g4)oZjhbFQt|(=X6JwQ4a83iK8SD;QV6^LPgv-gVxJ*BnnaKt)123c)iNv=hvNjbBCyH;dxuv1SoOSIh*Gu5~9cepM_*`G1p?`CqZqF5&xMRu}0a47mXfLR<6vy_SE!qi+HcHWkDB3cLmZfNE)}J%X^gnfi;S`1A zIOn+Qd5Ty}DtC*B7h5brEBptw{jHK`OIe1tNjVsEY)e^hiL23`BI=n6{4&Hx@W}BXf6;X1<%2`T9j&H`L<;zkeOL1JrfcV*67jO+5edBXv3Hc(W@$KSN$Cw4dYjjLFxqdcK#AyOvIg5@QR$$N!waTu1S!{%jGDn1oD$Vv8Y(0Act-Y~| zDcn#Y!Qzz45hI*Q^Yp@-@G+eX-A!sLmgq%09{~_vqBl`0ivh+n`lsCEg5(`}}$L*<)75f_~&{zzgKpM6%pFO=gXF<#}3 zq3zS8d>3N8kr=(R81AuC6@vN+IzC$%*IAb1ynF%etSGPeIJV|}ZW}O65W9-Mh!4`t Ii}0b}0vV7bA^-pY diff --git a/java/java-tests/testSrc/com/intellij/psi/SCR17094Test.java b/java/java-tests/testSrc/com/intellij/psi/FindClassInDeepPackagesTest.java similarity index 90% rename from java/java-tests/testSrc/com/intellij/psi/SCR17094Test.java rename to java/java-tests/testSrc/com/intellij/psi/FindClassInDeepPackagesTest.java index 501914bce501..5e5e010df2f7 100644 --- a/java/java-tests/testSrc/com/intellij/psi/SCR17094Test.java +++ b/java/java-tests/testSrc/com/intellij/psi/FindClassInDeepPackagesTest.java @@ -29,9 +29,13 @@ import java.io.File; /** * @author dsl */ -public class SCR17094Test extends PsiTestCase { - protected void setUpClasses(final String s) throws Exception { - final String testRoot = PathManagerEx.getTestDataPath() + "/psi/repositoryUse/scr17094"; +public class FindClassInDeepPackagesTest extends PsiTestCase { + @Override + protected void setUpJdk() { + } + + private void setUpLibrary(final String s) throws Exception { + final String testRoot = PathManagerEx.getTestDataPath() + "/psi/repositoryUse/deepPackages"; VirtualFile classesRoot = WriteCommandAction.runWriteCommandAction(null, new Computable() { @Override public VirtualFile compute() { @@ -44,20 +48,15 @@ public class SCR17094Test extends PsiTestCase { ModuleRootModificationUtil.addModuleLibrary(myModule, classesRoot.getUrl()); } - @Override - protected void setUpJdk() { - - } - public void testSRC() throws Exception { - setUpClasses("classes"); + setUpLibrary("classes"); final JavaPsiFacade psiManager = getJavaFacade(); final PsiClass classA = psiManager.findClass("a.a.a.a.e.f.i", GlobalSearchScope.moduleWithLibrariesScope(myModule)); assertNotNull(classA); } public void test3() throws Exception { - setUpClasses("classes2"); + setUpLibrary("classes2"); final JavaPsiFacade psiManager = getJavaFacade(); final PsiClass classA = psiManager.findClass("com.intellij.internal.f.a.b.a.i", GlobalSearchScope.moduleWithLibrariesScope(myModule)); assertNotNull(classA); diff --git a/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR17650Test.java b/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/ClassFileUnderSourceRootTest.java similarity index 84% rename from java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR17650Test.java rename to java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/ClassFileUnderSourceRootTest.java index 187d0c2ad80e..5311bd15dfec 100644 --- a/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR17650Test.java +++ b/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/ClassFileUnderSourceRootTest.java @@ -3,7 +3,6 @@ package com.intellij.psi.impl.cache.impl; import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.application.ex.PathManagerEx; import com.intellij.openapi.roots.ModuleRootModificationUtil; -import com.intellij.openapi.util.io.FileUtil; import com.intellij.openapi.vfs.LocalFileSystem; import com.intellij.openapi.vfs.VfsUtil; import com.intellij.openapi.vfs.VfsUtilCore; @@ -17,20 +16,15 @@ import java.io.IOException; /** * @author max */ -public class SCR17650Test extends PsiTestCase { +public class ClassFileUnderSourceRootTest extends PsiTestCase { private static final String TEST_ROOT = PathManagerEx.getTestDataPath() + "/psi/repositoryUse/cls"; - private VirtualFile myDir; @Override protected void setUp() throws Exception { super.setUp(); - final File root = FileUtil.createTempFile(getName(), ""); - root.delete(); - root.mkdir(); - myFilesToDelete.add(root); - + final File root = createTempDirectory(); ApplicationManager.getApplication().runWriteAction(new Runnable() { @Override public void run() { @@ -55,11 +49,10 @@ public class SCR17650Test extends PsiTestCase { private static VirtualFile getClassFile() { VirtualFile vDir = LocalFileSystem.getInstance().findFileByPath(TEST_ROOT.replace(File.separatorChar, '/')); - VirtualFile child = vDir.findChild("pack").findChild("MyClass.class"); - return child; + return vDir.findFileByRelativePath("pack/MyClass.class"); } - public void test17650() throws Exception { + public void testFindClass() throws Exception { assertEquals("p.A", myJavaFacade.findClass("p.A").getQualifiedName()); assertEquals("pack.MyClass", myJavaFacade.findClass("pack.MyClass").getQualifiedName()); } diff --git a/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR14423Test.java b/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/FindClassTest.java similarity index 92% rename from java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR14423Test.java rename to java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/FindClassTest.java index be7ef88c2001..e88027409dc0 100644 --- a/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR14423Test.java +++ b/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/FindClassTest.java @@ -23,7 +23,6 @@ import com.intellij.openapi.roots.ContentEntry; import com.intellij.openapi.roots.ModifiableRootModel; import com.intellij.openapi.roots.ModuleRootManager; import com.intellij.openapi.roots.ModuleRootModificationUtil; -import com.intellij.openapi.util.io.FileUtil; import com.intellij.openapi.vfs.LocalFileSystem; import com.intellij.openapi.vfs.VfsUtil; import com.intellij.openapi.vfs.VirtualFile; @@ -38,7 +37,7 @@ import java.io.IOException; /** * @author max */ -public class SCR14423Test extends PsiTestCase { +public class FindClassTest extends PsiTestCase { private VirtualFile myPrjDir1; private VirtualFile mySrcDir1; private VirtualFile myPackDir; @@ -47,11 +46,7 @@ public class SCR14423Test extends PsiTestCase { protected void setUp() throws Exception { super.setUp(); - final File root = FileUtil.createTempFile(getName(), ""); - root.delete(); - root.mkdir(); - myFilesToDelete.add(root); - + final File root = createTempDirectory(); WriteCommandAction.runWriteCommandAction(null, new Runnable() { @Override public void run() { @@ -76,14 +71,12 @@ public class SCR14423Test extends PsiTestCase { }); } - public void testBug2() throws Exception { + public void testSimple() throws Exception { PsiClass psiClass = myJavaFacade.findClass("p.A"); assertEquals("p.A", psiClass.getQualifiedName()); - - testBug1(); } - public void testBug1() { + public void testClassUnderExcludedFolder() { ApplicationManager.getApplication().runWriteAction(new Runnable() { public void run() { PsiTestUtil.addExcludedRoot(myModule, myPackDir); @@ -102,7 +95,7 @@ public class SCR14423Test extends PsiTestCase { }); } - public void testBug3() { + public void testClassUnderIgnoredFolder() { ApplicationManager.getApplication().runWriteAction(new Runnable() { public void run() { PsiClass psiClass = myJavaFacade.findClass("p.A", GlobalSearchScope.allScope(myProject)); @@ -126,7 +119,7 @@ public class SCR14423Test extends PsiTestCase { }); } - public void testSyncrhonizationAfterChange() { + public void testSynchronizationAfterChange() { ApplicationManager.getApplication().runWriteAction(new Runnable() { public void run() { FileDocumentManager.getInstance().saveAllDocuments(); diff --git a/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR20733Test.java b/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SameSourceRootInTwoModulesTest.java similarity index 91% rename from java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR20733Test.java rename to java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SameSourceRootInTwoModulesTest.java index 5fef7daea7d9..1a5d5faeca7c 100644 --- a/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR20733Test.java +++ b/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SameSourceRootInTwoModulesTest.java @@ -3,7 +3,6 @@ package com.intellij.psi.impl.cache.impl; import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.module.Module; import com.intellij.openapi.module.ModuleUtil; -import com.intellij.openapi.util.io.FileUtil; import com.intellij.openapi.vfs.LocalFileSystem; import com.intellij.openapi.vfs.VfsUtil; import com.intellij.openapi.vfs.VirtualFile; @@ -18,7 +17,7 @@ import java.io.IOException; /** * @author max */ -public class SCR20733Test extends PsiTestCase { +public class SameSourceRootInTwoModulesTest extends PsiTestCase { private VirtualFile myPrjDir1; private VirtualFile mySrcDir1; private VirtualFile myPackDir; @@ -27,11 +26,7 @@ public class SCR20733Test extends PsiTestCase { protected void setUp() throws Exception { super.setUp(); - final File root = FileUtil.createTempFile(getName(), ""); - root.delete(); - root.mkdir(); - myFilesToDelete.add(root); - + final File root = createTempDirectory(); ApplicationManager.getApplication().runWriteAction(new Runnable() { @Override public void run() { diff --git a/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR19174Test.java b/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SourceRootAddedAsLibraryRootTest.java similarity index 77% rename from java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR19174Test.java rename to java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SourceRootAddedAsLibraryRootTest.java index c47bbf7184e8..36baf5de0d76 100644 --- a/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SCR19174Test.java +++ b/java/java-tests/testSrc/com/intellij/psi/impl/cache/impl/SourceRootAddedAsLibraryRootTest.java @@ -2,7 +2,6 @@ package com.intellij.psi.impl.cache.impl; import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.roots.ModuleRootModificationUtil; -import com.intellij.openapi.util.io.FileUtil; import com.intellij.openapi.vfs.LocalFileSystem; import com.intellij.openapi.vfs.VfsUtil; import com.intellij.openapi.vfs.VirtualFile; @@ -16,7 +15,7 @@ import java.io.IOException; /** * @author max */ -public class SCR19174Test extends PsiTestCase { +public class SourceRootAddedAsLibraryRootTest extends PsiTestCase { private VirtualFile myDir; private VirtualFile myVFile; @@ -24,11 +23,7 @@ public class SCR19174Test extends PsiTestCase { protected void setUp() throws Exception { super.setUp(); - final File root = FileUtil.createTempFile(getName(), ""); - root.delete(); - root.mkdir(); - myFilesToDelete.add(root); - + final File root = createTempDirectory(); ApplicationManager.getApplication().runWriteAction(new Runnable() { @Override public void run() { @@ -37,12 +32,6 @@ public class SCR19174Test extends PsiTestCase { myDir = rootVFile.createChildDirectory(null, "contentAndLibrary"); - /* - myVFile = myDir.createChildData(null, "A.java"); - Writer writer1 = myVFile.getWriter(null); - writer1.write("package p; public class A{ public void foo(); }"); - writer1.close(); - */ PsiTestUtil.addSourceRoot(myModule, myDir); } catch (IOException e) {