From bf9dc8bef28bc5cce8c87959a1138f589c669a25 Mon Sep 17 00:00:00 2001 From: Yuriy Artamonov Date: Sat, 14 Sep 2024 19:31:25 +0200 Subject: [PATCH] [java] Do not access application service from class init of InferNullityAnnotationsAction GitOrigin-RevId: 6715ca73262ab8a950c236cb8410ed443acfda35 --- .../inferNullity/InferNullityAnnotationsAction.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/java/java-impl/src/com/intellij/codeInspection/inferNullity/InferNullityAnnotationsAction.java b/java/java-impl/src/com/intellij/codeInspection/inferNullity/InferNullityAnnotationsAction.java index 2fcc10c07ec0..0041b0d3eba3 100644 --- a/java/java-impl/src/com/intellij/codeInspection/inferNullity/InferNullityAnnotationsAction.java +++ b/java/java-impl/src/com/intellij/codeInspection/inferNullity/InferNullityAnnotationsAction.java @@ -67,9 +67,6 @@ public class InferNullityAnnotationsAction extends BaseAnalysisAction { private static final String SUGGEST_ANNOTATION_DEPENDENCY = "java.suggest.annotation.dependency"; private static final @NonNls String ANNOTATE_LOCAL_VARIABLES = "checkbox.annotate.local.variables"; private InferNullityAdditionalUi myUi; - private static final NotificationGroup NOTIFICATION_GROUP = NotificationGroupManager - .getInstance() - .getNotificationGroup("Infer Nullity"); public InferNullityAnnotationsAction() { super(JavaBundle.messagePointer("dialog.title.infer.nullity"), JavaBundle.messagePointer("action.title.infer.nullity.annotations")); @@ -287,8 +284,8 @@ public class InferNullityAnnotationsAction extends BaseAnalysisAction { if (command.myCount == 0) { NullityInferrer.nothingFoundMessage(project); } else { - NOTIFICATION_GROUP.createNotification(JavaBundle.message("notification.content.added.annotations", command.myCount), - NotificationType.INFORMATION) + getNotificationGroup().createNotification(JavaBundle.message("notification.content.added.annotations", command.myCount), + NotificationType.INFORMATION) .notify(project); } } @@ -303,6 +300,11 @@ public class InferNullityAnnotationsAction extends BaseAnalysisAction { }; } + private static NotificationGroup getNotificationGroup() { + return NotificationGroupManager.getInstance() + .getNotificationGroup("Infer Nullity"); + } + protected void restartAnalysis(final @NotNull Project project, final @NotNull AnalysisScope scope) { AppUIExecutor.onUiThread().inSmartMode(project).execute(() -> analyze(project, scope)); }