From bd822712f3bb956b646313ca467f0baa17dcdf3b Mon Sep 17 00:00:00 2001 From: Aleksey Pivovarov Date: Thu, 18 Jul 2013 12:23:39 +0400 Subject: [PATCH] IDEA-110677 Github: do not show warning on success --- .../org/jetbrains/plugins/github/GithubShareAction.java | 5 ++--- .../jetbrains/plugins/github/GithubShareProjectTest.java | 8 ++++---- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/plugins/github/src/org/jetbrains/plugins/github/GithubShareAction.java b/plugins/github/src/org/jetbrains/plugins/github/GithubShareAction.java index 56d02e644b21..40c5024b8c93 100644 --- a/plugins/github/src/org/jetbrains/plugins/github/GithubShareAction.java +++ b/plugins/github/src/org/jetbrains/plugins/github/GithubShareAction.java @@ -185,7 +185,7 @@ public class GithubShareAction extends DumbAwareAction { return; } - GithubNotifications.showInfoURL(project, "Successfully created project on GitHub", name, url); + GithubNotifications.showInfoURL(project, "Successfully shared project on GitHub", name, url); } }.queue(); } @@ -312,8 +312,7 @@ public class GithubShareAction extends DumbAwareAction { final Collection files2add = dialog.getSelectedFiles(); if (!dialog.isOK() || files2add.isEmpty()) { - GithubNotifications - .showWarningURL(project, "Can't finish GitHub sharing process", "No files to commit. ", "'" + name + "'", " on GitHub", url); + GithubNotifications.showInfoURL(project, "Successfully created empty repository on GitHub", name, url); return false; } GitFileUtils.addFiles(project, root, files2add); diff --git a/plugins/github/test/org/jetbrains/plugins/github/GithubShareProjectTest.java b/plugins/github/test/org/jetbrains/plugins/github/GithubShareProjectTest.java index 073d7010b9b6..3a5eddab15f4 100644 --- a/plugins/github/test/org/jetbrains/plugins/github/GithubShareProjectTest.java +++ b/plugins/github/test/org/jetbrains/plugins/github/GithubShareProjectTest.java @@ -20,7 +20,7 @@ public class GithubShareProjectTest extends GithubShareProjectTestBase { GithubShareAction.shareProjectOnGithub(myProject, myProjectRoot); - checkNotification(NotificationType.INFORMATION, "Successfully created project on GitHub", null); + checkNotification(NotificationType.INFORMATION, "Successfully shared project on GitHub", null); checkGitExists(); checkGithubExists(); checkRemoteConfigured(); @@ -52,7 +52,7 @@ public class GithubShareProjectTest extends GithubShareProjectTestBase { GithubShareAction.shareProjectOnGithub(myProject, myProjectRoot); - checkNotification(NotificationType.INFORMATION, "Successfully created project on GitHub", null); + checkNotification(NotificationType.INFORMATION, "Successfully shared project on GitHub", null); checkGitExists(); checkGithubExists(); checkRemoteConfigured(); @@ -70,7 +70,7 @@ public class GithubShareProjectTest extends GithubShareProjectTestBase { GithubShareAction.shareProjectOnGithub(myProject, myProjectRoot); - checkNotification(NotificationType.INFORMATION, "Successfully created project on GitHub", null); + checkNotification(NotificationType.INFORMATION, "Successfully shared project on GitHub", null); checkGitExists(); checkGithubExists(); checkRemoteConfigured(); @@ -83,7 +83,7 @@ public class GithubShareProjectTest extends GithubShareProjectTestBase { GithubShareAction.shareProjectOnGithub(myProject, myProjectRoot); - checkNotification(NotificationType.WARNING, "Can't finish GitHub sharing process", null); + checkNotification(NotificationType.INFORMATION, "Successfully created empty repository on GitHub", null); checkGitExists(); checkGithubExists(); checkRemoteConfigured();