diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/defUse/DefUseInspectionBase.java b/java/java-analysis-impl/src/com/intellij/codeInspection/defUse/DefUseInspectionBase.java
index 235e8718ab26..c346b14398b2 100644
--- a/java/java-analysis-impl/src/com/intellij/codeInspection/defUse/DefUseInspectionBase.java
+++ b/java/java-analysis-impl/src/com/intellij/codeInspection/defUse/DefUseInspectionBase.java
@@ -22,16 +22,16 @@ import com.intellij.psi.*;
import com.intellij.psi.controlFlow.DefUseUtil;
import com.intellij.util.ObjectUtils;
import com.intellij.util.containers.ContainerUtil;
+import com.intellij.util.ui.JBUI;
import gnu.trove.THashSet;
-import org.jetbrains.annotations.NonNls;
import org.jetbrains.annotations.NotNull;
import javax.swing.*;
-import javax.swing.event.ChangeEvent;
-import javax.swing.event.ChangeListener;
import java.awt.*;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
+import java.util.Set;
public class DefUseInspectionBase extends BaseJavaBatchLocalInspectionTool {
public boolean REPORT_PREFIX_EXPRESSIONS;
@@ -39,17 +39,19 @@ public class DefUseInspectionBase extends BaseJavaBatchLocalInspectionTool {
public boolean REPORT_REDUNDANT_INITIALIZER = true;
public static final String DISPLAY_NAME = InspectionsBundle.message("inspection.unused.assignment.display.name");
- @NonNls public static final String SHORT_NAME = "UnusedAssignment";
+ public static final String SHORT_NAME = "UnusedAssignment";
@Override
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, final boolean isOnTheFly) {
return new JavaElementVisitor() {
- @Override public void visitMethod(PsiMethod method) {
+ @Override
+ public void visitMethod(PsiMethod method) {
checkCodeBlock(method.getBody(), holder, isOnTheFly);
}
- @Override public void visitClassInitializer(PsiClassInitializer initializer) {
+ @Override
+ public void visitClassInitializer(PsiClassInitializer initializer) {
checkCodeBlock(initializer.getBody(), holder, isOnTheFly);
}
};
@@ -118,17 +120,21 @@ public class DefUseInspectionBase extends BaseJavaBatchLocalInspectionTool {
}
}
- body.accept(new JavaRecursiveElementWalkingVisitor() {
- @Override public void visitClass(PsiClass aClass) { }
+ if (!isOnTheFly) {
+ body.accept(new JavaRecursiveElementWalkingVisitor() {
+ @Override
+ public void visitClass(PsiClass aClass) { }
- @Override public void visitLocalVariable(PsiLocalVariable variable) {
- if (!usedVariables.contains(variable) && variable.getInitializer() == null && !isOnTheFly) {
- holder.registerProblem(ObjectUtils.notNull(variable.getNameIdentifier(), variable),
- InspectionsBundle.message("inspection.unused.assignment.problem.descriptor5", "#ref #loc"),
- ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ @Override
+ public void visitLocalVariable(PsiLocalVariable variable) {
+ if (!usedVariables.contains(variable) && variable.getInitializer() == null) {
+ PsiElement element = ObjectUtils.notNull(variable.getNameIdentifier(), variable);
+ String message = InspectionsBundle.message("inspection.unused.assignment.problem.descriptor5", "#ref #loc");
+ holder.registerProblem(element, message, ProblemHighlightType.LIKE_UNUSED_SYMBOL);
+ }
}
- }
- });
+ });
+ }
}
private static boolean isOnTheFlyOrNoSideEffects(boolean isOnTheFly,
@@ -166,44 +172,27 @@ public class DefUseInspectionBase extends BaseJavaBatchLocalInspectionTool {
myReportInitializer = new JCheckBox(InspectionsBundle.message("inspection.unused.assignment.option2"));
myReportInitializer.setSelected(REPORT_REDUNDANT_INITIALIZER);
- myReportInitializer.getModel().addChangeListener(new ChangeListener() {
- @Override
- public void stateChanged(ChangeEvent e) {
- REPORT_REDUNDANT_INITIALIZER = myReportInitializer.isSelected();
- }
- });
- gc.insets = new Insets(0, 0, 15, 0);
+ myReportInitializer.getModel().addChangeListener(e -> REPORT_REDUNDANT_INITIALIZER = myReportInitializer.isSelected());
+ gc.insets = JBUI.insetsBottom(15);
gc.gridy = 0;
add(myReportInitializer, gc);
myReportPrefix = new JCheckBox(InspectionsBundle.message("inspection.unused.assignment.option"));
myReportPrefix.setSelected(REPORT_PREFIX_EXPRESSIONS);
- myReportPrefix.getModel().addChangeListener(new ChangeListener() {
- @Override
- public void stateChanged(ChangeEvent e) {
- REPORT_PREFIX_EXPRESSIONS = myReportPrefix.isSelected();
- }
- });
- gc.insets = new Insets(0, 0, 0, 0);
+ myReportPrefix.getModel().addChangeListener(e -> REPORT_PREFIX_EXPRESSIONS = myReportPrefix.isSelected());
+ gc.insets = JBUI.emptyInsets();
gc.gridy++;
add(myReportPrefix, gc);
myReportPostfix = new JCheckBox(InspectionsBundle.message("inspection.unused.assignment.option1"));
myReportPostfix.setSelected(REPORT_POSTFIX_EXPRESSIONS);
- myReportPostfix.getModel().addChangeListener(new ChangeListener() {
- @Override
- public void stateChanged(ChangeEvent e) {
- REPORT_POSTFIX_EXPRESSIONS = myReportPostfix.isSelected();
- }
- });
-
+ myReportPostfix.getModel().addChangeListener(e -> REPORT_POSTFIX_EXPRESSIONS = myReportPostfix.isSelected());
gc.weighty = 1;
gc.gridy++;
add(myReportPostfix, gc);
}
}
-
@Override
@NotNull
public String getDisplayName() {