From bcbfbb2a0a80deecb4a028e8a36426bd0e182d83 Mon Sep 17 00:00:00 2001 From: Sergey Malenkov Date: Tue, 2 Apr 2019 13:15:28 +0300 Subject: [PATCH] IDEA-178054: extract temporary method to invalidate caches in TreeUI --- .../src/com/intellij/util/ui/tree/TreeUtil.java | 8 ++++++++ .../changes/committed/CommittedChangesTreeBrowser.java | 9 +-------- .../vcs/changes/ui/MultipleLocalChangeListsBrowser.java | 8 ++------ 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/platform/platform-api/src/com/intellij/util/ui/tree/TreeUtil.java b/platform/platform-api/src/com/intellij/util/ui/tree/TreeUtil.java index 1acc5bf7e388..51710bd052bc 100644 --- a/platform/platform-api/src/com/intellij/util/ui/tree/TreeUtil.java +++ b/platform/platform-api/src/com/intellij/util/ui/tree/TreeUtil.java @@ -29,6 +29,7 @@ import org.jetbrains.concurrency.Promise; import org.jetbrains.concurrency.Promises; import javax.swing.*; +import javax.swing.plaf.TreeUI; import javax.swing.plaf.basic.BasicTreeUI; import javax.swing.tree.*; import java.awt.*; @@ -1112,6 +1113,13 @@ public final class TreeUtil { } } + @Deprecated + public static void invalidateCache(@Nullable TreeUI ui) { + if (ui instanceof WideSelectionTreeUI) { + ((WideSelectionTreeUI)ui).invalidateNodeSizes(); + } + } + @NotNull public static RelativePoint getPointForSelection(@NotNull JTree aTree) { final int[] rows = aTree.getSelectionRows(); diff --git a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/committed/CommittedChangesTreeBrowser.java b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/committed/CommittedChangesTreeBrowser.java index dc7f5853d842..946eb4fa5f45 100644 --- a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/committed/CommittedChangesTreeBrowser.java +++ b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/committed/CommittedChangesTreeBrowser.java @@ -36,7 +36,6 @@ import com.intellij.util.messages.MessageBusConnection; import com.intellij.util.messages.Topic; import com.intellij.util.ui.StatusText; import com.intellij.util.ui.tree.TreeUtil; -import com.intellij.util.ui.tree.WideSelectionTreeUI; import org.jetbrains.annotations.NonNls; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -47,7 +46,6 @@ import javax.swing.event.ChangeEvent; import javax.swing.event.ChangeListener; import javax.swing.event.TreeSelectionEvent; import javax.swing.event.TreeSelectionListener; -import javax.swing.plaf.TreeUI; import javax.swing.tree.DefaultMutableTreeNode; import javax.swing.tree.DefaultTreeModel; import javax.swing.tree.TreeModel; @@ -559,12 +557,7 @@ public class CommittedChangesTreeBrowser extends JPanel implements TypeSafeDataP } public void invalidateNodeSizes() { - TreeUI ui = getUI(); - - if (ui instanceof WideSelectionTreeUI) { - ((WideSelectionTreeUI)ui).invalidateNodeSizes(); - } - + TreeUtil.invalidateCache(getUI()); repaint(); } } diff --git a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ui/MultipleLocalChangeListsBrowser.java b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ui/MultipleLocalChangeListsBrowser.java index 06ca9763b326..3ed55fb0f564 100644 --- a/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ui/MultipleLocalChangeListsBrowser.java +++ b/platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ui/MultipleLocalChangeListsBrowser.java @@ -37,14 +37,13 @@ import com.intellij.ui.SimpleTextAttributes; import com.intellij.util.containers.ContainerUtil; import com.intellij.util.ui.JBUI; import com.intellij.util.ui.ThreeStateCheckBox.State; -import com.intellij.util.ui.tree.WideSelectionTreeUI; +import com.intellij.util.ui.tree.TreeUtil; import com.intellij.util.ui.update.MergingUpdateQueue; import com.intellij.util.ui.update.Update; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; import javax.swing.*; -import javax.swing.plaf.TreeUI; import javax.swing.tree.DefaultTreeModel; import java.awt.*; import java.awt.event.ItemEvent; @@ -597,10 +596,7 @@ class MultipleLocalChangeListsBrowser extends CommitDialogChangesBrowser impleme } private void invalidateNodeSizes() { - TreeUI ui = getUI(); - if (ui instanceof WideSelectionTreeUI) { - ((WideSelectionTreeUI)ui).invalidateNodeSizes(); - } + TreeUtil.invalidateCache(getUI()); } private class MyStateHolder extends PartiallyExcludedFilesStateHolder {